16 Commits

Author SHA1 Message Date
kjellander
499dcb1ac0 Remove references to .isolate files that are no longer needed.
After the Android test framework in Chromium moved over to generated
scripts, these paths are no longer used, so let's clean them up.

BUG=webrtc:6323
NOTRY=True

Review-Url: https://codereview.webrtc.org/2327013002
Cr-Commit-Position: refs/heads/master@{#14151}
2016-09-09 08:39:00 +00:00
Henrik Kjellander
15583c19d7 Move talk/app/webrtc to webrtc/api
The previously disabled warnings that were inherited from
talk/build/common.gypi are now replaced by target-specific disabling
of only the failing warnings. Additional disabling was needed since the stricter
compilation warnings that applies to code in webrtc/.

License headers will be updated in a follow-up CL.

Other modifications:
* Updated the header guards.
* Sorted the includes using chromium/src/tools/sort-headers.py
  except for these files:
  talk/app/webrtc/peerconnectionendtoend_unittest.cc
  talk/app/webrtc/java/jni/androidmediadecoder_jni.cc
  talk/app/webrtc/java/jni/androidmediaencoder_jni.cc
  webrtc/media/devices/win32devicemanager.cc

The HAVE_SCTP define was added for the peerconnection_unittests target
in api_tests.gyp.

I also checked that none of
SRTP_RELATIVE_PATH
HAVE_SRTP
HAVE_WEBRTC_VIDEO
HAVE_WEBRTC_VOICE
were used by the talk/app/webrtc code.

For Chromium, the following changes will need to be applied to the roll CL that updates the
DEPS for WebRTC and libjingle:
https://codereview.chromium.org/1615433002

BUG=webrtc:5418
NOPRESUBMIT=True
R=deadbeef@webrtc.org, pthatcher@webrtc.org, tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1610243002 .

Cr-Commit-Position: refs/heads/master@{#11545}
2016-02-10 09:53:26 +00:00
perkj
8a2c31d208 Make it possible to run peerconnection_unittests on Android.
- renamed libjingle_peerconnection_unittest to peerconnection_unittest to circumvent cr issue http://crbug.com/543820

TEST=On an android build webrtc/build/android/test_runner.py gtest -s peerconnection_unittests --verbose -t 900
BUG=webrtc:2365,543820
NOTRY=True

Review URL: https://codereview.webrtc.org/1602443004

Cr-Commit-Position: refs/heads/master@{#11304}
2016-01-19 14:20:07 +00:00
phoglund
37ebcf0ce5 Reland "Add APK targets to build libjingle tests for Android."
patchset #10 id:180001 of https://codereview.webrtc.org/1511633002/

This reverts commit bc14164aad254e72ce4d1e381b912b7d3acf5391.

We have made more preparations downstream, so this should work now. Original CL by perkj@.

BUG=webrtc:2365
The work started from the work by kjellander@ in https://codereview.webrtc.org/1413663003/

Review URL: https://codereview.webrtc.org/1570513004

Cr-Commit-Position: refs/heads/master@{#11186}
2016-01-08 13:05:01 +00:00
stefan
bc14164aad Revert of Add APK targets to build libjingle tests for Android. (patchset #10 id:180001 of https://codereview.webrtc.org/1511633002/ )
Reason for revert:
Breaks bots.

Original issue's description:
> Add APK targets to build libjingle_peerconnection_unittests for Android.
>
> BUG=webrtc:2365
>
> The work started from the work by kjellander@ in https://codereview.webrtc.org/1413663003/
>
> Committed: https://crrev.com/a78c0211fd50369a75a962385db6163bd8ded239
> Cr-Commit-Position: refs/heads/master@{#11007}

TBR=kjellander@webrtc.org,tommi@webrtc.org,perkj@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:2365

Review URL: https://codereview.webrtc.org/1521993002

Cr-Commit-Position: refs/heads/master@{#11009}
2015-12-14 12:31:22 +00:00
perkj
a78c0211fd Add APK targets to build libjingle_peerconnection_unittests for Android.
BUG=webrtc:2365

The work started from the work by kjellander@ in https://codereview.webrtc.org/1413663003/

Review URL: https://codereview.webrtc.org/1511633002

Cr-Commit-Position: refs/heads/master@{#11007}
2015-12-14 10:41:37 +00:00
Peter Boström
bc32ab458b Remove 'video_engine_core_unittests' binary.
Merges tests into 'video_engine_tests' to reduce the number of test
targets.

BUG=webrtc:1695
R=kjellander@webrtc.org, phoglund@webrtc.org

Review URL: https://codereview.webrtc.org/1409803007 .

Cr-Commit-Position: refs/heads/master@{#10891}
2015-12-04 09:59:02 +00:00
Peter Boström
4f4f756f6f Create isolate files for nonparallel tests.
Adds missing Android things for webrtc_nonparallel_tests.

BUG=chromium:445880
R=kjellander@webrtc.org

Review URL: https://codereview.webrtc.org/1419023003 .

Cr-Commit-Position: refs/heads/master@{#10451}
2015-10-29 14:29:15 +00:00
Henrik Kjellander
d6d27e7340 Update isolate.gypi to support Swarming + move .isolate files
This updates the isolate.gypi copies we have to maintain in our
code repo to Chromium's revision 310ea93.
The changes about generating .isolated.gen.json files are needed
to support running with Swarming (https://www.chromium.org/developers/testing/isolated-testing)

Since isolated testing is now using a new launch script
in tools: isolate_driver.py, that's added to our links
script.

In order to use isolate_driver.py, the .isolate files must be in the
same directory as the test_name_run target is defined, which meant
I had to move around some of the isolate files and targets below
webrtc/modules.

BUG=497757
R=maruel@chromium.org
TBR=henrik.lundin@webrtc.org, mflodman@webrtc.org, niklas.enbom@webrtc.org
TESTED=Clobbered trybots:
git cl try -c --bot=linux_compile_rel --bot=mac_compile_rel --bot=win_compile_rel --bot=android_compile_rel --bot=ios_rel -m tryserver.webrtc

Review URL: https://codereview.webrtc.org/1373513002 .

Cr-Commit-Position: refs/heads/master@{#10081}
2015-09-25 20:19:21 +00:00
Henrik Kjellander
eecbab7cd5 Roll chromium_revision a28d8d5..5482f56 (346100:347609)
Recent changes (https://codereview.chromium.org/1311013010) introduces a
dependency on WebKit (Blink) in Chromium, which forces us to start pulling
down that as well (+6GB). However Blink is about to be merged into the
Chromium repo soon anyway, so the size increase is inevitable.
Luckily, this can be removed in the next roll, if we roll past
http://crrev.com/348812

The ijar dependency was introduced in https://codereview.chromium.org/1323053003 (#347208)

Relevant changes:
* src/third_party/boringssl/src: 12fe1b2..ac8302a
* src/third_party/libvpx: a208eca..0304cef
* src/third_party/libyuv: 3c4f573..0bc626a
* src/tools/gyp: 6ee91ad..5d01a8c
Details: a28d8d5..5482f56/DEPS

Clang version was not updated in this roll.

R=torbjorng@webrtc.org
TBR=marpan@webrtc.org
BUG=webrtc:5005, chromium:530112

Review URL: https://codereview.webrtc.org/1305043008 .

Cr-Commit-Position: refs/heads/master@{#9956}
2015-09-16 17:19:14 +00:00
Henrik Kjellander
57e5fd2e60 PRESUBMIT: Improve PyLint check and add GN format check.
Add pylintrc file based on
https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/pylintrc
bit tightened up quite a bit (the one in depot_tools is far
more relaxed).

Remove a few excluded directories from pylint check and fixed/
suppressed all warnings generated.

Add GN format check + formatted all GN files using 'gn format'.
Cleanup redundant rules in tools/PRESUBMIT.py

TESTED=Ran 'git cl presubmit -vv', fixed the PyLint violations.
Ran it again with a modification in webrtc/build/webrtc.gni, formatted
all the GN files and ran it again.

R=henrika@webrtc.org, phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/50069004

Cr-Commit-Position: refs/heads/master@{#9274}
2015-05-25 10:55:50 +00:00
kjellander@webrtc.org
7572d85aa8 rtc_unittests on Android
BUG=4364
R=pbos@webrtc.org, pthatcher@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/42549004

Cr-Commit-Position: refs/heads/master@{#8587}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8587 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-04 08:48:17 +00:00
andresp@webrtc.org
86e1e487e7 Move system_wrappers.gyp files to the proper directory.
Build targets should not refer to non-subpaths as was happening before when
 source/system_wrappers.gyp refers to ../interface/ files.

R=kjellander@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/37609004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8057 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-14 09:30:52 +00:00
kjellander@webrtc.org
626c09f6a3 Move isolate path into webrtc/build/android/test_runner.py
This will make it easier to execute tests and allows
for more cleanup in the buildbot recipes.
Now tests can be listed using:
webrtc/build/android/test_runner.py gtest --help
and executed like
webrtc/build/android/test_runner.py gtest -s audio_decoder_unittests

TESTED=
Ran:
webrtc/build/android/test_runner.py gtest --help
and verified the tests were listed.
I wiped /sdcard/resources on my device, executed:
webrtc/build/android/test_runner.py gtest -s audio_decoder_unittests
and verified it passed and that resources/audio_coding/testfile32kHz.pcm
was copied to the device.

BUG=
R=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/33619004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7873 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-11 11:59:46 +00:00
kjellander@webrtc.org
7ba9f27f2b Set CHECKOUT_SOURCE_ROOT environment variable for Android test wrapper.
This makes it possible to clean up the recipes a lot.

BUG=
R=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/34409004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7837 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-09 06:46:13 +00:00
kjellander@webrtc.org
c3e097cdc5 Add Android test runner script for WebRTC.
The Android test execution toolchain scripts in Chromium
has been causing headaches for us several times. Mostly
because they're tailored at running Chrome tests only.

Wrapping their script in our own avoids the pain of
upstreaming new test names to Chromium and rolling them
in to get them running on our bots.

TESTED=Ran a test on a local device using:
webrtc/build/android/test_runner.py gtest -s audio_decoder_unittests  --verbose --isolate-file-path webrtc/modules/audio_coding/neteq/audio_decoder_unittests.isolate --release
TBR=phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/25269004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7794 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-12-03 09:57:08 +00:00