7 Commits

Author SHA1 Message Date
Henrik Kjellander
f4efb6fb3d Reland "Move webrtc/{base => rtc_base} (stub headers)
Add the stub headers from https://codereview.webrtc.org/2877023002
as a separate commit. This preserves git blame history of the moved files.

BUG=webrtc:7634
NOTRY=True
TBR=kwiberg@webrtc.org

Change-Id: Ic141abf11801fbfdeea5bcdb23608696ad449013
Reviewed-on: https://chromium-review.googlesource.com/554623
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18822}
2017-06-29 06:21:49 +00:00
Henrik Kjellander
c03627683f Reland "Move webrtc/{base => rtc_base}" (https://codereview.webrtc.org/2877023002)
Reland the base->rtc_base without adding stub headers (will be
done in follow-up CL). This preserves git blame history of all files.

BUG=webrtc:7634
NOTRY=True
TBR=kwiberg@webrtc.org

Change-Id: Iea3bb6f3f67b8374c96337b63e8f5aa3e6181012
Reviewed-on: https://chromium-review.googlesource.com/554611
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18821}
2017-06-29 06:04:25 +00:00
Henrik Kjellander
ec78f1cebc Revert "Move webrtc/{base => rtc_base}" (https://codereview.webrtc.org/2877023002)
Will reland in two different commits to preserve git blame history.

BUG=webrtc:7634
NOTRY=True
TBR=kwiberg@webrtc.org

Change-Id: I550da8525aeb9c5b8f96338fcf1c9714f3dcdab1
Reviewed-on: https://chromium-review.googlesource.com/554610
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18820}
2017-06-29 05:54:22 +00:00
Henrik Kjellander
6776518bea Move webrtc/{base => rtc_base}
This refactoring takes a careful approach to avoid rushing the change:
* stub headers are left in all the old locations of webrtc/base
* existing GN targets are kept and now just forward to the moved ones
  using public_deps.
The only exception to the above is the base_java target and its .java files,
which were moved to webrtc/rtc_base right away since it's not possible
to use public_deps for android_library.
To avoid breaking builds, a temporary Dummy.java file was added to
the new intermediate target in webrtc/rtc_base:base_java as well to avoid
hitting a GN assert in the android_library template.

The above approach should make the transition smooth without breaking
downstream.

A helper script was created (https://codereview.webrtc.org/2879203002/)
and was run like this:
stub-headers.py -s webrtc/base -d webrtc/rtc_base -i 7634
stub-headers.py -s webrtc/base/numerics -d webrtc/rtc_base/numerics -i 7634

Fixed invalid header guards in the following files:
webrtc/base/base64.h
webrtc/base/cryptstring.h
webrtc/base/event.h
webrtc/base/flags.h
webrtc/base/httpbase.h
webrtc/base/httpcommon-inl.h
webrtc/base/httpcommon.h
webrtc/base/httpserver.h
webrtc/base/logsinks.h
webrtc/base/macutils.h
webrtc/base/nattypes.h
webrtc/base/openssladapter.h
webrtc/base/opensslstreamadapter.h
webrtc/base/pathutils.h
webrtc/base/physicalsocketserver.h
webrtc/base/proxyinfo.h
webrtc/base/sigslot.h
webrtc/base/sigslotrepeater.h
webrtc/base/socket.h
webrtc/base/socketaddresspair.h
webrtc/base/socketfactory.h
webrtc/base/stringutils.h
webrtc/base/testbase64.h
webrtc/base/testutils.h
webrtc/base/transformadapter.h
webrtc/base/win32filesystem.h

Added new header guards to:
sslroots.h
testbase64.h

BUG=webrtc:7634
NOTRY=True
NOPRESUBMIT=True
R=kwiberg@webrtc.org

Review-Url: https://codereview.webrtc.org/2877023002 .
Cr-Commit-Position: refs/heads/master@{#18816}
2017-06-28 18:58:10 +00:00
ilnik
531100dc7a Reland of Added GetCpuTime to base/ to get total CPU time consumed by process for perf tests.
BUG=webrtc:7095

Review-Url: https://codereview.webrtc.org/2695743003
Cr-Commit-Position: refs/heads/master@{#16665}
Committed: 3ff474b72b

patch from issue 2695743003 at patchset 440001 (http://crrev.com/2695743003#ps440001)

Review-Url: https://codereview.webrtc.org/2706823002
Cr-Commit-Position: refs/heads/master@{#16736}
2017-02-21 11:33:24 +00:00
tommi
658c3bb0ab Revert of Added GetCpuTime to base/ to get total CPU time consumed by process for perf tests. (patchset #24 id:440001 of https://codereview.webrtc.org/2695743003/ )
Reason for revert:
The GetThreadCpuTimeTest.SingleThread and .TwoThreads tests are unfortunately flaky on Mac (maybe other platforms).  See for example:

https://build.chromium.org/p/client.webrtc/builders/Mac%20Asan/builds/11271/steps/rtc_unittests%20on%20Mac-10.11/logs/stdio

https://build.chromium.org/p/client.webrtc/builders/Mac64%20Debug/builds/10395/steps/rtc_unittests%20on%20Mac-10.11/logs/stdio

https://build.chromium.org/p/client.webrtc/builders/Mac%20Asan/builds/11271/steps/rtc_unittests%20on%20Mac-10.11/logs/stdio

Since it's late, I'll have to revert the CL to get the tree and trybots green (instead of only disabling the failing tests).

Original issue's description:
> Added GetCpuTime to base/ to get total CPU time consumed by process for perf tests.
>
> BUG=webrtc:7095
>
> Review-Url: https://codereview.webrtc.org/2695743003
> Cr-Commit-Position: refs/heads/master@{#16665}
> Committed: 3ff474b72b

TBR=sprang@webrtc.org,mflodman@webrtc.org,deadbeef@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org,ilnik@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7095

Review-Url: https://codereview.webrtc.org/2698333004
Cr-Commit-Position: refs/heads/master@{#16679}
2017-02-17 22:59:19 +00:00
ilnik
3ff474b72b Added GetCpuTime to base/ to get total CPU time consumed by process for perf tests.
BUG=webrtc:7095

Review-Url: https://codereview.webrtc.org/2695743003
Cr-Commit-Position: refs/heads/master@{#16665}
2017-02-17 12:02:23 +00:00