11 Commits

Author SHA1 Message Date
oprypin
51d49b4983 Reland of Stop silently accepting unsupported flags in test binaries (patchset #1 id:1 of https://codereview.webrtc.org/3002963002/ )
Reason for revert:
Relanding without changes.
Problem with unused flags was fixed in
https://codereview.webrtc.org/2998143002/

Original issue's description:
> Revert of Stop silently accepting unsupported flags in test binaries (patchset #5 id:150001 of https://codereview.webrtc.org/2968003003/ )
>
> Reason for revert:
> Causes failures on perf bots
> https://luci-milo.appspot.com/buildbot/client.webrtc.perf/Mac%2010.11/3567
>
> Original issue's description:
> > Stop silently accepting unsupported flags in test binaries
> >
> > Instead explicitly ignore only the flags we know should be ignored.
> >
> > BUG=webrtc:7568
> >
> > Review-Url: https://codereview.webrtc.org/2968003003
> > Cr-Commit-Position: refs/heads/master@{#19412}
> > Committed: a2782f6f5d
>
> TBR=kjellander@webrtc.org,henrika@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7568
>
> Review-Url: https://codereview.webrtc.org/3002963002
> Cr-Commit-Position: refs/heads/master@{#19413}
> Committed: d64072c598

TBR=kjellander@webrtc.org,henrika@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7568

Review-Url: https://codereview.webrtc.org/2999383002
Cr-Commit-Position: refs/heads/master@{#19455}
2017-08-22 17:55:47 +00:00
oprypin
d64072c598 Revert of Stop silently accepting unsupported flags in test binaries (patchset #5 id:150001 of https://codereview.webrtc.org/2968003003/ )
Reason for revert:
Causes failures on perf bots
https://luci-milo.appspot.com/buildbot/client.webrtc.perf/Mac%2010.11/3567

Original issue's description:
> Stop silently accepting unsupported flags in test binaries
>
> Instead explicitly ignore only the flags we know should be ignored.
>
> BUG=webrtc:7568
>
> Review-Url: https://codereview.webrtc.org/2968003003
> Cr-Commit-Position: refs/heads/master@{#19412}
> Committed: a2782f6f5d

TBR=kjellander@webrtc.org,henrika@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7568

Review-Url: https://codereview.webrtc.org/3002963002
Cr-Commit-Position: refs/heads/master@{#19413}
2017-08-18 14:22:36 +00:00
oprypin
a2782f6f5d Stop silently accepting unsupported flags in test binaries
Instead explicitly ignore only the flags we know should be ignored.

BUG=webrtc:7568

Review-Url: https://codereview.webrtc.org/2968003003
Cr-Commit-Position: refs/heads/master@{#19412}
2017-08-18 14:12:20 +00:00
mbonadei
d5e3d0f958 Creating a more generic memcheck suppression
Chromium roll into WebRTC is failing because of a memcheck error.
The tool suggests to add this suppression:

{
   <insert_a_suppression_name_here>
   Memcheck:Uninitialized
   fun:vfprintf
   fun:vsnprintf
   fun:snprintf
   fun:_ZN7testing9internal220PrintBytesInObjectToEPKhmPSo
   fun:_ZN7testing8internal14Default...
   fun:_ZN7testing8internal20MatchPrint...
   fun:_ZNK7testing8internal29Predicate...
}

This CL tries to remove some duplication using a more generic pattern.

BUG=webrtc:6773
NOTRY=True

Review-Url: https://codereview.webrtc.org/2991643002
Cr-Commit-Position: refs/heads/master@{#19132}
2017-07-25 14:30:06 +00:00
deadbeef
13790bec6b Add suppression for "uninitialized memory" error in getaddrinfo.
I'm unsure what caused this to start occurring, but I don't believe it's
webrtc's fault, so I'm adding a suppression for now.

BUG=webrtc:7973
TBR=kjellander@webrtc.org
NOTRY=true

Review-Url: https://codereview.webrtc.org/2977723003
Cr-Commit-Position: refs/heads/master@{#18981}
2017-07-12 00:54:15 +00:00
Henrik Kjellander
9588682dfe Update memcheck suppression for HttpServer.SignalsCloseAfterForcedCloseAll
This failed on the Memcheck bot due to different stack signature.
Widening the suppression should fix that.

BUG=webrtc:5988
TBR=pthatcher@webrtc.org

Change-Id: Ia448d0f157d650e3ab6d4b02b3acbac91c62d1cd
Reviewed-on: https://chromium-review.googlesource.com/553377
Reviewed-by: Henrik Kjellander <kjellander@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#18818}
2017-06-28 20:39:36 +00:00
kjellander
0393de4b56 Roll chromium_revision b032878ebd..e438353b8b (480186:480311)
Copy Valgrind scripts from Chromium's tools/ to unblock rolling:
valgrind/chrome_tests.bat
valgrind/chrome_tests.py
valgrind/chrome_tests.sh
valgrind/common.py
valgrind/gdb_helper.py
valgrind/locate_valgrind.sh
valgrind/memcheck_analyze.py
valgrind/valgrind.gni
valgrind/valgrind.sh
valgrind/valgrind_test.py

valgrind_test.py was stripped of its Mac and Dr Memory specific parts, which
we don't use. There's still more cleanup to do, tracked in bugs.webrc.org/7849.

Change log: b032878ebd..e438353b8b
Full diff: b032878ebd..e438353b8b

Changed dependencies:
* src/base: cfcc86588b..12890c2e86
* src/build: da7ab41c0b..9ec24027ab
* src/ios: 6a7a3c369e..50158a755d
* src/testing: 3e351800c5..1f3a1393a1
* src/third_party: 541ca472e8..733d9dc5c9
* src/third_party/catapult: e9dc4c57fb..57e600c76c
* src/third_party/gtest-parallel: 6fb62e80ac..4bf9c03d93
* src/tools: bf99adb051..919bf71aa0
DEPS diff: b032878ebd..e438353b8b/DEPS

No update to Clang.

TBR=ehmaldonado@webrtc.org
BUG=webrtc:7849
NOTRY=True

Review-Url: https://codereview.webrtc.org/2945753002
Cr-Commit-Position: refs/heads/master@{#18650}
2017-06-18 20:21:21 +00:00
kjellander
d5115e0cac Roll chromium_revision fc674bec51..cca67d31f4 (473937:474153)
Memcheck suppression stacks changed slightly due to the googletest
roll so a few suppressions needed to be updated.

Change log: fc674bec51..cca67d31f4
Full diff: fc674bec51..cca67d31f4

Changed dependencies:
* src/base: 14fe060b4d..414d17a2ac
* src/build: b19d8a0c0e..5488ca8df8
* src/ios: 4378a2bccb..e344c3eca3
* src/testing: 34532746b5..2393ca4149
* src/third_party: 5530bd0f35..f336aafa2c
* src/third_party/catapult: 08a6e0ac16..f136f48001
* src/third_party/googletest/src: 8c7f93feda..42bc671f47
* src/tools: e9c26b8d46..06b0b52a2c
DEPS diff: fc674bec51..cca67d31f4/DEPS

No update to Clang.

TBR=
BUG=None
NOTRY=True

Review-Url: https://codereview.webrtc.org/2902923002
Cr-Commit-Position: refs/heads/master@{#18251}
2017-05-24 07:57:03 +00:00
henrik.lundin
e43397e079 Opus tests: Remove suppression for webrtc:5651
BUG=webrtc:5651
NOTRY=True

Review-Url: https://codereview.webrtc.org/2872373004
Cr-Commit-Position: refs/heads/master@{#18117}
2017-05-12 07:39:39 +00:00
henrik.lundin
fd14309d9e Opus tests: Remove suppressions for webrtc:6444
BUG=webrtc:6444
NOTRY=True

Review-Url: https://codereview.webrtc.org/2875803003
Cr-Commit-Position: refs/heads/master@{#18114}
2017-05-12 07:08:29 +00:00
Henrik Kjellander
90fd7d84fd Rename tools-webrtc -> tools_webrtc
This aligns with established naming convention for all
other directories.

BUG=webrtc:7593
NOTRY=True
NOTREECHECKS=True
R=ehmaldonado@webrtc.org, mbonadei@webrtc.org
TBR=henrika@webrtc.org

Review-Url: https://codereview.webrtc.org/2864213004 .
Cr-Commit-Position: refs/heads/master@{#18059}
2017-05-09 06:30:13 +00:00