8 Commits

Author SHA1 Message Date
Åsa Persson
2b9423f7a1 Revert of Re-enable UBsan on AGC. (patchset #8 id:300001 of https://codereview.webrtc.org/2003623003/ )
Reason for revert:
Breaks bot.

Original issue's description:
> Re-enable UBsan on AGC.
>
> BUG=webrtc:5530
>
> Committed: https://crrev.com/293c86d67384c15f46b8296096a62a14b4a58d33
> Cr-Commit-Position: refs/heads/master@{#13034}

R=kjellander@webrtc.org, peah@webrtc.org
TBR=kjellander@webrtc.org, minyue@webrtc.org, peah@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:5530

Review URL: https://codereview.webrtc.org/2056683002 .

Cr-Commit-Position: refs/heads/master@{#13096}
2016-06-10 07:12:43 +00:00
minyue
293c86d673 Re-enable UBsan on AGC.
BUG=webrtc:5530

Review-Url: https://codereview.webrtc.org/2003623003
Cr-Commit-Position: refs/heads/master@{#13034}
2016-06-03 13:07:41 +00:00
Henrik Kjellander
27178676cf UBSan: Suppress openh264 and NetEq errors.
As part of the work enabling OpenH264 in
WebRTC it was discovered that some of its code triggers
an UBSan errors:
third_party/openh264/src/codec/common/inc/golomb_common.h:103:3: runtime error: shift exponent 32 is too large for 32-bit type 'uint32_t' (aka 'unsigned int')
third_party/ffmpeg/libavcodec/h264_cavlc.c:585:54: runtime error: index -1 out of bounds for type 'VLC [15]'
Suppress such errors since this source code is out of our control.

This CL also includes a new NetEq suppression.

BUG=webrtc:5889
TBR=hbos@webrtc.org

Review URL: https://codereview.webrtc.org/1975863002 .

Cr-Commit-Position: refs/heads/master@{#12706}
2016-05-12 16:24:40 +00:00
kwiberg
806706875d iSAC entropy coder: Avoid signed integer overflow
By doing an unsigned instead of a signed addition, we get the exact
same machine code (in non-UBSan builds), but no longer trigger
undefined behavior since unsigned overflow is defined behavior.

BUG=webrtc:5485

Review URL: https://codereview.webrtc.org/1734883003

Cr-Commit-Position: refs/heads/master@{#11776}
2016-02-26 10:52:14 +00:00
peah
1cfe94096c Added the agc digital_agc.c file to the ubsan blacklist
in order to suppress UBSan errors from the AGC.

BUG=webrtc:5124, webrtc:5487

Review URL: https://codereview.webrtc.org/1696153002

Cr-Commit-Position: refs/heads/master@{#11730}
2016-02-24 07:06:56 +00:00
henrik.lundin
452df1cb44 Suppress UBSan errors in common_audio
BUG=webrtc:5486,webrtc:5512
NOTRY=true

Review URL: https://codereview.webrtc.org/1714443002

Cr-Commit-Position: refs/heads/master@{#11671}
2016-02-18 15:41:21 +00:00
henrik.lundin
abedbbd09a Suppress UBSan errors from iSAC
BUG=webrtc:5513
NOTRY=true

Review URL: https://codereview.webrtc.org/1690573002

Cr-Commit-Position: refs/heads/master@{#11549}
2016-02-10 13:01:44 +00:00
Henrik Kjellander
f1dcd46a9b UBSan: Add blacklist files for WebRTC standalone.
For more info, see
http://dev.chromium.org/developers/testing/undefinedbehaviorsanitizer

BUG=webrtc:5124
TESTED=Passing compilation using:
GYP_DEFINES="ubsan=1" webrtc/build/gyp_webrtc && ninja -C out/Release
GYP_DEFINES="ubsan_vptr=1" webrtc/build/gyp_webrtc && ninja -C out/Release
R=pbos@webrtc.org

Review URL: https://codereview.webrtc.org/1418213005 .

Cr-Commit-Position: refs/heads/master@{#10429}
2015-10-27 14:31:58 +00:00