Reason for revert:
This breaks our Chromium WebRTC FYI bots:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/6173
/mnt/data/b/build/slave/Linux_Builder/build/src/buildtools/linux64/gn gen //out/Release --check
-> returned 1
ERROR at //content/renderer/media/rtc_video_decoder.cc:24:11: Can't include this header from here.
#include "third_party/webrtc/video_frame.h"
^-------------------------------
The target:
//content/renderer:renderer
is including a file from the target:
//third_party/webrtc:webrtc_common
The //content/renderer:renderer target should probably be updated to depend on //third_party/webrtc:webrtc_common before relanding this.
Original issue's description:
> Add missing headers and fix some missing dependencies
>
> This is the first CL in a series of major cleanup and dependency
> corrections needed in order to satisfy 'gn check'.
>
> BUG=webrtc:4243, webrtc:5589
> NOTRY=True
>
> Committed: https://crrev.com/7bb6e75723eb64af079446cc6e3ff08c74fe02e4
> Cr-Commit-Position: refs/heads/master@{#12790}
TBR=pbos@webrtc.org,henrika@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4243, webrtc:5589
Review-Url: https://codereview.webrtc.org/1989823002
Cr-Commit-Position: refs/heads/master@{#12793}
This is the first CL in a series of major cleanup and dependency
corrections needed in order to satisfy 'gn check'.
BUG=webrtc:4243, webrtc:5589
NOTRY=True
Review-Url: https://codereview.webrtc.org/1990593002
Cr-Commit-Position: refs/heads/master@{#12790}
Reason for revert:
Breaks GN in chromium.
Original issue's description:
> Move webrtc/audio/audio_sink.h to webrtc/ and fix some dependencies.
>
> webrtc/audio/audio_sink.h is used by voice engine, but webrtc/audio is
> depending on voice engine, resulting in a cyclic dependency (which we
> don't detect since we have that check turned off, see webrtc:4243).
>
> BUG=webrtc:4243, webrtc:5589
> R=pbos@webrtc.org, perkj@webrtc.org, solenberg@webrtc.org
> TBR=tommi@webrtc.org
>
> Committed: https://crrev.com/99b345c4e50c59a776c56949c17da3f50992f1a2
> Cr-Commit-Position: refs/heads/master@{#11766}
TBR=solenberg@webrtc.org,pbos@webrtc.org,perkj@webrtc.org,tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4243, webrtc:5589
Review URL: https://codereview.webrtc.org/1739783002
Cr-Commit-Position: refs/heads/master@{#11769}
This is needed because the target is defined in webrtc/common.gyp
and its current location crosses package boundaries when generating
projects for some build systems.
NOTRY=True
Review URL: https://codereview.webrtc.org/1665603003
Cr-Commit-Position: refs/heads/master@{#11496}
Mostly, it's about moving constructors and descructors to the .cc
files, so that they won't be inlined everywhere.
The reason this CL is so big is that a lot of code was using
common_types.h without declaring a dependency on webrtc_common, which
broke the build once common_types.h started to depend on
common_types.cc.
BUG=163
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/26089004
Cr-Commit-Position: refs/heads/master@{#8516}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8516 4adac7df-926f-26a2-2b94-8c16560cd09d
