Harald Alvestrand
794d599741
Split media_channel and its dependencies from the rtc_media_base target
...
This helps in figuring out which dependencies exist, and gets closer
to obeying the "one target per .cc file" rule.
Test failures seem unrelated, so using No-Try.
No-Try: true
Bug: webrtc:14775
Change-Id: Id25466c8b8fe628d05c819cf7c69ae6d8421c6cf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/288020
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38910}
2022-12-16 12:15:22 +00:00
Mirko Bonadei
e9dc70b220
Remove webrtc::webrtc_pc_e2e::GetCurrentTestName().
...
After https://webrtc-review.googlesource.com/c/src/+/287126 , this is not
neeed anymore.
Bug: b/237982523, webrtc:14757
Change-Id: Ia91f2b09862d7d705d07f10f71f02b41f3c1c096
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/287128
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38869}
2022-12-11 09:36:52 +00:00
Mirko Bonadei
74e6f5b10c
Propagate PCLF test_case to kExperimentalTestNameMetadataKey.
...
Follow-up of https://webrtc-review.googlesource.com/c/src/+/287221 ,
instead of asking GTest for the test suite and the test name, let's
propagate the test case passed by the user of PCLF.
Bug: b/237982523, webrtc:14757
Change-Id: Ia2a6ed4781f8c53c25b0006b8c7483e08ecead26
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/287126
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38867}
2022-12-10 11:13:49 +00:00
Mirko Bonadei
fecbec261b
Add metadata key to export test name in PCLF generated metrics.
...
This metadata key is temporary, as explained in bugs.webrtc.org/14757,
this information will be at some point directly accessible via the
webrtc.test_metrics.Metric.test_case field.
Bug: b/237982523, webrtc:14757
Change-Id: Ie77875a33db5961f8a5572bd1b7066ad8ba17291
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/287221
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38858}
2022-12-09 10:40:56 +00:00
Sergey Silkin
1985b5a927
Refactor YUV frame reader
...
Purposes of this refactoring:
1. Add functionality for reading a specified frame.
2. Change resolution and frame rate on per-frame basis.
Both features are needed for https://webrtc-review.googlesource.com/c/src/+/283525
Bug: b/261160916
Change-Id: I6d60e62dbc3913c43b5c1b491690f5cb4a8632dd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/285483
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38829}
2022-12-06 16:23:48 +00:00
Artem Titov
6a8776a108
[DVQA] Provide more precise time for qp
...
Bug: None
Change-Id: Ic7b6323c296b20e164b7ff0aca861c439bb86c89
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284721
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38716}
2022-11-23 10:02:29 +00:00
Artem Titov
538fa81328
Add collection of EmulatedNetworkNode stats to stats collector
...
Bug: b/240540204
Change-Id: I9c2c2c35d0c3b6a99205e24d8b367fa7dab5d917
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283760
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38694}
2022-11-21 09:46:34 +00:00
Artem Titov
6d91a718c8
[DVQA] Allow processing of frames dropped by decoder
...
Bug: b/257402861
Change-Id: I4d495c33c162c4e3a0afef5b83adf19b6d79dfce
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284160
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38693}
2022-11-21 09:19:04 +00:00
Artem Titov
4440426792
[DVQA] Add QP metric to the video analyzer.
...
Bug: b/240540204
Change-Id: I43fbb779bac10e27f2607ce1545476b1389d7c69
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283763
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38686}
2022-11-18 20:06:20 +00:00
Ilya Nikolaevskiy
6eb1e709da
Reland "[DVQA] Create separate BUILD.gn file for video analyzer"
...
This reverts commit 76793c300fdd87fa8fd8be3dd2e5faf8c1916e96.
Reason for revert: Can't cleanly revert the old one. A forward fix will be provided.
Original change's description:
> Revert "[DVQA] Create separate BUILD.gn file for video analyzer"
>
> This reverts commit 116c0a53d4a35c6dee857eb4cc2b6ae233a0427c.
>
> Reason for revert: Breaks bot: https://ci.chromium.org/ui/p/chromium/builders/try/linux_chromium_compile_dbg_ng/1415352/overview
>
>
> Original change's description:
> > [DVQA] Create separate BUILD.gn file for video analyzer
> >
> > Bug: None
> > Change-Id: I37dd2262bf3f52b2f5abe7934b9c41eaa27ffd17
> > No-try: True
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283141
> > Commit-Queue: Artem Titov <titovartem@webrtc.org>
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Cr-Commit-Position: refs/heads/main@{#38662}
>
> Bug: None
> Change-Id: Ieeb8c569560cb9d60d0c4d3c1268fa57f56b8157
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284000
> Auto-Submit: Ilya Nikolaevskiy <ilnik@webrtc.org>
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#38672}
Bug: None
Change-Id: I74506eaa6a1060bf87e651881c86b4f576f447ec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284020
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38676}
2022-11-18 11:43:45 +00:00
Ilya Nikolaevskiy
76793c300f
Revert "[DVQA] Create separate BUILD.gn file for video analyzer"
...
This reverts commit 116c0a53d4a35c6dee857eb4cc2b6ae233a0427c.
Reason for revert: Breaks bot: https://ci.chromium.org/ui/p/chromium/builders/try/linux_chromium_compile_dbg_ng/1415352/overview
Original change's description:
> [DVQA] Create separate BUILD.gn file for video analyzer
>
> Bug: None
> Change-Id: I37dd2262bf3f52b2f5abe7934b9c41eaa27ffd17
> No-try: True
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283141
> Commit-Queue: Artem Titov <titovartem@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#38662}
Bug: None
Change-Id: Ieeb8c569560cb9d60d0c4d3c1268fa57f56b8157
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/284000
Auto-Submit: Ilya Nikolaevskiy <ilnik@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38672}
2022-11-18 09:18:32 +00:00
Artem Titov
116c0a53d4
[DVQA] Create separate BUILD.gn file for video analyzer
...
Bug: None
Change-Id: I37dd2262bf3f52b2f5abe7934b9c41eaa27ffd17
No-try: True
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283141
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38662}
2022-11-17 11:53:44 +00:00
Jeremy Leconte
c30835c712
Remove deprecated AddPeer method.
...
Change-Id: Icd15dc4d7d79276734260fb11932d9ede8dbbf23
Bug: webrtc:14627
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283661
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38659}
2022-11-17 09:00:21 +00:00
Artem Titov
5f42cdcb31
Remove deprecated API for emulated network stats
...
Bug: None
Change-Id: Ib70a117d67002d108474214490ed1a8bb61da463
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/283140
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38619}
2022-11-14 17:51:42 +00:00
Artem Titov
d53578e0f5
[PCLF] Close visibility of framework implementation
...
Bug: None
Change-Id: I33fac286adb2853e2c7868a3382d22da6fa7b65b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282921
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38614}
2022-11-12 13:32:29 +00:00
Jeremy Leconte
a3e51df5f3
Add a new PeerConnectionE2EQualityTestFixture::AddPeer method.
...
Change-Id: Ic5879613db51a00e3e958931f5eda19fda1ae94a
Bug: webrtc:14627
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282640
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38608}
2022-11-10 16:54:19 +00:00
Jeremy Leconte
389228d0f0
Remove PeerConfigurer interface.
...
PeerConfigurerImpl is renamed to PeerConfigurer.
Change-Id: Ie52c581126c21740536d42ff4831f0c4ed445ea4
Bug: webrtc:14627
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281883
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38603}
2022-11-10 12:52:25 +00:00
Artem Titov
e4c1b1cbed
Simplify Network Emulation stats API
...
Bug: b/240540204
Change-Id: I669b5b01d0a10ae5d8f0bafa661dbda6fc9260b7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282420
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38590}
2022-11-09 11:50:44 +00:00
Jeremy Leconte
0e2cf6cc01
Use classes from media_configuration.h instead of the ones in PeerConnectionE2EQualityTestFixture.
...
Classes defined inside the class PeerConnectionE2EQualityTestFixture are replaced by the ones define in media_configuration.h.
Change-Id: I1c025ff10aacf8cbc3df9bfa742a40622fe0807a
Bug: webrtc:14627
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281860
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38568}
2022-11-07 16:56:47 +00:00
Artem Titov
140eb82acd
[PCLF] Fix tests flakiness in AnalyzingVideoSinkTest
...
Bug: b/240540204
Change-Id: I62b99e0431bac7af5141eb44cbc31a18e7e407b8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282260
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38564}
2022-11-07 15:37:53 +00:00
Artem Titov
2af96059a3
[PCLF] Add infra metrics to the AnalyzingVideoSink
...
Bug: b/240540204
Change-Id: If3f5436d701336b0bc122477c61b97b5dc28f422
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282001
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38561}
2022-11-07 09:49:59 +00:00
Artem Titov
d34a7ab50d
[DVQA] Add infra metrics to measure time of each frame's processing step
...
Bug: b/240540204
Change-Id: Ib3395d2d8d61b3cfef60d0463d7b53f96a9f8c83
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/282000
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38559}
2022-11-07 09:03:53 +00:00
Jeremy Leconte
d16f290e41
Move PeerConfigurerImpl to the test public api.
...
End goal is to remove PeerConnectionE2EQualityTestFixture::PeerConfigurer interface.
Change-Id: I4a6aa0ab1fb5a0d6f85154159b7da16de9b53059
Bug: webrtc:14627
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281501
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#38551}
2022-11-04 08:02:53 +00:00
Artem Titov
15b97d6d90
[PCLF] Propagate relevant metadata to all metrics
...
Bug: None
Change-Id: Ifcb67a59b68cc3468dd06e932a2a3da7b40d9845
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281680
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38545}
2022-11-03 16:11:31 +00:00
Artem Titov
19813a4222
Remove unused MetricsLoggerAndExporter
...
Bug: None
Change-Id: I9e05e5c29cd80bf991bd50c3bd4ee4f09ddf8134
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281420
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38531}
2022-11-02 07:35:47 +00:00
Artem Titov
3ea1608816
[PCLF] Improve error handling and test coverage for AnalyzingVideoSink
...
Bug: b/240540204
Change-Id: If60ade3dce760e8e730cbde2b199d407461b16ce
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281080
Reviewed-by: Andrey Logvin <landrey@google.com>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38506}
2022-10-31 12:54:17 +00:00
Artem Titov
48f05cd0e8
[DVQA] Remove resolution_of_rendered_frame in favor of resolution_of_decoded_frame
...
Bug: b/240540204
Change-Id: I91be68c9f17b436f646246e24fe13484bef9b9ff
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/281121
Reviewed-by: Andrey Logvin <landrey@google.com>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38505}
2022-10-31 11:44:59 +00:00
Artem Titov
21b0572e3b
[PCLF] Rescale frame to the requested resolution before passing it to analyzer
...
Bug: b/240540204
Change-Id: Idafa74021dd136d8ec9fd54cabaa7f0d49d379d9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/280944
Reviewed-by: Andrey Logvin <landrey@google.com>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38498}
2022-10-28 20:42:17 +00:00
Artem Titov
d393543110
[PCLF] Use resolution from video subscription to dump video
...
Bug: b/240540204
Change-Id: I8f91cc68fc52de457e89f3b6247970b479b5f118
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/280420
Reviewed-by: Andrey Logvin <landrey@google.com>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38491}
2022-10-28 11:11:53 +00:00
Artem Titov
28da5462be
[PCLF] Fix ExampleVideoQualityAnalyzer to not use VideoFrame::kNotSetId as frame id
...
Bug: b/240540204
Change-Id: I7d529f22c93e529a26787dd4c0b5448ad27bb644
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/280382
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Auto-Submit: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Andrey Logvin <landrey@google.com>
Reviewed-by: Andrey Logvin <landrey@google.com>
Cr-Commit-Position: refs/heads/main@{#38466}
2022-10-25 12:21:52 +00:00
Henrik Boström
15166b2fa4
[ModernStats] Mark obsolete stats as [[deprecated]].
...
This includes the stats dictionaries that have been made obsolete in
the spec and whose IDs are prefixed "DEPRECATED_":
- RTCMediaStreamTrackStats
- RTCMediaStreamStats
There is an ongoing experiment to unship these stats dictionaries in
Chrome (https://crbug.com/1374215 ). Marking then as [[deprecated]] helps
alert other dependencies that these classes are deprecated.
In the meantime, the "DEPRECATED_RTCMediaStreamTrackStats" prefix makes
it possible to use the deprecated classes.
# Unrelated infra failures
NOTRY=True
Bug: webrtc:14175, webrtc:14419
Change-Id: I498d370294058a628278e1e5b027cd12e24ad31a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/279700
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38439}
2022-10-19 09:58:37 +00:00
Artem Titov
048f5c7516
[DVQA] Add capture_frame_rate metric as detailed stats
...
Bug: b/240540204
Change-Id: I3e4a8f903f5b01c31418cc3e29d4e663d62a86a3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/279640
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38427}
2022-10-18 09:33:48 +00:00
Artem Titov
2068d0daa7
[PCLF] Add ability to provide custom VideoFrameWriter
...
Bug: b/240540204
Change-Id: Ica85954ea61b7caf4e2d726895b6a439b47d7bbb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/278800
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38368}
2022-10-12 14:08:00 +00:00
Per Kjellander
78d80f9be7
Add SmokeSendAndReceivePacketsOnOneThread
...
Only use the network thread for sending and receiving packets.
The one and only network thread is used as a worker thread in all
PeerConnections. Pacing when sending packets is done on the worker thread.
Bug: webrtc:14502
Change-Id: Ib373315688ae4d810ae1e4421101a859fca93b31
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/278621
Reviewed-by: Evan Shrubsole <eshr@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38354}
2022-10-11 13:33:52 +00:00
Artem Titov
5584d4504e
[PCLF] Prepare to add extra scaling step before passing frame to analyzer and video sinks
...
Bug: b/240540204
Change-Id: Ic9774ea07316e59e842d1f4e8362c06ec9c3bf87
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/278623
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38348}
2022-10-11 11:15:32 +00:00
Artem Titov
6b75058774
[PCLF] Extract video dumping from video_quality_analyzer_injection_helper for testability
...
Bug: b/240540204
Change-Id: I7f5970fae2b1472b37ea5fd5cbb16b2ce25dd968
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/278622
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38347}
2022-10-11 11:10:02 +00:00
Mirko Bonadei
9d9c2d5795
Make header files self contained.
...
This CL adds #includes to header files in order to make them
self contained after the preprocessor pass.
Bug: b/251890128
Change-Id: I81c3ba38fb8ab8a2bbd151ba99aa871fae9f1b1b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/278422
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38327}
2022-10-08 08:38:36 +00:00
Artem Titov
b15faaa264
[PCLF] Annotate video metrics with peer, stream and receiver
...
Bug: b/240540204
Change-Id: I05eddea33a2eb680b59c8247f2acba1e7c7d6a84
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/278260
Reviewed-by: Andrey Logvin <landrey@google.com>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38316}
2022-10-07 09:58:48 +00:00
Artem Titov
7fe7091f8a
[DVQA] Annotate per frame stats with relevant frame id
...
Bug: b/240540204
Change-Id: Ic12a5778ecdbf7a0b8bd9a54f3d927289c49c34a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277802
Reviewed-by: Andrey Logvin <landrey@google.com>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38307}
2022-10-06 10:37:37 +00:00
Artem Titov
ab9849adbc
[PCLF] Sync frame ids export with fixed framerate exporter
...
Bug: b/240540204
Change-Id: I38722c8d5d2db685fc0aeb0c7a31b610bd9f64e4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/278120
Reviewed-by: Andrey Logvin <landrey@google.com>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38302}
2022-10-05 13:43:07 +00:00
Artem Titov
d2cb1f872e
[PCLF] Fix rounding issue in NetworkQualityMetricsReporter
...
Bug: b/246095034
Change-Id: Idba4aef450ade431822c9d5e43870281ded55f73
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277220
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38235}
2022-09-28 13:25:42 +00:00
Artem Titov
99f5d95dc6
[PCLF] Fix rounding issue in network stats
...
Bug: b/246095034
Change-Id: I55c874507ae6b51bc196846273fe0dcfa14a3eb9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277180
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38233}
2022-09-28 12:03:43 +00:00
Florent Castelli
4c7d3f82f9
PCLF: Ignore discarded frames in the DefaultVideoQualityAnalyzer
...
Bug: webrtc:14453, webrtc:11607
Change-Id: Iad0da2d85d9db74026205591e8b2ced399988998
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276420
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38204}
2022-09-26 13:42:01 +00:00
Artem Titov
c45f4e4a3d
[PCLF] Fully switch to new metrics export API
...
Bug: b/246095034
Change-Id: I9d588d53320e4eb19cb569db2b97dddc013c22bd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276621
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38188}
2022-09-24 18:49:29 +00:00
Artem Titov
f863182ce5
Migrate test_main_lib on new global metrics API
...
Bug: b/246095034
Change-Id: I99cd631cdae49ad1e0812f1204a6be4d6f43bc34
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276604
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38184}
2022-09-23 19:22:37 +00:00
Florent Castelli
bfdb9577ff
PCLF: Separate SFU functionality configuration into a new struct
...
Creates the EmulatedSFUConfig that will receive the parameters for
controlling the virtual SFU used in the call.
Its current only field is the previous target_spatial_index from
VideoSimulcastConfig.
This allow to filter out the bottom layers for SVC S mode tests
and enable them.
Bug: webrtc:11607
Change-Id: Id4f3a96b3a03b9be7155796c3bafefce01f32b7d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/274162
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38182}
2022-09-23 15:08:37 +00:00
Artem Titov
219ec71702
[PCLF] Replace MetricsLoggerAndExporter with MetricsLogger
...
Bug: b/246095034
Change-Id: I06b3b4eb43a3555b359e3c1aee332d5d05d1e567
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276601
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38181}
2022-09-23 14:36:28 +00:00
Artem Titov
6a49fb2d5f
[DVQA] Fix: cpu_usage was exported as cpu_usage_% before
...
Bug: b/246095034
Change-Id: I082865fadf69f11ec05dec32e5ec22deaef98db7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276400
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38169}
2022-09-22 11:50:20 +00:00
Artem Titov
f68a06c34b
[PCLF] Cleanup old video dumping API
...
Bug: b/240540206
Change-Id: I1184f3f73a6de430e7103783b8959d8ff222e31e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270485
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38163}
2022-09-21 16:58:22 +00:00
Artem Titov
3680605caa
[PCLF] Enable exporting of perf metric via new API
...
Bug: b/246095034
Change-Id: I05f28e5dfc6df793c035110f89d9ac40783687f8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/276267
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38161}
2022-09-21 15:55:09 +00:00