Miguel Casas-Sanchez
4765070b8d
Rename I420VideoFrame to VideoFrame.
...
This is a mechanical change since it affects so many
files.
I420VideoFrame -> VideoFrame
and reformatted.
Rationale: in the next CL I420VideoFrame will
get an indication of Pixel Format (I420 for
starters) and of storage type: usually
UNOWNED, could be SHMEM, and in the near
future will be possibly TEXTURE. See
https://codereview.chromium.org/1154153003
for the change that happened in Cr.
BUG=4730, chromium:440843
R=jiayl@webrtc.org , niklas.enbom@webrtc.org , pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/52629004
Cr-Commit-Position: refs/heads/master@{#9339}
2015-05-30 00:21:56 +00:00
Thiago Farina
9bfe3daf73
Cleanup: Remove i420_video_frame.h header.
...
It is just a pass through to webrtc/video_frame.h. Updated the callers
to include webrtc/video_frame.h instead and removed i420_video_frame.h.
This should fix pbos' TODO in i420_video_frame.h.
Tested on Linux with the following command lines:
$ rm -rf out/
$ ./webrtc/build/gyp_webrtc
$ ninja -C out/Debug
BUG=None
TEST=see above
R=magjed@webrtc.org , pbos@webrtc.org , tommi@webrtc.org
TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/46819004
Patch from Thiago Farina <tfarina@chromium.org>.
Cr-Commit-Position: refs/heads/master@{#8973}
2015-04-10 10:52:15 +00:00
magjed@webrtc.org
d4e7d49628
Scaler: Recycle allocations using buffer pool.
...
BUG=1128
R=stefan@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/49489004
Cr-Commit-Position: refs/heads/master@{#8828}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8828 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-23 12:28:14 +00:00
magjed@webrtc.org
2056ee3e3c
Revert "Changed argument occurences of const I420VideoFrame* to const I420VideoFrame& and non-const I420VideoFrame& to I420VideoFrame*."
...
This reverts commit r8731.
Reason for revert: Breakes Chromium FYI bots.
TBR=hbos, tommi
Review URL: https://webrtc-codereview.appspot.com/40359004
Cr-Commit-Position: refs/heads/master@{#8733}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8733 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-16 13:48:18 +00:00
hbos@webrtc.org
93d9d6503e
I420VideoFrame.CreateFrame: Removed unnecessary buffer size arguments.
...
R=magjed@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/45629004
Cr-Commit-Position: refs/heads/master@{#8732}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8732 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-16 13:26:41 +00:00
hbos@webrtc.org
2dc5fa69b2
Changed argument occurences of const I420VideoFrame* to const I420VideoFrame& and non-const I420VideoFrame& to I420VideoFrame*.
...
R=magjed@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/40299004
Cr-Commit-Position: refs/heads/master@{#8731}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8731 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-16 13:02:19 +00:00
guoweis@webrtc.org
59140d6a5a
Remove VideoRotationMode to VideoRotation.
...
With this change, there is only one copy of rotation enum.
BUG=4145
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/48369004
Cr-Commit-Position: refs/heads/master@{#8654}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8654 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-09 17:08:20 +00:00
kwiberg@webrtc.org
00b8f6b364
Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away
...
BUG=
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/36229004
Cr-Commit-Position: refs/heads/master@{#8517}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8517 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-26 14:43:50 +00:00
magjed@webrtc.org
6c66163567
Fix TestScaler PSNR tests
...
TestScaler::ComputeAvgSequencePSNR is currently a complex NOP, that always returns kPerfectPSNR. Two frames are read from files into arrays, and then converted into I420VideoFrames. However, the incorrect function ConvertFromI420 is used instead of ConvertToI420, resulting in two empty I420VideoFrames. I420PSNR on empty frames returns kPerfectPSNR.
This CL replaces ConvertFromI420 with ConvertToI420 and actually measures the PSNR. Unfortunately, some tests do not pass when we use the real psnr. The tests that fail are the ones that scale back and forth to a different aspect ratio. webrtc::Scaler has been changed to preserve aspect ratio, and this means that we will end up with a cropped frame if scale and rescale to a different target aspect ratio. I simply removed those tests to make it pass. Having some working tests instead of a lot of dummy tests seems like a win.
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/35339004
Cr-Commit-Position: refs/heads/master@{#8506}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8506 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-25 14:10:47 +00:00
magjed@webrtc.org
f68e186de3
Remove EnableMirroring and MirrorRenderStream
...
R=mflodman@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/35239004
Cr-Commit-Position: refs/heads/master@{#8409}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8409 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-18 12:55:17 +00:00
pkasting@chromium.org
4591fbd09f
Use size_t more consistently for packet/payload lengths.
...
See design doc at https://docs.google.com/a/chromium.org/document/d/1I6nmE9D_BmCY-IoV6MDPY2V6WYpEI-dg2apWXTfZyUI/edit?usp=sharing for more information.
This CL was reviewed and approved in pieces in the following CLs:
https://webrtc-codereview.appspot.com/24209004/
https://webrtc-codereview.appspot.com/24229004/
https://webrtc-codereview.appspot.com/24259004/
https://webrtc-codereview.appspot.com/25109004/
https://webrtc-codereview.appspot.com/26099004/
https://webrtc-codereview.appspot.com/27069004/
https://webrtc-codereview.appspot.com/27969004/
https://webrtc-codereview.appspot.com/27989004/
https://webrtc-codereview.appspot.com/29009004/
https://webrtc-codereview.appspot.com/30929004/
https://webrtc-codereview.appspot.com/30939004/
https://webrtc-codereview.appspot.com/31999004/
Committing as TBR to the original reviewers.
BUG=chromium:81439
TEST=none
TBR=pthatcher,henrik.lundin,tina.legrand,stefan,tkchin,glaznev,kjellander,perkj,mflodman,henrika,asapersson,niklas.enbom
Review URL: https://webrtc-codereview.appspot.com/23129004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7726 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-20 22:28:14 +00:00
magjed@webrtc.org
ea73ff7267
webrtc::Scaler: Preserve aspect ratio
...
BUG=3936
R=glaznev@webrtc.org , stefan@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=7679
Review URL: https://webrtc-codereview.appspot.com/28969004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7689 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-12 09:52:03 +00:00
magjed@webrtc.org
f7c5d4fac7
Revert 7679 "webrtc::Scaler: Preserve aspect ratio"
...
> webrtc::Scaler: Preserve aspect ratio
>
> BUG=3936
> R=glaznev@webrtc.org , stefan@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/28969004
TBR=magjed@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/30989004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7682 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-11 13:12:09 +00:00
magjed@webrtc.org
809986b95f
webrtc::Scaler: Preserve aspect ratio
...
BUG=3936
R=glaznev@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/28969004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7679 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-11 09:51:30 +00:00
pbos@webrtc.org
047a46f8b4
Remove Android.mk build files.
...
These files are generally not maintained and break, some contain files
that don't exist anymore and do not build anymore. If we need to add
some of these back we should really set up a bot for them.
R=andrew@webrtc.org , glaznev@webrtc.org , henrike@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/15249004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6974 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-26 08:48:51 +00:00
andrew@webrtc.org
8f69330310
Replace scoped_array<T> with scoped_ptr<T[]>.
...
scoped_array is deprecated. This was done using a Chromium clang tool:
http://src.chromium.org/viewvc/chrome/trunk/src/tools/clang/rewrite_scoped_ar ...
except for the few not-built-on-Linux files which were updated manually.
TESTED=trybots
BUG=2515
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12429004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5985 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-25 23:10:28 +00:00
mikhal@webrtc.org
635b2b88e4
Removing some TODO's from libyuv
...
BUG=1996
R=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2146004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4668 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-03 20:06:18 +00:00
henrike@webrtc.org
89c674053e
Adds all unittests to android NDK-APK framework.
...
BUG=N/A
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1872004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4474 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-02 16:53:47 +00:00
andrew@webrtc.org
b2d29bd2fe
Restore relative include paths to libyuv.
...
Required in order to use an externally compiled libyuv. Removed
in https://code.google.com/p/webrtc/source/detail?r=4167
TBR=tnakamura
Review URL: https://webrtc-codereview.appspot.com/1611005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4180 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-06-04 23:53:48 +00:00
pbos@webrtc.org
c69ae69d0b
Include files from webrtc/.. paths in common_video/
...
BUG=1662
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1546004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4167 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-06-04 09:02:37 +00:00
fbarchard@google.com
e5794cbc8e
Recalibrate point sample expectation
...
BUG=none
TESTED=try bots
Review URL: https://webrtc-codereview.appspot.com/1512004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4068 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-20 18:17:44 +00:00
phoglund@webrtc.org
5b689efe8e
Will now only require near-perfect PSNR and SSIM.
...
BUG=
TEST=Ran test and checked we accept somewhat lower values.
Committed: https://code.google.com/p/webrtc/source/detail?r=3269
Review URL: https://webrtc-codereview.appspot.com/964031
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3278 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-13 10:15:06 +00:00
andrew@webrtc.org
d8aeb30d55
Revert 3269
...
> Will now only require near-perfect PSNR and SSIM.
>
> BUG=
> TEST=Ran test and checked we accept somewhat lower values.
>
> Review URL: https://webrtc-codereview.appspot.com/964031
TBR=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/989004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3270 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-12 20:58:32 +00:00
phoglund@webrtc.org
735a6cec96
Will now only require near-perfect PSNR and SSIM.
...
BUG=
TEST=Ran test and checked we accept somewhat lower values.
Review URL: https://webrtc-codereview.appspot.com/964031
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3269 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-12 15:20:34 +00:00
phoglund@webrtc.org
273ccad59d
Fixed standard PSNR/SSIM test.
...
BUG=1103
Review URL: https://webrtc-codereview.appspot.com/971005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3197 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-29 10:08:16 +00:00
mikhal@webrtc.org
32b3f40b6c
Adding an aligned stride test to LibYuv
...
Review URL: https://webrtc-codereview.appspot.com/935020
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3139 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-20 23:52:50 +00:00
mikhal@webrtc.org
737ed3bfa5
libyuv wrapper: 1. Updating rotation settings - in case of 90 or 270 degree rotations, width and height should be updated accordingly. 2. Test clean-up.
...
TEST=trybots
Review URL: https://webrtc-codereview.appspot.com/936008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3039 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-01 15:45:38 +00:00
mikhal@webrtc.org
91a0340a61
Adding stride alignment
...
TEST= common_video_unittests and video_capture_module_test
BUG=985
Review URL: https://webrtc-codereview.appspot.com/965005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3023 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-30 19:19:32 +00:00
mikhal@webrtc.org
e08adf0957
fix print out in mirror test
...
Review URL: https://webrtc-codereview.appspot.com/928010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3008 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-26 22:58:58 +00:00
mikhal@webrtc.org
9fedff7c17
Switching to I420VideoFrame
...
Review URL: https://webrtc-codereview.appspot.com/922004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2983 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-24 18:33:04 +00:00
andrew@webrtc.org
14b43beb7c
Move src/ -> webrtc/
...
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/915006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-22 18:19:23 +00:00