11 Commits

Author SHA1 Message Date
deadbeef
59edb9298e Relanding: Remove rtc_p2p_unittests from ortc_unittests and rtc_media_unittests
These tests are already built into rtc_unittests, so they end up being
run three times. Fixed by creating a "p2p_test_utils" target that
contains the test utils that ortc_unittests and rtc_media_unittests
depend on, but not the tests themselves.

BUG=None
TBR=kjellander@webrtc.org

Review-Url: https://codereview.webrtc.org/2820263004
Cr-Commit-Position: refs/heads/master@{#17752}
2017-04-18 22:49:09 +00:00
deadbeef
19fd811736 Revert of Remove rtc_p2p_unittests from ortc_unittests executable. (patchset #1 id:1 of https://codereview.webrtc.org/2820263004/ )
Reason for revert:
Breaks checkdeps rules. Need to make a "p2p_test_utils" build target to include things like fakeicetransport.h.

Original issue's description:
> Remove rtc_p2p_unittests from ortc_unittests executable.
>
> These tests are already built into rtc_unittests; they shouldn't be
> built into two test executables.
>
> BUG=None
> TBR=kjellander@webrtc.org
> NOTRY=True
>
> Review-Url: https://codereview.webrtc.org/2820263004
> Cr-Commit-Position: refs/heads/master@{#17748}
> Committed: fe9d38f515

TBR=kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review-Url: https://codereview.webrtc.org/2826703002
Cr-Commit-Position: refs/heads/master@{#17749}
2017-04-18 18:11:31 +00:00
deadbeef
fe9d38f515 Remove rtc_p2p_unittests from ortc_unittests executable.
These tests are already built into rtc_unittests; they shouldn't be
built into two test executables.

BUG=None
TBR=kjellander@webrtc.org
NOTRY=True

Review-Url: https://codereview.webrtc.org/2820263004
Cr-Commit-Position: refs/heads/master@{#17748}
2017-04-18 17:59:20 +00:00
mbonadei
cde2528d28 Enabling 'gn check' on //webrtc/ortc.
BUG=webrtc:6828

Review-Url: https://codereview.webrtc.org/2804663002
Cr-Commit-Position: refs/heads/master@{#17642}
2017-04-11 09:52:49 +00:00
zhihuang
acfb017775 Disable the ORTC integration tests on TSan.
BUG=webrtc:7366

Review-Url: https://codereview.webrtc.org/2767123002
Cr-Commit-Position: refs/heads/master@{#17431}
2017-03-28 20:45:18 +00:00
zhihuang
243663965a Add the function ToRtpParameters.
The function converts the cricket::Codec, cricket::RtpHeaderExtensions
and cricket::StreamParamsVec to webrtc::RtpParameters.

BUG=webrtc:7311

Review-Url: https://codereview.webrtc.org/2735853004
Cr-Commit-Position: refs/heads/master@{#17124}
2017-03-09 01:15:06 +00:00
kjellander
98e1531012 Revert of Enable GN check for webrtc/{ortc,p2p} (patchset #4 id:60001 of https://codereview.webrtc.org/2714263004/ )
Reason for revert:
Fails compile in Chromium for NaCl:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/builds/9320/
 http://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/22215
http://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/14501

Original issue's description:
> Enable GN check for webrtc/{ortc,p2p}
>
> Introduce new target //webrtc/p2p:rtc_p2p_test_utils to host
> test-related utilities.
> Previously uncovered header "base/fakecandidatepair.h" is now also in a target.
>
> BUG=webrtc:6828
>
> Review-Url: https://codereview.webrtc.org/2714263004
> Cr-Commit-Position: refs/heads/master@{#17036}
> Committed: c9515b6ce6

TBR=deadbeef@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6828

Review-Url: https://codereview.webrtc.org/2735583002
Cr-Commit-Position: refs/heads/master@{#17038}
2017-03-04 23:08:44 +00:00
kjellander
c9515b6ce6 Enable GN check for webrtc/{ortc,p2p}
Introduce new target //webrtc/p2p:rtc_p2p_test_utils to host
test-related utilities.
Previously uncovered header "base/fakecandidatepair.h" is now also in a target.

BUG=webrtc:6828

Review-Url: https://codereview.webrtc.org/2714263004
Cr-Commit-Position: refs/heads/master@{#17036}
2017-03-04 21:47:44 +00:00
zhihuang
d3501adf17 Create the SrtpTransportInterface.
Create the SrtpTransportInterface, a subclass of RtpTransportInterface, which
allows the user to set the send and receive keys. The functionalities are
implemented inside the RtpTransportAdapters on top of BaseChannel.

BUG=webrtc:7013

Review-Url: https://codereview.webrtc.org/2714813004
Cr-Commit-Position: refs/heads/master@{#17023}
2017-03-03 22:39:06 +00:00
deadbeef
e814a0dee0 Adding "adapter" ORTC objects on top of ChannelManager/BaseChannel/etc.
This CL adds the following interfaces:
* RtpTransportController
* RtpTransport
* RtpSender
* RtpReceiver

They're implemented on top of the "BaseChannel" object, which is normally used
in a PeerConnection, and roughly corresponds to an SDP "m=" section. As a result
of this, there are several limitations:

* You can only have one of each type of sender and receiver (audio/video) on top
  of the same transport controller.
* The sender/receiver with the same media type must use the same RTP transport.
* You can't change the transport after creating the sender or receiver.
* Some of the parameters aren't supported.

Later, these "adapter" objects will be gradually replaced by real objects that don't
have these limitations, as "BaseChannel", "MediaChannel" and related code is
restructured. In this CL, we essentially have:

ORTC adapter objects -> BaseChannel -> Media engine
PeerConnection -> BaseChannel -> Media engine

And later we hope to have simply:

PeerConnection -> "Real" ORTC objects -> Media engine

See the linked bug for more context.

BUG=webrtc:7013
TBR=stefan@webrtc.org

Review-Url: https://codereview.webrtc.org/2675173003
Cr-Commit-Position: refs/heads/master@{#16842}
2017-02-26 02:15:09 +00:00
deadbeef
4b1bf6c2f0 Adding placeholder ortc_unittests target.
This will allow the trybots to be updated to start running this new test
executable, so that they can be used when landing this CL which will
replace the dummy test with real tests:
https://codereview.webrtc.org/2675173003/

BUG=webrtc:7013
TBR=tommi@webrtc.org

Review-Url: https://codereview.webrtc.org/2707013005
Cr-Commit-Position: refs/heads/master@{#16784}
2017-02-23 07:45:38 +00:00