henrik.lundin@webrtc.org
679cb07980
Fix build error for release build
...
Review URL: http://webrtc-codereview.appspot.com/252003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@874 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-02 19:52:27 +00:00
henrik.lundin@webrtc.org
baf6db5ead
Making dual decoder work again in VCM
...
Changing the assignment operator in VCMJitterBuffer to a named
function (CopyFrom) instead, since it is not a straight
assignment. Also fixing two bugs in the jitter copy function.
Bug fix in VCMEncodedFrame: The copy constructor did not
copy _length.
In VCM codec database, make sure that the callback object is
preserved when copying back from secondary to primary decoder.
In VP8 wrapper, adding code to copy the _decodedImage to the
Copy() method.
Bugfix in video_coding_test rtp_player:
The retransmissions where made in reverse order. Now new items are
appended to the end of the LostPackets list, which makes the order
correct when retransmitting.
Handling the case when cloning an unused decoder state:
When the decoder has not successfully decoded a frame yet,
it cannot be cloned. A NULL pointer will be returned all
the way out to VideoCodingModuleImpl::Decode(). When this
happens, the VCM will call Reset() for the dual receiver,
in order to reset the state to kPassive.
Review URL: http://webrtc-codereview.appspot.com/239010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@873 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-02 18:58:39 +00:00
kjellander@webrtc.org
d292b9c9da
Unit tests now compile and run at all platforms.
...
Cosmetic changes to mocks.h.
Review URL: http://webrtc-codereview.appspot.com/253003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@871 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-02 16:34:52 +00:00
punyabrata@webrtc.org
0ab521f754
Resolving a crash related to strncopy followed by a strcat
...
call. strncopy will not explicity copy or add a "\0" therefore
strcat did not know where to append the "\n" which was causing
an out of bounds crash.
Because we are checking the length, strcpy should be good enough
as it also copies the "\0". Please note that that I am pre-emptively
adding 2 instead of 1 to the length to take into account of the \n
that will be added later.
Review URL: http://webrtc-codereview.appspot.com/253004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@857 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-01 15:19:44 +00:00
stefan@webrtc.org
f960211f8b
Fixes two jitter buffer bugs related to NACK.
...
Avoid decoding delta frames after a Flush() and after requesting
a key frame due to full NACK list.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/247011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@837 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-28 16:00:49 +00:00
stefan@webrtc.org
eb65860720
Reverts the workaround in r823 and solves a macro bug.
...
The macro bug caused frames to be dropped after being grabbed
for decoding.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/248004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@831 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-28 12:25:34 +00:00
mikhal@webrtc.org
5200a05500
video_coding/jitter_buffer Updating condition on which we return a frame.
...
Review URL: http://webrtc-codereview.appspot.com/240011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@825 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-27 16:54:54 +00:00
mikhal@webrtc.org
30f6376802
VP8: Updating codec version: VP8 version will now return the libvpx version used.
...
Review URL: http://webrtc-codereview.appspot.com/247009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@824 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-27 16:45:00 +00:00
stefan@webrtc.org
2d28aff785
Workaround for an issue where frames are grabbed for decoding prematurely.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/240013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@823 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-27 16:13:18 +00:00
mflodman@webrtc.org
7e4269e9ee
Changed VP8 qp min and added noise reduction.
...
Review URL: http://webrtc-codereview.appspot.com/248003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@821 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-27 12:59:47 +00:00
kjellander@webrtc.org
6b7799021c
Fixing build errors on Windows platform. Minor changes...
...
Review URL: http://webrtc-codereview.appspot.com/241004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@819 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-26 02:38:09 +00:00
frkoenig@google.com
fc9bcef8c7
Data alignment fix for SSIM.
...
WebRtc_UWord64[2] wasn't always aligned to 128 bytes, which
is necessary for _mm_store_si128. By declaring the
variable as __m128i it will always be 128 bytes aligned.
Incorrect include files.
__m128i is defined in emmintrin.h for visual studio. Extra include on mac and linux is not a problem.
Review URL: http://webrtc-codereview.appspot.com/239013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@816 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-26 00:07:32 +00:00
stefan@webrtc.org
d855c1a4e8
Reverts r807 and fixes the real issue in the VCM.
...
This fixes an issue in the VCM where we don't wait for a packet to arrive
if the jitter buffer is empty. This also fixes an issue where an old
packet can trigger a packet event signal for a future frame.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/248001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@814 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-25 11:52:48 +00:00
wjia@webrtc.org
f0cd394a2e
Put fwrite calls under corresponding macros since they shouldn't show up in release build.
...
This also make chromeos build happy.
BUG=none
TEST=compile
Review URL: http://webrtc-codereview.appspot.com/247006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@808 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-25 00:40:43 +00:00
mikhal@webrtc.org
f31826e17b
adding a wait on the decode thread when no frames are available
...
Review URL: http://webrtc-codereview.appspot.com/246009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@807 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-25 00:20:54 +00:00
mikhal@webrtc.org
a412924c0e
VP8:Setting number of cores based on image size
...
Review URL: http://webrtc-codereview.appspot.com/242010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@806 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-25 00:02:43 +00:00
stefan@webrtc.org
158f496030
Fixes a rate control bug in the VP8 wrapper.
...
Changes how we signal frame rate and frame durations to the encoder. Rather
than changing the time base, we now only modify the frame durations, while
keeping the timebase constant. The frame duration is currently calculated
from the average input frame rate. Ideally, the frame duration should
be calculated as the timestamp diff, which is the real duration of a
frame, but the encoder doesn't seem to like too varying durations.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/247001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@795 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-21 13:15:16 +00:00
stefan@webrtc.org
ead87b5051
Fix potential issue where frame buffers might be freed while being decoded.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/243004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@791 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-21 06:46:37 +00:00
stefan@webrtc.org
2b0f094c8f
Avoid reallocating the decodedImage for every decoded frame.
...
Also made sure the right size is allocated.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/240004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@790 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-21 06:39:03 +00:00
mikhal@webrtc.org
ee3dfa6f43
Review URL: http://webrtc-codereview.appspot.com/241007
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@789 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-21 00:46:09 +00:00
mikhal@webrtc.org
1af915d8ae
video_coding: vp8: Updating error propagation threshold
...
Review URL: http://webrtc-codereview.appspot.com/246002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@788 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-20 18:19:18 +00:00
kma@webrtc.org
d75889e2eb
Change of Android makefiles to build latest video coding code.
...
Review URL: http://webrtc-codereview.appspot.com/239008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@786 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-20 16:28:56 +00:00
kjellander@webrtc.org
81f25f9ff8
Fixing build errors on Windows platform. Minor changes...
...
Review URL: http://webrtc-codereview.appspot.com/241004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@779 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-19 20:06:56 +00:00
stefan@webrtc.org
ffd28f95c5
Request key frames to battle error propagation.
...
The VP8 decoder wrapper will request key frames 30 frames after seeing
a packet loss, if it hasn't received a state refresh (only possible
through key frames in this version).
For this to be possible the jitter buffer has been made aware of
picture ids to be able to detect frame losses. Legacy JB code to
handle streams without marker bits was also removed since it
conflicts with streams with FEC.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/239002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@774 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-19 15:55:39 +00:00
mikhal@webrtc.org
d0752c370d
video_coding: Update to hybrid mode: Set FEC values for zero below a threshold.
...
Review URL: http://webrtc-codereview.appspot.com/245001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@773 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-19 15:48:30 +00:00
pwestin@webrtc.org
1da1ce0da5
First implementation of simulcast, adds VP8 simulcast to video engine.
...
Changed API to RTP module
Expanded Auto test with a test for simulcast
Made the video codec tests compile
Added the vp8_simulcast files to this cl
Added missing auto test file
Review URL: http://webrtc-codereview.appspot.com/188001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@736 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-13 15:19:55 +00:00
stefan@webrtc.org
4c059d87b3
Add metric for number of packets discarded by JB due to not being decodable
...
Also fixes a couple of bugs related to sequence number wrap found while
testing.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/218001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@732 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-13 07:35:37 +00:00
stefan@webrtc.org
791eec7424
Add API to get the number of packets discarded by the video jitter buffer due to being too late.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/200001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@723 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-11 07:53:43 +00:00
stefan@webrtc.org
06887aebae
Fixes two bugs when decoding with packet losses.
...
Disable _missingFrame bit since we can't set it correctly with FEC.
No longer return more than one decoded frame per Decode() call.
This is a work-around for a bug where the frame info map was popped more often than items were added to the map.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/215001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@722 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-10 14:17:46 +00:00
kjellander@webrtc.org
25e0b8e3a0
Python output flag and keyframe interval flags.
...
Refactored main method into using 6 helper methods for better overview.
Review URL: http://webrtc-codereview.appspot.com/207001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@710 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-07 07:52:00 +00:00
kjellander@webrtc.org
a31b254084
Python output flag and keyframe interval flags.
...
Refactored main method into using 6 helper methods for better overview.
Review URL: http://webrtc-codereview.appspot.com/207001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@709 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-07 06:50:22 +00:00
kjellander@webrtc.org
35a1756502
First version of video quality measurement program and test framework.
...
See https://docs.google.com/a/google.com/document/d/1w6Nrxw6yTg_sDu18Ux8oZPEMo5F_R-zt62udrmmTeOc/edit?hl=en_US
for background, details and additional instructions on usage.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/175001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@700 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-06 06:44:54 +00:00
stefan@webrtc.org
4b6f747373
Fixes a newly introduced bug in the jitter buffer where buffer reallocation
...
causes corrupt pointers.
Review URL: http://webrtc-codereview.appspot.com/186003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@688 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-04 06:58:39 +00:00
stefan@webrtc.org
93d216c23f
Fixed bug in jitter buffer which caused the missingFrames bit to never be set.
...
Also updated the VP8 wrapper to return fully concealed frames (for rendering).
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/190003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@687 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-04 06:48:11 +00:00
stefan@webrtc.org
61b4abf1f8
Proper use of frame rate argument in generic_codec_test.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/181005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@686 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-04 06:40:21 +00:00
mikhal@webrtc.org
e06be4f678
video coding tests: Adding ssimFrame to interface
...
Review URL: http://webrtc-codereview.appspot.com/188004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@685 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-03 22:54:43 +00:00
mikhal@webrtc.org
ae7a0522c5
video_coding robustness: Updating hybrid mode's settings
...
1. Disabling adjustment factor - temporary update.
2. Enabling a windowed filtered loss for the hybrid mode.
Review URL: http://webrtc-codereview.appspot.com/192003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@684 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-03 22:54:34 +00:00
marpan@google.com
f1f3fb33b5
Update to rate-mismatch factor in media_opt_util.
...
Review URL: http://webrtc-codereview.appspot.com/193003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@678 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-03 19:09:45 +00:00
stefan@webrtc.org
5b91464edf
Allow an aggregated partition to spill over to a new packet.
...
Adds support for the case where the partition 0 and parts of partition 1
are transmitted in packet 1, and the end of partition 2 is transmitted
in packet 2.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/181003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@675 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-03 10:26:12 +00:00
mikhal@webrtc.org
848fad23c6
video_coding: Updating media opt test - fixing call to protection callback.
...
Review URL: http://webrtc-codereview.appspot.com/179003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@653 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-27 16:30:59 +00:00
mikhal@webrtc.org
e185e9f68a
video_coding: updates to jitter buffer logic: Make sure that every frame is inserted only once to the list.
...
Review URL: http://webrtc-codereview.appspot.com/165001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@648 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 22:02:40 +00:00
mikhal@webrtc.org
105ff39dec
video coding: updating offline tests.
...
Additional clean-up to the offline test: Placing test callbacks in a designated file.
Review URL: http://webrtc-codereview.appspot.com/167002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@642 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-23 16:41:11 +00:00
marpan@google.com
45fa141f0a
qm_select: changed default settings for uep.
...
Review URL: http://webrtc-codereview.appspot.com/132015
git-svn-id: http://webrtc.googlecode.com/svn/trunk@584 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-12 16:53:19 +00:00
kjellander@webrtc.org
f0a8464b74
Added more statistics during SSIM/PSNR calculation, including calculation of min/max value.
...
Moved video_metrics.h into a GYP library so it can be used from other projects.
Review URL: http://webrtc-codereview.appspot.com/132013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@582 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-12 13:45:39 +00:00
xians@google.com
d3185fe219
refactor the gyp file to gypi file.
...
Basically, the gypi file is a copy of gyp file, but has some difference on the
path of the dependencies.
Review URL: http://webrtc-codereview.appspot.com/137020
git-svn-id: http://webrtc.googlecode.com/svn/trunk@581 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-12 12:24:39 +00:00
marpan@google.com
30ecda146a
media_opt_util: Added comment and lowered window size parameter.
...
Review URL: http://webrtc-codereview.appspot.com/135018
git-svn-id: http://webrtc.googlecode.com/svn/trunk@575 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-09 17:15:12 +00:00
marpan@google.com
3f28061f3a
media_opt_util: Modification to correction factor in FEC overhead.
...
Review URL: http://webrtc-codereview.appspot.com/133019
git-svn-id: http://webrtc.googlecode.com/svn/trunk@573 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-09 16:39:40 +00:00
mikhal@webrtc.org
6f54c20703
video coding test: Adding MT functionality
...
Review URL: http://webrtc-codereview.appspot.com/135008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@570 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-09 14:38:59 +00:00
stefan@webrtc.org
06e2c11703
Remove unintentional printfs
...
Review URL: http://webrtc-codereview.appspot.com/131018
git-svn-id: http://webrtc.googlecode.com/svn/trunk@563 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-08 13:16:24 +00:00
stefan@webrtc.org
167328eab6
Disable libvpx partitions code for libvpx versions prior Cayuga.
...
Necessary for WebRTC to build with Chromium.
Also fixes the decoder wrapper's Reset() function so that properly
reinitializes the decoder.
Review URL: http://webrtc-codereview.appspot.com/132012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@562 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-08 13:05:48 +00:00