188 Commits

Author SHA1 Message Date
mflodman@webrtc.org
657b2a4965 Added return due to gcc complaints in r1604.
TBR=andrew

TEST=Bulid with clang version 3.1 (trunk 148911) and gcc.

Review URL: https://webrtc-codereview.appspot.com/384004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1606 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 11:06:01 +00:00
mflodman@webrtc.org
c80d9d9361 Removed default cases causing clang errors, -Wcovered-switch-default.
BUG=
TEST=Bulid with clang version 3.1 (trunk 148911)

Review URL: https://webrtc-codereview.appspot.com/379008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1604 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 10:11:25 +00:00
kjellander@webrtc.org
ce0a6ff43d Restoring previous vie_auto_test.gypi structure due to problems on Mac
Now the unit test is included in the vie_auto_test target and executed when the automated flag is used.

TBR=mflodman
BUG=
TEST=vie_auto_test --automated --gtest_filter=FrameDropPrimitivesTest.FixOutputFileForComparison

Review URL: https://webrtc-codereview.appspot.com/381003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1598 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-03 14:06:46 +00:00
kjellander@webrtc.org
918a8bf40c External transport is modified to never drop packets from the first frame.
Refactoring of FrameDropHandler: It now also tracks when frames are leaving the encoder and is being sent to external transport.

Previous 'Sent' state is now renamed to 'Created'.

NOTICE: The test seems to be a little flaky on Linux so it's not ready for buildbots yet. Since this might be caused by unstable production code further investigation should be performed to clear out the flakiness. I will file an issue for this when this CL is submitted (since I don't have any code to refer to before that). Usually the flakiness is caused by a decoded/rendered callback that is left out for the last frame, but I have seen other flaky failures too, which means it's not as simple as ignoring the last frame.
These errors occur even if 400kbps bit rate and 0% PL and 0 delay is configured.

BUG=
TEST=vie_auto_test --automated --gtest_filter="ViEVideoVerificationTest.RunsFullStackWithoutErrors" in Debug+Release on Linux, Mac and Windows.

Review URL: http://webrtc-codereview.appspot.com/339005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1597 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-03 12:40:28 +00:00
stefan@webrtc.org
07b45a5dc4 Added API for getting the send-side estimated bandwidth.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/372006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1591 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-02 08:37:48 +00:00
mflodman@webrtc.org
7627843352 Added NULL check in external transport test code.
BUG=C-10246

Review URL: https://webrtc-codereview.appspot.com/367022

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1570 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 13:21:26 +00:00
mflodman@webrtc.org
832adebca2 Removed MapWrapper from ViEFrameProviderBase.
BUG=C-10189

Review URL: https://webrtc-codereview.appspot.com/356002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1560 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 09:31:34 +00:00
mflodman@webrtc.org
194a93ac66 Adding ViE NULL checks.
BUG=C-10188, C-10246, C-10595

Review URL: https://webrtc-codereview.appspot.com/373013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1559 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 09:11:22 +00:00
mflodman@webrtc.org
9b0a820624 Fixed double erase in ViEChannelManager channel map.
Review URL: https://webrtc-codereview.appspot.com/369011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1546 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 16:00:49 +00:00
mflodman@webrtc.org
b11424bc11 Remove ViEShared inheritance for interface impl.
Review URL: https://webrtc-codereview.appspot.com/357002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1545 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 13:42:03 +00:00
henrike@webrtc.org
567b99be5f Coverity report: fixes an issue where the returnvalue of a function is not checked.
Review URL: https://webrtc-codereview.appspot.com/347013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1542 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 23:43:54 +00:00
perkj@webrtc.org
40d3c08be4 Changed max number of vie channels to 32.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/374002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1527 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 14:04:17 +00:00
mflodman@webrtc.org
ba09cf16ec Correcting uninitialized members.
BUG=C-10344, C-10345, C-10346

Review URL: https://webrtc-codereview.appspot.com/345012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1525 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 07:49:33 +00:00
mflodman@webrtc.org
a5a5cbb992 Switched from WebRTC wrappers to stl in ChannelManager.
BUG=C-10187

Review URL: https://webrtc-codereview.appspot.com/357001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1524 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 06:50:15 +00:00
mflodman@webrtc.org
6cf529d082 Changed REMB return value to int instead of bool.
Review URL: https://webrtc-codereview.appspot.com/366001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1522 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 06:16:16 +00:00
leozwang@webrtc.org
f9cd693145 Enable vp8 and videoengine on android
Review URL: https://webrtc-codereview.appspot.com/368003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1510 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-23 16:56:13 +00:00
leozwang@webrtc.org
31627fe82c Add vie_remb.cc to makefile
Review URL: https://webrtc-codereview.appspot.com/358004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1501 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-20 23:10:26 +00:00
phoglund@webrtc.org
d056abd62f Prepared tests for running on build bot.
The changes will mostly clarify why PSNR and SSIM thresholds are chosen. I think those explanations will be good since these tests may well be a bit flaky.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/343017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1496 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-20 12:48:13 +00:00
mflodman@webrtc.org
c672d34ac7 Removed file duplicate added in r1312.
Review URL: https://webrtc-codereview.appspot.com/357003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1495 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-20 12:30:42 +00:00
mflodman@webrtc.org
2d03b8b217 REMB now works for two consecutive calls with different channels but same ViE instance.
BUG=241

Review URL: https://webrtc-codereview.appspot.com/361001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1484 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 21:21:15 +00:00
mflodman@webrtc.org
0f4cb131c6 Added NULL check in ViEFileImpl.
BUG=C-10188

Review URL: https://webrtc-codereview.appspot.com/344016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1480 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 18:41:39 +00:00
mflodman@webrtc.org
70111e69bf Switching to stl instead of WebRTC wrappers.
BUG=C-10436, C-10437, C-10438

Review URL: https://webrtc-codereview.appspot.com/343012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1468 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 12:48:53 +00:00
mflodman@webrtc.org
d5a83ce972 Changed to red and ULPFEC to ulpfec in GetCodec.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/355005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1462 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-18 22:39:32 +00:00
mflodman@webrtc.org
8224451ee4 Add check for ftell return value.
BUG=C-10170

Review URL: https://webrtc-codereview.appspot.com/355001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1450 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-18 09:36:46 +00:00
mflodman@webrtc.org
cdeb483c6a Fixed ignored return value.
BUG=C-10011

Review URL: https://webrtc-codereview.appspot.com/353003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1449 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-18 09:00:04 +00:00
mflodman@webrtc.org
a768ca13f4 Removed dead code.
BUG=C-10062, C-10063, C-10064, C-10065, C-10393, C-10394.

Review URL: https://webrtc-codereview.appspot.com/343013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1448 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-18 08:52:16 +00:00
pwestin@webrtc.org
38e0a771d2 Bugfix removed MPEG4 from windows test.
Review URL: https://webrtc-codereview.appspot.com/348010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1443 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-17 14:18:09 +00:00
pwestin@webrtc.org
5621057956 Removing unused code.
Review URL: https://webrtc-codereview.appspot.com/349008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1442 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-17 12:45:47 +00:00
mflodman@webrtc.org
e5297d2aaa Big parameter passed as argument.
BUG=C-10503, C-10504, C-10505

Review URL: https://webrtc-codereview.appspot.com/343011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1441 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-17 12:44:41 +00:00
mflodman@webrtc.org
2877bdc590 Cleaned up resource leaks.
BUG=C-10059, C-10228, C-10229.

Review URL: https://webrtc-codereview.appspot.com/345013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1439 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-17 12:18:16 +00:00
mflodman@webrtc.org
7b3f3b1e42 CalcBufferSize can return -1, which wasn't handled by ViERenderer.
BUG=C-10532

Review URL: https://webrtc-codereview.appspot.com/345010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1438 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-17 12:12:42 +00:00
perkj@webrtc.org
5735a63e5a Add video capture module to the list of dependent projects in video engine.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/348007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1409 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 14:22:58 +00:00
kjellander@webrtc.org
7f3c724e12 Renaming 47 files from .cpp to .cc
In addition to our naming guidelines, this will cause these files to get parsed by Sonar, and to make searching/grepping the source using file extensions easier in the future.

BUG=
TEST=Compiling on Linux.

Review URL: http://webrtc-codereview.appspot.com/348005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1405 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 10:23:41 +00:00
punyabrata@webrtc.org
9a85b500c5 Minor tracing fix in ::IncomfingFrame and ::IncomfingFrameI420
Review URL: http://webrtc-codereview.appspot.com/352001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1401 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 00:37:07 +00:00
mflodman@webrtc.org
684c7b71c3 Fixed vie_defines.h typo.
BUG=220
TEST=Mac debug build

Review URL: http://webrtc-codereview.appspot.com/347006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1389 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 13:52:06 +00:00
mflodman@webrtc.org
5007056767 Added REMB option to custom call.
Review URL: http://webrtc-codereview.appspot.com/347003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1388 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 13:46:10 +00:00
perkj@webrtc.org
ce5990cb0b Fix defect http://code.google.com/p/webrtc/issues/detail?id=222
"ViE GetSentRTCPStatistics fails on a sending channel if it don't receive rtp video packets.

BUG=222
TEST= tested in loopback. No new test added yet.

Review URL: http://webrtc-codereview.appspot.com/343003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1387 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 13:00:08 +00:00
pwestin@webrtc.org
8281e7dd4a Added RTX to ViE.
Review URL: http://webrtc-codereview.appspot.com/336001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1373 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-10 14:09:18 +00:00
phoglund@webrtc.org
caf39f335f Re-enabled RTP-RTCP test since it's not flaky anymore.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/345003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1369 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-10 13:43:33 +00:00
mflodman@webrtc.org
0ab8ba313b We now require a manually set sender to send REMB packets.
BUG=
TEST=video_engine_unittests

Review URL: http://webrtc-codereview.appspot.com/348003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1358 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-09 16:16:49 +00:00
phoglund@webrtc.org
d8d85711c7 Temporarily disabled the standard rtp-rtcp test because of flakiness.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/349001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1356 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-09 12:06:42 +00:00
phoglund@webrtc.org
dc9536dd0e Made vie_auto_test more robust in Linux when the X environment is broken.
BUG=
TEST=

Review URL: http://webrtc-codereview.appspot.com/329025

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1354 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-09 10:49:23 +00:00
punyabrata@webrtc.org
a0211c38ca Updating video revision
Review URL: http://webrtc-codereview.appspot.com/335016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1339 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 20:02:00 +00:00
mikhal@webrtc.org
d61e1cab08 Updating video engine following latest libyuv api changes
Review URL: http://webrtc-codereview.appspot.com/330026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1336 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 18:57:52 +00:00
pwestin@webrtc.org
c450a19669 Removed Version function from all modules.
TBR=henrik_a
Review URL: http://webrtc-codereview.appspot.com/329023

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1330 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 15:00:12 +00:00
kjellander@webrtc.org
cc33737a80 Changing all PSNR/SSIM calculations to use libyuv.
Removed old PSNR/SSIM implementations in:
* test/testsupport/metrics/video_metrics.cc
* src/modules/video_coding/codecs/test_framework/test.cc
The functions in video_metrics.cc is now using code in libyuv instead. Old code in test.cc is using the same functions.
The code for video_metrics.h had to be moved into a separate GYP file to avoid circular dependency error on Mac (see issue 160 for more details). The reason for this is that libyuv's unittest target depends on test_support_main.

BUG=
TEST=metrics_unittests in Debug+Release on Linux, Mac and Windows.

Review URL: http://webrtc-codereview.appspot.com/333025

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1325 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 08:09:32 +00:00
mflodman@webrtc.org
adec9271b0 Correcting VieChannelManager bug.
Review URL: http://webrtc-codereview.appspot.com/337010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1320 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-03 21:43:15 +00:00
amyfong@webrtc.org
de5a10a044 Added in setting the minimum bit rate of a codec to ViE Custom Call
Review URL: http://webrtc-codereview.appspot.com/333019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1319 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-03 21:06:26 +00:00
andrew@webrtc.org
877c54e230 Fix unused-variable warning in Release.
TBR=mflodman@webrtc.org
TEST=Build Debug/Release on Linux

Review URL: http://webrtc-codereview.appspot.com/338003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1316 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-03 18:32:01 +00:00
mflodman@webrtc.org
9c0aedc28b Removed constraint for changing resolution when using default encoder and added VP8 log.
Review URL: http://webrtc-codereview.appspot.com/330029

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1314 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-03 13:46:49 +00:00