mflodman@webrtc.org
657b2a4965
Added return due to gcc complaints in r1604.
...
TBR=andrew
TEST=Bulid with clang version 3.1 (trunk 148911) and gcc.
Review URL: https://webrtc-codereview.appspot.com/384004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1606 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 11:06:01 +00:00
mflodman@webrtc.org
c80d9d9361
Removed default cases causing clang errors, -Wcovered-switch-default.
...
BUG=
TEST=Bulid with clang version 3.1 (trunk 148911)
Review URL: https://webrtc-codereview.appspot.com/379008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1604 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-06 10:11:25 +00:00
pwestin@webrtc.org
f6bb77a6f0
Cleaning up all use of RTP_PAYLOAD_NAME_SIZE and RTCP_CNAME_SIZE also fixed the char handing in trace.
...
Review URL: https://webrtc-codereview.appspot.com/358001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1535 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 17:16:59 +00:00
mflodman@webrtc.org
67cdc22e7e
CpuLinux file handle leak.
...
BUG=crbug.com/110165
Review URL: http://webrtc-codereview.appspot.com/353001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1429 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-16 09:31:39 +00:00
pwestin@webrtc.org
df9866fedb
Bugfix mac pid_t
...
Review URL: http://webrtc-codereview.appspot.com/350004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1384 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 08:57:47 +00:00
pwestin@webrtc.org
b54d72778c
Changed thread Id handling in trace.
...
Review URL: http://webrtc-codereview.appspot.com/331020
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1383 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 08:28:04 +00:00
leozwang@webrtc.org
bccac66885
Use a more common macro to get thread id
...
Review URL: http://webrtc-codereview.appspot.com/342004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1349 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-06 00:32:00 +00:00
pwestin@webrtc.org
43761beb47
Bugfix get thread ID for linux.
...
Review URL: http://webrtc-codereview.appspot.com/331015
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1282 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-22 09:40:28 +00:00
andrew@webrtc.org
04f5cba069
Switch to new critsect interface for DataLog.
...
The introduction of the new interface broke DataLog in a release build
(with enable_data_logging=1).
TBR=henrike@webrtc.org
TEST=build Linux/Release with enable_data_logging=1
Review URL: http://webrtc-codereview.appspot.com/334001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1212 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 21:33:11 +00:00
andrew@webrtc.org
986fab1496
Clean up file wrapper a bit further.
...
- Make error handling in Read, Write and WriteText consistent.
- Improve the interface comments a bit.
TEST=voe_auto_test, vie_auto_test
Review URL: http://webrtc-codereview.appspot.com/321012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1210 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 19:11:41 +00:00
henrike@webrtc.org
bfa80ce95e
Removed usage of the deprecated critical section constructor in system_wrappers.
...
Review URL: http://webrtc-codereview.appspot.com/322004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1208 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 17:59:58 +00:00
leozwang@webrtc.org
e0e07bbaa0
Change file name because of r1199
...
Review URL: http://webrtc-codereview.appspot.com/320013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1201 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 00:51:45 +00:00
andrew@webrtc.org
59ccd5c71f
Rename _windows.h -> _win.h in system_wrappers.
...
- Also rename _dummy -> no_op which states its purpose more clearly.
- Always use exclusion lists (i.e. sources! instead of sources)
TEST=builds and passes system_wrapper_unittest on Linux, Mac, Win
Review URL: http://webrtc-codereview.appspot.com/317007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1199 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 00:17:43 +00:00
andrew@webrtc.org
7e5ddf5aa3
Restore behavior to FileWrapper::Read.
...
- Returning the number of bytes read was mistakenly removed in r1175 in
an overzealous attempt to unify the interface.
- Now both Read and WriteText return the number of bytes/characters
processed. Write unfortunately cannot be easily changed due to the
inheritance from OutStream.
- Improve the interface comments.
TBR=henrika@webrtc.org
BUG=issue196, issue198
TEST=voe_auto_test passes at last...
Review URL: http://webrtc-codereview.appspot.com/326001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1188 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 18:02:02 +00:00
andrew@webrtc.org
6d609b59f3
Fix crashes due to static_instance.
...
- Initialize a needed critsect in the constructor of
UdpSocket2ManagerWindows.
- Don't return NULL when creating a static instance.
TEST=voe_auto_test on Windows.
Review URL: http://webrtc-codereview.appspot.com/324008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1177 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 02:36:33 +00:00
andrew@webrtc.org
5a9c6f26ab
Fix max size and read-only errors in Write().
...
- A size of zero is now correctly interpreted as unlimited.
- The read-only flag is correctly checked.
TBR=henrika@webrtc.org
TEST=vie_auto_test (for real this time...)
Review URL: http://webrtc-codereview.appspot.com/315007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1176 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 00:53:30 +00:00
andrew@webrtc.org
5ae19de3ec
Fix error in RtpDump::Start due to r1156.
...
- r1156 fixed a check on the _text member of FileWrapper. Turns out this
was incompatibile with the RTP dumps, which want to write both binary
and text data. Writing text data to a file open as "b" isn't actually
an error, so I simply removed the check.
- Also cleans up the interface, most notably removing all WebRtc types.
TEST=vie_auto_test
Review URL: http://webrtc-codereview.appspot.com/317005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1175 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 22:59:33 +00:00
wjia@webrtc.org
c28e7980ef
exclude trace_windows.cc and trace_posix.cc when building with Chromium.
...
BUG=none
TEST=compiles
Review URL: http://webrtc-codereview.appspot.com/324004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1165 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 02:16:11 +00:00
andrew@webrtc.org
114c790be7
Remove character limit in WriteText().
...
- vfprintf can be used directly here, removing the need for the interim
buffer. This change allows us to remove the artificial character limit.
- Fix bugs with _text. It wasn't actually getting set earlier, and the
check was wrong.
- Remove asserts that should use real error checks.
TEST=DataLog and VoECallReport (through voe_auto_test), the only users of WriteText().
Review URL: http://webrtc-codereview.appspot.com/323001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1156 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-10 02:33:33 +00:00
henrike@webrtc.org
2f47b5a70f
Fixes a build error when disabling trace (which is done when building with chrome flag is set).
...
Review URL: http://webrtc-codereview.appspot.com/318006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1155 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-10 00:44:47 +00:00
henrike@webrtc.org
315282c01a
Fixes a compiler warning related to dynamically allocated static memory. the fix is to leak the memory since the OS will clean it up anyways. This will not add noise to memory tools so it's ok. The issue is reported here: http://code.google.com/p/webrtc/issues/detail?id=147 .
...
Review URL: http://webrtc-codereview.appspot.com/267023
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1150 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 17:46:20 +00:00
kma@webrtc.org
b59c031660
For Android ARMv7 platforms, added a feature of dynamically detecting the existence of Neon,
...
and when it's present, switch to some functions optimized for Neon at run time.
Review URL: http://webrtc-codereview.appspot.com/268002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1096 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-03 18:34:50 +00:00
henrike@webrtc.org
c2ac8953d5
Fixes Valgrind warnings in system wrappers unittest.
...
Review URL: http://webrtc-codereview.appspot.com/293006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1071 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-30 22:46:59 +00:00
henrike@webrtc.org
0bf2ca2eed
Fixes broken unit test http://code.google.com/p/webrtc/issues/detail?id=154
...
Review URL: http://webrtc-codereview.appspot.com/292007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1053 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-29 18:21:46 +00:00
kjellander@webrtc.org
c625c1010a
Updated system_wrappers_unittests to use the test_support_main target.
...
Review URL: http://webrtc-codereview.appspot.com/291012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1048 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-29 12:11:06 +00:00
henrike@webrtc.org
ce9d89d892
Fixes linux build error introduced in r980.
...
Review URL: http://webrtc-codereview.appspot.com/279012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@981 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-19 00:14:37 +00:00
henrike@webrtc.org
ad98a3eed0
Fixes TEST crash triggered by webrtc-codereview.appspot.com/268014.
...
Review URL: http://webrtc-codereview.appspot.com/280005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@980 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-18 23:55:12 +00:00
henrike@webrtc.org
3798ecb25b
Made CPU initialization on Windows lazy to prevent long startup time.
...
Review URL: http://webrtc-codereview.appspot.com/268014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@977 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-18 16:25:54 +00:00
tommi@webrtc.org
cde1e7f42a
Use a TraceNoop instance when tracing disabled (to be used in Chromium).
...
I'm also adding an empty implementation for static methods in the Trace
interface since the default implementation relies on TraceImpl.
Review URL: http://webrtc-codereview.appspot.com/267013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@946 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-15 12:23:36 +00:00
kma@webrtc.org
b61c410347
Fixed a couple of Android makefiles to let voe and vie build properly.
...
Review URL: http://webrtc-codereview.appspot.com/278001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@928 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-10 18:10:25 +00:00
henrikg@webrtc.org
c58ef08da2
Removes system CPU measurement for Chrome build.
...
It does not work on Chrome Windows, and is anyway not needed for Chrome.
Review URL: http://webrtc-codereview.appspot.com/243006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@902 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-08 08:44:17 +00:00
andrew@webrtc.org
f1a45d77fb
Add missing <stdlib.h> to data_log test.
...
BUG=
TEST=system_wrappers_unittests
Review URL: http://webrtc-codereview.appspot.com/256002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@851 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-31 21:44:54 +00:00
kjellander@webrtc.org
84736882ad
Fixing system_wrappers unittests.
...
Not complete, but enough to include them in the build again.
Review URL: http://webrtc-codereview.appspot.com/241008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@848 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-31 20:44:24 +00:00
kjellander@webrtc.org
177bb523bd
Fixing system_wrappers unittests.
...
Not complete, but enough to include them in the build again.
Review URL: http://webrtc-codereview.appspot.com/241008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@842 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-31 17:10:01 +00:00
henrike@webrtc.org
0d0037c2fd
Return cached data instead of sleeping in CpuWrapperMac (shaves 2s off WebrtcMediaEngine creation time on Mac).
...
Review URL: http://webrtc-codereview.appspot.com/226005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@804 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-24 15:48:14 +00:00
henrik.lundin@webrtc.org
5dedd0ee38
Handling of white-space in DataLog::Combine
...
The Combine method cannot handle white-space. Adding a comment to
the header file saying this, and modifying the unittests. Also,
adding a new unittest to test the method.
Review URL: http://webrtc-codereview.appspot.com/217001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@760 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-18 05:45:08 +00:00
henrike@webrtc.org
a0258defd4
Fixes test build errors (warnings treated as errors) in system_wrappers.
...
Review URL: http://webrtc-codereview.appspot.com/212003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@725 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-11 14:49:27 +00:00
henrik.lundin@webrtc.org
26c9ff983e
Add dummy implementation of DataLog::Combine method
...
The dummy implementations of class methods are needed when
building without support for data logging (i.e., when
enable_data_logging != 1). The Combine method was missing
from data_log_dummy.cc.
Review URL: http://webrtc-codereview.appspot.com/220003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@724 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-11 14:43:41 +00:00
henrik.lundin@webrtc.org
d855bd4d6f
C wrapper for DataLog class
...
A pure C wrapper for the DataLog class was created. Since templates
are not supported in C, the InsertCell method of the DataLog class
must be wrapped using one wrapper function for each data type. So far,
the wrapper includes int, float, double, Word32, UWord32, and Word64.
Unittests were created for the wrapper. A separate helper file was
included in the tests. This helper file was implemented as a C file,
in order to actually test the C linkage of the wrapper.
The unittests for DataLog were cloned to make versions that do the same
things but through the C wrapper interface. Restructured the code
so that the log file verification was not duplicated.
Review URL: http://webrtc-codereview.appspot.com/195003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@715 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-10 08:06:17 +00:00
henrike@webrtc.org
1a2933c71a
Fixes a Valgrind warning triggering when the number of pending messages hit the limit.
...
Review URL: http://webrtc-codereview.appspot.com/200002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@705 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-06 17:55:56 +00:00
andrew@webrtc.org
a3c6d61c44
Integrate the built-in WASAPI AEC DMO to VoE.
...
Review URL: http://webrtc-codereview.appspot.com/108006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@592 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-13 17:17:49 +00:00
stefan@webrtc.org
3bbe41aad6
Add support for a numeric table id in DataLogs.
...
Useful when logging in modules which have multiple instances and the logs
should be separated into different tables.
Review URL: http://webrtc-codereview.appspot.com/132003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@555 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-07 15:31:03 +00:00
perkj@google.com
88a0da8fde
Add ref_count.h to gyp file.
...
Review URL: http://webrtc-codereview.appspot.com/133013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@520 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 12:51:35 +00:00
stefan@webrtc.org
c9cff24ff0
Adding classes to be used for logging data within the engines and the
...
components for offline processing. Data logged with these classes can
conveniently be parsed and processed with e.g. Matlab.
Review URL: http://webrtc-codereview.appspot.com/95009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@477 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-29 07:39:02 +00:00
hellner@google.com
23a8065e36
Fixed broken build due to r453.
...
Review URL: http://webrtc-codereview.appspot.com/131004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@455 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-25 21:40:11 +00:00
zakkhoyt@google.com
59af6f1434
Porting Mac keypress detection from GIPS repository.
...
Mac keypress detection was added specifically for GTalk.
Review URL: http://webrtc-codereview.appspot.com/124001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@453 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-25 20:30:25 +00:00
wu@webrtc.org
ae53bf87d7
The variable ‘dummy’ set but not used being treated as errors in Fedora.
...
Review URL: http://webrtc-codereview.appspot.com/122004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@425 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 18:56:56 +00:00
hellner@google.com
aab69a4145
removed trailing whitespaces.
...
Review URL: http://webrtc-codereview.appspot.com/109010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@386 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-16 23:17:32 +00:00
hellner@google.com
064a8dfaa2
Minimal fixes to remove build warnings.
...
Review URL: http://webrtc-codereview.appspot.com/113004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@376 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-16 15:52:28 +00:00
wu@webrtc.org
3d48d5b107
Bug fix. When GetNumCores failed it will return -1, which is a huge number if cast to unsigned int.
...
Review URL: http://webrtc-codereview.appspot.com/116005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@371 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-16 00:03:36 +00:00