admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,542 Commits 1 Branch 0 Tags
Commit Graph

52 Commits

Author SHA1 Message Date
phoglund@webrtc.org
78088c2f36 Removed warnings on Windows and enabled warnings-as-errors on Windows. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/377004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1624 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-07 14:56:45 +00:00
bjornv@webrtc.org
530963925e Solves buffer overrun crash on Windows [issue 258]. 
Removed function calls not tested. Added a TODO on activating them when refactoring signal_processing.
Review URL: https://webrtc-codereview.appspot.com/379012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1620 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-07 08:10:46 +00:00
bjornv@webrtc.org
26e8a58130 VAD refactor: Create() and Free() 
Style and return value changes. No impact externally, since audio_processing, audio_conference_mixer and audio_coding either already assumes 'int' as return value, assumes nothing or doesn't take care of the return value.

TESTS=vad_unittests, audioproc_unittest
Review URL: https://webrtc-codereview.appspot.com/374006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1581 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-31 14:42:50 +00:00
bjornv@webrtc.org
0c6f931420 Removed versions in module/audio_processing and common_audio/vad. 
Affected vad_unittest only.
In addition changed to correct header guards.
Review URL: https://webrtc-codereview.appspot.com/367019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1567 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-30 09:39:08 +00:00
bjornv@webrtc.org
f4b77fd722 VAD refactor: Mode changed to "int". 
As part of style this CL includes changing the input aggressiveness mode from int16_t to int. No other style changes made.
Impact on:
- Audio Processing: Changed return value on MapSetting().
- Function test in audio_conference_mixer already uses int. No action.
- NetEq: Function pointer changes and input parameter changes in SetVADMode() and SetVADModeInternal().
- Audio Coding: Uses enum ACMVADMode which is type independent.
- VAD: Two unit tests.

TESTS=vad_unittests, neteq_unittests, audioproc_unittest
Review URL: https://webrtc-codereview.appspot.com/373001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1544 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-25 12:40:00 +00:00
bjornv@webrtc.org
2a4dcd7d15 VAD refactor: WebRtcVad_InitCore(). 
Impact only locally.
- Replaced for loops with memset().
- Added guard against NULL pointer.
- Removed mode as input parameter (never really used).
- Updated unit tests.
- Made struct member init_flag "int".
- Updated function description.
- Updated Copyright notes with 2012.
- Removed some lint warnings.

TESTS=vad_unittests, audioproc_unitest
Review URL: https://webrtc-codereview.appspot.com/369005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1543 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-25 12:18:12 +00:00
kma@webrtc.org
4bc24c4afa Optimized function WebRtcSpl_FilterARFastQ12 for ARM platform. 
Speed close to doubled for an offline test in NetEq.
Bit exact.
Review URL: https://webrtc-codereview.appspot.com/346001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1520 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-24 02:12:49 +00:00
bjornv@webrtc.org
152c34cf11 VAD-refactor. Changed to int as return value for WebRtcVad_set_mode(). 
Impact on NetEq function pointers. Other components already treat the output as int. These are:
* audio_processing
* funtion test in audio_conference_mixer
* audio_coding

TEST=vad_unittests, neteq_unittests
Review URL: https://webrtc-codereview.appspot.com/367003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1503 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-23 12:36:46 +00:00
bjornv@webrtc.org
6748087467 Incorrect pointer inputs in filter test. 
Two filter functions were called wrongly, which made us read from uninitialized values.
Added short comment.
No style changes. The tests will be revisited and extended during an upcoming refactor.

signal_processing_unittests now pass Valgrind.

TEST=signal_processing_unittests
Review URL: https://webrtc-codereview.appspot.com/344015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1466 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-19 10:41:39 +00:00
bjornv@webrtc.org
ab2bb82ac9 VAD refactor: int return value for Init. 
For consistency and as part of style, the return value of WebRtcVad_Init() has been changed to int.

Impact:
 1) audio_processing, audio_coding, a test in CNG, functionTest in audio_conference_mixer, a test in net_eq all used int values. Hence, unaffected.
 2) Function pointers in net_eq changed.
 3) The VADInit in neteq/dsp.c boiled down to typecast into int anyhow, which now is removed.

TEST=vad_unittests, neteq_unittests
Review URL: https://webrtc-codereview.appspot.com/355003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1453 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-18 14:51:02 +00:00
bjornv@webrtc.org
4259fd725c Refactor VAD: Code restructure 
- Tests added for vad_core.
- Replaced two macros with constants.
- Made an internal function static.
- Replaced replicated code with function call.
Review URL: https://webrtc-codereview.appspot.com/354001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1444 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-17 14:37:59 +00:00
bjornv@webrtc.org
40ea5106f6 Refactoring vad_filterbank 
Made internal function LogOfEnergy() more efficient.
Includes
- Name change "vector" -> "data"
- Complete refactor of LogOfEnergy()
- Removed lint warning

Major changes:
* Removed unnecessary variables
* Reduced number of shifts
* Removed one norm calculation


TEST=vad_unittests, audioproc_unittest
Review URL: http://webrtc-codereview.appspot.com/347004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1407 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-12 12:47:42 +00:00
bjornv@webrtc.org
d1f148da77 Refactor vad_filterbank: Some restructuring. 
- Removed unnecessary type casting.
- Added comments.
- Removed shift macros.
- Name change of _get_features() to _CalculateFeatures(). Affects vad_core.c and vad_filterbank_unittest.cc.
Review URL: http://webrtc-codereview.appspot.com/343002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1371 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-10 13:48:09 +00:00
bjornv@webrtc.org
d9c87b2146 Refactor vad_filterbank: Local functions made static. 
Review URL: http://webrtc-codereview.appspot.com/342002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1357 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-09 13:11:29 +00:00
bjornv@webrtc.org
e6471ba8d2 VAD unittest updates. 
Split the local function tests into separate files.
Review URL: http://webrtc-codereview.appspot.com/330031

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1352 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-09 09:54:07 +00:00
kma@webrtc.org
b0abbd353d Optimized spl function WebRtcSpl_CrossCorrelation for ARM Neon platforms. 
When used in Neteq, Neteq performance improved from 13 to 33% with different
test configurations.
Output is not bit-exact with generic C code in file cross_correlation.c, 
due to reduction of shift operations from using Neon registers, although in
theory now the result is more accurate than before.
Review URL: http://webrtc-codereview.appspot.com/333013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1350 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-06 19:50:20 +00:00
bjornv@webrtc.org
8f4a4ce13b Refactoring vad_filterbank: Style changes. 
Consists of:
- variable names.
- variable initialization.
- ordered input/output parameters.

TEST=vad_unittest, audioproc_unittest
Review URL: http://webrtc-codereview.appspot.com/339004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1345 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-05 08:42:39 +00:00
bjornv@webrtc.org
226c5a1a95 Refactoring of vad_sp.[h/c] 
- define guard name change
- changed to stdint
- added unit test
- removed shift macros
- style changes
- comments
Review URL: http://webrtc-codereview.appspot.com/336004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1326 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-04 09:15:12 +00:00
bjornv@webrtc.org
f175125e96 Refactoring vad_filterbank: Style changes. 
Includes:
- Correct header guard
- Indentations and white spaces
- Changed to stdint
Review URL: http://webrtc-codereview.appspot.com/330030

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1315 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-03 15:07:42 +00:00
tina.legrand@webrtc.org
5c43b1b861 Updated resampler unit test with stereo. 
I needed to run valgrind on this particular test, to exclude from valgrind warnings in ACM. Test passes valgrind without problems.
Review URL: http://webrtc-codereview.appspot.com/332010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1278 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-22 08:28:05 +00:00
bjornv@webrtc.org
c68f80a70a Refactoring vad_gmm.[c/h]. 
- Changed to stdint.
- Replaced SHIFT macros.
- Variable name changes.
- Style changes.
- Comments updates.
- Added a unit test.
Review URL: http://webrtc-codereview.appspot.com/323011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1249 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-20 14:08:34 +00:00
bjornv@webrtc.org
0edb25dcc9 Removed valgrind warnings in resampler_unittest. 
Valgrind complained on uninitialized values in resampler_unittest. Added initialization of the member variable data_in_ in the tests.
Review URL: http://webrtc-codereview.appspot.com/322006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1167 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-13 09:06:54 +00:00
bjornv@webrtc.org
132feb1270 Made tables static. 
In this CL global tables have been moved to where they are actually used. If for some reason they need to be available in a larger scope we can add them again at that point.
Review URL: http://webrtc-codereview.appspot.com/303002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1075 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-01 15:40:50 +00:00
bjornv@webrtc.org
bedabb25bf Added const on const tables. 
Builds on Linux.

Tommi: Can you try on Windows?
Review URL: http://webrtc-codereview.appspot.com/300002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1072 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-12-01 07:44:32 +00:00
bjornv@webrtc.org
48b68c0c24 Added support for 96 kHz sampling frequency. 
Updated resampler_unittests with the new valid combinations.
Verified audio quality on files.

TEST=resampler_unittests, voe_auto_test
BUILDTYPE=Debug, Release
PLATFORM=Linux
Review URL: http://webrtc-codereview.appspot.com/294001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1002 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-11-23 13:50:41 +00:00
kjellander@webrtc.org
0403ef419f Restructuring and adding unit test targets on project level instead of in common_audio. 
Review URL: http://webrtc-codereview.appspot.com/280001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@959 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-11-17 08:35:47 +00:00
kjellander@webrtc.org
20a370e875 Changing the namespace of TestSuite to webrtc::test. 
Adding gmock initialization into main test runner class

Review URL: http://webrtc-codereview.appspot.com/254004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@885 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-11-04 01:19:16 +00:00
bjornv@webrtc.org
250cd6f41b Added a VAD unit test to common_audio. At this stage it runs through the API calls, but should later be complemented with tests on a file. 
Review URL: http://webrtc-codereview.appspot.com/243002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@832 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-10-28 12:45:58 +00:00
bjornv@webrtc.org
52eddf7378 Made Tina, Andrew and Jan as OWNERS to entire common_audio and removed the sub-OWNERS files. Let me know if that's fine. 
Review URL: http://webrtc-codereview.appspot.com/225006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@763 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-10-18 07:57:04 +00:00
bjornv@webrtc.org
2111d3b0b0 Removed the vad_const files and added the constants to the files where they are 
used. Having them in a separate file did not add anything in readability or
conceptual overview.
Review URL: http://webrtc-codereview.appspot.com/230004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@746 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-10-14 12:58:34 +00:00
kma@webrtc.org
a58224f9f0 Introduced a SPL inline function (multiple-accumulate), for preformance in ARMv7. 
It's used in quite some occations over many modules.
Review URL: http://webrtc-codereview.appspot.com/178004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@691 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-10-05 16:44:11 +00:00
kma@google.com
961885a8bb In spl, introduced function WebRtcSpl_Sat32To16(), and changed file resample_by_2.c, both for optimization in ARMv7. 
Review URL: http://webrtc-codereview.appspot.com/140010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@649 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-09-26 16:35:25 +00:00
andrew@webrtc.org
19eefdc9f0 Add a unit testing framework. 
Populate it with the beginnings of a resampler unit test to have it do someting.

Also fix a bug in resampler caught with the test ;)
Review URL: http://webrtc-codereview.appspot.com/135019

git-svn-id: http://webrtc.googlecode.com/svn/trunk@595 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-09-14 17:02:44 +00:00
xians@google.com
d3185fe219 refactor the gyp file to gypi file. 
Basically, the gypi file is a copy of gyp file, but has some difference on the
path of the dependencies.
Review URL: http://webrtc-codereview.appspot.com/137020

git-svn-id: http://webrtc.googlecode.com/svn/trunk@581 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-09-12 12:24:39 +00:00
kma@google.com
0ada410d37 Corrected conditional compilations for spl inline functions in ARM. 
Review URL: http://webrtc-codereview.appspot.com/140004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@571 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-09-09 16:23:50 +00:00
kma@google.com
b6fc9f1d6f optimized one spl function for AECM. 
AECM test results bit-exact.
Review URL: http://webrtc-codereview.appspot.com/139012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@556 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-09-07 17:20:49 +00:00
kma@google.com
78dc99e2a1 performance in ARM V7 improved 7~8 %. 
Review URL: http://webrtc-codereview.appspot.com/114007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@384 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-08-16 20:00:18 +00:00
andrew@webrtc.org
5cdec9e399 Fix common_audio warnings. 
- Unused variable.
- Explicit operator precedence.
Review URL: http://webrtc-codereview.appspot.com/112004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@380 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-08-16 16:39:32 +00:00
kma@google.com
8d0c98b954 some optimization in aecm for armv7. 
Review URL: http://webrtc-codereview.appspot.com/89018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@346 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-08-10 23:31:24 +00:00
andrew@webrtc.org
8910f278c5 Switch to webrtc.org accounts (for those which exist). 
Review URL: http://webrtc-codereview.appspot.com/97010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@342 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-08-10 05:16:31 +00:00
ajm@google.com
4a4d7c6693 Fix a compile error on MSVC. 
- Declare all variables at the start of scope.
- Remove the needless local variables from these functions.
Review URL: http://webrtc-codereview.appspot.com/97009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@330 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-08-08 20:40:31 +00:00
kma@google.com
881103225d optimization of resampling by 2 in ARMv7, in spl. 
Review URL: http://webrtc-codereview.appspot.com/92015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@327 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-08-08 15:40:10 +00:00
leozwang@google.com
79835d1bd3 Clean up Android.mk 
Review URL: http://webrtc-codereview.appspot.com/92014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@315 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-08-05 21:01:02 +00:00
leozwang@google.com
77f49d8219 Clean up ANDROID macro definitions [common_audio] 
Review URL: http://webrtc-codereview.appspot.com/91004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@262 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-07-27 18:58:33 +00:00
ajm@google.com
1e34241426 Fixing some warnings in common_audio. 
Review URL: http://webrtc-codereview.appspot.com/77002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@227 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-07-18 17:27:02 +00:00
leozwang@google.com
f70cc07137 Revert back to reviewed version, http://webrtc-codereview.appspot.com/60003/ 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@226 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-07-18 17:12:22 +00:00
leozwang@google.com
c93db4c4e1 Remove legacy fft arm9e code 
Either for generic FFT code or FFT code specific to ARM-Cortex or ARM-Neon will be used, this folder should be removed. 
Review URL: http://webrtc-codereview.appspot.com/60003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@225 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-07-18 16:48:17 +00:00
bjornv@google.com
801809c768 Removed invalid declarations in spl unit_test. 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@223 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-07-18 14:05:24 +00:00
leozwang@google.com
3c0a86f83d Change android makefile to be able to build for x86 
Review URL: http://webrtc-codereview.appspot.com/68001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@207 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-07-14 18:23:07 +00:00
bjornv@google.com
c83a3d6e2e Added the new sqrt routine as a separate function. 
Review URL: http://webrtc-codereview.appspot.com/55004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@175 4adac7df-926f-26a2-2b94-8c16560cd09d
 2011-07-07 12:34:44 +00:00