kjellander
569cf942c0
PRESUBMIT: Add check for JSON parse errors + fix JSON
...
The PRESUBMIT code is basically a stripped-down copy of the code in
Chromium's src/PRESUBMIT.py.
BUG=chromium:498746
TESTED=I verified with 'git cl presubmit' that the existing
error was found. Then I ran it again after fixing it, with
presubmit passing.
NOTRY=True
Review URL: https://codereview.webrtc.org/1682393002
Cr-Commit-Position: refs/heads/master@{#11572}
2016-02-11 13:03:05 +00:00
kjellander@webrtc.org
15ba6242ad
Revert of Rename iOS test specs to match buildbot names. (patchset #1 id:1 of https://codereview.webrtc.org/1665783002/ )
...
Reason for revert:
*sigh* that didn't work, the reading of the JSON file fails (which I was suspecting it would).
Example: https://build.chromium.org/p/client.webrtc.fyi/builders/iOS64%20Simulator%20Debug/builds/17/steps/steps/logs/stdio
I'll rename all the iOS bots instead since I think it's reasonably rare we link to their logs, so there won't be that many broken URLs.
Original issue's description:
> Rename iOS test specs to match buildbot names.
>
> I really prefer not using spaces in any filenames but
> if we were to rename all the bots all existing URLs to builds
> would stop working (or we'd loose the build history), so I'd
> like to see if this works first.
> The bots that hits the errors are the new ones I'm experimenting
> with in client.webrtc.fyi. Example failing build:
> https://build.chromium.org/p/client.webrtc.fyi/builders/iOS64%20Simulator%20Debug
>
> BUG=chromium:498746
> NOTRY=True
> TBR=phoglund@webrtc.org
>
> Committed: https://crrev.com/86512b401ecee4b5e18ee6fbec28ec9c1d0ead9b
> Cr-Commit-Position: refs/heads/master@{#11473}
TBR=phoglund@webrtc.org
NOTRY=True
NOPRESUBMIT=True
BUG=chromium:498746
Review URL: https://codereview.webrtc.org/1666163002 .
Cr-Commit-Position: refs/heads/master@{#11489}
2016-02-04 14:13:51 +00:00
kjellander
86512b401e
Rename iOS test specs to match buildbot names.
...
I really prefer not using spaces in any filenames but
if we were to rename all the bots all existing URLs to builds
would stop working (or we'd loose the build history), so I'd
like to see if this works first.
The bots that hits the errors are the new ones I'm experimenting
with in client.webrtc.fyi. Example failing build:
https://build.chromium.org/p/client.webrtc.fyi/builders/iOS64%20Simulator%20Debug
BUG=chromium:498746
NOTRY=True
TBR=phoglund@webrtc.org
Review URL: https://codereview.webrtc.org/1665783002
Cr-Commit-Position: refs/heads/master@{#11473}
2016-02-03 12:41:10 +00:00
kjellander
8e85a3f39a
iOS buildbot configurations.
...
This will make it possible for WebRTC to use the same buildbot
scripts as Chrome's iOS bots.
Buildbot changes are done in https://codereview.chromium.org/1659163003/
BUG=chromium:498746
NOTRY=True
Review URL: https://codereview.webrtc.org/1660053002
Cr-Commit-Position: refs/heads/master@{#11468}
2016-02-03 08:06:06 +00:00
