pkasting@chromium.org
4591fbd09f
Use size_t more consistently for packet/payload lengths.
...
See design doc at https://docs.google.com/a/chromium.org/document/d/1I6nmE9D_BmCY-IoV6MDPY2V6WYpEI-dg2apWXTfZyUI/edit?usp=sharing for more information.
This CL was reviewed and approved in pieces in the following CLs:
https://webrtc-codereview.appspot.com/24209004/
https://webrtc-codereview.appspot.com/24229004/
https://webrtc-codereview.appspot.com/24259004/
https://webrtc-codereview.appspot.com/25109004/
https://webrtc-codereview.appspot.com/26099004/
https://webrtc-codereview.appspot.com/27069004/
https://webrtc-codereview.appspot.com/27969004/
https://webrtc-codereview.appspot.com/27989004/
https://webrtc-codereview.appspot.com/29009004/
https://webrtc-codereview.appspot.com/30929004/
https://webrtc-codereview.appspot.com/30939004/
https://webrtc-codereview.appspot.com/31999004/
Committing as TBR to the original reviewers.
BUG=chromium:81439
TEST=none
TBR=pthatcher,henrik.lundin,tina.legrand,stefan,tkchin,glaznev,kjellander,perkj,mflodman,henrika,asapersson,niklas.enbom
Review URL: https://webrtc-codereview.appspot.com/23129004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7726 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-20 22:28:14 +00:00
asapersson@webrtc.org
96dc685143
Add stats for video:
...
- number of sent/received RTCP NACK/FIR/PLI per minute
- percentage of unique sent/received NACK requests
- percentage of discarded/duplicated packets by the jitter buffer
- permille of sent/received key frames
BUG=crbug/419657
R=mflodman@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/24959004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7592 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-03 14:40:38 +00:00
andrew@webrtc.org
cc476aa038
Fix a name collision with Android libc++
...
The Android libc++ has a symbol called '_P'
This CL renames a property called _P in webrtc.
BUG=chromium:427718
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/30009004
Patch from Fabrice de Gans-Riberi <fdegans@chromium.org>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7579 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-31 16:01:25 +00:00
henrike@webrtc.org
bd6bdca57f
scoped_ptr.h: Renames function and change namespace scope to fix conflicts with Chromium not detected by the FYI bots.
...
BUG=N/A
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/23259004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7546 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-28 18:06:42 +00:00
andrew@webrtc.org
b787f4c593
Move scoped_ptr "free" functions into the webrtc namespace.
...
Resolves a conflict with Chromium's scoped_ptr on the recently added
make_scoped_ptr().
TEST=local Chromium Linux build passes.
R=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/26969004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7535 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-27 17:42:22 +00:00
andrew@webrtc.org
df429882af
Upgrade our scoped_ptr copy to match Chromium's latest.
...
In particular add the move constructor and assignment operator.
Diff between our version and Chromium's:
https://paste.googleplex.com/4887047529562112
R=henrike@webrtc.org , kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31789004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7531 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-27 16:12:38 +00:00
asapersson@webrtc.org
580d367b14
Add macros and APIs for webrtc histograms.
...
BUG=crbug/419657
Code that links system_wrappers.gyp:system_wrappers should either:
- provide implementations for the APIs, or
- link with default implementations in system_wrappers.gyp:system_wrappers_default.
R=andresp@webrtc.org , kjellander@webrtc.org , mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/22809004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7508 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-23 12:57:56 +00:00
andrew@webrtc.org
325cff01b4
Import LappedTransform and friends.
...
Add code for doing block-based frequency domain processing. Developed
and reviewed in isolation. Corresponding export CL:
https://chromereviews.googleplex.com/95187013/
R=bercic@google.com , kjellander@webrtc.org , turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31539004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7359 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-10-01 17:42:18 +00:00
pbos@webrtc.org
38344ed280
Move thread_annotations.h to webrtc/base/.
...
R=andresp@webrtc.org , mflodman@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/27579004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7283 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-24 06:05:00 +00:00
henrike@webrtc.org
7ea71de396
clock.h: Removed GUARDED_BY annotation as it breaks som builds.
...
BUG=N/A
TBR=henrik.lundin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14769004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6547 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-26 16:13:58 +00:00
henrik.lundin@webrtc.org
19db3e3164
Don't forward declare RWLockWrapper in clock.h
...
Include rw_lock_wrapper.h instead of forward declaring. This is to
come around problems with thread annotations in some build systems.
BUG=3516
R=mflodman@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17809004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6545 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-26 14:01:18 +00:00
henrik.lundin@webrtc.org
190a32fd55
Make some methods in Clock class const declared
...
R=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/20579004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6375 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-09 17:40:49 +00:00
henrik.lundin@webrtc.org
59336e85fb
Adding R/W lock to SimulatedClock
...
This change makes the SimulatedClock class thread safe.
R=mflodman@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15569004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6251 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-27 09:34:58 +00:00
henrike@webrtc.org
88fbb2d86b
Switch to using base/constructormagic.h and remove system_wrappers/interface/constructor_magic.h.
...
Same as https://webrtc-codereview.appspot.com/19519004 . The issue in
http://chromegw.corp.google.com/i/internal.chromium.webrtc.fyi/builders/Linux ...
is solved by this change
http://src.chromium.org/viewvc/chrome/trunk/src/third_party/libjingle/libjing ...
(tested locally).
BUG=3380
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17619005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6218 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-21 21:18:46 +00:00
mcasas@webrtc.org
2fa7f79094
Revert 6202 "Switch to using base/constructormagic.h and remove ..."
...
> Switch to using base/constructormagic.h and remove system_wrappers/interface/constructor_magic.h.
>
> BUG=N/A
> R=andrew@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/19519004
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14579007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6210 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-21 11:07:29 +00:00
henrike@webrtc.org
125ffd709d
Switch to using base/constructormagic.h and remove system_wrappers/interface/constructor_magic.h.
...
BUG=N/A
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19519004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6202 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-20 15:20:44 +00:00
andresp@webrtc.org
60015d27ae
Wire up --force_fieldtrials for vie_auto_test and for test targets linking with test/test.gyp:{test_main|test_support_main}
...
This allows use of webrtc field trials and opens up the possibility to try the different code paths when running the unit tests by wiring them up to a --force_fieldtrials.
Tested: running a test target that links with the above with a flag --force_fieldtrials=invalid leads the test to crash.
BUG=crbug/367114
R=mflodman@webrtc.org , phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/19439004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6181 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-16 09:39:51 +00:00
andresp@webrtc.org
a36ad6929d
Add webrtc field trials API.
...
From now on it is expected that code linking system_wrappers.gyp:system_wrappers
provides an implementation for field_trial API or links with the default one in
system_wrappers.gyp:field_trial_default.
Note: Since there is no use of webrtc::field_trial API inside webrtc this CL on
itself does not forces the clients to actually define it. It however lays the
API and updates the gyp rules to link with so that it is ready to use.
Tested: Introduced a use of field trial in system wrappers and make sure all
bots were building successfully.
BUG=crbug/367114
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14489004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6147 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-14 12:24:04 +00:00
andresp@webrtc.org
93ec9c557b
Revert "FieldTrial implementation for webrtc." (rev 6089)
...
New wiring plans require it to be landed first in chrome for a cleaner roll of webrtc.
BUG=crbug/367114
R=tommi@webrtc.org
TBR=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17479004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6122 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 14:09:40 +00:00
andresp@webrtc.org
6a8a6723d3
FieldTrial implementation for webrtc.
...
BUG=crbug/367114
R=asvitkine@chromium.org , mflodman@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14399004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6089 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-09 07:14:34 +00:00
wu@webrtc.org
66773a032a
Move timestamp_extrapolator and rtp_to_ntp to system wrapper so that it can be shared by both audio and video engine.
...
BUG=3111
TEST=try bots
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/13459004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6074 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-07 17:09:44 +00:00
andrew@webrtc.org
a0edf4cb04
Remove ALLOW_UNUSED.
...
Turns out Chromium won't be applying this to COMPILE_ASSERT. We don't
need it at all then.
R=thakis@chromium.org
TBR=thakis@chromium.org
Review URL: https://webrtc-codereview.appspot.com/13469005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6055 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-05 18:18:02 +00:00
andrew@webrtc.org
9f453b1a1b
Add ALLOW_UNUSED and update COMPILE_ASSERT to Chromium's latest.
...
Fixes building with gcc 4.8.
TBR=fdegans@google.com
BUG=chromium:321833
Review URL: https://webrtc-codereview.appspot.com/12439004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6050 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-04 03:04:26 +00:00
andrew@webrtc.org
8f69330310
Replace scoped_array<T> with scoped_ptr<T[]>.
...
scoped_array is deprecated. This was done using a Chromium clang tool:
http://src.chromium.org/viewvc/chrome/trunk/src/tools/clang/rewrite_scoped_ar ...
except for the few not-built-on-Linux files which were updated manually.
TESTED=trybots
BUG=2515
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12429004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5985 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-25 23:10:28 +00:00
andrew@webrtc.org
0daa8be9d6
Add Chromium's ScopedVector.
...
Trivial changes from the original excepting scoped_vector_unittest.cc,
diff here: https://paste.googleplex.com/6664017300946944
This is a prerequisite for:
http://review.webrtc.org/9919004/
TBR=henrike@webrtc.org
BUG=2894
Review URL: https://webrtc-codereview.appspot.com/12179004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5938 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-18 21:20:54 +00:00
kjellander@webrtc.org
7de47bce12
Remove use of tmpnam.
...
This solves compilation with the Mac SDK 10.9.
BUG=3120, 3151
TEST=git try -t modules_tests:VideoProcessorIntegrationTest*
R=fischman@webrtc.org , henrike@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/10739005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5917 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-16 08:04:26 +00:00
pbos@webrtc.org
3ecc162d01
Remove std:: prefixes from C functions in webrtc/.
...
std::memcpy -> memcpy for instance. This change was motivated by a
compile report complaining that std::rand() was used instead of rand(),
probably with a stdlib.h include instead of cstdlib. Use of C functions
without the std:: prefix is a lot more common, so removing std:: to
address this.
BUG=
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/9549004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5658 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-07 15:23:34 +00:00
andrew@webrtc.org
d617a44a4f
Add an AlignedFreeDeleter and remove scoped_ptr_malloc.
...
- Transition scoped_ptr_mallocs to scoped_ptr.
- AlignedFreeDeleter matches Chromium's version.
TESTED=try bots
R=turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8969005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5587 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-20 21:08:36 +00:00
jiayl@webrtc.org
cf1b51b6fb
Moves the display reconfiguration callback into a separate class,
...
so that it can be shared with the cursor monitor when single monitor capturing
is added (https://webrtc-codereview.appspot.com/4679005/ ).
This Cl should have no functionality change.
BUG=2253
R=henrike@webrtc.org , sergeyu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/7599004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5461 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-29 21:59:12 +00:00
henrike@webrtc.org
3907c2e7e5
Removes the remaining uses of the list wrapper class and the list wrapper class.
...
BUG=2164
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7019007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5378 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-13 22:41:34 +00:00
andresp@webrtc.org
7fb75ecbd4
Add thread_annotations for clang targets.
...
TESTED: As expected clang bots catched a few issues which are fixed with this CL, other bots ignore the annotations and compile fine.
R=niklas.enbom@webrtc.org , phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6209004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5328 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-20 20:20:50 +00:00
henrikg@webrtc.org
863b536100
Allow opening an AEC dump from an existing file handle.
...
This is necessary for Chromium to be able enable the dump with the sanbox enabled. It will open the file in the browser process and pass the handle to the render process.
This changes FileWrapper to deal with the case were the file handle is not managed by the wrapper.
BUG=2567
R=andrew@webrtc.org , henrika@webrtc.org , perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4649004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5239 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-06 16:05:17 +00:00
pbos@webrtc.org
57eb858698
Remove ".." from include_dirs in build/common.
...
BUG=1662
TEST=compile on trybots
R=tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2332004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5107 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-11 10:20:27 +00:00
henrikg@webrtc.org
bff9620116
Fix log build error for Chromium builds.
...
This only happens when building in Chromium. Can't roll due to this.
../../third_party/webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc: In function 'Window {anonymous}::GetTopLevelWindow(Display*, Window)':
../../third_party/webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc:39:7: error: 'LS_INFO' was not declared in this scope
../../third_party/webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc:39:7: note: suggested alternative:
../../third_party/webrtc/system_wrappers/interface/logging.h:71:29: note: 'webrtc::LS_INFO'
See for example http://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20%5Blatest%20WebRTC%2Blibjingle%5D/builds/3039/steps/compile/logs/stdio
R=henrika@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3619004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5100 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-08 10:37:27 +00:00
andrew@webrtc.org
f1a48174d4
Replace disabled logging with a restricted logging mode.
...
This will enable some low-level webrtc logging in a Chromium build,
while limiting the binary size impact.
For a Mac Release build, it results in an increase to Chrome.app of 37k
and libpeerconnection.so of 25k. For comparison, enabling full logs
costs 230k and 218k respectively.
BUG=b/11470432
TESTED=voe_cmd_test produces logs of the appropriate severity.
R=fischman@webrtc.org , henrikg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3479004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5097 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-07 23:47:26 +00:00
wu@webrtc.org
de748c806c
Remove unused make_scoped_ptr which causes an "ambiguous" error with chromium build.
...
TEST=build
R=andrew@webrtc.org , fischman@webrtc.org
TBR=andrew
Review URL: https://webrtc-codereview.appspot.com/3149004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5059 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-30 20:43:27 +00:00
andrew@webrtc.org
b3731da68f
Prefix MOVE_ONLY_TYPE_FOR_CPP_03 with WEBRTC_.
...
Will fix a redefinition error in Chromium against webrtc head.
TESTED=trybots
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2869004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5029 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-24 15:16:53 +00:00
andrew@webrtc.org
d1bcf1180a
Check if WARN_UNUSED_RESULT and COMPILE_ASSERT are defined.
...
Works around a multiple definition error from webrtc and libjingle.
Corresponds to the libjingle change here:
https://critique.corp.google.com/#review/55489575-p10
TESTED=trybots
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2809004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5025 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-23 19:11:32 +00:00
andrew@webrtc.org
31628aae7e
Upgrade scoped_ptr to Chromium's latest version.
...
Analogous to the recent libjingle change: http://cl/54929753-p10 .
This supports scoped_ptr<T[]> and scoped_ptr<C, FreeDeleter> rather
than scoped_array and scoped_ptr_malloc respectively.
- Add Chromium's template-based COMPILE_ASSERT. We didn't have this
previously in order to support the macro in C. Instead, move the
existing macro to compile_assert_c.h.
- Additionally copy the move.h and template_util.h depedencies and add
the WARN_UNUSED_RESULT macro.
- Leave scoped_array and scoped_ptr_malloc for now, but mark as
deprecated.
- Remove scoped_ptr foo(NULL) use. The default constructor handles it.
- Remove the now redundant COMPILE_ASSERT from peerconnection_jni.cc.
- Add a CHECK_ARRAY_SIZE macro to rtp_format_vp8_unittest.cc to remove
some repeated code.
TESTED=trybots
R=pbos@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2449005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5015 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-22 12:50:00 +00:00
fischman@webrtc.org
7e4d0df8ee
PeerConnection(Android): enable tracing to logcat.
...
BUG=1295
R=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2258007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4888 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-01 02:40:43 +00:00
henrike@webrtc.org
82f014aa0b
OpenSL (not default): Enables low latency audio on Android.
...
BUG=1669
R=andrew@webrtc.org , fischman@webrtc.org , niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2032004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4719 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-10 18:24:07 +00:00
andrew@webrtc.org
9080518a39
Restore severity precondition to logging.h.
...
I mistakenly ommitted the checks when logging.h was ported from
libjingle to webrtc. This caused a significant CPU cost for logs which
were later filtered out anyway.
Verified with LS_VERBOSE logging in neteq4, running:
$ out/Release/modules_unittests \
--gtest_filter=NetEqDecodingTest.TestBitExactness \
--gtest_repeat=50 > time.txt
$ grep "case ran" time.txt | grep "[0-9]* ms" -o | sort
Results on a MacBook Retina, averaged over 5 runs:
Verbose logs disabled: 666 ms
Exisiting implementation, verbose logs enabled: 944 ms (1.42x)
New implementation, verbose logs enabled: 673 ms (1.01x)
BUG=2314
R=henrik.lundin@webrtc.org , henrike@webrtc.org , kjellander@webrtc.org , turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2160005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4682 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-05 16:40:43 +00:00
pbos@webrtc.org
4ca7d3f9fe
Replace MapWrapper with std::map<>.
...
MapWrapper was needed on some platforms where STL wasn't supported, we
now use std::map<> directly.
BUG=2164
TEST=trybots
R=henrike@webrtc.org , phoglund@webrtc.org , stefan@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2001004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4530 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-12 19:51:57 +00:00
pbos@webrtc.org
12dc1a38ca
Switch C++-style C headers with their C equivalents.
...
The C++ headers define the C functions within the std:: namespace, but
we mainly don't use the std:: namespace for C functions. Therefore we
should include the C headers.
BUG=1833
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1917004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4486 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-05 16:22:53 +00:00
pbos@webrtc.org
a2a2718a6c
Fix some chromium-style warnings in webrtc/system_wrappers/
...
BUG=163
R=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1906004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4464 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-01 17:26:15 +00:00
pbos@webrtc.org
d900e8bea8
Proper spacing for end-of-namespace comments.
...
BUG=
R=mflodman@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1760006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4293 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-03 15:12:26 +00:00
fischman@webrtc.org
1d4a2d5daf
Move TickTime::QueryOsForTicks out-of-line
...
This inline function is no longer expanded on arm Android, but on x86 Android it
will still be expanded. Move it out-of-line to make things consistent.
This change list will also fix a potential bug on webrtc for Android:
Since the inline function won't be expanded on arm Android,
TickTime::MillisecondTimestamp and Clock::GetRealTimeClock()->TimeInMilliseconds
will be treated as function call, due to macro WEBRTC_CLOCK_TYPE_REALTIME's
guard defined in system_wrappers module they will get current time using
CLOCK_REALTIME.
But on x86 Android, the inline function will be expanded to where it's been
called, if the call happens in other compilation units which don't have
WEBRTC_CLOCK_TYPE_REALTIME definition, it will get current time using
CLOCK_MONOTONIC, while Clock::GetRealTimeClock()->TimeInMilliseconds will always
use CLOCK_REALTIME, then there will be two types of time in x86 Android which
will cause some weird issues like all received remote streams will be dropped
due to future render timestamp.
BUG=None
TEST=WebRTCViEDemo application works well on both arm and x86 Android
R=fischman@webrtc.org , niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1688004
Patch from Jeremy Mao <yujie.mao@intel.com>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4274 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-06-27 17:15:20 +00:00
andrew@webrtc.org
c1eb560a5c
Replace the old resampler with SincResampler in the voice engine signal path.
...
* The old resampler was found to have a wraparound bug.
* Remove support for the old resampler from PushResampler.
* Use PushResampler in AudioCodingModule.
* The old resampler must still be removed from the file utility.
BUG=webrtc:1867,webrtc:827
TESTED=unit tests, Chrome using apprtc and voe_cmd_test to verify wrap-around is corrected, voe_cmd_test running through all supported codec sample rates and channels to verify good quality audio
R=henrika@webrtc.org , turaj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1590004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4156 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-06-03 19:00:29 +00:00
pbos@webrtc.org
acaf3a1b13
Include files from webrtc/.. paths in system_wrappers/
...
BUG=1662
R=henrikg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1550004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4111 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-27 15:07:45 +00:00
niklas.enbom@webrtc.org
3be565b502
Refactoring for typing detection
...
R=henrika@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1370004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3976 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-07 21:04:24 +00:00