admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,165 Commits 1 Branch 0 Tags
Commit Graph

176 Commits

Author SHA1 Message Date
tina.legrand@webrtc.org
4517585db5 Adding separate payload types for stereo modes 
BUG=Issue 452
TEST=audio_coding_test, voe_auto_test, voe_cmd_test

Edit: adding Patrik to review:
src/modules/rtp_rtcp/source/rtp_receiver.cc
...and Shijing to review:
src/voice_engine/main/source/channel.cc
src/voice_engine/main/test/cmd_test/voe_cmd_test.cc

Review URL: https://webrtc-codereview.appspot.com/540004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2340 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-06-01 09:27:35 +00:00
andrew@webrtc.org
36ccce4f58 Remove documentation folders. 
Review URL: https://webrtc-codereview.appspot.com/606007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2329 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-30 17:28:24 +00:00
tina.legrand@webrtc.org
0de1ee3830 NetEQ: Remove an unnecessary condition, to fix a clang warning 
This is a duplicate of issue 606005: https://webrtc-codereview.appspot.com/606005/

BUG=
TEST=neteq_unittests

Review URL: https://webrtc-codereview.appspot.com/605005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2305 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-28 11:37:50 +00:00
turaj@webrtc.org
10d3b5239b I haven't done any refactoring here. 
Resolve coverity warnings.

14305.

The warning is not really valid. The 'decode' function should be called with a 'mode' variable, where inside the function it is assumed that mode is either zero or one. If mode is taking other values some varibles are used uninitialized. However, this is an internal function and it is always called with either ZERO or ONE. Therefore, the code operates correctly. I made small changes as I beleive it is a bit nicer way. 

In ACM:
- Conditions on 'mode' is changed.


Tested with trybots.

BUG=None
TEST=None
Review URL: https://webrtc-codereview.appspot.com/564014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2297 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-24 21:20:25 +00:00
mflodman@webrtc.org
6af9594d71 Added gyp variable to include/exclude all tests. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/597004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2292 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-24 13:23:35 +00:00
turaj@webrtc.org
ea0aa13aa8 I haven't done any refactoring here. 
Resolve coverity warnings.

14240, 14241.

In ACM:
- NULL pointer sanity checks corrected.

Tested with trybots.

BUG=None
TEST=None
Review URL: https://webrtc-codereview.appspot.com/571012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2281 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 15:43:51 +00:00
andrew@webrtc.org
9dc45dad1b Move trunk/test/data -> trunk/data 
BUG=
TEST=all trybot test failures passed locally

Review URL: https://webrtc-codereview.appspot.com/583007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2280 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-23 15:39:01 +00:00
andrew@webrtc.org
b3bea2eb3e Fix build errors on OS X Lion. 
TBR=henrika@webrtc.org
TEST=build on Lion, trybots
Review URL: https://webrtc-codereview.appspot.com/583005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2261 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-18 19:02:42 +00:00
tina.legrand@webrtc.org
86da94ea69 Remove functions for unregistering decoder 
This cl removes unused functions in the ACMGenericCodec class.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/568005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2245 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-16 07:11:53 +00:00
andrew@webrtc.org
e59a0aca6a Fix AudioFrame types. 
volume_ is not set anywhere so I'm removing it.

BUG=
TEST=trybots

Review URL: https://webrtc-codereview.appspot.com/556004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2196 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-08 17:12:40 +00:00
turaj@webrtc.org
fe4cfa7e5e Hi Tina, 
I have uploaded this patch for your review. I have done an extensive test to be sure that removing of tables does not create any problem. 

The test file, is called test_lpc.c which requires a hack to standard iSAC. The test computes LPC coefficients, then encodes and decodes with old and new (size-reduced) tables. It compares the results is all steps. I have ran the test over large set of files, more then 51 hours of audio, and there was no error. 

I tried to do no formatting so the review to be easier, but I know it can be a tricky CL. Hopefully, the test file helps you to be more confident on the CL. 

Thanks,... Turaj  

In this change list the LPC tables associated with mode 1 & 2 are remoded, and necessary cahnges are made to other files. 

The only model allowed is model number 0. Therefore, this CL breaks compatibility with iSAC released prior to 2.4.3. To avoid changing the bit-stream, we still keep the model number in the bit-stream. 

entropy_coding.c is cleaned up, especially encoding of LAR had KLT transform of LPC gains which are removed now. 
Review URL: https://webrtc-codereview.appspot.com/548004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2186 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-07 20:36:22 +00:00
andrew@webrtc.org
63a509858d Rename AudioFrame members. 
BUG=
TEST=trybots

Review URL: https://webrtc-codereview.appspot.com/542005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2164 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-05-02 23:56:37 +00:00
andrew@webrtc.org
5c0c18d823 Fix coverity issues in ACM. 
Fixes: Big parameter passed by value (PASS_BY_VALUE)
Passing parameter codec of size 52 bytes by value.

BUG=
TEST=audio_coding_module_tests, trybots

Review URL: https://webrtc-codereview.appspot.com/529002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2142 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-27 17:06:48 +00:00
tina.legrand@webrtc.org
bc1b43b297 Refactoring of audio_coding_module_impl 
First patch set: pure formatting.

Review URL: https://webrtc-codereview.appspot.com/522001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2125 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-26 08:53:45 +00:00
tina.legrand@webrtc.org
a6ecd1ebb5 Refactoring one of the ACM tests: TestStereo, to follow the style guide. 
(First patch: formatting the test file)

TEST=audio_coding_module_test

Review URL: https://webrtc-codereview.appspot.com/507001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2124 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-26 07:54:30 +00:00
andrew@webrtc.org
4e423b3b1e Handle master/slave timestamp wrap. 
BUG=issue410
TEST=neteq_unittests, audio_coding_module_test

Review URL: https://webrtc-codereview.appspot.com/506001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2098 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-23 18:59:00 +00:00
asapersson@webrtc.org
92591adc67 Fixes link issues in google3 (change by tomasl). 
Review URL: https://webrtc-codereview.appspot.com/509001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2090 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-23 13:10:55 +00:00
andrew@webrtc.org
b61f1fa675 Reset slave when switching to a stereo codec. 
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/494003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2073 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-20 01:10:14 +00:00
tina.legrand@webrtc.org
faa0ab85d7 NetEQ stereo sync 
This CL allows NetEQ to do expand at startup, to make master and slave always go in sync. Before it could happen that master did merge, while slave performed an expand, leading to sync-problems between the channels.

Updating DEPS for new reference files for unittest.

BUG=410
TEST=neteq_unittests

Review URL: https://webrtc-codereview.appspot.com/487005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2055 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-18 17:59:53 +00:00
leozwang@webrtc.org
16f6bb35b6 Fix a minor compilation error on android 
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/479014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2053 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-18 16:49:06 +00:00
mflodman@webrtc.org
3c611fd4fd Removed NetEQ Test compile error. 
BUG=443
TEST=Compiles using clang version 3.1 (trunk 153589)

Review URL: https://webrtc-codereview.appspot.com/493005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2029 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-16 10:57:27 +00:00
tina.legrand@webrtc.org
16b6b90a82 Split of stereo packets moved 
In this CL I have rewritten the way we handle stereo packets in VoE.
Before this change we split the packets in the RTP module and added two packets to ACM, one for the left channel and one for the right. This lead to timing problems caused when a different thread called RecOut in between the two calls to add stereo packet to ACM. (RecOut is called to pull audio data, decode packets, on the receiving side).

While doing the change I also took the opportunity to changed some functions so that the data stream is uint8 everywhere.

The list of files in this CL is long, but should be fairly easy to review. It is difficult to see what has been changed  in some of the tests, but I can explain offline.

Reviewers:
Björn - /src/modules/audio_coding
Patrik - /src/modules/rtp_rtcp
Patrik -/src/modules/utility
Henrik A - /src/voice_engine

BUG=410
TEST=voe_cmd_test

Review URL: https://webrtc-codereview.appspot.com/473003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2012 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-04-12 11:02:38 +00:00
andrew@webrtc.org
952f601405 Fix Linux-release errors and Valgrind errors. 
BUG=
TEST=build on Linux release.
TBR=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/456008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1949 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-27 18:30:26 +00:00
andrew@webrtc.org
61b1b4b472 Fix neteq-rtpplay Linux build errors. 
BUG=
TEST=build on Linux.
TBR=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/457007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1948 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-27 17:33:29 +00:00
andrew@webrtc.org
f589dfede4 Merge header-only neteq-rtpplay changes. 
TEST=build

Review URL: https://webrtc-codereview.appspot.com/452003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1947 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-27 17:05:44 +00:00
tina.legrand@webrtc.org
196e491c46 Adding init decode slave to celt 
Minor rearanging of calls. Added a init function to the slave channel of CELT.

Review URL: https://webrtc-codereview.appspot.com/458005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1931 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-23 14:39:46 +00:00
tina.legrand@webrtc.org
0e0390dc33 Flush NetEQ when receiving payload type switches between mono and stereo. 
TEST=voe_cmd_test

Review URL: https://webrtc-codereview.appspot.com/448004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1893 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-15 11:23:51 +00:00
tina.legrand@webrtc.org
ae1c4547ee Reregister of stereo receiver didn't work. 
This CL takes care of the re-registration of codecs, and tests unregistering stereo codecs.

One bug fixed in Celt too.

TEST=audio_coding_module_test: TestStereo.

Review URL: https://webrtc-codereview.appspot.com/436002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1871 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-12 08:41:30 +00:00
tina.legrand@webrtc.org
0dab9e1523 Revert of r1859 
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1866 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-09 10:03:09 +00:00
tina.legrand@webrtc.org
f1befad273 Reregister of stereo receiver didn't work. 
This CL takes care of the re-registration of codecs, and tests unregistering stereo codecs.

One bug fixed in Celt too.

TEST=audio_coding_module_test: TestStereo.

Review URL: https://webrtc-codereview.appspot.com/436002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1859 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-08 13:23:18 +00:00
leozwang@webrtc.org
db2de5b49f Fix building errors on android 
TBR=Tina

BUG=
TEST=build on android
Review URL: https://webrtc-codereview.appspot.com/430001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1840 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-05 19:53:24 +00:00
tina.legrand@webrtc.org
1f2cabaecd Crash when deleting Celt. 
BUG=issue 6087770
TEST=audio_coding_module_test

Review URL: https://webrtc-codereview.appspot.com/420001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1805 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-03-01 08:46:09 +00:00
andrew@webrtc.org
547c157a49 Temporarily use _Word8 to avoid clang error. 
BUG=issue311
TEST=build on clang

Review URL: https://webrtc-codereview.appspot.com/415003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1788 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-28 22:30:30 +00:00
leozwang@webrtc.org
91b359ea9b Change WebRtc_Word8 to char 
Review URL: https://webrtc-codereview.appspot.com/407003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1787 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-28 17:26:14 +00:00
xians@webrtc.org
539ef94f20 Remove the deprecated kTraceModuleCall trace from audio coding module. 
Review URL: https://webrtc-codereview.appspot.com/399002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1741 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-22 08:35:03 +00:00
tina.legrand@webrtc.org
145f04f0c4 Changing Celt to use stereo as default. 
Review URL: https://webrtc-codereview.appspot.com/397009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1720 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-18 00:32:16 +00:00
tina.legrand@webrtc.org
79e29e510f Adding option to change bitrate for Celt. 
I have updated the code so that Celt rate can be changed to any value between 48 and 128 kbps.
Tests for both mono and stereo are updated.Updated tests for Celt mono.

Review URL: https://webrtc-codereview.appspot.com/391014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1712 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-17 00:38:33 +00:00
tina.legrand@webrtc.org
13ac430bef Adding missing timestamp calculation to RTPencode. 
Review URL: https://webrtc-codereview.appspot.com/392002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1641 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 13:20:36 +00:00
tina.legrand@webrtc.org
df69775bfa Adding support for full-stereo codec. 
This is an experiment, letting Celt represent a full-stereo codec.

Review URL: https://webrtc-codereview.appspot.com/379013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1636 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-08 10:22:21 +00:00
wu@webrtc.org
13e0345b35 Fix uninitialized variable error in Relase mode. 
TBR=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/377007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1611 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 16:19:15 +00:00
mflodman@webrtc.org
517e5e3846 NetEQ switch fix. 
Review URL: https://webrtc-codereview.appspot.com/381006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1610 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 15:04:00 +00:00
mflodman@webrtc.org
c80d9d9361 Removed default cases causing clang errors, -Wcovered-switch-default. 
BUG=
TEST=Bulid with clang version 3.1 (trunk 148911)

Review URL: https://webrtc-codereview.appspot.com/379008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1604 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-06 10:11:25 +00:00
henrik.lundin@webrtc.org
683833442a Fix for warning in GCC 4.6 
Upstream copy of a fix provided in http://codereview.chromium.org/9309007/.

BUG=none
TEST=neteq_unittests

Review URL: https://webrtc-codereview.appspot.com/383002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1596 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-03 12:33:50 +00:00
henrik.lundin@webrtc.org
82e1c8d0e7 Fix for issue 253 
Initializing a few arrays to avoid compiler warnings under
the O3 flag.

BUG=http://code.google.com/p/webrtc/issues/detail?id=253

Review URL: https://webrtc-codereview.appspot.com/380005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1595 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-03 09:46:01 +00:00
kma@webrtc.org
de66b91274 In voice engine, added member audioFrame to classes AudioCodingModuleImpl and VoEBaseImpl, 
and touched VoEBaseImpl::NeedMorePlayData and AudioCodingModuleImpl::PlayoutData10Ms(), for
performance reasons in Android platforms.
The two functions used about 6% of VoE originally. After the change, the percentage reduced
to about 0.2%.
Review URL: https://webrtc-codereview.appspot.com/379001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1589 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-02-01 18:39:44 +00:00
henrik.lundin@webrtc.org
dd478e2081 Fix for warning in GCC 4.6 
Upstream copy of a fix provided in http://codereview.chromium.org/9159058/.

Review URL: https://webrtc-codereview.appspot.com/369024

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1580 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-31 13:12:41 +00:00
kma@webrtc.org
89a100092a A minor change in function WebRtcNetEQ_PacketBufferFindLowestTimestamp for 
NetEq, for performance reasons.
In Android platform, with an offline testing file, the function cycles was reduced by 25%.
This function was also reformatted.
Review URL: https://webrtc-codereview.appspot.com/367010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1571 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-30 15:37:33 +00:00
phoglund@webrtc.org
2f7740973d Fixed C errors from GCC 4.6. 
Fixed errors in .c files.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/373014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1563 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-27 13:44:26 +00:00
tina.legrand@webrtc.org
cbe1de9aa6 This CL solves three remaining Coverity warnings. 
A few more members were left uninitialized, and one more size mismatch in a multiplication.

Review URL: https://webrtc-codereview.appspot.com/367001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1558 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-27 09:00:46 +00:00
phoglund@webrtc.org
d1a860b415 Fixed GCC 4.6 errors (mostly 'unused variable' errors and incorrect usage of EXPECT_EQ with booleans. 
Fixed remaining compilation errors in release, etc.

Fixed errors from GCC 4.6 compilation.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/366008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1554 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-01-26 14:49:28 +00:00