webrtc_m130

admin/webrtc_m130

Fork 0

Commit Graph

Author	SHA1	Message	Date
henrikg	91d6edef35	Add RTC_ prefix to (D)CHECKs and related macros. We must remove dependency on Chromium, i.e. we can't use Chromium's base/logging.h. That means we need to define these macros in WebRTC also when doing Chromium builds. And this causes redefinition. Alternative solutions: * Check if we already have defined e.g. CHECK, and don't define them in that case. This makes us depend on include order in Chromium, which is not acceptable. * Don't allow using the macros in WebRTC headers. Error prone since if someone adds it there by mistake it may compile fine, but later break if a header in added or order is changed in Chromium. That will be confusing and hard to enforce. * Ensure that headers that are included by an embedder don't include our macros. This would require some heavy refactoring to be maintainable and enforcable. * Changes in Chromium for this is obviously not an option. BUG=chromium:468375 NOTRY=true Review URL: https://codereview.webrtc.org/1335923002 Cr-Commit-Position: refs/heads/master@{#9964}	2015-09-17 07:24:51 +00:00
andrew	d40af69278	Split MoveReadPosition into Forward and Backward versions. This makes the interface consistent in its use of size_t, and will reduce casts in callers as they shift to size_t, e.g. this CL: https://codereview.webrtc.org/1227203003/ Review URL: https://codereview.webrtc.org/1252943007 Cr-Commit-Position: refs/heads/master@{#9646}	2015-07-28 07:53:05 +00:00
andrew@webrtc.org	041035b390	Add an AudioRingBuffer class wrapper for the ring_buffer.h C interface. Integrate it in Blocker to demonstrate use. TEST=beamforming sounds good. R=aluebs@webrtc.org, mgraczyk@chromium.org, sahark@google.com Review URL: https://webrtc-codereview.appspot.com/36799004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@8157 4adac7df-926f-26a2-2b94-8c16560cd09d	2015-01-26 21:23:53 +00:00

Author

SHA1

Message

Date

henrikg

91d6edef35

Add RTC_ prefix to (D)CHECKs and related macros.

We must remove dependency on Chromium, i.e. we can't use Chromium's base/logging.h. That means we need to define these macros in WebRTC also when doing Chromium builds. And this causes redefinition.

Alternative solutions:
* Check if we already have defined e.g. CHECK, and don't define them in that case. This makes us depend on include order in Chromium, which is not acceptable.
* Don't allow using the macros in WebRTC headers. Error prone since if someone adds it there by mistake it may compile fine, but later break if a header in added or order is changed in Chromium. That will be confusing and hard to enforce.
* Ensure that headers that are included by an embedder don't include our macros. This would require some heavy refactoring to be maintainable and enforcable.
* Changes in Chromium for this is obviously not an option.

BUG=chromium:468375
NOTRY=true

Review URL: https://codereview.webrtc.org/1335923002

Cr-Commit-Position: refs/heads/master@{#9964}

2015-09-17 07:24:51 +00:00

andrew

d40af69278

Split MoveReadPosition into Forward and Backward versions.

This makes the interface consistent in its use of size_t, and will
reduce casts in callers as they shift to size_t, e.g. this CL:
https://codereview.webrtc.org/1227203003/

Review URL: https://codereview.webrtc.org/1252943007

Cr-Commit-Position: refs/heads/master@{#9646}

2015-07-28 07:53:05 +00:00

andrew@webrtc.org

041035b390

Add an AudioRingBuffer class wrapper for the ring_buffer.h C interface.

Integrate it in Blocker to demonstrate use.

TEST=beamforming sounds good.
R=aluebs@webrtc.org, mgraczyk@chromium.org, sahark@google.com

Review URL: https://webrtc-codereview.appspot.com/36799004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@8157 4adac7df-926f-26a2-2b94-8c16560cd09d

2015-01-26 21:23:53 +00:00

3 Commits