noahric
5d9b92b53d
Update Bind to match its comments and always capture by value. Also update the generated count to 9 args.
...
The existing comment is wrong, and the test even ensures it: Bind will capture reference values by reference. That makes it hard to use with AsyncInvoker, because you can't safely Bind to a function that takes (const) reference params.
The new version of this code strips references in the bound object, so it captures by value, but can bind against functions that take const references, they'll just be references to the copy.
As the class comment implies, actual by-reference args should be passed as pointers or things that safely share (e.g. scoped_refptr) and not references directly. A new test case ensures the pointer reference works. The new code will also give a compiler error if you try to bind
to a non-const reference.
BUG=
Review URL: https://codereview.webrtc.org/1291543006
Cr-Commit-Position: refs/heads/master@{#10397}
2015-10-24 18:14:52 +00:00
Magnus Jedvert
b274547ebd
rtc::Bind: Capture scoped_refptr reference arguments by value
...
R=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1308563004 .
Cr-Commit-Position: refs/heads/master@{#9780}
2015-08-25 15:56:37 +00:00
Magnus Jedvert
d3de9c548d
rtc::Bind: Capture method objects as scoped_refptr if they are ref counted
...
R=tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1300523004 .
Cr-Commit-Position: refs/heads/master@{#9744}
2015-08-20 14:04:01 +00:00
Fredrik Solenberg
c937139176
Regenerate bind.h using pump.py
...
BUG=webrtc:4690
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1261093005 .
Cr-Commit-Position: refs/heads/master@{#9682}
2015-08-06 10:41:04 +00:00
Jelena Marusic
5d6e58e76e
Improvements to rtc::Bind
...
BUG=webrtc:4690
Support for rtc::scoped_ptr as return type.
Support for up to 6 input parameters.
R=pthatcher@webrtc.org , solenberg@webrtc.org
Review URL: https://codereview.webrtc.org/1226153003 .
Cr-Commit-Position: refs/heads/master@{#9569}
2015-07-13 09:16:47 +00:00
henrike@webrtc.org
f048872e91
Adds a modified copy of talk/base to webrtc/base. It is the first step in
...
migrating talk/base to webrtc/base.
BUG=N/A
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17479005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
perkj@webrtc.org
e9a604accd
Revert 6107 "Adds a modified copy of talk/base to webrtc/base. I..."
...
This breaks Chromium FYI builds and prevent roll of webrtc/libjingle to Chrome.
http://chromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win%20Builder/builds/457
> Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
>
> BUG=N/A
> R=andrew@webrtc.org , wu@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/12199004
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14479004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6116 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 08:15:48 +00:00
henrike@webrtc.org
2c7d1b39b9
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
...
BUG=N/A
R=andrew@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12199004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6107 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-12 18:03:09 +00:00
