stefan@webrtc.org
faada6e604
Integrate fake_network_pipe into direct_transport.
...
TEST=trybots
R=mflodman@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5529004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5321 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-18 20:28:25 +00:00
mflodman@webrtc.org
b429e516a9
cpplint cleaning new API and its implementation files.
...
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6089005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5317 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-18 09:46:22 +00:00
mflodman@webrtc.org
bcd124cdba
Reduced execution time for CallTest::ReceivesPliAndRecovers, by dropping only one packet and made it predictable by removing rand().
...
Follow up steps is to support NackConfig.rtp_hostory_ms and/or increase fake encoder bitrate.
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6109005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5316 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-18 09:45:45 +00:00
mflodman@webrtc.org
1fa41be66a
Speeding up CallTest.ReceivesAndRetransmitsNack and removed the random packet loss.
...
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/6119004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5315 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-18 09:44:53 +00:00
pbos@webrtc.org
052fa6243a
Stop transport in test SuspendBelowMinBitrate.
...
Avoids race when packets are still left in the network while the Call is
being destroyed.
R=mflodman@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/6009004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5307 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-17 11:19:58 +00:00
pbos@webrtc.org
eb7b7bce3d
Modify video_render/ to allow a single old frame.
...
This stabilizes tests as a single frame reaches end-to-end, as well as
allowing slow or heavily-loaded systems to see any video updates even if
the frame takes more than 500ms in the pipeline.
R=mflodman@webrtc.org , stefan@webrtc.org
BUG=2724
Review URL: https://webrtc-codereview.appspot.com/5949004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5303 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-16 18:24:37 +00:00
pbos@webrtc.org
919f87fb36
Delete capturers after destroying streams in test.
...
Since the renderers in CallTest.SendsAndReceiveStreams also stopped the
capturers they must be deleted after the VideoReceiveStream is stopped
or an use-after-free may occur.
R=mflodman@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/5969004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5300 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-16 14:55:54 +00:00
pbos@webrtc.org
5ab756703e
Revert r5294 to re-roll r5293.
...
To fix races in test each stream now owns its own encoder/decoder.
R=mflodman@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/5919004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5297 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-16 12:24:44 +00:00
turaj@webrtc.org
41e2615e02
Revert 5293 "Auto instantiate RBE depending on whether AST or TO..."
...
> Auto instantiate RBE depending on whether AST or TOF is available in incoming packet stream.
>
> BUG=
> R=mflodman@webrtc.org , stefan@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/5409004
TBR=solenberg@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5889004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5294 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-15 18:42:32 +00:00
solenberg@webrtc.org
341e91441a
Auto instantiate RBE depending on whether AST or TOF is available in incoming packet stream.
...
BUG=
R=mflodman@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5409004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5293 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 23:57:54 +00:00
mflodman@webrtc.org
92c2793154
Adding REMB to receive stream configuration, the send side will always
...
react to incoming REMB for now.
Adding a test to verify the receive side is generating RTCP REMB and
will follow up with a send side test as soon as the bitrate stats are
wired up for the new API.
TEST=See above.
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5779004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5286 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 16:36:28 +00:00
pbos@webrtc.org
1d096901ac
Move realtime tests to webrtc_perf_tests.
...
New binary not to be run on our VMs as they result in flaky tests. These
will instead be run on baremetal machines.
BUG=2710
R=kjellander@webrtc.org , mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5679004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5283 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 12:48:05 +00:00
mflodman@webrtc.org
f3973e81d5
Make sure channels in the same call are in the same channel group.
...
Tested manually. I'll make a follow CL with a proper test once review.webrtc.org/5619004 has been committed.
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5509004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5280 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 09:40:45 +00:00
henrik.lundin@webrtc.org
e9abd591d7
Making RemoteRateControl::min_configured_bit_rate_ configurable
...
The minimum bitrate can now be configured from WrappingBitrateEstimator.
BUG=2698
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5699004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5279 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 08:42:42 +00:00
wu@webrtc.org
a9890800e0
Update talk to 58127566 together with
...
https://webrtc-codereview.appspot.com/5309005/ .
R=mallinath@webrtc.org , niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5719004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5277 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-13 00:21:03 +00:00
wu@webrtc.org
2018269dc3
Revert 5274 "Update talk to 58113193 together with https://webrt ..."
...
> Update talk to 58113193 together with https://webrtc-codereview.appspot.com/5309005/ .
>
> R=mallinath@webrtc.org , niklas.enbom@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/5719004
TBR=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5729004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5275 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-12 22:54:25 +00:00
wu@webrtc.org
a129b6cd13
Update talk to 58113193 together with https://webrtc-codereview.appspot.com/5309005/ .
...
R=mallinath@webrtc.org , niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5719004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5274 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-12 22:40:39 +00:00
pbos@webrtc.org
724947b8ef
Add SwapFrame() to VideoSendStreamInput.
...
Optionally prevents doing a frame copy when putting frames into a
VideoSendStream. PutFrame() is still there, which copies the frame.
Also removes time_since_capture_ms as a parameter, since
I420VideoFrame::render_time_ms() denotes when the frame was captured.
BUG=2657
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5119004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5265 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-11 16:26:16 +00:00
sprang@webrtc.org
8b8819262f
Improve VideoSendStreamTest::MaxPacketSize
...
This CL was submitted as issue https://webrtc-codereview.appspot.com/4849004/ , but was reverted because of flakiness. This new issue will correct that.
Patch Set 1 contains the code that was submitted in 4849004.
BUG=2428
R=pbos@webrtc.org , phoglund@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5399004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5251 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-10 10:05:17 +00:00
andrew@webrtc.org
797522f9f2
Revert 5229 "Make VideoSendStreamTest::MaxPacketSize test a whol..."
...
> Make VideoSendStreamTest::MaxPacketSize test a whole range of frame sizes, to make sure all corner cases are covered.
>
> BUG=2428
> R=pbos@webrtc.org , phoglund@webrtc.org , stefan@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/4849004
It caused a failure in video_engine_tests on the Linux Tsan bot.
TBR=sprang@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5269004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5240 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-06 17:42:32 +00:00
pbos@webrtc.org
0f3d0bb601
Stop video capturers in multi-stream test.
...
Expected to reduce runtime and flakiness in
CallTest.SendsAndReceivesMultipleStreams on linux_memcheck which is
presumed to be due to contention between the threads.
BUG=
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5249004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5238 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-06 15:48:17 +00:00
sprang@webrtc.org
7104fc1906
Make VideoSendStreamTest::MaxPacketSize test a whole range of frame sizes, to make sure all corner cases are covered.
...
BUG=2428
R=pbos@webrtc.org , phoglund@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4849004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5229 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-05 16:15:11 +00:00
pbos@webrtc.org
5cea89f3e1
Remove CallTest dependency on voice_engine/test/.
...
Loading file out of resources/ instead of data/ which is deprecated.
BUG=
R=holmer@google.com , mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5069004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5226 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-05 14:24:17 +00:00
pbos@webrtc.org
c49d5b7df8
Move implementation files out of the webrtc/ root.
...
Leaves the root for public headers. Also fixes the issue of requiring
root OWNERS approval for changes in the Call implementation and adding
end-to-end tests.
BUG=
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/5049005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5223 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-05 12:11:47 +00:00
stefan@webrtc.org
7e9315b42e
Adds support for sending redundant payloads over RTX.
...
TEST=trybots
BUG=1812
R=mflodman@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4169004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5209 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-04 10:24:26 +00:00
pbos@webrtc.org
b613b5ab2b
Set local SSRC for VideoReceiveStream.
...
As a bonus, also removes GenerateRandomSsrc, which only worked on sender
configs. There's no point to generate random SSRCs in tests.
BUG=2691
R=mflodman@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4689004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5201 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-12-03 10:13:04 +00:00
pbos@webrtc.org
e1fc3f22ea
Disable check for all sent SSRCs being valid.
...
Since the code for setting these up will set the codec before setting
SSRCs for the streams, any frames sent in between will be sent on
random-generated SSRCs.
This part should be added back during work on issue 1695.
BUG=1695
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4629004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5192 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-28 15:40:12 +00:00
pbos@webrtc.org
13d38a13e3
Set up SSRCs correctly after switching codec.
...
Before SSRCs were not set up correctly, as the old VideoEngine API
doesn't support setting additional SSRCs before a codec with as many
streams are set.
No test was in place to catch this, so two tests are added to make sure
that we send the SSRCs that are set, and also that we can switch from
using one to using all SSRCs, even though initially not all of them are
set up.
BUG=
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4539004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5188 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-28 11:59:31 +00:00
sprang@webrtc.org
4070935f4f
Implement and test EncodedImageCallback in new ViE API.
...
R=mflodman@webrtc.org , pbos@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4059004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5179 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-26 11:41:59 +00:00
stefan@webrtc.org
4ab4fc0044
Add test for automatically disabling padding when no video is being captured.
...
BUG=2648
TEST=trybots
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4329004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5169 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-25 11:54:24 +00:00
henrik.lundin@webrtc.org
331d4402fc
Connect pacer/padding to SuspendBelowMinBitrate
...
The suspend function must not be engaged unless padding is also enabled.
This CL makes the connection so that the pacer and padding is enabled
when SuspendBelowMinBitrate is.
Had to change the unit test to make it aware of the padding packets.
BUG=2606
R=mflodman@webrtc.org , pbos@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4089004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5153 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-21 14:05:40 +00:00
pbos@webrtc.org
2c46f8d854
Rename DestroyStream methods to include Video.
...
Matches r5135 which renames CreateSendStream->CreateVideoSendStream for
instance.
BUG=
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4109005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5151 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-21 13:49:43 +00:00
pbos@webrtc.org
d29d4e9c08
Deliver I420VideoFrames from VideoRender module.
...
Performance issue and simplicity, this implementation skips conversion
to VideoEngine's frame format and then back again to I420VideoFrame.
BUG=2526
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3989004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5140 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-20 13:19:54 +00:00
pbos@webrtc.org
27326b6a42
Rename newapi::Transport::SendRTP()->SendRtp().
...
Also fit rampup_tests.cc to use internal::TransportAdapter instead of
implementing its own.
BUG=
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3419004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5138 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-20 12:17:04 +00:00
pbos@webrtc.org
ce90eff345
Rename RTP-extension constants.
...
BUG=
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3969004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5137 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-20 11:48:56 +00:00
pbos@webrtc.org
53c8573525
Rename video streams' start/stop methods.
...
{Start,Stop}{Send,Receive}() -> {Start,Stop}{Sending,Receiving}().
BUG=
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3609005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5136 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-20 11:36:47 +00:00
pbos@webrtc.org
5a63655ab0
Rename Call::Create{Receive,Send}Stream().
...
Renaming the methods to include Video. Long-term there will hopefully be
AudioSendStream/AudioReceiveStreams as well.
BUG=
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3439004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5135 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-20 10:40:25 +00:00
henrik.lundin@webrtc.org
ce8e0936d9
Rename AutoMute to SuspendBelowMinBitrate
...
Changes all instances throughout the WebRTC stack.
BUG=2436
R=mflodman@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3919004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5130 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-18 12:18:43 +00:00
stefan@webrtc.org
b082ade3db
Hook up audio/video sync to Call.
...
Adds an end-to-end audio/video sync test.
BUG=2530, 2608
TEST=trybots
R=henrika@webrtc.org , mflodman@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3699004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5128 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-18 11:45:11 +00:00
stefan@webrtc.org
4cfa6050f6
Fix breakage after introducing new test.
...
TBR=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3899005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5127 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-15 13:15:56 +00:00
stefan@webrtc.org
69969e2e2f
Improve Call tests for RTX.
...
Also does some refactoring to reuse RtpRtcpObserver.
BUG=1811
R=mflodman@webrtc.org , pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3809004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5126 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-15 12:32:15 +00:00
pbos@webrtc.org
6488761f2e
Implement VideoSendStream::SetCodec().
...
Removing assertion that SSRC count should be the same as the number of
streams in the codec. It makes sense that you don't always use the same
number of streams under one call. Dropping resolution due to CPU overuse
for instance can require less streams, but the SSRCs should stay
allocated so that operations can resume when not overusing any more.
This change also means we can get rid of the ugly SendStreamState whose
content wasn't defined. Instead we use SetCodec to change resolution
etc. on the fly. Should something else have to be replaced on the fly
then that functionality simply has to be implemented.
BUG=
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3499005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5123 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-14 08:58:14 +00:00
pbos@webrtc.org
47ebbaddbb
Make video/ only depend on video_engine_core.
...
Fixes Android/Chromium build error. Previous dependencies included
VideoEngine tests that couldn't build on this configuration.
BUG=2535
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3109004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5050 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-29 13:11:56 +00:00
pbos@webrtc.org
def22b455b
Stop DirectTransports in VideoSendStreamTests.
...
Prevents racy packet delivery during or after Call destruction.
BUG=
R=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3099005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5049 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-29 10:12:10 +00:00
pbos@webrtc.org
16e03b7bd8
Separate Call API/build files from video_engine/.
...
BUG=2535
R=andrew@webrtc.org , mflodman@webrtc.org , niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2659004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5042 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-28 16:32:01 +00:00