kjellander@webrtc.org
fa53d8717c
Fixing/disabling Windows x64 warnings
...
Disabled MSVC #4267 warnings in common.gypi to enable x64 builds
for Windows.
Fixed MSVC #4267 warnings in test/testsupport.
Added third_party/directxsdk to .gitignore.
With http://review.webrtc.org/1070008 landed, this should make it possible
to build for x64 on Windows.
BUG=1348
TEST=Compiling with http://review.webrtc.org/1070008 applied:
set GYP_DEFINES="target_arch=x64"
set GYP_GENERATORS=ninja
gclient sync
ninja -C out\Debug_x64
Review URL: https://webrtc-codereview.appspot.com/1060008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3464 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-04 10:07:17 +00:00
stefan@webrtc.org
becf9c897c
Fix mismatch between different NACK list lengths and packet buffers.
...
This is a second version of http://review.webrtc.org/1065006/ which passes the parameters via methods instead of via constructors.
BUG=1289
Review URL: https://webrtc-codereview.appspot.com/1065007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3456 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-01 15:09:57 +00:00
stefan@webrtc.org
b586507986
Break out RemoteBitrateEstimator from RtpRtcp module and make RemoteBitrateEstimator::Process trigger new REMB messages.
...
Also make sure RTT is computed independently of whether it's time to send RTCP messages or not.
BUG=1298
Review URL: https://webrtc-codereview.appspot.com/1060005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3455 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-01 14:33:42 +00:00
andrew@webrtc.org
63e0964039
Fix webrtc compilation errors for Chrome Win64
...
Mostly disabling warnings in the gyp files.
BUG=1348
BUG=http://crbug.com/166496
BUG=http://crbug.com/167187
Review URL: https://webrtc-codereview.appspot.com/1063011
Patch from Justin Schuh <jschuh@chromium.org>.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3423 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-29 06:45:22 +00:00
phoglund@webrtc.org
43da54a458
Reformatted rtp_sender: made lint clean.
...
TESTED=rtp_rtcp_unittests
BUG=
Review URL: https://webrtc-codereview.appspot.com/1062004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3412 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-25 10:53:38 +00:00
phoglund@webrtc.org
5accd370e7
RTP Receiver is now only deals with a receiver strategy. Cleaned up dependencies.
...
BUG=
TESTED=vie/voe_auto_test, rtp_rtcp_unittests
Review URL: https://webrtc-codereview.appspot.com/1058004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3397 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-22 12:31:01 +00:00
stefan@webrtc.org
a678a3baee
Move video_coding to new Clock interface and remove fake clock implementations from RTP module tests.
...
TEST=video_coding_unittests, video_coding_integrationtests, rtp_rtcp_unittests, trybots
Review URL: https://webrtc-codereview.appspot.com/1044004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3393 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-21 07:42:11 +00:00
wjia@webrtc.org
a3c82bf667
Remove '<(library)' in gyp files.
...
This will remove all usage of '<(library)' in all webrtc gyp files.
Review URL: https://webrtc-codereview.appspot.com/1049005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3392 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-18 23:42:21 +00:00
phoglund@webrtc.org
efae5d5901
Extracted rtp receiver payload management to its own class, made video receiver depend on that instead.
...
Eliminated need for video receiver to talk to its parent. Also we will now determine if the packet is the first one already in the rtp general receiver. The possible downside would be that recovered video packets no longer can be flagged as the first packet, but I don't think that can happen. Even if it can happen, maybe the bit was set anyway at an earlier stage. The tests run fine.
BUG=
TEST=rtp_rtcp_unittests, vie_auto_test, voe_auto_test
Review URL: https://webrtc-codereview.appspot.com/1022011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3382 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-17 16:10:45 +00:00
stefan@webrtc.org
20ed36dada
Break out RtpClock to system_wrappers and make it more generic.
...
The goal with this new clock interface is to have something which is used all
over WebRTC to make it easier to switch clock implementation depending on where
the components are used. This is a first step in that direction.
Next steps will be to, step by step, move all modules, video engine and voice
engine over to the new interface, effectively deprecating the old clock
interfaces. Long-term my vision is that we should be able to deprecate the clock
of WebRTC and rely on the user providing the implementation.
TEST=vie_auto_test, rtp_rtcp_unittests, trybots
Review URL: https://webrtc-codereview.appspot.com/1041004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3381 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-17 14:01:20 +00:00
phoglund@webrtc.org
acfdd96ee3
Reformatted rtp_rtcp_impl*.
...
BUG=
TEST=Trybots.
Review URL: https://webrtc-codereview.appspot.com/1035004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3374 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-16 10:27:33 +00:00
phoglund@webrtc.org
a22a9bd9ca
Cleaned up the data path for payload data, made callbacks to rtp_receiver nonoptional.
...
The audio receiver is now completely independent of rtp_receiver: video will hopefully be too in the next patch.
BUG=
TEST=vie & voe_auto_test full runs
Review URL: https://webrtc-codereview.appspot.com/1014006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3372 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-14 10:01:55 +00:00
andrew@webrtc.org
f908011eb4
Remove extra line.
...
TBR=elham
Review URL: https://webrtc-codereview.appspot.com/1024008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3365 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-11 22:39:55 +00:00
mflodman@webrtc.org
2f225cadde
Add logs when no RTCP RR has been received for three regular RTCP intervals.
...
BUG=1267
TEST=Unittest added.
Review URL: https://webrtc-codereview.appspot.com/1019006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3346 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-09 13:54:43 +00:00
phoglund@webrtc.org
c38eef896a
Reformatted RTPReceiver.
...
This is a pure reformat patch, with the exception that I also fixed all comments and moved a constant. I did not change the types in this patch since I
though that is more risky, so I'll do that in a separate patch later (perhaps
we could purge the types from the whole module in one go?)
BUG=
TEST=Trybots, vie_ & voe_auto_test --automated
Review URL: https://webrtc-codereview.appspot.com/998007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3338 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-07 10:18:30 +00:00
pwestin@webrtc.org
1b6da28047
Bugfix for NACK behavior. Current code sends a number of duplicate NACK requests.
...
Landing of 573005 On behalf of an1kumar@gmail.com
TBR=mflodman
Review URL: https://webrtc-codereview.appspot.com/1002008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3322 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-21 17:46:24 +00:00
phoglund@webrtc.org
ad0ed582b5
Fixed a missed initialization (found by valgrind FYI bot).
...
http://webrtc-cb-linux-master.cbf.corp.google.com:8011/builders/LinuxLargeTests/builds/327/steps/memory%20test%3A%20memcheck_voe_auto_test/logs/stdio
BUG=
TEST=Reproduced valgrind error, verified gone after fixing.
Review URL: https://webrtc-codereview.appspot.com/1008005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3318 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-20 09:14:36 +00:00
phoglund@webrtc.org
61f39a3174
Fixed bad header name.
...
TBR=stefan@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/1001008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3307 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-18 16:02:13 +00:00
phoglund@webrtc.org
07bf43c673
Replaced the _audio parameter with a strategy.
...
The purpose is to make _rtpReceiver mostly agnostic to if it processes audio or video, and make its delegates responsible for that. This patch makes the actual interfaces and interactions between the classes a lot clearer which will probably help straighten out the rather convoluted business logic in here. There are a number of rough edges I hope to address in coming patches.
In particular, I think there are a lot of audio-specific hacks, especially when it comes to telephone event handling. I think we will see a lot of benefit once that stuff moves out of rtp_receiver altogether. The new strategy I introduced doesn't quite pull its own weight yet, but I think I will be able to remove a lot of that interface later once the responsibilities of the classes becomes move cohesive (e.g. that audio specific stuff actually lives in the audio class, and so on). Also I think it should be possible to extract payload type management to a helper class later on.
BUG=
TEST=vie/voe_auto_test, trybots
Review URL: https://webrtc-codereview.appspot.com/1001006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3306 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-18 15:40:53 +00:00
fbarchard@google.com
3c37354b70
Initialize 3 variables which are preventing VS2012 from building.
...
BUG=1211
TESTED=ninja -C out\Release
Review URL: https://webrtc-codereview.appspot.com/992005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3301 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-15 01:09:18 +00:00
phoglund@webrtc.org
7659d914bb
Decoupled video rtp receiver from rtp receiver.
...
BUG=
Review URL: https://webrtc-codereview.appspot.com/995005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3292 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-14 09:57:37 +00:00
phoglund@webrtc.org
92bb417cb1
Decoupled RTP audio processor from RTP receiver.
...
BUG=
TEST=Ran vie_auto_test, rtp_rtcp_unittests, voe_auto_test
Review URL: https://webrtc-codereview.appspot.com/979004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3279 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-13 10:48:24 +00:00
stefan@webrtc.org
8d0cd07d0c
Add test to verify that padding only frames are passing through the RTP module.
...
Review URL: https://webrtc-codereview.appspot.com/934023
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3224 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-03 14:01:46 +00:00
marpan@webrtc.org
f3cefe1104
Added metrics test code for the FEC packet masks.
...
The test computes metrics (average residual loss) for each mask type and size,
for a given set of loss models (random and bursty), and verifies various
behaviour of the codes (including relation/comparison to RS code).
http://webrtc-codereview.appspot.com/748008
TBR=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/929034
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3189 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 23:27:34 +00:00
marpan@webrtc.org
c244cefe1d
Reverting r3185
...
TBR=marpan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/933029
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3186 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 21:00:36 +00:00
marpan@webrtc.org
993494764d
Added metrics test code for the FEC packet masks.
...
The test computes metrics (average residual loss) for each mask type and size,
for a given set of loss models (random and bursty), and verifies various
behaviour of the codes (including relation/comparison to RS code).
Review URL: https://webrtc-codereview.appspot.com/748008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3185 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 19:43:58 +00:00
phoglund@webrtc.org
ef90c3227e
Will now correctly identify the first-ever received packet as the first packet in its frame.
...
We used to flag the _second_ packet in the first frame as the first. Subsequent frames worked as intended.
BUG=1103
TEST=vie_auto_test --automated, rtp_rtcp_unittests
Review URL: https://webrtc-codereview.appspot.com/964020
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3164 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-26 16:30:40 +00:00
mflodman@webrtc.org
7c894b7cc7
Wire up CallStats to provide modules with correct RTT.
...
BUG=769
TEST=Manual test since there is no ViE APi to get RTT for receive channels.
Review URL: https://webrtc-codereview.appspot.com/937027
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3163 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-26 12:40:15 +00:00
andrew@webrtc.org
418443c531
Remove operator overloading from RTPFragmentationHeader.
...
Instead supply a CopyFrom() method.
TEST=vie_auto_test
Review URL: https://webrtc-codereview.appspot.com/972004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3158 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-23 19:17:23 +00:00
mflodman@webrtc.org
1c61196095
Removed not used include.
...
TEST=Compiles.
Review URL: https://webrtc-codereview.appspot.com/966025
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3150 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-22 09:37:27 +00:00
stefan@webrtc.org
4100b0402e
Move SSRC list to RemoteBitrateEstimator.
...
BUG=1105
Review URL: https://webrtc-codereview.appspot.com/965027
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3130 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-19 10:09:20 +00:00
mflodman@webrtc.org
b2f474e8bb
Adding ViE CallStats to keep track of call statistics. As a start, only rtt is handled.
...
This CL will be followed by another CL connecting the dots.
BUG=769
TEST=New unittest added.
Review URL: https://webrtc-codereview.appspot.com/968006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3117 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-16 13:57:26 +00:00
pwestin@webrtc.org
571a1c035b
Enable paced sender.
...
Review URL: https://webrtc-codereview.appspot.com/965016
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3089 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-13 21:12:39 +00:00
asapersson@webrtc.org
1726661ca2
Update parsed non ref frame info.
...
Review URL: https://webrtc-codereview.appspot.com/932015
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3084 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-13 13:39:51 +00:00
pwestin@webrtc.org
c66e8b3f31
pre-factor cleanup pre-work.
...
Review URL: https://webrtc-codereview.appspot.com/938010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3054 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-07 17:01:04 +00:00
asapersson@webrtc.org
e5b49a0472
Update timestamp offset for re-transmitted packets.
...
BUG=1059
Review URL: https://webrtc-codereview.appspot.com/930011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3046 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-06 13:09:39 +00:00
andrew@webrtc.org
14b43beb7c
Move src/ -> webrtc/
...
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/915006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-22 18:19:23 +00:00