deadbeef
9922016ee4
Fix "IsLoopbackIp" to cover all loopback addresses; not just 127.0.0.1.
...
The loopback range is 127.0.0.0/8, which is everything from 127.0.0.0 to
127.255.255.255.
BUG=chromium:649118
Review-Url: https://codereview.webrtc.org/2445933003
Cr-Commit-Position: refs/heads/master@{#14807}
2016-10-28 01:30:28 +00:00
terelius
d802b5b7c3
Fix some signed overflow errors causing undefined behavior (in theory).
...
BUG=webrtc:5491
Review URL: https://codereview.webrtc.org/1744183002
Cr-Commit-Position: refs/heads/master@{#11832}
2016-03-01 19:07:40 +00:00
Sergey Ulanov
beed8280d8
Fix IPAddress::ToSensitiveString() to avoid dependency on inet_ntop().
...
Previosly ToSesnsetiveString() wasn't working witn some implementations
of inet_ntop(). Rewrote it to avoid that dependency.
BUG=chromium:577344
R=pthatcher@webrtc.org , tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1584793004 .
Cr-Commit-Position: refs/heads/master@{#11242}
2016-01-14 02:14:59 +00:00
henrikg
ac921d7365
Add "x"s in the end of a stripped IPv6 address string.
...
This makes it clearer that the IP address has been stripped.
BUG=chromium:254329
Review URL: https://codereview.webrtc.org/1516163003
Cr-Commit-Position: refs/heads/master@{#11005}
2015-12-14 10:07:08 +00:00
Peter Boström
cdb38e5397
Strip IP addresses in NDEBUG (release) builds.
...
Also removes the ability to override (set) this.
BUG=
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1480743002 .
Cr-Commit-Position: refs/heads/master@{#10796}
2015-11-25 23:36:20 +00:00
Guo-wei Shieh
9af97f8910
WebRTC should generate default private address even when adapter enumeration is disabled.
...
Introduce a DefaultAddressProvider such that rtc::Network can't access other part of NetworkManager.
This also removes the hack of generating the loopback address. The dependency has been removed by https://codereview.chromium.org/1417023003/
BUG=webrtc:5061
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1411253008 .
Cr-Commit-Position: refs/heads/master@{#10590}
2015-11-10 22:47:49 +00:00
Peter Boström
0c4e06b4c6
Use suffixed {uint,int}{8,16,32,64}_t types.
...
Removes the use of uint8, etc. in favor of uint8_t.
BUG=webrtc:5024
R=henrik.lundin@webrtc.org , henrikg@webrtc.org , perkj@webrtc.org , solenberg@webrtc.org , stefan@webrtc.org , tina.legrand@webrtc.org
Review URL: https://codereview.webrtc.org/1362503003 .
Cr-Commit-Position: refs/heads/master@{#10196}
2015-10-07 10:23:32 +00:00
Guo-wei Shieh
fe3bc9d5ae
Relanding "Generate localhost candidate when no STUN/TURN and portallocator has the right flag spefied."
...
Migrated from https://codereview.webrtc.org/1275703006/ which causes test failures for android. On android, loopback interface was used as local interface to generate candidates. Add a test case to make sure this won't be broken in the future.
Also observed some failures under content_browsertests in chromium.fyi bot but can't repro locally. Might just be temporary test issue.
BUG=webrtc:4517
TBR=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1299333003 .
Cr-Commit-Position: refs/heads/master@{#9746}
2015-08-20 15:48:27 +00:00
Guo-wei Shieh
370c8848ad
Revert "Generate localhost candidate when no STUN/TURN and portallocator has the right flag spefied."
...
This reverts commit 0a2955f227666efd87b2a303a69c083ef801c528.
Revert "In the past, P2PPortAllocator.enable_multiple_routes is the indicator whether we should bind to the any address. It's easy to translate that into a port allocator flag in P2PPortAllocator's ctor. Going forward, we have to depend on an asynchronous permission check to determine whether gathering local address is allowed or not, hence the current way of passing it through constructor approach won't work any more. The asynchronous check will trigger SignalNetowrksChanged so we could only check that inside DoAllocate."
This reverts commit ba9ab4cd8d2e8fbc068dc36b5e6f6331d7deeccf.
TBR=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1288843003 .
Cr-Commit-Position: refs/heads/master@{#9729}
2015-08-19 00:00:21 +00:00
Guo-wei Shieh
0a2955f227
Generate localhost candidate when no STUN/TURN and portallocator has the right flag spefied.
...
BUG=webrtc:4517
R=pthatcher@webrtc.org
Review URL: https://codereview.webrtc.org/1275703006 .
Cr-Commit-Position: refs/heads/master@{#9726}
2015-08-18 20:05:29 +00:00
Guo-wei Shieh
1147702958
WebRTC Bug 4865
...
Bug 4865: even without STUN/TURN, as long as the peer is on the open internet, the connectivity should work. This is actually a regression even for hangouts.
We need to issue the 0.0.0.0 candidate into Port::candidates_ and filter it out later. The reason is that when we create connection, we need a local candidate to match the remote candidate.
The same connection later will be updated with the prflx local candidate once the STUN ping response is received.
BUG=webrtc:4865
R=juberti@webrtc.org
Committed: 38f8893235
Review URL: https://codereview.webrtc.org/1274013002 .
Cr-Commit-Position: refs/heads/master@{#9717}
2015-08-15 16:28:46 +00:00
guoweis@webrtc.org
b91d0f5130
1. Have IPIsPrivate calling IPIsLinkLocal
...
2. Also check the Mac based IPv6
3. move the ip filtering into createnetwork. It shouldn't be done in IsIgnoredNetwork as the IP inside that could change later.
BUG=
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/48509004
Cr-Commit-Position: refs/heads/master@{#8758}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8758 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-17 14:43:42 +00:00
guoweis@webrtc.org
bbce5efaa6
Turn on IPv6 for WebRTC as default as required before ramping the experiment to 30%.
...
BUG=
R=juberti@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8582
Committed: https://code.google.com/p/webrtc/source/detail?r=8607
Review URL: https://webrtc-codereview.appspot.com/43529004
Cr-Commit-Position: refs/heads/master@{#8609}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8609 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-05 04:39:07 +00:00
guoweis@webrtc.org
d43b2c098d
Revert "Turn on IPv6 for WebRTC as default as required before ramping the experiment to 30%."
...
This reverts commit 86c33e3a94f51f8e4b4f305708ec327786ad3794.
TBR=guoweis@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/47409004
Cr-Commit-Position: refs/heads/master@{#8608}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8608 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-05 04:03:44 +00:00
guoweis@webrtc.org
86c33e3a94
Turn on IPv6 for WebRTC as default as required before ramping the experiment to 30%.
...
BUG=
R=juberti@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8582
Review URL: https://webrtc-codereview.appspot.com/43529004
Cr-Commit-Position: refs/heads/master@{#8607}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8607 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-05 03:40:48 +00:00
guoweis@webrtc.org
59ae5ff310
Filter logic for ip leak misses ::ffff:0.0.0.0
...
The current logic filtering out "any" address is incomplete in the case
when any address in IPv4 converted in IPv6 form is not filtered out.
BUG=
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/44429004
Cr-Commit-Position: refs/heads/master@{#8545}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8545 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-01 23:45:42 +00:00
guoweis@webrtc.org
fa603981f2
Add a new class InterfaceAddress inherited from IPAddress to keep track of IPv6 Address flags.
...
Skeleton put in place in Network::GetFilterIPs() which will be used to
filter addresses
BUG=3773
R=jiayl@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/23439004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7126 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-09 23:42:40 +00:00
henrike@webrtc.org
f048872e91
Adds a modified copy of talk/base to webrtc/base. It is the first step in
...
migrating talk/base to webrtc/base.
BUG=N/A
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17479005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
perkj@webrtc.org
e9a604accd
Revert 6107 "Adds a modified copy of talk/base to webrtc/base. I..."
...
This breaks Chromium FYI builds and prevent roll of webrtc/libjingle to Chrome.
http://chromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win%20Builder/builds/457
> Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
>
> BUG=N/A
> R=andrew@webrtc.org , wu@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/12199004
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14479004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6116 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 08:15:48 +00:00
henrike@webrtc.org
2c7d1b39b9
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
...
BUG=N/A
R=andrew@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12199004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6107 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-12 18:03:09 +00:00