5 Commits

Author SHA1 Message Date
kwiberg
427ce3d86f Move FilePlayer and FileRecorder to Voice Engine
Because Voice Engine was the only user.

(This has been landed twice before, as
https://codereview.webrtc.org/2037623002 and
https://codereview.webrtc.org/2240163002. Third time's a charm!)

NOPRESUBMIT=True
TBR=kjellander@webrtc.org

Review-Url: https://codereview.webrtc.org/2247033003
Cr-Commit-Position: refs/heads/master@{#13777}
2016-08-16 10:34:50 +00:00
kwiberg
c8c71f484e Revert of Move FilePlayer and FileRecorder to Voice Engine (patchset #6 id:100001 of https://codereview.webrtc.org/2240163002/ )
Reason for revert:
Breaks downstream code, so revert again. Yay.

Original issue's description:
> Move FilePlayer and FileRecorder to Voice Engine
>
> Because Voice Engine was the only user.
>
> (This is a re-land of https://codereview.webrtc.org/2037623002, which
> had to be reverted.)
>
> NOPRESUBMIT=True
>
> Committed: https://crrev.com/dc65ea29b3270ad418050658ad962ddd33ee70c1
> Cr-Commit-Position: refs/heads/master@{#13757}

TBR=perkj@webrtc.org,kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.webrtc.org/2245153002
Cr-Commit-Position: refs/heads/master@{#13758}
2016-08-15 18:43:56 +00:00
kwiberg
dc65ea29b3 Move FilePlayer and FileRecorder to Voice Engine
Because Voice Engine was the only user.

(This is a re-land of https://codereview.webrtc.org/2037623002, which
had to be reverted.)

NOPRESUBMIT=True

Review-Url: https://codereview.webrtc.org/2240163002
Cr-Commit-Position: refs/heads/master@{#13757}
2016-08-15 17:36:38 +00:00
kwiberg
e7edea9759 Revert of Move FilePlayer and FileRecorder to Voice Engine (patchset #5 id:80001 of https://codereview.chromium.org/2037623002/ )
Reason for revert:
voice_engine_unittests: FilePlayerTest.PlayWavPcm16File and FilePlayerTest.PlayWavPcmuFile fail on 32-bit android (android_rel and android-dbg try bots, Android32 Tests (L Nexus5) and Android32 Tests (L Nexus7.2) build bots).

Not sure why this would happen, since I just moved the test without modifying it. Some test filtering that no longer manages to disable them? Anyway, reverting until I know how to fix.

This was actually caught by the try bots, but I missed it because I was manually ignoring them because of an error with the bots. :-(

Original issue's description:
> Move FilePlayer and FileRecorder to Voice Engine
>
> Because Voice Engine was the only user.
>
> R=perkj@webrtc.org, solenberg@webrtc.org
>
> Committed: 65874b163e

TBR=perkj@webrtc.org,solenberg@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.webrtc.org/2092633002
Cr-Commit-Position: refs/heads/master@{#13267}
2016-06-22 23:29:58 +00:00
Karl Wiberg
65874b163e Move FilePlayer and FileRecorder to Voice Engine
Because Voice Engine was the only user.

R=perkj@webrtc.org, solenberg@webrtc.org

Review URL: https://codereview.webrtc.org/2037623002 .

Cr-Commit-Position: refs/heads/master@{#13261}
2016-06-22 21:47:53 +00:00