admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
8,171 Commits 1 Branch 0 Tags
Commit Graph

26 Commits

Author SHA1 Message Date
Minyue
cf3c83e76c Revert "Split EventWrapper in twain." 
This reverts commit 9509fbfc301dd5412804ce5731afedc81480f2f8.

This is to debug a Chromium issue that WebRTC hangs if there is > 1 PeerConnection active in the browser on Win XP.

BUG=

TBR=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/43019004

Cr-Commit-Position: refs/heads/master@{#8912}
 2015-04-01 14:31:45 +00:00
tommi@webrtc.org
9509fbfc30 Split EventWrapper in twain. 
I'm splitting the timer functions in EventWrapper into a separate interface.
- Users of the timer functions have different needs than users of a generic event
- Providing a default implementation for EventWrapper that simply uses rtc::Event.

This means that clients of WebRTC that don't use the relatively few classes, typically rendering classes, that depend on the event timer functionality, also don't pull in dependencies on multimedia timers.

R=mflodman@webrtc.org, mflodman
BUG=

Review URL: https://webrtc-codereview.appspot.com/48599004

Cr-Commit-Position: refs/heads/master@{#8833}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8833 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-23 16:25:46 +00:00
tommi@webrtc.org
38492c5b6f Re-land 8810 "- Add a SetPriority method to ThreadWr..." 
> Revert 8810 "- Add a SetPriority method to ThreadWrapper"
> Seeing if this is causing roll issues.
> 
> > - Add a SetPriority method to ThreadWrapper
> > - Remove 'priority' from CreateThread and related member variables from implementations
> > - Make supplying a name for threads, non-optional
> > 
> > BUG=
> > R=magjed@webrtc.org
> > 
> > Review URL: https://webrtc-codereview.appspot.com/44729004
> 
> TBR=tommi@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/48609004

TBR=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/50459005

Cr-Commit-Position: refs/heads/master@{#8819}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8819 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-22 14:42:46 +00:00
tommi@webrtc.org
90a1cb4630 Revert 8810 "- Add a SetPriority method to ThreadWrapper" 
Seeing if this is causing roll issues.

> - Add a SetPriority method to ThreadWrapper
> - Remove 'priority' from CreateThread and related member variables from implementations
> - Make supplying a name for threads, non-optional
> 
> BUG=
> R=magjed@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/44729004

TBR=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/48609004

Cr-Commit-Position: refs/heads/master@{#8818}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8818 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-22 14:34:46 +00:00
tommi@webrtc.org
b6817d793f - Add a SetPriority method to ThreadWrapper 
- Remove 'priority' from CreateThread and related member variables from implementations
- Make supplying a name for threads, non-optional

BUG=
R=magjed@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/44729004

Cr-Commit-Position: refs/heads/master@{#8810}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8810 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-20 15:52:43 +00:00
tommi@webrtc.org
361981faa8 Use scoped_ptr for ThreadWrapper::CreateThread. 
BUG=
R=henrika@webrtc.org, pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/45799004

Cr-Commit-Position: refs/heads/master@{#8794}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8794 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-19 14:45:42 +00:00
pbos@webrtc.org
86639737b8 Remove thread id from ThreadWrapper::Start(). 
Removes ThreadPosix::InitParams and a corresponding wait for an event.
This unblocks ThreadPosix::Start which had to wait for thread scheduling
for an event to trigger on the spawned thread, giving faster Start()
calls.

BUG=4413
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/43699004

Cr-Commit-Position: refs/heads/master@{#8709}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8709 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-03-13 00:07:45 +00:00
tommi@webrtc.org
875c97ed9d Remove SetNotAlive method from the thread class. 
Also cleaning up methods with the same name in other classes that are derived from the above method.

R=perkj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/41759004

Cr-Commit-Position: refs/heads/master@{#8242}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8242 4adac7df-926f-26a2-2b94-8c16560cd09d
 2015-02-04 11:12:39 +00:00
braveyao@webrtc.org
bf09976e86 Add more sanity checks to workaround the unidentified problem that CaptureThread is still running while related resouces are destroyed already. 
BUG=
TEST=auto test
R=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/28859004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7590 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-11-03 09:58:40 +00:00
henrike@webrtc.org
6ac22e6b47 Remove more dependencies on openssl, add dependency on boringssl. Continues on r6798 
R=andrew@webrtc.org, fbarchard@chromium.org, kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14029004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6867 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-08-11 21:06:30 +00:00
tommi@webrtc.org
d212ffcfc6 Remove unnecessary build message. 
R=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/13909004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6660 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-07-11 11:15:35 +00:00
andrew@webrtc.org
c7c432aa9b Remove AudioDevice::{Microphone,Speaker}IsAvailable. 
This was only used for logging, except on Mac, where the methods are
now private.

BUG=3132
R=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10959004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5831 4adac7df-926f-26a2-2b94-8c16560cd09d
 2014-04-02 16:49:26 +00:00
andrew@webrtc.org
2553450959 Fix win trybot errors due to r4729. 
The addition of logging.h in r4729 was causing the win trybot to fail
with "#pragma deprecated" errors in standard library headers. This
turned out to be due to including strsafe.h (via audio_device_config.h)
before sstream (via logging.h).

strsafe.h was only being included for the unused DEBUG_PRINT macro. I
removed all references to it.

This incidentally removes a bunch of other unneeded headers discovered
while trying to track the problem down.

This didn't show up in the commitbots; my guess is that the trybots are
using the VC10 toolchain and the commitbots the VC11 toolchain.

TBR=pbos

Review URL: https://webrtc-codereview.appspot.com/2204004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4738 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-09-13 00:02:13 +00:00
pbos@webrtc.org
12dc1a38ca Switch C++-style C headers with their C equivalents. 
The C++ headers define the C functions within the std:: namespace, but
we mainly don't use the std:: namespace for C functions. Therefore we
should include the C headers.

BUG=1833
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1917004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4486 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-08-05 16:22:53 +00:00
pbos@webrtc.org
811269df40 Include files from webrtc/.. paths in audio_device/. 
BUG=1662
R=xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1785005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4330 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-07-11 13:24:38 +00:00
braveyao@webrtc.org
0b8636a783 In AudioDeviceWindowsCore::_EnumerateEndpointDevicesAll(), continue enumerating if one individual device failed. 
BUG=
TEST=manual Test
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1753005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4295 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-07-04 07:24:12 +00:00
pbos@webrtc.org
d900e8bea8 Proper spacing for end-of-namespace comments. 
BUG=
R=mflodman@webrtc.org, tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1760006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4293 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-07-03 15:12:26 +00:00
pbos@webrtc.org
9aca5b34e1 Remove #pragma once 
BUG=1830
R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1568004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4130 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-05-29 13:19:09 +00:00
braveyao@webrtc.org
c93b1d038d CoreAudio Win: release resources safely under certain rare circumstance in GTalkplugin 
BUG=
TEST=voe_auto_test
R=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1479004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4033 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-05-15 10:14:56 +00:00
niklas.enbom@webrtc.org
3be565b502 Refactoring for typing detection 
R=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1370004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3976 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-05-07 21:04:24 +00:00
andrew@webrtc.org
7cb766b016 Remove 44.1 kHz workaround from AudioDevice on WASAPI. 
We currently inform VoE that 44.1 kHz audio is 44 kHz. We now have arbitrary
resampling in VoE, allowing us to pass in the native 44.1 kHz.

BUG=webrtc:1395
TESTED=Set capture device to 44.1 and render device to 48 and vice versa and observed good AEC. The quality is considerably worse before this change. Using 44.1 for capture and render in loopback, ran through all codec channel/rate combinations. Quality is good.
R=xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1383004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3954 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-05-03 18:56:38 +00:00
braveyao@webrtc.org
c14b728b71 Add lock to prevent possible rare race condition in Win coreAudio capture implementation. 
BUG = 
TEST = voe_auto_test

Review URL: https://webrtc-codereview.appspot.com/1320011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3868 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-04-18 09:32:07 +00:00
pbos@webrtc.org
2550988baa WebRtc_Word32 -> int32_t in audio_device/ 
BUG=314

Review URL: https://webrtc-codereview.appspot.com/1302006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3793 4adac7df-926f-26a2-2b94-8c16560cd09d
 2013-04-09 10:30:35 +00:00
braveyao@webrtc.org
72feb0b2e2 Not to enum NOTPRESENT audio devices with CoreAudio on Win 
BUG = 
TEST = Manual test
Review URL: https://webrtc-codereview.appspot.com/939037

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3251 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-12-07 22:36:07 +00:00
henrika@webrtc.org
5ba3decc94 Ensures that we can build using VS 2012 on Windows. 
See more details at https://code.google.com/p/webrtc/issues/detail?id=1146&

TBR=Niklas
BUG=1146

Review URL: https://webrtc-codereview.appspot.com/939028

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3162 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-11-26 09:12:02 +00:00
andrew@webrtc.org
14b43beb7c Move src/ -> webrtc/ 
TBR=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/915006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
 2012-10-22 18:19:23 +00:00