11 Commits

Author SHA1 Message Date
kwiberg
e61103dc6c Don't add or rename files in webrtc/ and webrtc/api/ without a proper review
NOTRY=true
BUG=none

Review-Url: https://codereview.webrtc.org/2862343002
Cr-Commit-Position: refs/heads/master@{#18049}
2017-05-08 13:01:54 +00:00
kjellander
f17cae24f4 Cleanup unused rules in webrtc/DEPS + add kjellander to OWNERS for it
Remove entries for headers that no longer exists in the webrtc/ dir.

BUG=webrtc:5878
NOTRY=True

Review-Url: https://codereview.webrtc.org/2540633002
Cr-Commit-Position: refs/heads/master@{#15292}
2016-11-29 10:52:22 +00:00
Henrik Kjellander
b4af3d673a Remove all references to GYP
Remove all .gyp and .gypi files.
Remove entries from OWNERS files for *.isolate, *.gyp, *.gypi
Remove unused scripts in webrtc/build.

BUG=webrtc:6323
R=henrika@webrtc.org, phoglund@webrtc.org

Review URL: https://codereview.webrtc.org/2509703002 .

Cr-Commit-Position: refs/heads/master@{#15107}
2016-11-16 19:11:38 +00:00
Henrik Kjellander
a41c13e6a2 OWNERS: Make everyone able to change *.gn,*.gni files.
Project-wide change to make it possible for all team members
to do changes to GN files.

NOTRY=True
R=kwiberg@webrtc.org
TBR=henrika@webrtc.org

Review URL: https://codereview.webrtc.org/2320043002 .

Cr-Commit-Position: refs/heads/master@{#14163}
2016-09-09 12:51:48 +00:00
stefan
c99d5a6132 Add stefan@ to webrtc/OWNERS.
NOTRY=true

Review-Url: https://codereview.webrtc.org/2224353002
Cr-Commit-Position: refs/heads/master@{#13717}
2016-08-10 15:49:59 +00:00
solenberg
87abc289a9 Add kwiberg@webrtc.org as root owner.
NOTRY=true

Review-Url: https://codereview.webrtc.org/2060923003
Cr-Commit-Position: refs/heads/master@{#13125}
2016-06-14 09:39:40 +00:00
kjellander
2f5ae66471 Add root owners to webrtc/OWNERS
For WebRTC inside Chromium, only the webrtc/ directory is present
(as src/third_party/webrtc). That makes it impossible to add DEPS
check_deps rules in Chromium without approval of a webrtc.org owner
(see https://codereview.chromium.org/1818903004).

By having our root owners also be owners in webrtc/, this should be
less confusing.

NOTRY=True

Review-Url: https://codereview.webrtc.org/1934523002
Cr-Commit-Position: refs/heads/master@{#12687}
2016-05-11 12:47:43 +00:00
nisse
e31dc95084 Make pbos owner of additional video files.
NOTRY=True

Review URL: https://codereview.webrtc.org/1724303005

Cr-Commit-Position: refs/heads/master@{#11781}
2016-02-26 12:29:17 +00:00
kjellander@webrtc.org
1227ab89a7 GN: Add BUILD.gn files + kjellander to OWNERS
This should work as a foundation for all the work that is
left to do to make the parts of WebRTC that Chromium uses
to build with GN.

I implemented some the smaller modules myself in this CL.
The remaining work (TODO's in the .gn files) will be distributed
to various team members.

I'm adding myself to OWNERS files for BUILD.gn files in all the
directories where I'm adding a BUILD.gn file.

BUG=3441
TEST=
Successful compilation of WebRTC as standalone:
gn gen out/Default --args="build_with_chromium=false" && ninja -C out/Default
gn gen out/Default --args="build_with_chromium=false is_clang=true clang_use_chrome_plugins=false" && ninja -C out/Default

I built successfully from a Chromium checkout (with
https://codereview.chromium.org/321313006/ applied) using:
gn gen out/Default && ninja -C out/Default webrtc

R=brettw@chromium.org, niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/13749004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6523 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-23 19:21:07 +00:00
kjellander@webrtc.org
7b82c18979 Add kjellander@webrtc.org as OWNER for *.isolate
This should make project-wide changes for isolate files
easier and make it more obvious who's a suitable reviewer
for them.

BUG=
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/19689004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6379 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-06-10 05:42:53 +00:00
fischman@webrtc.org
2c89b5cb27 Make everyone an OWNER for .gyp/.gypi add/delete purposes, non-talk/ edition.
This CL brought to you by:
$ for d in $(for f in $(git ls-files '*gyp' '*gypi'); do dirname $f; done|sort|uniq|grep -v '^\.$'); do echo -e "\n# These are for the common case of adding or renaming files. If you're doing\n# structural changes, please get a review from a reviewer in this file.\nper-file *.gyp=*\nper-file *.gypi=*" >> $d/OWNERS; done
$ for d in $(for f in $(git ls-files '*gyp' '*gypi'); do dirname $f; done|sort|uniq|grep -v '^\.$'); do git add $d/OWNERS; done

(and then removed the talk/ impact)

R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/11969004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5903 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-14 20:08:03 +00:00