This is a reland of bd33ce26202272177af6c52e195e7c13f0d1bf23
Now it doesn't apply flags_compatibility to Android, because the device runner actually requires it to be dashes (so it can intercept the flag and substitute it with an Android-local file path), but that's OK because the runner also already passes the flag with underscores: https://cs.chromium.org/?q=%22--isolated_script_test_perf_output%22
Original change's description:
> Reland "Add wrapper to normalize flags."
>
> This is a reland of 642a49d1eb20b8c5744e745de79ddb585e0f7472
>
> The change has the same effect but is now implemented through mb, rather than specifying a 'script', so that Android's special handling is not skipped.
>
> Original change's description:
> > Add wrapper to normalize flags.
> >
> > Bug: None
> > Change-Id: I9d43602cc66198a29dbc0e7586d948ee76c5ec84
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145204
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> > Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#28532}
>
> Bug: webrtc:10616
> Change-Id: I60ebd4891dbe8de18c653f8af88181ea966307de
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145409
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#28572}
Bug: webrtc:10616
Change-Id: I56aae5475aed62f069c5cecc01b75d7d6ffcf568
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145920
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28589}
This is a reland of 642a49d1eb20b8c5744e745de79ddb585e0f7472
The change has the same effect but is now implemented through mb, rather than specifying a 'script', so that Android's special handling is not skipped.
Original change's description:
> Add wrapper to normalize flags.
>
> Bug: None
> Change-Id: I9d43602cc66198a29dbc0e7586d948ee76c5ec84
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145204
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#28532}
Bug: webrtc:10616
Change-Id: I60ebd4891dbe8de18c653f8af88181ea966307de
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145409
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28572}
Followup to https://webrtc-review.googlesource.com/120404
Add forgotten bot ios_arm64_perf.
Drop dcheck_always_on from perf bots like it was before.
Bug: webrtc:10253
Change-Id: I1ab989a6d6059f5ddf6f341e54fcc92cac97755a
Reviewed-on: https://webrtc-review.googlesource.com/c/120804
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Artem Titarenko <artit@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26506}
FFmpeg hasn't been rolled since [1] in order to avoid to break MSVC
trybots (//third_party/ffmpeg dropped MSVC support, in theory it is
possible to bring the support back but some work is needed every time
//third_party/ffmpeg gets updated).
Not rolling //third_party/ffmpeg is not enough to keep the Chromium
Roll working because -Wstring-plus-int becomes more chatty with clang 350768
and it has been suppressed in //third_party/ffmpeg/BUILD.gn [2].
Since WebRTC needs to update clang, //third_party/ffmpeg needs to be
updated. The only way to do it without fixing MSVC errors in
//third_party/ffmpeg is to enforce rtc_use_h264=False when MSVC is used.
PSA: https://groups.google.com/forum/#!topic/discuss-webrtc/cfkPPq5nvNE.
[1] - https://webrtc-review.googlesource.com/78402
[2] - https://chromium-review.googlesource.com/c/chromium/third_party/ffmpeg/+/1376376
Bug: webrtc:9213
Change-Id: I36bd7fb2db21012760e4ff7a791d81350e402ec0
Reviewed-on: https://webrtc-review.googlesource.com/c/116982
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26257}
Perf bots can be removed from this config because they will not perform compilation anymore.
Note that Linux64 Builder already exists.
Bug: chromium:908001
Change-Id: I3d2de332083bc0e7054fa09f8814c6500fad9ee4
Reviewed-on: https://webrtc-review.googlesource.com/c/115413
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26087}
because they actually produce exactly the same GN args.
No-Try: True
Bug: None
Change-Id: Ib9315ec6ded28bfa64606cdb14c61ec6479203be
Reviewed-on: https://webrtc-review.googlesource.com/c/115412
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26085}
Explicitly say "_compile_" for ARM and Clang and GCC.
Explicitly say "_arm_" for mobiles.
Explicitly say "_x86_" for Windows.
Fill in some gaps where both tester and compile-only bots are viable.
Also remove unused "experimental" tryjobs.
No-Try: True
Bug: webrtc:10072
Change-Id: Ib22e0518fc1e600b237c3c687994f27c7e88b8b3
Reviewed-on: https://webrtc-review.googlesource.com/c/112585
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25872}
The UWP toolchain code appears to be broken with clang, so let's see
if we have better luck with MSVC.
Bug: webrtc:10050
Change-Id: If8d29e7a95a0780c310ccd665c99d7a3add1016a
Reviewed-on: https://webrtc-review.googlesource.com/c/112290
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25841}
These special bots will be monitored by Microsoft engineers.
Bug: webrtc:10050
Change-Id: I124789628a1f0bbe4ef1a2988261d2175da6387a
Reviewed-on: https://webrtc-review.googlesource.com/c/112082
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25835}
This test binary has been introduced in [1] and should be run on bots.
[1] - https://webrtc-review.googlesource.com/c/src/+/107345
Bug: webrtc:9518
Change-Id: I77e1aebd5fae73a9168f09334ac09be0e865ae90
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/c/110701
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25614}
Since it is currently unused and not actively maintained, code under
ortc/ will be deleted by this CL.
Bug: webrtc:9824
Change-Id: I20f890b1a1e5e1dbd2b3949af916ae0a6bc8a032
Reviewed-on: https://webrtc-review.googlesource.com/c/102601
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25082}
This is a reland of d8ff3f29ce92e27529e100ecf71afbae6334419f.
See https://webrtc-review.googlesource.com/c/src/+/100681/1..4 for
the fix. Error "Failed to open video file for emulated camera" should
be addressed by that change.
Original change's description:
> Compile frame analyzer for the host machine on perf tests.
>
> Bug: webrtc:9665
> Change-Id: I05c01ee4bef0995556b1a679498b3d9132de7c26
> Reviewed-on: https://webrtc-review.googlesource.com/100360
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#24756}
TBR=phoglund@webrtc.org, oprypin@webrtc.org
Bug: webrtc:9665
Change-Id: If6a4f2259dabf50718abf47c9cf303d143a1895a
Reviewed-on: https://webrtc-review.googlesource.com/100681
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24762}
The intelligibility enhancer is always disabled and it is the only non-test
target using the lapped transform in common_audio (which we planned to remove).
Bug: webrtc:9689, webrtc:5298
Change-Id: Ida65d3aa11ac366471e7e5cbc053108b376c67d8
Reviewed-on: https://webrtc-review.googlesource.com/96460
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Alex Loiko <aleloi@webrtc.org>
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24504}
Making video_capture_tests have the non_parallel_console_test_launcher
type will pass --workers=1 to gtest-parallel, which ensures the tests
execute sequentially. This is necessary now that we're accessing a
real physical webcam, which is a system-wide resource that doesn't
work well if several processes access it concurrently.
Follow-ups:
1) get video_capture_test back up on Linux
2) drop sw webcams for Mac and Win
3) remove ensure_webcam_is_running.pu and surrounding machinery
Bug: webrtc:9292
Change-Id: I5e3347ad234f6b942de736513075097d79c0fd36
Reviewed-on: https://webrtc-review.googlesource.com/94761
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24325}
Since the linux_memcheck trybot is no more, this CL removes all the
code needed to make it work.
Bug: webrtc:7737, webrtc:8356, webrtc:9570
Change-Id: I09a9467b8bf895146a3384c2c915b54662721af6
Reviewed-on: https://webrtc-review.googlesource.com/90863
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24201}
Fixes a target name that was missed in the last CL.
TBR=phoglund
Bug: webrtc:9588
No-Try: True
Change-Id: I704325666b758cee7eb080f8628fc839ab89831d
Reviewed-on: https://webrtc-review.googlesource.com/92389
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24188}
This matches Chromium pattern of naming instrumentation test apks with
a name ending in _test_apk. The old naming confuses generate_gradle.py.
Renames:
- AppRTCMobileTest
-> AppRTCMobile_test_apk
- AppRTCMobileTestStubbedVideoIO
-> AppRTCMobile_stubbed_video_io_test_apk
- libjingle_peerconnection_android_unittest
-> android_instrumentation_test_apk
Bug: webrtc:9588
TBR: phoglund
Change-Id: Idb82dc4bd089bc7c90e9373f7c3d572f9fd2d95a
Reviewed-on: https://webrtc-review.googlesource.com/92380
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24184}
In order to unblock the Chromium Roll, WebRTC should set use_lld=false
when MSVC is used (as discussed here [1]).
[1] - https://chromium-review.googlesource.com/c/chromium/src/+/1092611
Bug: None
Change-Id: Ia052d3d8842871c3051fe36991396976f5839f4c
Reviewed-on: https://webrtc-review.googlesource.com/83102
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23582}
