5 Commits

Author SHA1 Message Date
Henrik Kjellander
57e5fd2e60 PRESUBMIT: Improve PyLint check and add GN format check.
Add pylintrc file based on
https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/pylintrc
bit tightened up quite a bit (the one in depot_tools is far
more relaxed).

Remove a few excluded directories from pylint check and fixed/
suppressed all warnings generated.

Add GN format check + formatted all GN files using 'gn format'.
Cleanup redundant rules in tools/PRESUBMIT.py

TESTED=Ran 'git cl presubmit -vv', fixed the PyLint violations.
Ran it again with a modification in webrtc/build/webrtc.gni, formatted
all the GN files and ran it again.

R=henrika@webrtc.org, phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/50069004

Cr-Commit-Position: refs/heads/master@{#9274}
2015-05-25 10:55:50 +00:00
Henrik Kjellander
fa16dda238 Revert "Port frame_analyzer and rgba_to_i420_converter targets to GN build."
This reverts commit 6ac53b2b37c36d4e09f4252c91cada0462adf741.

Reason: breaks compile on Win GN:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20GN/builds/131

TBR=tfarina@chromium.org

Review URL: https://webrtc-codereview.appspot.com/45919004

Cr-Commit-Position: refs/heads/master@{#8915}
2015-04-01 20:54:08 +00:00
Henrik Kjellander
6ac53b2b37 Port frame_analyzer and rgba_to_i420_converter targets to GN build.
Tested on Linux with the following command lines:

$ gn gen //out/Debug --args='is_debug=true target_cpu="x64" build_with_chromium=false'
$ ninja -C out/Debug frame_analyzer rgba_to_i420_converter

BUG=chromium:461019
TEST=see above
R=kjellander@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/42999004

Cr-Commit-Position: refs/heads/master@{#8914}
2015-04-01 15:29:51 +00:00
kjellander@webrtc.org
3037bc3447 GN: Add common configs to tools and test.
Similar changes as in https://review.webrtc.org/28589004/
were missed in https://review.webrtc.org/25569004/.
This should fix the Chromium WebRTC FYI bots that currently
are broken due to lack of include paths.

BUG=3441
TBR=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/25749004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7347 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-30 19:07:58 +00:00
kjellander@webrtc.org
b8caf6a504 GN: Enable libvpx, add link target and convert some test targets
Libvpx now supports GN and this CL turns on compiling it.
I also introduced an executable target 'webrtc_tests'
that depends on all in WeBRTC + tests in order to get a full
linking step executed (since we've seen link problems for GN
when rolling WebRTC into Chromium).

I also converted a few test targets and made a GN file for
third_party/gflags.

BUG=3441
TESTED=Trybots + full Chromium build with a symlinked src/third_party/webrtc
dir to a workspace wit this CL applied.

R=brettw@chromium.org
TBR=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/25569004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7344 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-30 18:05:02 +00:00