Guo-wei Shieh
5d55c98cd2
WebRTC 4521: Remove usage of deprecated timezone global variable
...
BUG=4521
R=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/56469004
Cr-Commit-Position: refs/heads/master@{#9285}
2015-05-26 18:53:39 +00:00
Thiago Farina
0dd58026a8
Update callers to include messagedigest.h.
...
And remove pass-through stringdigest.h include.
This should fix the TODO in stringdigest.h that were that saying to update the callers to the new location.
BUG=None
TEST=ninja -C out/Debug still works fine
R=henrika@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/48779004
Patch from Thiago Farina <tfarina@chromium.org>.
Cr-Commit-Position: refs/heads/master@{#8920}
2015-04-02 07:03:28 +00:00
kwiberg@webrtc.org
67186fe00c
Fix clang style warnings in webrtc/base
...
Mostly this consists of marking functions with override when
applicable, and moving function bodies from .h to .cc files.
Not inlining virtual functions with simple bodies such as
{ return false; }
strikes me as probably losing more in readability than we gain in
binary size and compilation time, but I guess it's just like any other
case where enabling a generally good warning forces us to write
slightly worse code in a couple of places.
BUG=163
R=kjellander@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/47429004
Cr-Commit-Position: refs/heads/master@{#8656}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8656 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-09 22:24:25 +00:00
andresp@webrtc.org
ff689be3c0
Use std::min and std::max instead of self-defined functions such as rtc::_min/_max.
...
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/35079004
Cr-Commit-Position: refs/heads/master@{#8347}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8347 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-02-12 11:55:32 +00:00
henrike@webrtc.org
1711104b8a
Fix MSVC warnings about value truncations, webrtc/base/ edition.
...
BUG=chromium:81439
TEST=none
R=henrike@webrtc.org , marpan@google.com
Review URL: https://webrtc-codereview.appspot.com/20249004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7143 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-10 22:10:24 +00:00
sergeyu@chromium.org
af9e7943d1
Fix compilation on windows with clang, indentation cleanups
...
R=henrike@webrtc.org , thakis@chromium.org
TBR=hellner@chromium.org
Committed: https://code.google.com/p/webrtc/source/detail?r=6779
Review URL: https://webrtc-codereview.appspot.com/18849004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6786 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-25 19:42:19 +00:00
sergeyu@chromium.org
2386882266
Revert "Fix compilation on windows with clang, indentation cleanups"
...
This reverts commit f628eaedfeea97e13c63c78dd42f2b1c76723619.
TBR=sergeyu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/13069004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6780 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-25 17:37:12 +00:00
sergeyu@chromium.org
a44fce5920
Fix compilation on windows with clang, indentation cleanups
...
R=henrike@webrtc.org , thakis@chromium.org
TBR=hellner@chromium.org
Review URL: https://webrtc-codereview.appspot.com/18849004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6779 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-25 17:28:25 +00:00
henrike@webrtc.org
f048872e91
Adds a modified copy of talk/base to webrtc/base. It is the first step in
...
migrating talk/base to webrtc/base.
BUG=N/A
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17479005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6129 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 18:00:26 +00:00
perkj@webrtc.org
e9a604accd
Revert 6107 "Adds a modified copy of talk/base to webrtc/base. I..."
...
This breaks Chromium FYI builds and prevent roll of webrtc/libjingle to Chrome.
http://chromegw.corp.google.com/i/chromium.webrtc.fyi/builders/Win%20Builder/builds/457
> Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
>
> BUG=N/A
> R=andrew@webrtc.org , wu@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/12199004
TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14479004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6116 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-13 08:15:48 +00:00
henrike@webrtc.org
2c7d1b39b9
Adds a modified copy of talk/base to webrtc/base. It is the first step in migrating talk/base to webrtc/base.
...
BUG=N/A
R=andrew@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12199004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6107 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-12 18:03:09 +00:00