henrik.lundin@webrtc.org
33d5f69d5e
Fix issue 218 with new solution
...
This one is slightly more elegant and efficient.
BUG=http://code.google.com/p/webrtc/issues/detail?id=218
TEST=
Review URL: http://webrtc-codereview.appspot.com/344009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1420 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-13 07:46:50 +00:00
henrik.lundin@webrtc.org
053c7991e3
Add minimum waiting time to NetEQ metrics
...
Adding minWaitingTimeMs to ACMNetworkStatistics and to
NetworkStatistics. Also adding unittest.
TEST=audio_coding_unittests
Review URL: http://webrtc-codereview.appspot.com/350006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1408 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 14:16:44 +00:00
kjellander@webrtc.org
7f3c724e12
Renaming 47 files from .cpp to .cc
...
In addition to our naming guidelines, this will cause these files to get parsed by Sonar, and to make searching/grepping the source using file extensions easier in the future.
BUG=
TEST=Compiling on Linux.
Review URL: http://webrtc-codereview.appspot.com/348005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1405 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 10:23:41 +00:00
tina.legrand@webrtc.org
6b6ff558a8
Implementation if mono-to-stereo and vice versa in ACM.
...
Added stereo-to-mono and mono-to-stereo tests to end of TestStereo.cpp.
BUG=Aim to resolve issue 207, "Investigate stereo capture handling in modules"
TEST=audio_coding_module_test
Review URL: http://webrtc-codereview.appspot.com/345002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1385 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 10:12:54 +00:00
tina.legrand@webrtc.org
ac4eb046e3
Added registration of RED and CNG to NetEq slave.
...
Bug found when working on issue 221. Missing registration of CNG was the cause of the bad audio (master and slave out of sync) reported in the issue.
NOTE! File has not been refactored to follow Google style.
BUG=http://code.google.com/p/webrtc/issues/detail?id=221
Review URL: http://webrtc-codereview.appspot.com/342006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1372 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-10 13:59:55 +00:00
henrik.lundin@webrtc.org
d4e8c0b3ff
Fixing Issue 218
...
Taking care of the case when the raw waiting times vector from
NetEQ is zero length.
Also adding a new unittest to cover this case.
BUG=http://code.google.com/p/webrtc/issues/detail?id=218
TEST=AcmNetEqTest.TestZeroLengthWaitingTimesVector
Review URL: http://webrtc-codereview.appspot.com/349003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1370 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-10 13:46:06 +00:00
pwestin@webrtc.org
c450a19669
Removed Version function from all modules.
...
TBR=henrik_a
Review URL: http://webrtc-codereview.appspot.com/329023
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1330 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 15:00:12 +00:00
henrik.lundin@webrtc.org
d439870473
Adding two new network metrics to NetEQ
...
Clock-drift (in parts-per-million) and peaky-jitter mode status.
Both metrics are propagated to the VoE API. Tests are added
in the NetEQ unittests, and to some extent in ACM unittests
and VoE tests.
Introducing a proper translation between structs NetworkStatistics
and ACMNetworkStatistics.
Note: The file neteq_network_stats.dat in resources must be updated
for the unittests to pass.
Review URL: http://webrtc-codereview.appspot.com/337005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1328 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-04 13:09:55 +00:00
kjellander@webrtc.org
5490c71a1b
Converted to gtest, writing output files properly and no longer uses exceptions.
...
This test now runs and fails as a gtest should (previously it always
exited with 0 even if the tests failed).
The audio_coding_module_test target no longer uses exceptions in the generated project.
Output files are written to our global output folder, using
testsupport/fileutils.h.
BUG=
TEST=audio_coding_module_test on all platforms, in Debug+Release
Review URL: http://webrtc-codereview.appspot.com/334004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1266 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-21 13:34:18 +00:00
henrik.lundin@webrtc.org
dbba1f969f
Packet waiting-time statistics
...
Adding new statistics API to NetEQ, reporting the waiting time
for each frame. The output is raw waiting time for the frames
that have been decoded since the last statistics report (or
maximum 100 frames). The statistics are reset on each query.
Implemented functionality in ACM to query NetEQ for the raw
waiting times, and process it to produce max, average and
median.
Updating common_types.h and VoiceEngine tests to include the
new metrics.
Unit tests are also added for NetEQ and AcmNetEq.
Review URL: http://webrtc-codereview.appspot.com/328011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1251 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-20 15:45:05 +00:00
tina.legrand@webrtc.org
554ae1ad4e
Changes to solve warnings on Mac, issue #178 .
...
Review URL: http://webrtc-codereview.appspot.com/320005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1216 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 10:09:04 +00:00
perkj@webrtc.org
6b1bfd6c5e
Changed webrtc::ACMCodecDB::neteq_decoders_ to a const array.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/304003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1092 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-02 12:48:19 +00:00
henrik.lundin@webrtc.org
524eb48081
Removing deprecated NetEQ APIs
...
Removing WebRtcNetEQ_GetPreferredBufferSize and
WebRtcNetEQ_GetCurrentDelay and all dependent APIs.
Review URL: http://webrtc-codereview.appspot.com/289006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1063 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-30 16:21:22 +00:00
xians@webrtc.org
0dffc6449a
To be able to get webrtc into chrome, we need to reduce the size of the binary and the usage of memory.
...
This patch disbale some codecs which are not considered necessary.
Review URL: http://webrtc-codereview.appspot.com/299001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1062 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-30 15:35:44 +00:00
henrik.lundin@webrtc.org
4257790d2d
NetEQ-related bug in ACM
...
Fixing a bug when creating new NetEQ slave instances in ACM.
The old code called WebRtcNetEQ_GetCurrentDelay() for the
master instance to get a delay value for WebRtcNetEQ_SetExtraDelay().
This is wrong, since WebRtcNetEQ_GetCurrentDelay() reports on the
current total buffer length, while WebRtcNetEQ_SetExtraDelay() is
the extra delay that is desired to in order to sync with video.
The fix includes keeping the extra delay value in a member variable
in the ACMNetEQ class.
Review URL: http://webrtc-codereview.appspot.com/295001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1001 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-23 13:04:05 +00:00
kjellander@webrtc.org
543c3eaa46
Fixing Release compilation errors
...
Review URL: http://webrtc-codereview.appspot.com/267026
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1000 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-23 12:20:35 +00:00
henrik.lundin@webrtc.org
df10de4b27
Removing statistics API from NetEQ
...
Removing WebRtcNetEQ_GetJitterStatistics(),
WebRtcNetEQ_ResetJitterStatistics(), and the associated
struct WebRtcNetEQ_JitterStatistics. The change ripples
through all the way to the VoiceEngine API.
Review URL: http://webrtc-codereview.appspot.com/285002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@998 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-23 09:36:23 +00:00
kjellander@webrtc.org
3f1cb8e546
Restructuring and adding dummy unit test target.
...
Empty test added to get code coverage recorded.
Review URL: http://webrtc-codereview.appspot.com/269018
git-svn-id: http://webrtc.googlecode.com/svn/trunk@967 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 13:56:54 +00:00
kjellander@webrtc.org
cc2ecb3c2e
Restructuring and adding dummy unit test target.
...
Empty test added to get code coverage recorded.
Review URL: http://webrtc-codereview.appspot.com/267019
git-svn-id: http://webrtc.googlecode.com/svn/trunk@966 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 13:48:36 +00:00
kjellander@webrtc.org
b72268e147
Restructuring and adding dummy unit test target.
...
Empty test added to get code coverage recorded.
Review URL: http://webrtc-codereview.appspot.com/280004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@965 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 13:39:15 +00:00
kjellander@webrtc.org
64a897a772
Restructuring and adding dummy unit test target.
...
Empty test added to get code coverage recorded.
Review URL: http://webrtc-codereview.appspot.com/282001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@964 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 13:33:11 +00:00
kjellander@webrtc.org
0403ef419f
Restructuring and adding unit test targets on project level instead of in common_audio.
...
Review URL: http://webrtc-codereview.appspot.com/280001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@959 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-17 08:35:47 +00:00
tina.legrand@webrtc.org
855a77c972
Audio Coding Module: Fixing a bug that prevented the encoder from being re-initialized when changing codec from mono to stereo.
...
Solving issue 130 reported by Niklas.
Reviewer: Turaj
Review URL: http://webrtc-codereview.appspot.com/268007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@921 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-10 08:17:08 +00:00
kma@webrtc.org
9b813510eb
Changes for building audio coding in anroid. Only makefiles are touched.
...
Review URL: http://webrtc-codereview.appspot.com/266004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@899 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-07 23:30:01 +00:00
henrike@webrtc.org
e2a34f8275
Removes the API for setting RX VAD since the RX vad should always be on anyways.
...
Review URL: http://webrtc-codereview.appspot.com/264001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@897 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-07 21:33:24 +00:00
tina.legrand@webrtc.org
2475a1953a
Committing a file that was part of CL 175002, but for wome reason weren't uploaded correctly.
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@882 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-03 17:54:27 +00:00
tina.legrand@webrtc.org
fb389e3b02
This CL is divided in several patches, to make review easier.
...
Patch Set 1: Removing blanks at end of lines.
Patch Set 2: Removing tabs.
Patch Set 3: Fixing include-guards.
Patch Set 4-7: Formatting files in the list.
Patch Set 8: Formatting CNG.
Patch Set 9:
* Fixing comments from code review
* Fixing formating in acm_dtmf_playout.cc
* Started fixing formating of acm_g7221.cc. More work needed, so don't spend too much time reviewing.
* Refactored constructor of ACMGenericCodec. Rest of file still to be fixed.
* Fixing break; after return ...; in several files.
Patch Set 10:
* Chaning from reintepret_cast to static_cast in three files, acm_amr.cc, acm_cng.cc and acm_g722.cc
NOTE! Not all files have the right format. That work will continue in separate CLs.
Review URL: http://webrtc-codereview.appspot.com/175002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@881 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-11-03 17:20:10 +00:00
tina.legrand@webrtc.org
8b1f621e3a
Updated gypi for tests to work on osx.
...
Review URL: http://webrtc-codereview.appspot.com/250002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@830 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-10-28 08:57:34 +00:00
xians@google.com
d3185fe219
refactor the gyp file to gypi file.
...
Basically, the gypi file is a copy of gyp file, but has some difference on the
path of the dependencies.
Review URL: http://webrtc-codereview.appspot.com/137020
git-svn-id: http://webrtc.googlecode.com/svn/trunk@581 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-12 12:24:39 +00:00
tina.legrand@webrtc.org
31c6b60456
Adding calls to Version functions for external codecs.
...
Also clarified in comments where to put interface files for external codecs.
Review URL: http://webrtc-codereview.appspot.com/135017
git-svn-id: http://webrtc.googlecode.com/svn/trunk@579 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-12 07:18:37 +00:00
zakkhoyt@google.com
c6e8b72c83
Removing qualifiers on include path
...
Review URL: http://webrtc-codereview.appspot.com/132014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@576 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-09 17:41:13 +00:00
zakkhoyt@google.com
fb298d3783
Modified path on speex lib
...
Review URL: http://webrtc-codereview.appspot.com/137018
git-svn-id: http://webrtc.googlecode.com/svn/trunk@524 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 22:06:49 +00:00
turajs@google.com
d7a41774ce
header included twice.
...
Review URL: http://webrtc-codereview.appspot.com/139013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@522 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-02 20:52:47 +00:00
tina.legrand@webrtc.org
84519ec0a2
Fixing some inconsistencies in WebRTC audio coding module. I've added setup information for all codecs which are not part of WebRTC, but possible to hook in.
...
Please help me review.
Henrik: review neteq_defines.h
Turaj: review all files, but the one Henrik reviews.
Zakk: FYI only.
Review URL: http://webrtc-codereview.appspot.com/138004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@505 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-09-01 07:47:31 +00:00
turajs@google.com
eaf3185105
Take care of unused variable.
...
Review URL: http://webrtc-codereview.appspot.com/137013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@499 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-31 21:27:53 +00:00
tina.legrand@webrtc.org
81fd2bfbba
New ACM codec database, created at compile time.
...
Review URL: http://webrtc-codereview.appspot.com/127002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@480 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-29 11:18:44 +00:00
turajs@google.com
5cc9c68e8d
Fixing a warning discovered while compiling with clang.
...
Review URL: http://webrtc-codereview.appspot.com/120003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@441 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-24 21:20:33 +00:00
andrew@webrtc.org
ceb148ce59
Fix compile warnings in Release configuration.
...
Review URL: http://webrtc-codereview.appspot.com/119003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@424 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-23 17:53:54 +00:00
tina.legrand@webrtc.org
2e09692006
This CL fixes the warnings when building acm or acm test.
...
Review URL: http://webrtc-codereview.appspot.com/109013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@397 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-18 06:20:30 +00:00
leozwang@google.com
79835d1bd3
Clean up Android.mk
...
Review URL: http://webrtc-codereview.appspot.com/92014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@315 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-05 21:01:02 +00:00
xians@google.com
88f94f985e
exclude the ACM test target from building with chromium.
...
Review URL: http://webrtc-codereview.appspot.com/95011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@312 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-08-05 16:14:51 +00:00
niklase@google.com
470e71d364
git-svn-id: http://webrtc.googlecode.com/svn/trunk@156 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-07-07 08:21:25 +00:00