marpan@webrtc.org
307c1ff20c
Fix for issue #254 : windows crash of test_fec.
...
Review URL: https://webrtc-codereview.appspot.com/379010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1600 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-04 02:45:22 +00:00
stefan@webrtc.org
07b45a5dc4
Added API for getting the send-side estimated bandwidth.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/372006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1591 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-02 08:37:48 +00:00
andrew@webrtc.org
7fe219f681
Add some additional checks for corrupt payload.
...
Investigation with corrupt payloads revealed a few places we could
be using stronger checks. These are not foolproof by any means, but
I figure the earlier we catch this the better.
BUG=242
TEST=loopback call with a hacked ViE to insert corrupt payloads, and vie_auto_test without the hacks.
Review URL: https://webrtc-codereview.appspot.com/369015
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1585 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-01 02:40:37 +00:00
marpan@webrtc.org
cdba1a836b
test_fec: Reduce execution time of test, and use testsupport/fileutils.h for path of randomSeedLog file.
...
Review URL: https://webrtc-codereview.appspot.com/373016
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1576 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-31 00:36:14 +00:00
pwestin@webrtc.org
5dad00be52
Coverty fix: FEC unintended signed extension and resource leaks.
...
Review URL: https://webrtc-codereview.appspot.com/368010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1569 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 13:05:29 +00:00
stefan@webrtc.org
2fd1e1e40d
Add unittests for ReceiverFec.
...
Also added mock for RtpReceiverVideo and did appropriate changes to
allow for mocking.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/367017
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1566 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-30 09:03:37 +00:00
pwestin@webrtc.org
04cf69a714
Coverty: cleanup CheckCSRC.
...
Review URL: https://webrtc-codereview.appspot.com/369014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1564 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-27 13:47:19 +00:00
phoglund@webrtc.org
d1a860b415
Fixed GCC 4.6 errors (mostly 'unused variable' errors and incorrect usage of EXPECT_EQ with booleans.
...
Fixed remaining compilation errors in release, etc.
Fixed errors from GCC 4.6 compilation.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/366008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1554 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-26 14:49:28 +00:00
henrike@webrtc.org
567b99be5f
Coverity report: fixes an issue where the returnvalue of a function is not checked.
...
Review URL: https://webrtc-codereview.appspot.com/347013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1542 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 23:43:54 +00:00
pwestin@webrtc.org
f6bb77a6f0
Cleaning up all use of RTP_PAYLOAD_NAME_SIZE and RTCP_CNAME_SIZE also fixed the char handing in trace.
...
Review URL: https://webrtc-codereview.appspot.com/358001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1535 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 17:16:59 +00:00
pwestin@webrtc.org
b73c3d1f5d
Bugfix android build.
...
Review URL: https://webrtc-codereview.appspot.com/374003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1532 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 15:25:30 +00:00
pwestin@webrtc.org
28a5cb29ab
Bugfix receive side only packet loss estimate with NACK.
...
Review URL: https://webrtc-codereview.appspot.com/373006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1529 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 14:34:58 +00:00
punyabrata@webrtc.org
6da8eeb946
Removing an assert for a case that can occur
...
when corrupt packets are injected into voice engine.
Review URL: https://webrtc-codereview.appspot.com/373004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1518 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 00:48:36 +00:00
leozwang@webrtc.org
376be6c904
Fix compilation error
...
Review URL: https://webrtc-codereview.appspot.com/358005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1508 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-23 16:46:38 +00:00
pwestin@webrtc.org
b30f0edce6
Bugfix buffer usage out of scope.
...
Review URL: https://webrtc-codereview.appspot.com/372001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1507 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-23 16:23:31 +00:00
pwestin@webrtc.org
56ee5d5d98
Bugfix 32 bit linux.
...
Review URL: https://webrtc-codereview.appspot.com/353010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1490 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-20 07:47:38 +00:00
pwestin@webrtc.org
95cf47932d
Remove list wrapper from FEC code.
...
Review URL: https://webrtc-codereview.appspot.com/350013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1489 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-20 06:59:06 +00:00
pwestin@webrtc.org
0074187436
Removed map_wrapper from rtp_sender
...
Review URL: https://webrtc-codereview.appspot.com/343014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1478 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 15:56:10 +00:00
pwestin@webrtc.org
3c9be1bc4d
Removed list wrapper fromr overuse detector.
...
Review URL: https://webrtc-codereview.appspot.com/353004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1477 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 15:55:54 +00:00
pwestin@webrtc.org
d4adc5b26f
removed unused include from remote rate control.
...
Review URL: https://webrtc-codereview.appspot.com/350015
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1476 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 15:55:30 +00:00
pwestin@webrtc.org
af6f15c1bf
Changed RTP reveivers to use stl map and list.
...
Review URL: https://webrtc-codereview.appspot.com/349010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1475 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 15:53:59 +00:00
pwestin@webrtc.org
38f4816737
Removed unused include from rtp sender audio.
...
Review URL: https://webrtc-codereview.appspot.com/348012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1474 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 15:53:33 +00:00
pwestin@webrtc.org
26f8d9c7f3
Removed list and map wrappers, for RTCP handling.
...
Review URL: https://webrtc-codereview.appspot.com/349011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1473 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 15:53:09 +00:00
pwestin@webrtc.org
1da2327473
Changing header extension to use stl map.
...
Review URL: https://webrtc-codereview.appspot.com/350014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1469 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 12:58:53 +00:00
andrew@webrtc.org
267ca3162b
Fix comparison-always-true warning with -Wextra.
...
TEST=build on Linux with -Wextra.
Review URL: https://webrtc-codereview.appspot.com/353005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1456 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-18 19:41:40 +00:00
henrik.lundin@webrtc.org
4407edc314
Bugfix in VP8 packetizer
...
Handle the case with no small partitions in Vp8PartitionAggregator.
Also added a new unit test for the packetizer to verify that the
bug is fixed.
TEST=RtpFormatVp8Test.TestAggregateModeTwoLargePartitions
TBR=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/348011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1451 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-18 10:01:03 +00:00
henrik.lundin@webrtc.org
7f2c2a5db2
Adding optimized aggrgation to VP8 packetizer
...
This change introduces a new algorithm for aggregating small
partitions into packets. The algorithm is based on a tree-search
to find an optimal allocation of the packets, such that the
difference in size between packets is minimized.
The new method is used when partition aggregation is allowed and
balanced packets are requested. Otherwise, the old method is used.
The new method is implemented using the new classes
Vp8PartitionAggregator and PartitionTreeNode. Both classes have
dedicated unit tests.
In order to facilitate the new algorithm, the packetizer was
redesigned to calculate all packet sizes when the first packet is
extracted. The information about all packets is stored in a packet
queue structure, which is then popped for each packet extracted.
Finally, a bug in the old packetizer algorithm was fixed. The bug
caused a +/-1 error in packet sizes when balanced packets were
produced. The unit test were updated accordingly.
TEST=rtp_rtcp_unittests: PartitionTreeNode.* Vp8PartitionAggregator.* RtpFormatVp8Test.*
Review URL: https://webrtc-codereview.appspot.com/345008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1447 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-18 08:21:15 +00:00
pwestin@webrtc.org
5621057956
Removing unused code.
...
Review URL: https://webrtc-codereview.appspot.com/349008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1442 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-17 12:45:47 +00:00
pwestin@webrtc.org
df9bd9bdbd
Removed dead code.
...
Review URL: https://webrtc-codereview.appspot.com/352010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1437 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-17 11:42:02 +00:00
pwestin@webrtc.org
aafa5a331c
Coverty report: Unititialized members
...
Review URL: http://webrtc-codereview.appspot.com/349007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1436 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-17 07:07:37 +00:00
asapersson@webrtc.org
43b8fc5c0d
Review URL: http://webrtc-codereview.appspot.com/345011
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1435 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-16 13:49:04 +00:00
asapersson@webrtc.org
869ce2d441
Review URL: http://webrtc-codereview.appspot.com/353002
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1432 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-16 11:58:36 +00:00
asapersson@webrtc.org
0b3c35a258
Review URL: http://webrtc-codereview.appspot.com/321011
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1431 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-16 11:06:31 +00:00
henrika@webrtc.org
f75901fa4c
Resolves CID 10540: Copy into fixed size buffer (STRING_OVERFLOW).
...
You might overrun the 32 byte fixed-size string "receiveCodec.plname" by copying "payloadName" without checking the length.
Note: This defect has an elevated risk because the source argument is a parameter of the current function.
Review URL: http://webrtc-codereview.appspot.com/352009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1428 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-16 08:45:42 +00:00
mflodman@webrtc.org
117c119501
Only update REMB value if there is a calid bitrate estimate.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/352005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1421 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-13 08:52:58 +00:00
stefan@webrtc.org
c8277db7c8
Fix selective retransmissions after corrupt merge in r1373.
...
BUG=228
TEST=
Review URL: http://webrtc-codereview.appspot.com/345006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1414 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 15:38:50 +00:00
mflodman@webrtc.org
80d60420ff
RTCPSender::_bitrate_observer not initialized.
...
BUG=227
TEST=Valgrind
Review URL: http://webrtc-codereview.appspot.com/352004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1410 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 14:28:53 +00:00
kjellander@webrtc.org
7f3c724e12
Renaming 47 files from .cpp to .cc
...
In addition to our naming guidelines, this will cause these files to get parsed by Sonar, and to make searching/grepping the source using file extensions easier in the future.
BUG=
TEST=Compiling on Linux.
Review URL: http://webrtc-codereview.appspot.com/348005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1405 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 10:23:41 +00:00
kjellander@webrtc.org
93546f8ed6
Removing unused file
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/347010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1404 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 10:00:33 +00:00
niklas.enbom@webrtc.org
553657b2f8
See http://codereview.chromium.org/9188022/ for details
...
Review URL: http://webrtc-codereview.appspot.com/347009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1403 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-12 08:49:34 +00:00
mflodman@webrtc.org
04c18cb37a
Update all child modules of with received bandwidth estimate.
...
BUG=224
Review URL: http://webrtc-codereview.appspot.com/347007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1391 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 14:18:33 +00:00
perkj@webrtc.org
ce5990cb0b
Fix defect http://code.google.com/p/webrtc/issues/detail?id=222
...
"ViE GetSentRTCPStatistics fails on a sending channel if it don't receive rtp video packets.
BUG=222
TEST= tested in loopback. No new test added yet.
Review URL: http://webrtc-codereview.appspot.com/343003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1387 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-11 13:00:08 +00:00
stefan@webrtc.org
c5b73e3974
Further cleanup of OverUseDetector. Removed member no longer used.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/344007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1377 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-10 16:42:09 +00:00
pwestin@webrtc.org
a1783598a7
Bugfix for clang.
...
Review URL: http://webrtc-codereview.appspot.com/351001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1375 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-10 15:33:40 +00:00
pwestin@webrtc.org
5d35ceb34a
Bugfix array length in test.
...
Review URL: http://webrtc-codereview.appspot.com/343007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1374 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-10 15:06:09 +00:00
pwestin@webrtc.org
8281e7dd4a
Added RTX to ViE.
...
Review URL: http://webrtc-codereview.appspot.com/336001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1373 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-10 14:09:18 +00:00
asapersson@webrtc.org
c5a1cee73e
Review URL: http://webrtc-codereview.appspot.com/348004
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1367 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-10 12:54:44 +00:00
stefan@webrtc.org
727e1611ac
Removes debug file writing.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/343006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1365 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-10 11:45:47 +00:00
stefan@webrtc.org
e21a8cf4d4
Fix issue 211: Make sure we always generate at least one FEC packet per frame if we need protection.
...
BUG=211
TEST=
Review URL: http://webrtc-codereview.appspot.com/348002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1363 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-10 08:37:33 +00:00
pwestin@webrtc.org
12d97f6637
Made send pad data generic (audio and video)
...
Review URL: http://webrtc-codereview.appspot.com/343001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1346 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-05 10:54:44 +00:00