leozwang@webrtc.org
2fc6e388c0
Check return value of fwrite. [Video Module]
...
Description:
On ChromeOS/ARM, compiler enforces to check return result of a function.
Currently, we don't check return result of fwrite, it causes building errors.
The following files need to patch. The patch should be similar, before I patch all
of them, I will start with 3 files, once we agree upon the solution, we will expand
it to all of them.
The question is should we do
1. if (error) { return -1;}
or
2. if (error) { /*ignor the error*/ }
I took "return -1" in this patch, but I'm OK with either. Please let me know your
thoughts and I will upload a new patch.
Review URL: https://webrtc-codereview.appspot.com/583010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2315 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-29 17:33:13 +00:00
stefan@webrtc.org
5abab0b1b5
Revert 2311 - Disable error concealment.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/609004
TBR=stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/604006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2312 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-29 09:04:40 +00:00
stefan@webrtc.org
3348b2990b
Disable error concealment.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/609004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2311 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-29 08:44:00 +00:00
stefan@webrtc.org
42e78ac087
Disable normal_async_test and rename tests to vp8_integrationtests.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/598004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2294 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-24 14:36:34 +00:00
mflodman@webrtc.org
6af9594d71
Added gyp variable to include/exclude all tests.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/597004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2292 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-24 13:23:35 +00:00
stefan@webrtc.org
78d8d99180
Fixes the vp8_test on Linux.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/579015
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2277 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-23 14:18:56 +00:00
stefan@webrtc.org
1bca6d2437
Fixes coverity warnings.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/566014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2262 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-21 07:42:12 +00:00
kma@webrtc.org
f1ccdb9fb5
Aligned video buffer to 32 bytes boundary, when using vpx_img_alloc() in vp8.
...
Review URL: https://webrtc-codereview.appspot.com/570009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2242 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-15 18:16:46 +00:00
marpan@webrtc.org
cf2cd7e4c4
Enable VP8 deblocker.
...
Review URL: https://webrtc-codereview.appspot.com/569011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2237 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-14 16:50:36 +00:00
kma@webrtc.org
4e7840d943
Revert 2233 - Aligned video buffer to 32 bytes boundary, when using vpx_img_alloc() in vp8.
...
M vp8.cc
TBR=kma@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/579013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2234 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-11 18:16:35 +00:00
kma@webrtc.org
6d47c08e14
Aligned video buffer to 32 bytes boundary, when using vpx_img_alloc() in vp8.
...
M vp8.cc
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2233 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-11 17:29:59 +00:00
pwestin@webrtc.org
2853dde520
Refactor the internal API to the rtp/rtcp module.
...
Combination of previous CLs in revisions 2211, 2212, 2214, 2215, 2216.
Review URL: https://webrtc-codereview.appspot.com/570008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2231 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-11 11:08:54 +00:00
turaj@webrtc.org
3c383abd27
Revert 2211 - Refactor the internal API to the rtp/rtcp module.
...
Review URL: https://webrtc-codereview.appspot.com/568004
A series of CL:s by Patrik W. is breaking the auto-test. It started with CL 2211, but the later CL:s seems dependent on another. So I decided to go in reverse order and revert all of them.
TBR=pwestin@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/563011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2226 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 23:01:04 +00:00
leozwang@webrtc.org
f29d3fa177
Fix vp8 complexity parameter on android
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/575007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2217 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 18:12:01 +00:00
pwestin@webrtc.org
0774838f3d
Refactor the internal API to the rtp/rtcp module.
...
Review URL: https://webrtc-codereview.appspot.com/568004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2211 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-10 12:33:50 +00:00
pwestin@webrtc.org
7415f371ac
Revert VP8 Deblocker.
...
Review URL: https://webrtc-codereview.appspot.com/563007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2191 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 09:06:31 +00:00
pwestin@webrtc.org
5019c9583c
Enable VP8 deblocker.
...
Review URL: https://webrtc-codereview.appspot.com/578004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2190 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-05-08 08:40:28 +00:00
pwestin@webrtc.org
ddab60be56
Wire up pading.
...
Review URL: https://webrtc-codereview.appspot.com/509002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2094 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 14:52:15 +00:00
pwestin@webrtc.org
fcbbe1f341
Removed unused callback code from video coding test.
...
Review URL: https://webrtc-codereview.appspot.com/504003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2086 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-23 08:33:18 +00:00
marpan@webrtc.org
88ad06b999
VCM: Added condition(s) for setting FEC protection factor to zero at low bitrates.
...
Review URL: https://webrtc-codereview.appspot.com/494001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2084 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-20 16:05:24 +00:00
pwestin@webrtc.org
ce33035dee
Cleanup encode call.
...
Review URL: https://webrtc-codereview.appspot.com/491003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2011 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-12 06:59:14 +00:00
stefan@webrtc.org
c35f5ced92
Enable multi-frame FEC by default for temporal layers <= 2. For two temporal layers we currently only protect the base layer.
...
This also introduces zero column insertion into packet masks when some sequence numbers deliberately haven't been given to the FEC generator.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/477001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2005 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-11 07:42:25 +00:00
pwestin@webrtc.org
ae19720982
Fixed assert strings where string literals are used as booleans.
...
Review URL: https://webrtc-codereview.appspot.com/473002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1986 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-04-04 14:43:54 +00:00
stefan@webrtc.org
af5ffd5bb9
Fixes for coverity warnings.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/461001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1933 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-23 16:01:15 +00:00
stefan@webrtc.org
c8e4886774
Upgrade libvpx to 6b66c01 and enabling temporal denoising.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/448006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1921 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-21 16:52:03 +00:00
marpan@webrtc.org
6503ecdc39
Fix to windows test from commit 1914.
...
Review URL: https://webrtc-codereview.appspot.com/455002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1917 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-21 00:18:13 +00:00
marpan@webrtc.org
3fe3252cb3
Fix to windows build from commit 1914.
...
Review URL: https://webrtc-codereview.appspot.com/456002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1916 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-20 22:13:24 +00:00
stefan@webrtc.org
e0d6fa4c66
Adding classes for handling multi-frame FEC.
...
The FEC behavior is unchanged with this commit, we will still be
limited to FEC over one frame for now.
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/450006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1915 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-20 22:10:56 +00:00
marpan@webrtc.org
e22d81ce4d
Updates to resolution adpatation:
...
-moved calculation of selected frame size & frame rate to qm_select class.
-various updates to qm_select class (switch to 1/2 from 2 stages of 3/4,
include native frame rate for going up temporal, favor spatial action for temporal layers,..).
-updates to unittest.
Review URL: https://webrtc-codereview.appspot.com/450008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1914 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-20 18:21:53 +00:00
stefan@webrtc.org
b9c50b68bf
Revert commit 1908.
...
Review URL: https://webrtc-codereview.appspot.com/452009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1909 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-17 00:56:36 +00:00
stefan@webrtc.org
fb5944edf9
Upgrade libvpx to 6b66c01 and enabling temporal denoising.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/448006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1908 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-17 00:15:13 +00:00
marpan@webrtc.org
accf607b3e
Updates for resolution adaptation.
...
1) added support for two additional modes:
-3/4 spatial down-sampling
-2/3 frame rate reduction
2) updated unittest and added a few more tests
3) some code refactoring
Review URL: https://webrtc-codereview.appspot.com/429005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1854 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-07 17:16:10 +00:00
leozwang@webrtc.org
db2de5b49f
Fix building errors on android
...
TBR=Tina
BUG=
TEST=build on android
Review URL: https://webrtc-codereview.appspot.com/430001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1840 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-05 19:53:24 +00:00
marpan@webrtc.org
26762e3e40
Allow for spatial-downsampling without reinitializaing encoder. Change of frame
...
size will automatically trigger new key frame in codec. This feature is set off
in video engine until we upgrade to a newer version of libvpx.
Review URL: https://webrtc-codereview.appspot.com/427003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1827 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-03-02 16:48:36 +00:00
marpan@webrtc.org
4788bf4256
Fix to warnings on windows.
...
Review URL: https://webrtc-codereview.appspot.com/415004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1792 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-29 01:11:39 +00:00
marpan@webrtc.org
9d76b4ea54
Updates for resolution adaptation:
...
1) code cleanup and some updates to selection logic for qm_select.
2) added unit test for the QmResolution class.
3) update codec frame size and reset/update frame rate in media-opt:
4) removed unused motion vector metrics and some related code of content metrics processing.
Review URL: https://webrtc-codereview.appspot.com/405008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1791 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-28 23:39:31 +00:00
stefan@webrtc.org
4ce0ba00de
Fix issue 310.
...
BUG=310
TEST=session_info_unittest.cc
Review URL: https://webrtc-codereview.appspot.com/404004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1782 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-28 12:09:09 +00:00
stefan@webrtc.org
1bb1da4c30
Enable MFQE if we are recieving temporal layers.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/411002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1769 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-27 13:52:34 +00:00
xians@webrtc.org
843c8c78ff
Remove the deprecated kTraceModuleCall trace from video modules.
...
Review URL: https://webrtc-codereview.appspot.com/391015
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1725 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-20 08:45:02 +00:00
marpan@webrtc.org
bd5648f2db
Reverting 1718: failed linux video test.
...
TBR=stefan, andrew, marpan.
Review URL: https://webrtc-codereview.appspot.com/392018
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1719 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-17 23:16:58 +00:00
marpan@webrtc.org
883e716304
Removed unused motion vector metrics from VideoContentMetrics;
...
also removed other related unused variables and code.
Reset frame rate estimate in mediaOpt when frame rate reduction is decided.
Update content_metrics with frame rate and qm_resolution with frame size.
Review URL: https://webrtc-codereview.appspot.com/395007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1718 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-17 18:35:23 +00:00
stefan@webrtc.org
439be29445
Add APIs for getting receive-side estimated bandwidth and codec target rate.
...
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/391012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1704 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-16 14:45:37 +00:00
marpan@webrtc.org
79a99de8e4
Reverting 1680: valgrind memory leak reported.
...
TBR=marpan
Review URL: https://webrtc-codereview.appspot.com/392011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1686 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-14 22:37:10 +00:00
marpan@webrtc.org
4e34dcbd62
Allow for spatial-downsampling without reinitializaing encoder. Change of frame size will automatically trigger new key frame in codec. This feature is set off in vie_encoder until we upgrade to the new libvpx.
...
Also reset frame rate estimate in mediaOpt when frame rate reduction is decided.
Review URL: https://webrtc-codereview.appspot.com/390006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1680 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-14 17:26:24 +00:00
pwestin@webrtc.org
c76c096c19
Bugfix issue 273, workaround for compiler issue.
...
Review URL: https://webrtc-codereview.appspot.com/392005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1675 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-13 09:56:57 +00:00
pwestin@webrtc.org
52fd98d876
Removing encoder reset. Function did not make sence.
...
Review URL: https://webrtc-codereview.appspot.com/391005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1674 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-13 09:03:53 +00:00
pwestin@webrtc.org
5e954814a8
Clanup handling of key frame requests and FIR.
...
Review URL: https://webrtc-codereview.appspot.com/387004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1667 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-10 12:13:12 +00:00
kjellander@webrtc.org
cf6a295b13
Making video codecs test framework integration test execute in a reproducable fashion.
...
Fixed reproducable random behavior in packet_manipulator.h.
Test is now fully reproducable (runs on only one core) so much tighter limits are now set for the SSIM/PSNR values for the encoding/decoding (verified on all platforms)
BUG=
TEST=out/Debug/video_codecs_test_framework_integrationtests in Debug+Release on Linux, Mac, Windows and in Linux Valgrind.
Review URL: https://webrtc-codereview.appspot.com/381005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1649 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-09 09:01:51 +00:00
mflodman@webrtc.org
d2940f71e4
VCM::JB critsect fix.
...
Review URL: https://webrtc-codereview.appspot.com/390004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1639 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 12:42:56 +00:00
stefan@webrtc.org
23307f7c4b
Remove frame_list.cc from Andorid.mk.
...
TBR=mflodman
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/390003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1638 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-02-08 10:39:13 +00:00