By using the --extra-gn-args flag, it is now possible to
specify additional GN arguments for the build. This is needed
in order to pass a non-default Goma directory (needed for the bots).
Example use: --extra-gn-args goma_dir=\"/path/to/goma\"
You can also pass multiple args (separated by spaces).
BUG=chromium:684387
NOTRY=True
TESTED=Did a local successful run.
Review-Url: https://codereview.webrtc.org/2670743004
Cr-Commit-Position: refs/heads/master@{#16458}
Adds ignore for all lint errors in Chromium code. Changes minimum SDK for
instrumentation tests to 16 from 14. Adds TargetApi annotations.
BUG=webrtc:6597
Review-Url: https://codereview.webrtc.org/2670473004
Cr-Commit-Position: refs/heads/master@{#16412}
We are moving the whole content of "webrtc/build" to new
locations (see crbug.com/611808 for further information).
The new location for the "webrtc/build/android" stuff is
"tools-webrtc/android".
BUG=webrtc:7030
Review-Url: https://codereview.webrtc.org/2647343006
Cr-Commit-Position: refs/heads/master@{#16269}
We have to move the content of the 'webrtc/build/' directory up of one level (see crbug.com/611808 for further details).
To avoid a collision with the DEPSed build/ at the top level we are moving all the content of 'webrtc/build/' to different locations (see webrtc:7030 for the suggested locations).
BUG=webrtc:7030
NOTRY=True
Review-Url: https://codereview.webrtc.org/2651913002
Cr-Commit-Position: refs/heads/master@{#16259}
Before promoting it to the main waterfall I thought it made
sense to ensure it works for a phone that actually is 32-bit
(iPhone 6s isn't). It also makes more sense to run the older
iOS version (9) on the older phone.
BUG=chromium:677385
TBR=ehmaldonado@webrtc.org
Review-Url: https://codereview.webrtc.org/2604203002 .
Cr-Commit-Position: refs/heads/master@{#15837}
This changes the way we pull in dependencies WebRTC shares with
Chromium. The base, build, tools and third_party directories from
Chromium are now synced as Git subtree mirrors in the DEPS file.
All symlinks to directories that were previously created by the
setup_links.py are replaced with proper DEPS entries.
One downside with this solution is that we get a lot of directories
in tools/ and third_party/ that we currently don't use. Going forward
it might be possible to improve this but as long as the BUILD.gn files
are stored in the Chromium repo rather at each dependency's repo,
this will be very cumbersome.
The DEPS file will be kept auto-rolled by the script in
https://chromium.googlesource.com/external/webrtc/+/master/tools-webrtc/autoroller/roll_deps.py
which is periodically executed by a bot.
This change brings back the Google Play Services download for Android,
which displays a license confirmation dialog to the user at the first sync.
By running it as a proper hook instead of inside sync_chromium.py, the
problems with that the interactive prompt gets hidden/stuck should be
fixed (now the behavior is identical to Chromium).
Some measurements on the size savings for a clean, newly created checkout:
Linux: 15GB -> 6.4GB (-8.6GB)
Linux (with Android): 25 GB -> 16 GB (-9GB). 8.4GB of this is Android SDK+NDK.
Mac (with iOS): 14 GB -> 5.6GB (-8.4GB)
Note that for all of the above, 1GB is occupied by the resources/ dir.
BUG=webrtc:5006, webrtc:5578
NOTRY=True
R=agable@chromium.org, henrika@webrtc.org, iannucci@chromium.org
Review-Url: https://codereview.webrtc.org/1414343008 .
Cr-Commit-Position: refs/heads/master@{#15754}
In addition to moving tools/mb -> tools-webrtc/mb, also
move webrtc/build/mb_config.pyl into tools-webrtc/mb
to match the default location better.
Remove Chromium-specific check for 'mb validate' that failed
due to doing this (we never cleaned that when we forked the code).
BUG=webrtc:5006
TBR=ehmaldonado@webrtc.org
NOTRY=True
TESTED=Manually ran:
tools-webrtc/mb/mb.py gen -m client.webrtc -b 'iOS64 Release' --config-file tools-webrtc/mb/mb_config.pyl //out/Release-iphoneos
tools-webrtc/mb/mb.py gen -m client.webrtc -b 'Mac64 Release' --config-file tools-webrtc/mb/mb_config.pyl //out/Release-mac
Review-Url: https://codereview.webrtc.org/2585743002 .
Cr-Commit-Position: refs/heads/master@{#15664}
The WebRTC valgrind wrapper scripts needs to be moved in order to
unlock us from depending on a Chromium checkout.
BUG=webrtc:5006
TBR=ehmaldonado@webrtc.org
NOTRY=True
Review-Url: https://codereview.webrtc.org/2578093002
Cr-Commit-Position: refs/heads/master@{#15662}
In order to get rid of the Chromium checkout for WebRTC, the plan is to
instead of cloning all of Chromium, only clone the build, third_party and
tools sub-directories. In order to do so, we must first move all things
checked into the WebRTC tools/ directory somewhere else.
Due to many hardcoded assumptions of tools/ existing in Chrome, this
is only manageble solution to the problem.
This first step only moves stuff not used by the build system or bots,
and deletes a few unused directories.
BUG=webrtc:5006
R=henrika@webrtc.org
Review-Url: https://codereview.webrtc.org/2584433002 .
Cr-Commit-Position: refs/heads/master@{#15622}
