61 Commits

Author SHA1 Message Date
sergeyu@chromium.org
23516638fa Move WEBRTC_THREAD_RR and WEBRTC_CLOCK_TYPE_REALTIME to system_wrappers.gypi .
WEBRTC_THREAD_RR and WEBRTC_CLOCK_TYPE_REALTIME are used only in code compiled
in system_wrappers, so they don't need to be in common.gypi.

R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1368005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3926 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-30 22:53:51 +00:00
wu@webrtc.org
e44a064915 Make win_support_condition_variables_primitive global to aligned with |library|
so that once we set it to true it will remain.
Review URL: https://webrtc-codereview.appspot.com/1319006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3852 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-15 18:06:42 +00:00
stefan@webrtc.org
b8e7f4cc97 Change capture interface to use NTP capture time.
Move NTP functionality to Clock.

BUG=1563
TEST=trybots and vie_auto_test --automated

Review URL: https://webrtc-codereview.appspot.com/1313005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3842 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-12 11:56:23 +00:00
stefan@webrtc.org
7da3459b2a Revert "With these changes we will assume that the capture time of a frame is based on NTP time. This makes the interface of video engine more well defined and makes it easier and cleaner to handle user provided capture timestamps."
This reverts commit 4954b3650192d78037714138a5c519ef08f2670e.
Reverts r3799

TBR=pbos@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1308004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3802 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-09 14:56:29 +00:00
stefan@webrtc.org
afcc6101d0 With these changes we will assume that the capture time of a frame is based on NTP time. This makes the interface of video engine more well defined and makes it easier and cleaner to handle user provided capture timestamps.
We should consider making the same change to the render timestamps generated at the receiver.

BUG=1563

Review URL: https://webrtc-codereview.appspot.com/1283005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3799 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-09 13:37:40 +00:00
hta@webrtc.org
a701c0ed03 Fixing the flakiness of ThreadWakesTwice.
TESTED=ran the test 10.000 times with machine load.
BUG=1270

Review URL: https://webrtc-codereview.appspot.com/1303004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3795 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-09 12:36:28 +00:00
pbos@webrtc.org
046deb9b20 WebRtc_Word32 -> int32_t in system_wrappers
BUG=314

Review URL: https://webrtc-codereview.appspot.com/1301004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3791 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-09 09:06:11 +00:00
wu@webrtc.org
123b618f48 Fix a crash issue on WinXP where LoadLibrary(TEXT("Kernel32.dll")) may fail.
BUG=crbug.com/226301
TBR=henrike
Review URL: https://webrtc-codereview.appspot.com/1293004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3772 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-06 04:13:51 +00:00
henrika@webrtc.org
19da719a5f Resolves TSan v2 reports data races in voe_auto_test.
--- Note that I will add more fixes to this CL ---

BUG=1590

Review URL: https://webrtc-codereview.appspot.com/1286005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3770 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-05 14:34:57 +00:00
henrike@webrtc.org
626c663115 Fixes build break in previous cl (https://code.google.com/p/webrtc/source/detail?r=3739) found by Android bots.
TBR=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1269005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3740 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-28 16:31:51 +00:00
henrike@webrtc.org
93bea51517 Removed CPU APIs from VoEHardware. Code is now only used by test applications.
Recommitting https://code.google.com/p/webrtc/source/detail?r=3736 after fixing build break.

BUG=8404677
TBR=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1269004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3739 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-28 15:58:49 +00:00
wu@webrtc.org
80fccc29de Revert 3736 "Removed CPU APIs from VoEHardware. Code is now only..."
> Removed CPU APIs from VoEHardware. Code is now only used by test applications.
> 
> BUG=8404677
> 
> Review URL: https://webrtc-codereview.appspot.com/1238004

TBR=henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1267004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3737 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-27 23:38:21 +00:00
henrike@webrtc.org
4c138e8fca Removed CPU APIs from VoEHardware. Code is now only used by test applications.
BUG=8404677

Review URL: https://webrtc-codereview.appspot.com/1238004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3736 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-27 21:23:42 +00:00
henrike@webrtc.org
686001dd96 Split condition_variable_win.cc into native (for Vista and newer OS versions) and generic implementation (based on events).
Note that this means that there is no new code. The code has been taken directly from condition_variable_win.cc/h compensating minimally to be able to split up the two code paths.

Tested by:
1) Disabling native implementation and send to try bots.
2) Only return native implementation (i.e. if native implementation returns NULL there will be a crash when using the condition variable) and send to try bots.
3) The final cl sent to trybots.
All tests pass.

The changes are due to static analyzer code complaints.

BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/1191004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3728 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-26 14:16:05 +00:00
andrew@webrtc.org
c1ffd337f1 Add trace printouts to all unit tests.
Unfortunately, this requires splitting system_wrappers_unittests out of system_wrappers.gyp to avoid a cyclic dependency.

TESTED=ran a few unit tests and observed printouts

Review URL: https://webrtc-codereview.appspot.com/1221006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3711 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-22 17:13:23 +00:00
hta@webrtc.org
2cec0b1670 Cleanup nanosleep -> SleepMs
Remove some leftover stuff

BUG=603
TEST=

Review URL: https://webrtc-codereview.appspot.com/672005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3700 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-21 14:02:29 +00:00
wjia@webrtc.org
95a8ddd272 Android: rename android_build_type gyp variable.
Following Chromium r187556 this variable has been renamed to
android_webview_build to better describe what it does.

Contributed by torne@chromium.org (https://webrtc-codereview.appspot.com/1195006/).
Review URL: https://webrtc-codereview.appspot.com/1214005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3686 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-18 21:41:04 +00:00
henrike@webrtc.org
728b7ea245 Tool found: pass by value when pass by reference is better in system wrapper unit test.
BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/1186006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3662 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-12 21:49:56 +00:00
henrike@webrtc.org
23875c1694 Fixes issue detected by tool.
BUG=N/A

Review URL: https://webrtc-codereview.appspot.com/1189004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3659 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-12 17:36:54 +00:00
phoglund@webrtc.org
17b867ae00 compile fix for get_nprocs() with uClibc
BUG=

Review URL: https://webrtc-codereview.appspot.com/1150006
Patch from Mostyn Bramley-Moore <mostynb@opera.com>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3598 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-04 15:09:03 +00:00
andrew@webrtc.org
076fc12539 Modify SincResampler to build in webrtc.
This is the first in a series of CLs to bring arbitrary resampling to webrtc.

* Replace Chromium-specific helpers with their respective webrtc versions.
* Add a second constructor to permit runtime selection of block_size.
* Add stringize_macros to system_wrappers.

BUG=webrtc:1395
TESTED=unit tests

Review URL: https://webrtc-codereview.appspot.com/1097012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3518 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-15 03:54:22 +00:00
andrew@webrtc.org
45eab19e7d Import stringize_macros from Chromium.
Committing the originals to make further reviews cleaner.

TBR=bjornv
BUG=webrtc:1395

Review URL: https://webrtc-codereview.appspot.com/1106005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3509 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-13 23:37:14 +00:00
kjellander@webrtc.org
fa53d8717c Fixing/disabling Windows x64 warnings
Disabled MSVC #4267 warnings in common.gypi to enable x64 builds
for Windows.
Fixed MSVC #4267 warnings in test/testsupport.
Added third_party/directxsdk to .gitignore.

With http://review.webrtc.org/1070008 landed, this should make it possible
to build for x64 on Windows.

BUG=1348
TEST=Compiling with http://review.webrtc.org/1070008 applied:
set GYP_DEFINES="target_arch=x64"
set GYP_GENERATORS=ninja
gclient sync
ninja -C out\Debug_x64

Review URL: https://webrtc-codereview.appspot.com/1060008

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3464 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-04 10:07:17 +00:00
henrike@webrtc.org
57e6b81954 Mac 64-bit compatibility for WebRTC.
pthread_t is a pointer type on Mac OS X, and is thus 32 bits wide in the
32-bit environment and 64 bits wide in the 64-bit environment. WebRTC's
thread ID routines assume that thread IDs can always fit inside a uint32_t,
but this is not the case in the 64-bit Mac environment when using pthread_t
as the basis for a thread ID. Instead, switch to using the underlying Mach
port for the thread, which is a 32-bit quantity in both the 32-bit and 64-bit
environments.

The only place this seems to be used is in TraceImpl::AddThreadId, and it's
only used there for a thread ID for display.

This is a better fix than https://webrtc-codereview.appspot.com/929015 .
Review URL: https://webrtc-codereview.appspot.com/1063005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3427 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-29 15:08:29 +00:00
andrew@webrtc.org
63e0964039 Fix webrtc compilation errors for Chrome Win64
Mostly disabling warnings in the gyp files.

BUG=1348
BUG=http://crbug.com/166496
BUG=http://crbug.com/167187

Review URL: https://webrtc-codereview.appspot.com/1063011
Patch from Justin Schuh <jschuh@chromium.org>.

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3423 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-29 06:45:22 +00:00
stefan@webrtc.org
a678a3baee Move video_coding to new Clock interface and remove fake clock implementations from RTP module tests.
TEST=video_coding_unittests, video_coding_integrationtests, rtp_rtcp_unittests, trybots

Review URL: https://webrtc-codereview.appspot.com/1044004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3393 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-21 07:42:11 +00:00
wjia@webrtc.org
a3c82bf667 Remove '<(library)' in gyp files.
This will remove all usage of '<(library)' in all webrtc gyp files. 
Review URL: https://webrtc-codereview.appspot.com/1049005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3392 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-18 23:42:21 +00:00
henrike@webrtc.org
a3e6bec23a Posix Thread: Removes the setting of the run function to NULL which could cause data race.
BUG=http://code.google.com/p/chromium/issues/detail?id=103711
TESTED=Code analysis (no tools)

Review URL: https://webrtc-codereview.appspot.com/1008006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3388 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-18 16:39:21 +00:00
mflodman@webrtc.org
c7e935f5eb Adding timeEndPeriod to Synchronize function, see bug for details.
BUG=748
TEST=Win try bots.

Review URL: https://webrtc-codereview.appspot.com/1043005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3383 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-17 17:12:50 +00:00
stefan@webrtc.org
20ed36dada Break out RtpClock to system_wrappers and make it more generic.
The goal with this new clock interface is to have something which is used all
over WebRTC to make it easier to switch clock implementation depending on where
the components are used. This is a first step in that direction.

Next steps will be to, step by step, move all modules, video engine and voice
engine over to the new interface, effectively deprecating the old clock
interfaces. Long-term my vision is that we should be able to deprecate the clock
of WebRTC and rely on the user providing the implementation.

TEST=vie_auto_test, rtp_rtcp_unittests, trybots

Review URL: https://webrtc-codereview.appspot.com/1041004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3381 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-17 14:01:20 +00:00
phoglund@webrtc.org
5c8d9d30e2 Reformatted tick_util.
BUG=
TEST=Trybots.

Review URL: https://webrtc-codereview.appspot.com/1014004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3330 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-03 09:50:17 +00:00
phoglund@webrtc.org
daabfd25a6 Reformatted trace* files.
BUG=
TEST=Trybots.

Review URL: https://webrtc-codereview.appspot.com/1015004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3329 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-03 09:37:03 +00:00
phoglund@webrtc.org
ec9c942e45 Reformatted thread and static_instance.
BUG=
TEST=Trybots.

Review URL: https://webrtc-codereview.appspot.com/1006005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3324 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-02 08:45:03 +00:00
phoglund@webrtc.org
6bc5d4dc07 Reformatted sort.
BUG=
TEST=Trybots.

Review URL: https://webrtc-codereview.appspot.com/998006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3316 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-19 14:55:24 +00:00
phoglund@webrtc.org
6e0ce73741 Reformatted map classes.
BUG=
TEST=Trybots.

Review URL: https://webrtc-codereview.appspot.com/1006004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3308 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-18 17:18:35 +00:00
phoglund@webrtc.org
59ad541e57 Reformatted rw_lock classes.
BUG=
TEST=Trybots.

Review URL: https://webrtc-codereview.appspot.com/1007004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3305 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-18 15:20:35 +00:00
hclam@chromium.org
c5fcb0879b Update trace_event.h to match the one in Chromium
Chromium's trace_event.h has updated to remove some not-well-used features.
Update WebRTC's copy to match.
Review URL: https://webrtc-codereview.appspot.com/995006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3296 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-14 21:16:46 +00:00
phoglund@webrtc.org
52d981f60c Reformatted list classes.
BUG=
TEST=Trybots

Review URL: https://webrtc-codereview.appspot.com/995004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3291 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-14 09:52:34 +00:00
phoglund@webrtc.org
740be44af5 Reformatted file_* classes.
BUG=
TEST=Trybots.

Review URL: https://webrtc-codereview.appspot.com/980004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3268 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-12 12:52:15 +00:00
hclam@chromium.org
4e16f25774 Remove atomicops.h from WebRTC
atomicops.h are not necessary in trace_event.h similar to the port in WebKit.
It will cause a benign race condition detected by TSAN. If it shows up in
TSAN we will either suppress it or annotate it with dynamic annotations.

BUG=1215
Review URL: https://webrtc-codereview.appspot.com/982004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3267 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-12 01:13:19 +00:00
hclam@chromium.org
ad7efa6944 Port Chromium's trace_event.h to WebKit and add
trace_event.h is ported from Chromium code.

These files are defined new for WebRTC:
* event_tracer.h
* event_tracer.cc
* event_tracer_unittest.cc
Review URL: https://webrtc-codereview.appspot.com/933034

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3262 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-11 21:19:08 +00:00
phoglund@webrtc.org
5bbe069f28 Reformatted event* classes.
TEST=Ran trybots.

Review URL: https://webrtc-codereview.appspot.com/972012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3253 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-10 10:44:37 +00:00
wjia@webrtc.org
df94329a4b Use different cpufeatures library when building with chrome.
There are more than one target when building with chrome. They have different build setup.
This patch just puts content of build/android/cpufeatures.gypi inside system_wrappers.gyp.
In the future, if more modules will use cpufeatures lib, we can move the code into a gypi file.
Review URL: https://webrtc-codereview.appspot.com/939030

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3242 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-05 22:54:52 +00:00
hclam@chromium.org
81cffd1f2c Port Chromium's atomicops to WebRTC
Porting Chromium's base/atomicops.h and friends into WebRTC.

Included the original unit test in Chromium.
Review URL: https://webrtc-codereview.appspot.com/964026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3241 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-05 22:51:01 +00:00
phoglund@webrtc.org
ba21c95e15 Reformatted data_log.
BUG=

Review URL: https://webrtc-codereview.appspot.com/974007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3221 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-12-03 09:01:21 +00:00
phoglund@webrtc.org
99f7c917d2 Reformatted critical_section wrappers.
BUG=
TEST=ran trybots

Review URL: https://webrtc-codereview.appspot.com/971012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3210 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-30 10:44:49 +00:00
andrew@webrtc.org
c3e5d3422b Add a logging_no_op.cc when enable_tracing==0.
This should hopefully fix static initializer warnings when rolling webrtc
in Chromium.

TEST=logging_unittest succeeds with enable_tracing==1 and fails appropriately with enable_tracing==0.

Review URL: https://webrtc-codereview.appspot.com/939026

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3159 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-23 19:30:59 +00:00
phoglund@webrtc.org
b15d285458 Reformatted most of the CPU stuff in system_wrappers.
BUG=

Review URL: https://webrtc-codereview.appspot.com/930025

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3142 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-21 08:02:57 +00:00
andrew@webrtc.org
655d8f56f6 Add a kTraceTerseInfo level for non-verbose logging.
Review URL: https://webrtc-codereview.appspot.com/937023

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3134 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-20 07:34:45 +00:00
wjia@webrtc.org
815653bfa4 Use cpu_features library from ndk when built with chromium.
In Chromium on Andorid, nkd provides cpu_features library so that all modules using that library can link against it to avoid function re-definition.
Review URL: https://webrtc-codereview.appspot.com/937024

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3127 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-19 04:04:10 +00:00