admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
43,169 Commits 1 Branch 0 Tags
Commit Graph

405 Commits

Author SHA1 Message Date
Rasmus Brandt
bdb9db695d Make ParsedRtcEventLog non-copyable 
Bug: webrtc:396148607
Change-Id: I74e5fafd0348f8f1352e7876073ee17fe987e66a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/377080
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43895}
 2025-02-14 03:40:34 -08:00
Boris Tsirkin
dfb507dd39 Format /logging folder 
Formatting done via:

git ls-files | grep -E '^logging\/.*\.(h|cc|mm)' | xargs clang-format -i

No-Iwyu: Includes didn't change and it isn't related to formatting
Bug: webrtc:42225392
Change-Id: Id89565ab061f299efea283e9c5ae295f47d05359
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/373584
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43678}
 2025-01-08 04:52:32 -08:00
Per Kjellander
17554c1c4c Add graph for ecn packet count in incoming/outgoing CCFB 
Also add a plot group l4s.

Usage: event_log_visualizer --plot=l4s filename |python3

Bug: webrtc:42225697
Change-Id: I5e1ee7028b9fb0707d5cabfe6d6f27c348e70a22
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/367199
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43416}
 2024-11-18 13:45:07 +00:00
Björn Terelius
661ed679a2 Return a status in ParsedRtcEventLog instead of checked_cast. 
Bug: webrtc:375120297
Change-Id: I64bd6b9e5ef646c787d23e3abc1bd6b3fd209d4a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/367121
Reviewed-by: Mirta Dvornicic <mirtad@webrtc.org>
Auto-Submit: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Mirta Dvornicic <mirtad@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43345}
 2024-11-01 10:24:00 +00:00
Dor Hen
297fe1a2d9 [reland] Comment unused variables in implemented functions 10\n 
Bug: webrtc:370878648
Change-Id: Icbfacf8113942f60ba168e4aa884f0172eaa0fca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/367080
Commit-Queue: Dor Hen <dorhen@meta.com>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43336}
 2024-10-31 07:08:00 +00:00
Harald Alvestrand
461e828d57 Revert "Comment unused variables in implemented functions 10\n" 
This reverts commit f5e0f038440ae1cf46f84c3d740a75e420d808ca.

Reason for revert: Use of [[maybe_unused]] in .h files compiled in objC

Original change's description:
> Comment unused variables in implemented functions 10\n
>
> Bug: webrtc:370878648
> Change-Id: Ic2dda55058ed4474d898fa938c2a66dab2f6f20e
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/366204
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
> Commit-Queue: Dor Hen <dorhen@meta.com>
> Cr-Commit-Position: refs/heads/main@{#43327}

Bug: webrtc:370878648, b/376178831
Change-Id: Ibeaecd6ae21b6fc478ce153ad72f8941d7af4a46
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/367060
Reviewed-by: Christoffer Dewerin <jansson@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#43331}
 2024-10-30 08:22:53 +00:00
Dor Hen
a154b73097 Comment unused variables in implemented functions 11\n 
Bug: webrtc:370878648
Change-Id: Ic31d7744cc8516e4c014bc044fbe2dba9e4d835b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/366525
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Dor Hen <dorhen@meta.com>
Cr-Commit-Position: refs/heads/main@{#43328}
 2024-10-29 17:25:36 +00:00
Dor Hen
f5e0f03844 Comment unused variables in implemented functions 10\n 
Bug: webrtc:370878648
Change-Id: Ic2dda55058ed4474d898fa938c2a66dab2f6f20e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/366204
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Dor Hen <dorhen@meta.com>
Cr-Commit-Position: refs/heads/main@{#43327}
 2024-10-29 17:24:33 +00:00
Dor Hen
bec7015797 Comment unused variables in implemented functions 9\n 
Bug: webrtc:370878648
Change-Id: I2cdc8456c9fe1131fa09f02cdb4ba4ab13beccc2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/366740
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Dor Hen <dorhen@meta.com>
Cr-Commit-Position: refs/heads/main@{#43326}
 2024-10-29 17:23:30 +00:00
Dor Hen
3f1a04acf9 Comment unused variables in implemented functions 5\n 
Bug: webrtc:370878648
Change-Id: I8ac032b5621fd0a75bce11541133579d22f63af3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/364684
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Dor Hen <dorhen@meta.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43280}
 2024-10-22 12:00:53 +00:00
Dor Hen
ca07d54192 Comment unused variables in implemented functions 4\n 
Bug: webrtc:370878648
Change-Id: I32d472174ce4f9f31b829ea89a82a003d333d2b8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/364539
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Dor Hen <dorhen@meta.com>
Cr-Commit-Position: refs/heads/main@{#43279}
 2024-10-22 11:59:50 +00:00
Dor Hen
6d58a43413 Comment unused variables in implemented functions 3\n 
Bug: webrtc:370878648
Change-Id: I40251cc529cc20fbf2b034fa25798965b91dbd88
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/364683
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Dor Hen <dorhen@meta.com>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43278}
 2024-10-22 11:58:48 +00:00
Philipp Hancke
db1c618fa1 Remove legacy transitive include for RtcEventLogOutputFile 
BUG=webrtc:42231521

Change-Id: Id9bec9d762d2a273ac9683f45593ae4009e5ca38
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/364864
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43246}
 2024-10-16 10:41:03 +00:00
Dor Hen
fe6ed1364b Remove unused parameter from FixedLengthEncodingParameters::ValidParameters 
Bug: webrtc:370878648
Change-Id: I0031426ebc7ea9b95d7d322a6637c57cb6344ae9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/364506
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43161}
 2024-10-03 10:40:56 +00:00
Björn Terelius
4a7ea89ac9 Fix lint issues in logging/ 
Bug: None
Change-Id: I998b3da0294bbf71f852c5947577622619c832d8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361262
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42941}
 2024-09-04 07:58:47 +00:00
Florent Castelli
8037fc6ffa Migrate absl::optional to std::optional 
Bug: webrtc:342905193
No-Try: True
Change-Id: Icc968be43b8830038ea9a1f5f604307220457807
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/361021
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42911}
 2024-09-02 12:16:47 +00:00
Tommi
187a4363c0 Remove more sstream deps 
Bug: webrtc:8982
Change-Id: I7e1e2a8515b84567d6fe8127ff0e2806a2a4714a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/356400
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42610}
 2024-07-09 10:30:26 +00:00
Björn Terelius
ac4e0b6f46 Include-what-you-use logging/rtc_event_log/ 
Forwarding headers like rtc_event_log2_proto_include.h and test/gtest.h
were omitted.

Presubmit gn checks for existing (implicit) dependencies were disabled.

Bug: webrtc:42226242
Change-Id: Id08ae1b244db1a6f65069775f47deec05191ff89
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/350923
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42393}
 2024-05-28 14:33:25 +00:00
Björn Terelius
0596503938 Split BandwidthUsage from network_state_predictor.h 
Bug: None
Change-Id: Ie1d0c1fd4b32fc5f9e4252bfe0fd2ca1412bd594
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/351002
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42376}
 2024-05-24 13:44:37 +00:00
Björn Terelius
3baefbf2dd Return absl::optional<size_t> from FileWrapper::FileSize() 
Bug: None
Change-Id: If5219a8f7f7e81ea660b0495c48f96adb6948228
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/348860
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42206}
 2024-05-02 10:40:38 +00:00
Joachim Reiersen
5075cb4a60 Expose AudioLevel as an absl::optional struct in api/rtp_headers.h 
Start migrating away from `hasAudioLevel`, `voiceActivity`, `audioLevel` fields in RTPHeaderExtension and switch usages to a more modern absl::optional<AudioLevel> accessor instead.

The old fields are preserved for compatibility with downstream projects, but will be removed in the future.

Bug: webrtc:15788
Change-Id: I76599124fd68dd4d449f850df3b9814d6a002f5d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/336303
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41947}
 2024-03-22 10:07:47 +00:00
Markus Handell
97df932ecc Remove multiplex codec. 
The feature isn't in use by Google and has proven to contain security
issues. It's time to remove it.

Bug: b/324864439
Change-Id: I80344eb2f2060469d2d69a54dc4519fdd02ab4ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/340324
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41808}
 2024-02-26 11:26:04 +00:00
Joachim Reiersen
4a97488714 Rename AudioLevel to AudioLevelExtension in rtp_header_extensions.h 
To prepare for a new AudioLevel struct to be added to the public WebRTC API, rename the internal RTP extension reader/writer class to AudioLevelExtension. A temporary alias is provided to avoid breaking downstream projects.

Bug: webrtc:15788
Change-Id: Ie231668f25932fd9b539229114128b1d0b949a6e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/339887
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41787}
 2024-02-22 23:12:52 +00:00
Tommi
32f2a30e5e Move IceCandidateType to candidate.h 
Bug: none
Change-Id: I3152d36c379ef0b2c8928a0e5750e012157fd26c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/336920
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41711}
 2024-02-09 17:15:40 +00:00
Bjorn Terelius
15062c8739 Create helper for constructing empty LoggedPacketInfo for testing. 
Bug: b/318801494
Change-Id: Ie063ac3a63276f5fbc14794b6aba8e7b839cc910
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/338740
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41705}
 2024-02-09 10:04:30 +00:00
Tommi
5e04753e7a Remove deprecated IceCandidateType values 
Bug: none
Change-Id: I13ebcc6fd38aa25fee8afd92bda06a0f3483cda1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/337120
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41692}
 2024-02-08 08:47:24 +00:00
Tommi
2c169aef97 Rename kLocal to kHost and kStun to kSrflx 
Bug: none
Change-Id: I92845014024e5780365057e81b613b0882724d1d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/336740
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41652}
 2024-02-01 12:31:08 +00:00
Danil Chapovalov
d071dc1725 Bypass global field trial string in RtcEventLog unittests 
Pass explicit field trials for object under test,
Bypass field trial altogether for setting expectations

Bug: webrtc:10335
Change-Id: Id17d70aa2c650bd9a00f4bca0035f37b3b415b76
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/337183
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41651}
 2024-02-01 11:16:15 +00:00
Danil Chapovalov
14b016fbf9 In RtcEventLogEncoderNewFormat use propagated instead of global field trials 
Bug: webrtc:10335
Change-Id: Id407a7bc25375cadccba4cf4ae0c771f22a19a0e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/333581
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41644}
 2024-01-31 15:23:24 +00:00
Tommi
7cb4ce0079 Remove IceCandidateType::kNumValues 
Bug: none
Change-Id: I108a006d6ff00f436c87dc9ee5b7e3c27b7b6c83
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/336242
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41642}
 2024-01-31 13:39:30 +00:00
Tommi
c4dd03dfcb Remove kUnknown as a possible value for IceCandidateType. 
Subsequently also tighten IceCandidateType error checking.
The Candidate type in `cricket` should be using something similar
(currently using a string for the type), so I'm making sure that
types that we have already, align with where we'd like to be overall.
Possibly we can move IceCandidateType to where Candidate is defined.

Bug: none
Change-Id: Iffeba7268f2a393e18a5f33249efae46e6e08252
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/335980
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41640}
 2024-01-31 11:26:53 +00:00
Danil Chapovalov
dc64596510 Remove RtcEventLogImpl dependency on rtc::TaskQueue 
same functionality can be achieved by using TaskQueueBase directly

Bug: webrtc:14169
Change-Id: Id7c27afdbf61b4cab3d006d9a7b690b915759cdb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/333440
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41476}
 2024-01-08 12:12:10 +00:00
Danil Chapovalov
c41977d303 Propagate Environment into RtcEventLogImpl 
With intention to propagte it futher into RtcEventLogEncoderNewFormat
where it can replace usage of the global field trials

Same environment can be saved in RtcEventLogImpl itself wthere it can
replace usage of the global clock

Bug: webrtc:10335
Change-Id: Ia147d7073af5aab54190fdf192cd5c046c3d40a1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/330423
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41472}
 2024-01-05 11:28:00 +00:00
Danil Chapovalov
2ca1d0f809 Delete legacy RtcEventLogFactory Create functions 
All usage was migrated to the latest variant of the Create function that takes the Environment paramter.

Bug: webrtc:15656
Change-Id: I2fb2bf4bc4a858d69adc64c2804c1bd830011f10
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/329440
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41302}
 2023-12-03 11:10:35 +00:00
Danil Chapovalov
1a82d31cb5 Add RtcEventLogFactory::Create variant that uses Environment 
With intent to delete previous versions of the Create functions.

Bug: webrtc:15656
Change-Id: I972377701becca21b8ecfe15d41a10a4248f87ec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/328420
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41275}
 2023-11-29 13:22:32 +00:00
Björn Terelius
efeeba0864 Try removing RTC_PUSH_IGNORING_WUNDEF() around proto includes 
Bug: webrtc:15623
Change-Id: Ia184993769f74d51e68a5a536d5fdde26890bcfd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/325481
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41058}
 2023-11-01 08:21:05 +00:00
qwu16
ae82df718c Add codec name H265 to support H265 in WebRTC 
Bug: webrtc:13485
Change-Id: I352b15a65867f0d56fc8e9a9e03081bd3258108e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/316283
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40773}
 2023-09-20 09:25:32 +00:00
Björn Terelius
ff58aed678 Process events with the same timestamp in a defined order. 
As before, events are processed primarily in timestamp order.
This CL adds a heuristic to break ties for events with the same timestamp.

- Roughly speaking, configs and connectivity events are processed first, followed by incoming packets, then BWE updates, then other (general) events and finally outgoing packets and ALR events.

- Among RTP packets, transport sequence number is used to break ties.

- The insertion order (into the EventProcessor) is used as a last resort.

Bug: b/282153758
Change-Id: I914e4500ca63e1a8754766d1833a7b32f6a38176
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/308140
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40318}
 2023-06-20 14:21:17 +00:00
Björn Terelius
9e247b6262 Add RtcEventProcessor::AddEvents overload that accepts PacketDirection. 
Bug: b/282153758
Change-Id: I53d379752f2e8eca91eb190e966ca1853330a210
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/309480
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40315}
 2023-06-20 10:42:58 +00:00
philipel
d1e5dedffe Use DD encoder/decoder in RTC event log encoder/parser. 
Bug: webrtc:14801
Change-Id: I7013c42765e81d147bf8284f8c29666e67fdb91f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296765
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39929}
 2023-04-24 10:35:22 +00:00
Danil Chapovalov
95e7a0398c Delete clamping cumulative loss in ReportBlocks on receiving side 
Bug: webrtc:9598
Change-Id: I8a54af88708e5d96e46ba67ab0ef2e0e59fe0b86
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/300941
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39887}
 2023-04-18 13:43:27 +00:00
Björn Terelius
31a10d321a Ensure correct destruction order in RtcEventLogImplTest 
Bug: b/269744492
Change-Id: I0b7b92ec31baf3515562adde7617de0873cfd537
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/298882
Reviewed-by: Markus Handell <handellm@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39653}
 2023-03-23 11:50:41 +00:00
Jianhui Dai
0a025345fe RtcEventLog: Separate LogToMemory from TaskQueue to current thread 
Original implementation uses TaskQueue to async execute both `LogToMemory` and `WriteToOutput`. `LogToMemory` is invoked in high frequency, but the execution takes a very short time. It would be a bit more expensive to post on TaskQueue than execution on current thread with locking. It is because that the TaskQueue switches the thread context for execution.

This CL separates `LogToMemory` from TaskQueue to current thread, in
order to avoid frequent context switching; And periodically schedule
`WriteToOutput` to TaskQueue, not block current thread.

Link: https://webrtc-review.googlesource.com/c/src/+/283641
Bug: chromium:1288710
Change-Id: Ic78216aff16d1883b109e360a0892da3ca8f5ecb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/295640
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Markus Handell <handellm@webrtc.org>
Reviewed-by: Markus Handell <handellm@google.com>
Cr-Commit-Position: refs/heads/main@{#39629}
 2023-03-21 23:07:40 +00:00
philipel
d20b1cf215 Encoder/Decoder for dependecy descriptor in RTC event log. 
Bug: webrtc:14801
Change-Id: I3eb1884f4f7e52cc66fab12251b5a8efae5a1ace
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296300
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39607}
 2023-03-20 14:10:53 +00:00
Rasmus Brandt
21d7cf5879 Remove deprecated logged_events.h 
Bug: None
Change-Id: I7969d7792b6614340d71475a600b69c3681a50d0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296760
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39517}
 2023-03-09 19:42:57 +00:00
philipel
f5127616aa Fix convenience macros for RtcEventLogParseStatus. 
Bug: webrtc:14801
Change-Id: I56f352b9997fb6215cc04e90e50861985c22a2b4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296720
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39511}
 2023-03-09 11:04:17 +00:00
Jianhui Dai
7d6b5b878f Add StopOutputOnWriteFailure to RtcEventLogImplTest 
Bug: chromium:1288710
Change-Id: Ib913fb392077512d43ea408c95115129d3ff3425
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/295800
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Jianhui J Dai <jianhui.j.dai@intel.com>
Reviewed-by: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39509}
 2023-03-09 08:50:12 +00:00
philipel
de0afb7df6 Move RtcEventLogParseStatus and related macros to a separate file and buildtarget. 
Bug: webrtc:14801
Change-Id: I204f46d47933a1ad95682042bc7009e421109ba1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296660
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39505}
 2023-03-08 15:18:28 +00:00
philipel
f3e90cd03a OptionalBlobEncoder encode empty string on no input. 
Bug: webrtc:14801
Change-Id: I934849322294ae10f0d7cd405e73bc48892543c9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296661
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39502}
 2023-03-08 13:11:41 +00:00
Danil Chapovalov
f4dfa1ce01 Reassign TODO from self to bug with more context 
No-try: true
Bug: webrtc:14449
Change-Id: Iab1954d4a7a2fd791ad2ac97062ac73d5ce372dd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/296581
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39501}
 2023-03-08 09:02:13 +00:00