1082 Commits

Author SHA1 Message Date
andrew@webrtc.org
24bd58e689 Properly count anonymous mixing participants.
When _amountOfMixableParticipants == 1, we skip mixing and saturation
protection. Without this fix, an anonymous participant would only be
properly counted if it was the last added.

For example, if an anonymous participant was added first, followed by
a regular participant, _amoutOfMixableParticipants would == 1 and the
regular participant would not be mixed.

BUG=issue209
TEST=New test added to voe_auto_test to verify, and used voe_cmd_test.

Review URL: https://webrtc-codereview.appspot.com/367006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1551 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 18:57:44 +00:00
henrik.lundin@webrtc.org
dcf006480c Fix typo in a comment
TBR=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/369012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1548 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 16:48:00 +00:00
henrik.lundin@webrtc.org
4679652d57 Implemented a fix for Issue 88.
NetEQ now checks for too early CNG packets, and modifies the CNG
sample counter to jump forward in time if needed to combat clock
drift.

Adding a new unittest to reproduce and solve the issue. The
unittest LongCngWithClockDrift verifies that the buffer delay
before and after a long CNG period is almost constant. The test
introduces a clock drift of 25 ms/s.

BUG=http://code.google.com/p/webrtc/issues/detail?id=88
TEST=neteq_unittests NetEqDecodingTest.LongCngWithClockDrift

Review URL: https://webrtc-codereview.appspot.com/372002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1547 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 16:37:41 +00:00
mflodman@webrtc.org
9b0a820624 Fixed double erase in ViEChannelManager channel map.
Review URL: https://webrtc-codereview.appspot.com/369011

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1546 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 16:00:49 +00:00
mflodman@webrtc.org
b11424bc11 Remove ViEShared inheritance for interface impl.
Review URL: https://webrtc-codereview.appspot.com/357002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1545 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 13:42:03 +00:00
bjornv@webrtc.org
f4b77fd722 VAD refactor: Mode changed to "int".
As part of style this CL includes changing the input aggressiveness mode from int16_t to int. No other style changes made.
Impact on:
- Audio Processing: Changed return value on MapSetting().
- Function test in audio_conference_mixer already uses int. No action.
- NetEq: Function pointer changes and input parameter changes in SetVADMode() and SetVADModeInternal().
- Audio Coding: Uses enum ACMVADMode which is type independent.
- VAD: Two unit tests.

TESTS=vad_unittests, neteq_unittests, audioproc_unittest
Review URL: https://webrtc-codereview.appspot.com/373001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1544 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 12:40:00 +00:00
bjornv@webrtc.org
2a4dcd7d15 VAD refactor: WebRtcVad_InitCore().
Impact only locally.
- Replaced for loops with memset().
- Added guard against NULL pointer.
- Removed mode as input parameter (never really used).
- Updated unit tests.
- Made struct member init_flag "int".
- Updated function description.
- Updated Copyright notes with 2012.
- Removed some lint warnings.

TESTS=vad_unittests, audioproc_unitest
Review URL: https://webrtc-codereview.appspot.com/369005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1543 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-25 12:18:12 +00:00
henrike@webrtc.org
567b99be5f Coverity report: fixes an issue where the returnvalue of a function is not checked.
Review URL: https://webrtc-codereview.appspot.com/347013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1542 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 23:43:54 +00:00
andrew@webrtc.org
f5d8c3bc3b Fix audioproc_unittest on Windows.
On Windows, files have to be closed before they can be removed.

TBR=bjornv
BUG=none
TEST=audioproc_unittest on Windows.

Review URL: https://webrtc-codereview.appspot.com/369010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1541 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 21:35:39 +00:00
pwestin@webrtc.org
f6bb77a6f0 Cleaning up all use of RTP_PAYLOAD_NAME_SIZE and RTCP_CNAME_SIZE also fixed the char handing in trace.
Review URL: https://webrtc-codereview.appspot.com/358001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1535 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 17:16:59 +00:00
mallinath@webrtc.org
218db3de20 Iterator was invalid while removing entries from codec db maps.
Review URL: http://webrtc-codereview.appspot.com/373003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1534 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 17:11:44 +00:00
stefan@webrtc.org
9e332ab95b Make sure we check the return value from shmat().
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/358007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1533 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 16:33:27 +00:00
pwestin@webrtc.org
b73c3d1f5d Bugfix android build.
Review URL: https://webrtc-codereview.appspot.com/374003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1532 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 15:25:30 +00:00
pwestin@webrtc.org
28a5cb29ab Bugfix receive side only packet loss estimate with NACK.
Review URL: https://webrtc-codereview.appspot.com/373006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1529 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 14:34:58 +00:00
perkj@webrtc.org
40d3c08be4 Changed max number of vie channels to 32.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/374002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1527 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 14:04:17 +00:00
mflodman@webrtc.org
ba09cf16ec Correcting uninitialized members.
BUG=C-10344, C-10345, C-10346

Review URL: https://webrtc-codereview.appspot.com/345012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1525 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 07:49:33 +00:00
mflodman@webrtc.org
a5a5cbb992 Switched from WebRTC wrappers to stl in ChannelManager.
BUG=C-10187

Review URL: https://webrtc-codereview.appspot.com/357001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1524 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 06:50:15 +00:00
andrew@webrtc.org
eeaf3d1fc1 Merge /branches/3.2:r1380 to /trunk
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1523 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 06:30:02 +00:00
mflodman@webrtc.org
6cf529d082 Changed REMB return value to int instead of bool.
Review URL: https://webrtc-codereview.appspot.com/366001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1522 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 06:16:16 +00:00
andrew@webrtc.org
d3a0c1cb66 Merge /branches/3.2:r1378 to /trunk
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1521 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 03:20:53 +00:00
kma@webrtc.org
4bc24c4afa Optimized function WebRtcSpl_FilterARFastQ12 for ARM platform.
Speed close to doubled for an offline test in NetEq.
Bit exact.
Review URL: https://webrtc-codereview.appspot.com/346001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1520 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 02:12:49 +00:00
punyabrata@webrtc.org
6da8eeb946 Removing an assert for a case that can occur
when corrupt packets are injected into voice engine.
Review URL: https://webrtc-codereview.appspot.com/373004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1518 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-24 00:48:36 +00:00
leozwang@webrtc.org
f5cacdce8c Fix line aligement
Review URL: https://webrtc-codereview.appspot.com/373002

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1516 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-23 23:14:13 +00:00
leozwang@webrtc.org
f9cd693145 Enable vp8 and videoengine on android
Review URL: https://webrtc-codereview.appspot.com/368003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1510 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-23 16:56:13 +00:00
leozwang@webrtc.org
a45d05a341 Add brighten.cc to makefile
Review URL: https://webrtc-codereview.appspot.com/369003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1509 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-23 16:54:13 +00:00
leozwang@webrtc.org
376be6c904 Fix compilation error
Review URL: https://webrtc-codereview.appspot.com/358005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1508 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-23 16:46:38 +00:00
pwestin@webrtc.org
b30f0edce6 Bugfix buffer usage out of scope.
Review URL: https://webrtc-codereview.appspot.com/372001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1507 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-23 16:23:31 +00:00
phoglund@webrtc.org
12dbc23851 Rewrote volume test.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/367004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1506 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-23 16:03:04 +00:00
stefan@webrtc.org
175fecde97 Fix clang build error.
TBR=henrik.lundin@webrtc.org
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/367005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1505 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-23 15:23:31 +00:00
stefan@webrtc.org
8fe03af674 Refactor to use std::list in the video rtp play tools.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/349013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1504 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-23 14:56:14 +00:00
bjornv@webrtc.org
152c34cf11 VAD-refactor. Changed to int as return value for WebRtcVad_set_mode().
Impact on NetEq function pointers. Other components already treat the output as int. These are:
* audio_processing
* funtion test in audio_conference_mixer
* audio_coding

TEST=vad_unittests, neteq_unittests
Review URL: https://webrtc-codereview.appspot.com/367003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1503 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-23 12:36:46 +00:00
phoglund@webrtc.org
3b57ee0238 Rewrote DTMF test.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/368001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1502 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-23 09:22:33 +00:00
leozwang@webrtc.org
31627fe82c Add vie_remb.cc to makefile
Review URL: https://webrtc-codereview.appspot.com/358004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1501 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-20 23:10:26 +00:00
andrew@webrtc.org
e2ed5baf47 Enable audioproc_unittest on all platforms.
But, for the time being, limit the bit-exact test to 64-bit Linux debug.

TEST=build and run all configs on Linux, and standard configs on Win and Mac.

Review URL: https://webrtc-codereview.appspot.com/343005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1500 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-20 19:06:38 +00:00
leozwang@webrtc.org
2638577f03 Add an argument in ANDROID_NOT_SUPPORT macro
Review URL: https://webrtc-codereview.appspot.com/363003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1499 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-20 18:45:45 +00:00
stefan@webrtc.org
f27916a76a Remove use of MapWrapper in video_coding.
BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/344018

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1498 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-20 14:04:13 +00:00
henrik.lundin@webrtc.org
d798953846 NetEqRTPplay modification
Make the program look for the ptypes.txt file in the default trunk
path, if the path to the executable indicates that it sits in the
trunk/out/Debug folder.

Changing PT for CNG-WB to 98

Remove warnings when building NetEQ with NETEQ_DELAY_LOGGING

Review URL: https://webrtc-codereview.appspot.com/339003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1497 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-20 13:42:16 +00:00
phoglund@webrtc.org
d056abd62f Prepared tests for running on build bot.
The changes will mostly clarify why PSNR and SSIM thresholds are chosen. I think those explanations will be good since these tests may well be a bit flaky.

BUG=
TEST=

Review URL: https://webrtc-codereview.appspot.com/343017

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1496 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-20 12:48:13 +00:00
mflodman@webrtc.org
c672d34ac7 Removed file duplicate added in r1312.
Review URL: https://webrtc-codereview.appspot.com/357003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1495 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-20 12:30:42 +00:00
kjellander@webrtc.org
5e1625ed2d Fixing Valgrind problem detected by video_processing_unittests.
Simple initialization of the allocated memory for the image buffer avoids reading uninitialized data in some special cases.

This fix is only intended for Linux, since the test is known to fail on Windows. But since we're currently only running Valgrind on Linux, this will give us improved control over memory issues.

BUG=
TEST=tools/valgrind-webrtc/webrtc_tests.sh -t cmdline out/Debug/video_processing_unittests

Review URL: http://webrtc-codereview.appspot.com/349012

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1493 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-20 08:40:55 +00:00
pwestin@webrtc.org
56ee5d5d98 Bugfix 32 bit linux.
Review URL: https://webrtc-codereview.appspot.com/353010

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1490 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-20 07:47:38 +00:00
pwestin@webrtc.org
95cf47932d Remove list wrapper from FEC code.
Review URL: https://webrtc-codereview.appspot.com/350013

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1489 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-20 06:59:06 +00:00
leozwang@webrtc.org
9165f1fe91 Changed to use std::sort
Review URL: https://webrtc-codereview.appspot.com/356003

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1488 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-20 01:39:13 +00:00
andrew@webrtc.org
f33dfa89b9 Add target and config info to merged lib name.
BUG=None
TEST=build merged_lib on Linux, Mac, Win

Review URL: https://webrtc-codereview.appspot.com/344014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1487 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-20 01:32:16 +00:00
leozwang@webrtc.org
a191506ce9 Enable all modules without building errors
Review URL: https://webrtc-codereview.appspot.com/360004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1485 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 22:11:37 +00:00
mflodman@webrtc.org
2d03b8b217 REMB now works for two consecutive calls with different channels but same ViE instance.
BUG=241

Review URL: https://webrtc-codereview.appspot.com/361001

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1484 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 21:21:15 +00:00
andrew@webrtc.org
300aed945d Use -Wextra on Linux for standalone builds.
BUG=None
TEST=build on Linux, Mac, Windows

Review URL: https://webrtc-codereview.appspot.com/348009

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1482 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 20:10:19 +00:00
mflodman@webrtc.org
0f4cb131c6 Added NULL check in ViEFileImpl.
BUG=C-10188

Review URL: https://webrtc-codereview.appspot.com/344016

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1480 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 18:41:39 +00:00
marpan@webrtc.org
20cd06123c For TL(temporal layers) = 2, the alt-ref frame should not be used as a reference.
Correction for the last frame in the cycle.
Review URL: https://webrtc-codereview.appspot.com/343015

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1479 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 18:25:23 +00:00
pwestin@webrtc.org
0074187436 Removed map_wrapper from rtp_sender
Review URL: https://webrtc-codereview.appspot.com/343014

git-svn-id: http://webrtc.googlecode.com/svn/trunk@1478 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-01-19 15:56:10 +00:00