Boris Tsirkin
4b96bfde96
Make .clang-format ObjC respect Chromium column limit length
...
Currently, WebRTC .clang-format file is configured to support column length of up to 100: https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/.clang-format;l=12;drc=73012534918d8c65ae748fff8ca18ad5c857b82e
While Google guidelines mention supporting up to 100 (https://google.github.io/styleguide/objcguide.html#line-length ), Chromium guidelines mention up to 80, like in C++ (https://chromium.googlesource.com/chromium/src/+/lkgr/styleguide/objective-c/objective-c.md#line-length )
WebRTC guidelines mention that in case of conflicts, the Chromium guidelines should be followed (https://webrtc.googlesource.com/src/+/HEAD/g3doc/style-guide.md )
Hence, I'm suggesting changing the ObjC ColumnLimit parameter from 100 to 80.
Bug: webrtc:387828388
Change-Id: If9186bebec92cb0c01015084c3e47ad210dccc33
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/373620
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43663}
2025-01-07 02:05:31 -08:00
Mirko Bonadei
7301253491
Add IncludeBlocks to clang-format.
...
This should make "git cl format" compliant with [1].
[1] - https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes
Bug: None
Change-Id: Iaccae6c37965e390de8f8a3fe8e3866f51690b5a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/204485
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33151}
2021-02-03 16:29:07 +00:00
magjed
198a9300cd
Tune ObjC clang-format configuration
...
This CL sets some options for ObjC in the .clang-format file to closer
match our style guide.
NOTRY=True
BUG=webrtc:7406
Review-Url: https://codereview.webrtc.org/2869593002
Cr-Commit-Position: refs/heads/master@{#18092}
2017-05-11 09:14:18 +00:00
sakal
708f731fd1
Update clang-format to use Google style guide for ObjC.
...
We are using Google style guide for ObjC code. Clang-format now allows
us to differentiate between C++ and ObjC code. With this change it now
uses Google style guide with ColumnLimit of 100 for ObjC code.
NOTRY=True
BUG=webrtc:7406
Review-Url: https://codereview.webrtc.org/2775613002
Cr-Commit-Position: refs/heads/master@{#17387}
2017-03-27 11:35:05 +00:00
magjed
25337bb5ab
Android: Update clang-format to follow Google style guide
...
BUG=webrtc:6419
NOTRY=True
Review-Url: https://codereview.webrtc.org/2368963002
Cr-Commit-Position: refs/heads/master@{#14385}
2016-09-26 18:47:53 +00:00
pbos@webrtc.org
4e3161dd55
Style-option file for clang-format.
...
Specifies that clang-format as well as related editor plugins should use
Chromium style.
BUG=
TEST=formatting code with vim, running :ClangFormat before/after this change.
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4339004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5172 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-25 15:30:37 +00:00
