phoglund
18832f6c35
Make rtc_include_tests true by default in gn.
...
See bug for discussion.
BUG=webrtc:6119
TBR=kjellander@webrtc.org
Review-Url: https://codereview.webrtc.org/2156203002
Cr-Commit-Position: refs/heads/master@{#13500}
2016-07-19 19:56:56 +00:00
phoglund
136778252d
Revert of Fix inconsistent setting of the rtc_include_unittests flag. (patchset #1 id:1 of https://codereview.webrtc.org/2154693002/ )
...
Reason for revert:
Nope, breaks chromium
Original issue's description:
> Fix inconsistent setting of the rtc_include_unittests flag.
>
> On advice from brettw, se discussion here:
> https://codereview.webrtc.org/2149543002/
>
> The problem was we were setting the flag to both false and true,
> and the the true happened to win out for WebRTC checkouts and
> false for Chromium checkouts. This change should make this
> mechanic more obvious.
>
> This change _should_ have no effect downstream.
>
> Doing tbr to see if we can get the chromium import back into a good state today.
>
> TBR=tommi@webrtc.org
>
> Committed: https://crrev.com/9d34148714773339a4e8396bd28aceb571554d36
> Cr-Commit-Position: refs/heads/master@{#13484}
TBR=tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.webrtc.org/2150293002
Cr-Commit-Position: refs/heads/master@{#13486}
2016-07-15 11:13:28 +00:00
phoglund
9d34148714
Fix inconsistent setting of the rtc_include_unittests flag.
...
On advice from brettw, se discussion here:
https://codereview.webrtc.org/2149543002/
The problem was we were setting the flag to both false and true,
and the the true happened to win out for WebRTC checkouts and
false for Chromium checkouts. This change should make this
mechanic more obvious.
This change _should_ have no effect downstream.
Doing tbr to see if we can get the chromium import back into a good state today.
TBR=tommi@webrtc.org
Review-Url: https://codereview.webrtc.org/2154693002
Cr-Commit-Position: refs/heads/master@{#13484}
2016-07-15 10:56:14 +00:00
kjellander
68208897be
Roll chromium_revision 7fa6701bc5..1a73d11e65 (398458:399420)
...
A fix was needed to make Android tests pass after
https://codereview.chromium.org/2043803003
Another fix was needed for the webrtc_perf_tests.isolate sinc eit was missing
one file.
Change log: 7fa6701bc5..1a73d11e65
Full diff: 7fa6701bc5..1a73d11e65
Changed dependencies:
* src/buildtools: 8dd3c8e39a..099f1da55b
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/0fc7df55c0..171b5403ee
* src/third_party/ffmpeg: 7f03319b9d..bcb8b67b8b
DEPS diff: 7fa6701bc5..1a73d11e65 /DEPS
No update to Clang.
TBR=
BUG=webrtc:5990
NOTRY=True
Review-Url: https://codereview.webrtc.org/2074043002
Cr-Commit-Position: refs/heads/master@{#13178}
2016-06-17 06:29:38 +00:00
kjellander
dfe6937666
Revert of Roll chromium_revision 7fa6701bc5..1a73d11e65 (398458:399420) (patchset #2 id:20001 of https://codereview.webrtc.org/2061723002/ )
...
Reason for revert:
webrtc_perf_tests fails on all Android Release testers:
http://build.chromium.org/p/client.webrtc/builders/Android64%20Tests%20%28L%20Nexus9%29/builds/3673
Original issue's description:
> Roll chromium_revision 7fa6701bc5..1a73d11e65 (398458:399420)
>
> A fix was needed to make Android tests pass after
> https://codereview.chromium.org/2043803003
>
> Change log: 7fa6701bc5..1a73d11e65
> Full diff: 7fa6701bc5..1a73d11e65
>
> Changed dependencies:
> * src/buildtools: 8dd3c8e39a..099f1da55b
> * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/0fc7df55c0..171b5403ee
> * src/third_party/ffmpeg: 7f03319b9d..bcb8b67b8b
> DEPS diff: 7fa6701bc5..1a73d11e65 /DEPS
>
> No update to Clang.
>
> TBR=
> BUG=webrtc:5990
> NOTRY=True
>
> Committed: https://crrev.com/c49cf1308f879ce029f5f0e804b4eef3b08b67c5
> Cr-Commit-Position: refs/heads/master@{#13117}
TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5990
Review-Url: https://codereview.webrtc.org/2059423002
Cr-Commit-Position: refs/heads/master@{#13118}
2016-06-13 21:11:09 +00:00
kjellander
c49cf1308f
Roll chromium_revision 7fa6701bc5..1a73d11e65 (398458:399420)
...
A fix was needed to make Android tests pass after
https://codereview.chromium.org/2043803003
Change log: 7fa6701bc5..1a73d11e65
Full diff: 7fa6701bc5..1a73d11e65
Changed dependencies:
* src/buildtools: 8dd3c8e39a..099f1da55b
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/0fc7df55c0..171b5403ee
* src/third_party/ffmpeg: 7f03319b9d..bcb8b67b8b
DEPS diff: 7fa6701bc5..1a73d11e65 /DEPS
No update to Clang.
TBR=
BUG=webrtc:5990
NOTRY=True
Review-Url: https://codereview.webrtc.org/2061723002
Cr-Commit-Position: refs/heads/master@{#13117}
2016-06-13 19:12:47 +00:00
kjellander
e72db17556
GN: Use rtc_include_tests variable to exclude tests.
...
This is closer to what the GYP build does, and is more readable.
BUG=webrtc:5949
TBR=phoglund@webrtc.org
NOTRY=True
Review-Url: https://codereview.webrtc.org/2043873003
Cr-Commit-Position: refs/heads/master@{#13054}
2016-06-06 21:00:09 +00:00
Patrik Höglund
87f8c0d072
Adding in objc vars for WebRTC GN config.
...
Appears to be needed after https://codereview.chromium.org/1941053002 .
R=ivoc@webrtc.org
TBR=kjellander@webrtc.org
Review URL: https://codereview.webrtc.org/1941413002 .
Cr-Commit-Position: refs/heads/master@{#12609}
2016-05-03 15:20:03 +00:00
kjellander
e3897ad7e2
Roll chromium_revision 2a03e86fcf..bc1c2103ef (389507:390316)
...
The BoringSSL changes in
https://codereview.chromium.org/1917223004/
https://codereview.chromium.org/1919383002/
required moving the build_with_chromium variable to build.gni.
Change log: 2a03e86fcf..bc1c2103ef
Full diff: 2a03e86fcf..bc1c2103ef
Changed dependencies:
* src/buildtools: e84114dbe2..cdbd50759b
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/f01fb5dc0e..a081423809
* src/tools/gyp: 6ea68631cd..4cf07e8d61
DEPS diff: 2a03e86fcf..bc1c2103ef /DEPS
Clang version changed 266460:267383
Details: 2a03e86fcf..bc1c2103ef /tools/clang/scripts/update.py
TBR=pbos@webrtc.org
NOTRY=True
Review-Url: https://codereview.webrtc.org/1925843003
Cr-Commit-Position: refs/heads/master@{#12544}
2016-04-28 09:51:10 +00:00
kjellander
80381aac5c
Roll chromium_revision 61ed337cfe..21934f358a (388120:388405)
...
Change log: 61ed337cfe..21934f358a
Full diff: 61ed337cfe..21934f358a
No dependencies changed.
No update to Clang.
TBR=
NOTRY=True
Review URL: https://codereview.webrtc.org/1901763005
Cr-Commit-Position: refs/heads/master@{#12434}
2016-04-20 05:59:51 +00:00
kjellander
10cd6ff5d0
Roll chromium_revision 7542f07..38664e7 (377632:377790) + set SDK 10.11 on Mac
...
Change log: 7542f07..38664e7
Full diff: 7542f07..38664e7
Changed dependencies:
* src/buildtools: 97b5c48..14288a0
* src/tools/swarming_client: 71c61c8..a72f46e
DEPS diff: 7542f07..38664e7 /DEPS
No update to Clang.
TBR=tkchin@webrtc.org
Review URL: https://codereview.webrtc.org/1741663002
Cr-Commit-Position: refs/heads/master@{#11780}
2016-02-26 11:21:18 +00:00
Henrik Kjellander
0be9df4293
Roll chromium_revision aa04eb9..4d6ba6e (376768:376909)
...
Add build_overrides/build.gni similar to
https://codereview.chromium.org/1686373002 in order for us
to have some targets generated only for WebRTC.
Change log: aa04eb9..4d6ba6e
Full diff: aa04eb9..4d6ba6e
Changed dependencies:
* src/buildtools: ef3e530..97b5c48
DEPS diff: aa04eb9..4d6ba6e /DEPS
No update to Clang.
TBR=tkchin@webrtc.org
BUG=webrtc:5453
Review URL: https://codereview.webrtc.org/1720353002 .
Cr-Commit-Position: refs/heads/master@{#11715}
2016-02-23 06:19:06 +00:00
Henrik Kjellander
48e66b4463
GN: Remove build_overrides/v8.gni
...
After https://codereview.chromium.org/1413893003
this workaround is no longer needed (since we've now
rolled that revision into WebRTC).
BUG=541791
R=phoglund@webrtc.org
Review URL: https://codereview.webrtc.org/1418063002 .
Cr-Commit-Position: refs/heads/master@{#10370}
2015-10-22 08:50:43 +00:00
Henrik Kjellander
b79472a4fb
Roll chromium_revision c089d37..159828f (353662:353696)
...
Due to https://codereview.chromium.org/1397493004 we're now adding
a build_overrides directory in WebRTC. Thanks to this, we no longer
need to pass --args="build_with_chromium=false" when running GN in
standalone WebRTC.
Change log: c089d37..159828f
Full diff: c089d37..159828f
No dependencies changed.
No update to Clang.
BUG=webrtc:5070,chromium:541791
TBR=tommi@webrtc.org
CQ_EXTRA_TRYBOTS=tryserver.webrtc:win_baremetal,mac_baremetal,linux_baremetal
Review URL: https://codereview.webrtc.org/1403453003 .
Cr-Commit-Position: refs/heads/master@{#10270}
2015-10-14 06:14:10 +00:00