18 Commits

Author SHA1 Message Date
sakal
5f70d3b559 Fix org.mockito.Matchers deprecation warnings in DirectRTCClientTest.
ArgumentMatchers is the new name of the class. Also, we don't need to
pass a class to the isNotNull matcher.

BUG=webrtc:6558
R=magjed@webrtc.org

Review-Url: https://codereview.webrtc.org/2440433002
Cr-Commit-Position: refs/heads/master@{#14706}
2016-10-20 12:49:12 +00:00
sakal
7e76560c35 Enable logging to console in DirectRTCClientTest.
This CL enables printing Android log to stdout for the test. This makes debugging the flakiness of the test easier.

BUG=webrtc:6475
R=magjed@webrtc.org

Review-Url: https://codereview.webrtc.org/2418413002
Cr-Commit-Position: refs/heads/master@{#14649}
2016-10-17 10:17:32 +00:00
sakal
11d37ba862 Speculatively increase timeouts for DirectRTCClientTest to reduce flakiness.
BUG=webrtc:6475

Review-Url: https://codereview.webrtc.org/2393143002
Cr-Commit-Position: refs/heads/master@{#14539}
2016-10-06 07:34:47 +00:00
ehmaldonado
eb5040ae44 Disable TCPChannelClientTest.testConnectIPv6
This test is failing because IPv6 is not fully supported on some of the
bots. (See https://bugs.chromium.org/p/chromium/issues/detail?id=612380)

R=kjellander@webrtc.org
TBR=perkj@webrtc.org
BUG=webrtc:6437
NOTRY=True
TESTED=ninja -C out/gn && out/gn/bin/run_android_junit_tests with and without the CL and verified the test is not run.

Review-Url: https://codereview.webrtc.org/2381503005
Cr-Commit-Position: refs/heads/master@{#14449}
2016-09-30 07:20:12 +00:00
sakal
b6760f9e44 Format all Java in WebRTC.
BUG=webrtc:6419
TBR=henrika@webrtc.org

Review-Url: https://codereview.webrtc.org/2377003002
Cr-Commit-Position: refs/heads/master@{#14432}
2016-09-29 11:12:51 +00:00
Magnus Jedvert
c1815cf084 Reland of name AppRTCDemo on Android and iOS to AppRTCMobile (patchset #1 id:1 of https://codereview.webrtc.org/2358133003/ )
Reason for revert:
Internal project is updated.

Original issue's description:
> Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ )
>
> Reason for revert:
> Breaks internal project.
>
> Original issue's description:
> > Rename AppRTCDemo on Android and iOS to AppRTCMobile
> >
> > The purpose is to make it clearer it is a mobile application.
> >
> > BUG=webrtc:6359
> > NOPRESUBMIT=true
> >
> > Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a
> > Cr-Commit-Position: refs/heads/master@{#14356}
>
> TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6359
>
> Committed: https://crrev.com/87ef6f750126f9f17f4714d696a8e77a2dd0a3f1
> Cr-Commit-Position: refs/heads/master@{#14358}

TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:6359

Review URL: https://codereview.webrtc.org/2373443005 .

Cr-Commit-Position: refs/heads/master@{#14391}
2016-09-27 08:10:52 +00:00
magjed
87ef6f7501 Revert of Rename AppRTCDemo on Android and iOS to AppRTCMobile (patchset #2 id:20001 of https://codereview.webrtc.org/2343403002/ )
Reason for revert:
Breaks internal project.

Original issue's description:
> Rename AppRTCDemo on Android and iOS to AppRTCMobile
>
> The purpose is to make it clearer it is a mobile application.
>
> BUG=webrtc:6359
> NOPRESUBMIT=true
>
> Committed: https://crrev.com/d3af58bdab5b25acd62cd816363becc7003d3e5a
> Cr-Commit-Position: refs/heads/master@{#14356}

TBR=sakal@webrtc.org,kthelgason@webrtc.org,tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6359

Review-Url: https://codereview.webrtc.org/2358133003
Cr-Commit-Position: refs/heads/master@{#14358}
2016-09-22 17:15:43 +00:00
magjed
d3af58bdab Rename AppRTCDemo on Android and iOS to AppRTCMobile
The purpose is to make it clearer it is a mobile application.

BUG=webrtc:6359
NOPRESUBMIT=true

Review-Url: https://codereview.webrtc.org/2343403002
Cr-Commit-Position: refs/heads/master@{#14356}
2016-09-22 16:12:38 +00:00
kjellander
4bb04985c4 Merge AppRTCDemoJUnitTest into android_junit_tests target
With the small number of tests these targets contain, it
makes more sense to gather them into android_junit_tests
instead, which was created to be a high-level target containing
all the junit tests.

BUG=chromium:647390
NOTRY=True

Review-Url: https://codereview.webrtc.org/2347403002
Cr-Commit-Position: refs/heads/master@{#14292}
2016-09-19 15:53:30 +00:00
sakal
57b490004d Change AppRTCDemoJUnitTest to use LocalRobolectricTestRunner.
It was previously using org.robolectric.RobolectricTestRunner. Due to
changes in Chromium this no longer works. This CL fixes the issue.

BUG=webrtc:6363
NOTRY=True

Review-Url: https://codereview.webrtc.org/2342783002
Cr-Commit-Position: refs/heads/master@{#14261}
2016-09-16 13:02:52 +00:00
sakal
5d4d59c069 Remove LooperExecutor and replace it with built-in HandlerThread.
Review-Url: https://codereview.webrtc.org/2206473003
Cr-Commit-Position: refs/heads/master@{#13688}
2016-08-09 09:03:41 +00:00
Sami Kalliomaki
d3235f0cd9 Re-order and remove unused Java imports.
R=tommi@webrtc.org

Review URL: https://codereview.webrtc.org/2203723002 .

Cr-Commit-Position: refs/heads/master@{#13608}
2016-08-02 13:44:19 +00:00
sakal
b0cf1a8916 Improve IP_PATTERN in DirectRTCClient in Android AppRTC Demo
Earlier, strings like "aaaa" and "1111" would be interpreted as IP
addresses, which is not optimal. This CL improves the IP_PATTERN and
adds a test for it.

Review-Url: https://codereview.webrtc.org/2009493002
Cr-Commit-Position: refs/heads/master@{#12887}
2016-05-25 09:26:29 +00:00
sakal
f8312cb45a Convert LooperExecutorTest in AppRTC Demo into JUnit test
LooperExecutorTest now uses Robolectric instead of being instrumentation
test. This allows the test to be run faster and easier.

Review-Url: https://codereview.webrtc.org/1989813002
Cr-Commit-Position: refs/heads/master@{#12825}
2016-05-20 10:56:54 +00:00
sakal
7cf11476b9 Replace LooperExecutor with built-in class in Android AppRTC Demo
LooperExecutor is only truly needed in WebSocketChannelClient because of
WebSocketClient from autobanh requiring thread to have a looper. So
LooperExecutor was left there but replaced everywhere else with built-in
singleThreadExecutor/singleThreadScheduledExecutor.

Motivation behind this change is that built-in class behaves better
under testing environment and doesn't require hacky
RobolectricLooperExecutor.

Review-Url: https://codereview.webrtc.org/1992213002
Cr-Commit-Position: refs/heads/master@{#12823}
2016-05-20 09:41:08 +00:00
sakal
f910ecdfc5 Add test for DirectRTCClient in AppRTC Demo for Android
Test is very simple but should test the basic sanity of the class.
Test is implemented as a JUnit test using Robolectric. Also
removed unused imports from TCPChannelClientTest.

Review-Url: https://codereview.webrtc.org/1989013003
Cr-Commit-Position: refs/heads/master@{#12804}
2016-05-19 07:00:49 +00:00
sakal
299ccdee0c Direct IP connect functionality for AppRTC Android demo.
This allows connecting between clients without using external servers, which is useful to OEMs if they are working in a network without internet connection. Implementation uses custom AppRTCClient that replaces WebSocketRTCClient if roomId looks like an IP. Instead of a web socket, this class uses direct TCP connection between peers as a signaling channel.

Review-Url: https://codereview.webrtc.org/1963053002
Cr-Commit-Position: refs/heads/master@{#12789}
2016-05-18 10:36:50 +00:00
sakal
ee3732622c JUnit test framework for AppRTC Android demo.
This allows creating tests for AppRTC Android demo that will be run on
the host machine instead of a device. These tests can mock Android APIs
through Robolectric. Because the tests are run on the host machine,
they run much faster.

BUG=webrtc:5896
NOTRY=True

Review-Url: https://codereview.webrtc.org/1985663002
Cr-Commit-Position: refs/heads/master@{#12769}
2016-05-17 10:22:38 +00:00