webrtc-version-updater
137c2a8316
Update WebRTC code version (2022-04-08T04:02:16).
...
Bug: None
Change-Id: I5e9ba82f5e67d3a1721a799b0904d518ec0ea6d6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258340
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36488}
2022-04-08 05:44:07 +00:00
webrtc-version-updater
7cbbcc96ee
Update WebRTC code version (2022-04-07T04:03:02).
...
Bug: None
Change-Id: I2060b6b8312b82ccc6253b00abdc05da2badca84
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258282
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36471}
2022-04-07 05:55:43 +00:00
Florent Castelli
dd837e28fa
Remove //rtc_base:timeutils from public deps
...
Bug: webrtc:8603
Change-Id: Iaca9356d16275a02e8842c783f259131d72ef010
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257914
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36460}
2022-04-06 11:23:21 +00:00
webrtc-version-updater
901bf55ef7
Update WebRTC code version (2022-04-06T04:02:56).
...
Bug: None
Change-Id: I15217920ec552e1ce793091df5d524ab8c52cb6d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258166
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36454}
2022-04-06 05:07:00 +00:00
Florent Castelli
57aa81bce7
Remove //rtc_base:stringutils from public deps
...
Bug: webrtc:8603
Change-Id: Ic2dfbe28d310cb4b35983b73e895fc95e8439669
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257913
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36453}
2022-04-05 22:42:19 +00:00
Florent Castelli
e10a9f609a
Remove //rtc_base:safe_conversions from public deps
...
Bug: webrtc:8603
Change-Id: I285ac30975039f8fe9882d1673cc8e4a615c8618
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257912
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36452}
2022-04-05 20:04:59 +00:00
Florent Castelli
33d31fbc48
Remove //rtc_base:rtc_event from public deps
...
Bug: webrtc:8603
Change-Id: Ib99f43043da17723c939b0fe2aa9f3e515462c93
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257911
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36450}
2022-04-05 17:34:09 +00:00
Florent Castelli
f86f6f9afd
Remove //rtc_base:refcount from public deps
...
Bug: webrtc:8603
Change-Id: Ib27a107ae809df739492846175f0e9c4af40d21a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257910
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36447}
2022-04-05 15:32:29 +00:00
Florent Castelli
4467ad7835
Remove //rtc_base:macromagic from public deps
...
Bug: webrtc:8603
Change-Id: I9708df48c9bde9f86ba2d1a92a278bb0d09f3865
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257909
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36444}
2022-04-05 12:36:12 +00:00
Florent Castelli
0af55ba60d
Remove //rtc_base:logging from public deps
...
Bug: webrtc:8603
Change-Id: I2704da8618f88032adac7ae9eb2a0f47fce4a836
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257908
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36443}
2022-04-05 10:31:19 +00:00
webrtc-version-updater
2f52f054f6
Update WebRTC code version (2022-04-05T04:02:56).
...
Bug: None
Change-Id: I32b8e719e4a66122ba6c8b464be326ccd94e7713
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258003
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36437}
2022-04-05 05:35:32 +00:00
webrtc-version-updater
c9e796dffc
Update WebRTC code version (2022-04-04T04:03:51).
...
Bug: None
Change-Id: I9783bb1bfad6be81bf1fb3709daf11df617b7048
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257861
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36416}
2022-04-04 05:17:55 +00:00
webrtc-version-updater
343227b6c9
Update WebRTC code version (2022-04-03T04:02:21).
...
Bug: None
Change-Id: Ie356ea7f92ac04de7f6c98a713f3187a6e452943
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257700
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36414}
2022-04-03 05:24:51 +00:00
webrtc-version-updater
62e423d6f8
Update WebRTC code version (2022-04-02T04:01:43).
...
Bug: None
Change-Id: I21d0a5bc0eb089f9cfefcae222d6bd546c7714bc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257500
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36411}
2022-04-02 05:42:46 +00:00
webrtc-version-updater
63542409ef
Update WebRTC code version (2022-04-01T04:04:24).
...
Bug: None
Change-Id: I5b571225ed725b19e5093f38d1f481999d3919a8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257381
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36403}
2022-04-01 05:15:16 +00:00
Erik Språng
128addb1a2
Update TQ pacer holdback window defaults.
...
Default holdback-window for non-prio packets is now 5ms, or the expected
pacing time for 3 packets if lower.
This brings wakeup frequency in line with legacy pacer at medium to low
packet rates.
Bug: webrtc:10809
Change-Id: I4045c40ae6b6d50f1ea049f3a26768023f77ec3c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257301
Auto-Submit: Erik Språng <sprang@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36397}
2022-03-31 13:54:46 +00:00
webrtc-version-updater
38f35db4d4
Update WebRTC code version (2022-03-31T04:03:30).
...
Bug: None
Change-Id: I1d31a641c0df497e2b28f1bff1f3f3ea644f4f51
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257223
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36386}
2022-03-31 05:29:02 +00:00
webrtc-version-updater
c58942b189
Update WebRTC code version (2022-03-30T04:03:18).
...
Bug: None
Change-Id: Ica6a8eb3cf0de506a953e7cf93ce3ad0686ec362
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257123
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36375}
2022-03-30 05:44:58 +00:00
Jonas Oreland
e62c2f2c77
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 12/inf
...
rename WebRtcKeyValueConfig to FieldTrialsView
Bug: webrtc:10335
Change-Id: If725bd498c4c3daf144bee638230fa089fdde833
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256965
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36365}
2022-03-29 10:14:00 +00:00
webrtc-version-updater
f07ef551a7
Update WebRTC code version (2022-03-29T04:03:03).
...
Bug: None
Change-Id: Iadff50dea35bbc412284a6699209d4c517168148
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256987
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36360}
2022-03-29 05:15:11 +00:00
webrtc-version-updater
4aabf0ff5c
Update WebRTC code version (2022-03-26T04:03:18).
...
Bug: None
Change-Id: I10a033d2537a0ec062ebdb2d8790666de118304f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256902
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36346}
2022-03-26 05:23:45 +00:00
Jonas Oreland
e02f9eedb3
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 10/inf
...
This patch takes a stab at modules/video_coding,
but reaches only about half.
Bug: webrtc:10335
Change-Id: I0d47d0468b818145470c51ae4e8e75ff58d499ae
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256112
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36335}
2022-03-25 12:35:36 +00:00
webrtc-version-updater
48aeb965fa
Update WebRTC code version (2022-03-25T04:07:38).
...
Bug: None
Change-Id: I8c3fd97767bc8ea70881350982b702918e8596a7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256761
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36327}
2022-03-25 05:23:25 +00:00
webrtc-version-updater
6c61b90458
Update WebRTC code version (2022-03-24T04:09:55).
...
Bug: None
Change-Id: Ie69631a4fe14b83c62971ecd7a2b1f4da27f7d10
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256544
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36310}
2022-03-24 05:24:42 +00:00
Alessio Bazzica
d7fdb95346
Remove typing detection
...
Motivation: never used.
Follow-up CL of https://webrtc-review.googlesource.com/c/src/+/250680 .
Tested on a custom chromium build by making a video call and with
keyboard activity. The expected logs from the APM transient suppressor
sub-module were shown.
Bug: webrtc:11226
Change-Id: I4186994412dd8ba2e71ed8f9dcc9cf8f8e40fbd3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250667
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36300}
2022-03-23 10:23:54 +00:00
webrtc-version-updater
445a750d38
Update WebRTC code version (2022-03-23T04:05:31).
...
Bug: None
Change-Id: I0bdb52494a01c82bcdc682807f37a4be1e69559b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256425
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36296}
2022-03-23 06:25:33 +00:00
Evan Shrubsole
6dbc1723f1
[cleanup] Prefer VCMTiming unique_ptr in VideoReceiveStream2 c'tor
...
Change-Id: Ifc2667ef9da38563266fb5ca7800ec757464035e
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256363
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Evan Shrubsole <eshr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36289}
2022-03-22 13:15:33 +00:00
webrtc-version-updater
2b168062d6
Update WebRTC code version (2022-03-22T04:02:08).
...
Bug: None
Change-Id: I5732b1ca0e5266952f5d33f9a7257236586c7c79
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256217
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36287}
2022-03-22 05:51:13 +00:00
Jianhui Dai
df59e53818
Reland "Pacer: Reduce TQ wake up and improve packet size estimation"
...
Update `early_execute_margin` after process packets, and the test case.
Original change's description:
>Pacer: Reduce TQ wake up and improve packet size estimation
>
>The TQ Pacer schedules delayed task according to target time of
>PacingController. It drains all valid ProcessPackets() in single loop,
>denies retired scheduled tasks, and round up the timeout to 1ms.
>
>This CL also improves packet size estimation in TQ Pacer by removing
>zero initialization, and introduces `include_overhead_` configuration.
>
>Tests:
>1. webrtc_perf_tests: MaybeProcessPackets() calls
> 2075147 -> 2007995
>
>2. module_unittests: MaybeProcessPackets() calls
> 203393 -> 183563
>
>3. peerconnection_unittests: MaybeProcessPackets() calls
> 66713-> 64333
>
>Bug: webrtc:13417, webrtc:13437
>Change-Id: I18eb0a36dbe063c606b1f27014df74a65ebfc486
>Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/242962
>Reviewed-by: Erik Språng <sprang@webrtc.org>
>Reviewed-by: Henrik Boström <hbos@webrtc.org>
>Commit-Queue: Erik Språng <sprang@webrtc.org>
>Cr-Commit-Position: refs/heads/main@{#36179}
Bug: webrtc:13417, webrtc:13437
Change-Id: I79f2554cf02364b67ce7073698611a3ae337a73b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256145
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Owners-Override: Erik Språng <sprang@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36283}
2022-03-21 16:41:42 +00:00
webrtc-version-updater
9d52093ff9
Update WebRTC code version (2022-03-21T04:05:30).
...
Bug: None
Change-Id: I5701b2ffa1d17aab2ac159d8d7094acd068b2dc7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256205
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36272}
2022-03-21 05:21:34 +00:00
webrtc-version-updater
1568f55668
Update WebRTC code version (2022-03-20T04:05:29).
...
Bug: None
Change-Id: Ia96519e30bf8ccef120f3c53e1e92d7bc784f3d8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256156
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36268}
2022-03-20 05:06:01 +00:00
webrtc-version-updater
346abbc68a
Update WebRTC code version (2022-03-19T04:04:24).
...
Bug: None
Change-Id: Ib8158e2d3116652dc268e955832aa81d19fa5aaa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256141
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36266}
2022-03-19 04:57:37 +00:00
webrtc-version-updater
2464612bbe
Update WebRTC code version (2022-03-18T04:05:46).
...
Bug: None
Change-Id: Iae0332ef971075f07c88f53c305d1789f1752109
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256045
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36242}
2022-03-18 04:55:07 +00:00
Erik Språng
1a08096998
Clean up the TaskQueuePacedSender constructor.
...
Removes the unused event log pointer and the default arguments.
Bug: webrtc:13417
Change-Id: I90341528cdfd7a5c102addaa4e7c83e875525386
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/255562
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36238}
2022-03-17 15:23:46 +00:00
Jonas Oreland
a943e730b2
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 7/inf
...
Convert audio/ and collateral (audio encoder copy red).
Bug: webrtc:10335
Change-Id: Iac54c0cfd2f62f4402f3deec35ae2725ec35b81a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/255820
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36229}
2022-03-17 07:11:44 +00:00
webrtc-version-updater
e72f4bc524
Update WebRTC code version (2022-03-17T04:07:28).
...
Bug: None
Change-Id: Ib97334d7c83ea6759cc2736039db11c701a3d48a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/255903
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36228}
2022-03-17 05:02:05 +00:00
Erik Språng
6673437775
Move ownership of congestion window state to rtp sender controller.
...
When congestion window is used, two different mechanisms can currently
update the outstanding data state in the pacer:
* OnPacketSent() withing the pacer itself, when a packet is sent
* UpdateOutstandingData(), when RtpTransportControllerSend either:
a. Receives an OnPacketSent() callback (increase outstanding data)
b. Receives transport feedback (decrease outstanding data)
This creates a lot of calls to UpdateOutstandingData(), more than one
per sent packet. Each requires locking and/or thread jumps. To avoid
that, this CL moves the congestion window state to
RtpTransportController send - and we only post a congested flag down
the the pacer when the state is changed.
The only benefit I can see is of the old way is we prevent sending
new packets immedately when the window is full, rather than in some
edge cases queue extra packets on the network task queue before the
congestion signal is received. That should be rare and benign.
I think this simplified logic, which is easier to read and more
performant, is a better tradeoff.
Bug: webrtc:13417
Change-Id: I326dd88db86dc0d6dc685c61920654ac024e57ef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/255600
Auto-Submit: Erik Språng <sprang@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36220}
2022-03-16 15:30:03 +00:00
webrtc-version-updater
7b0f538462
Update WebRTC code version (2022-03-16T04:05:20).
...
Bug: None
Change-Id: Idbdabfb918758492bd471ed80aabc98713098fe4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/255721
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36210}
2022-03-16 04:47:32 +00:00
Erik Språng
e486a7bdf7
Make KeyValueConfig mandatory in the pacer.
...
This CL also removes dependency on the legacy field trial methods.
Bug: webrtc:11926
Change-Id: I53feeee86b92878cf0f2b8ebdce3d101f9e04014
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/255381
Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
Auto-Submit: Erik Språng <sprang@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36205}
2022-03-15 15:07:46 +00:00
webrtc-version-updater
b1e9402331
Update WebRTC code version (2022-03-15T04:05:24).
...
Bug: None
Change-Id: I658691cae7f5f9a78f94fd94a56ca4a59d29d29d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/255462
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36199}
2022-03-15 05:59:06 +00:00
Jonas Oreland
8ca06137dc
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 4/inf
...
convert almost all of video/ (and the collateral)
Bug: webrtc:10335
Change-Id: Ic94e05937f54d11ee8a635b6b66fd146962d9f11
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254601
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36192}
2022-03-14 14:36:35 +00:00
Ali Tofigh
6364d0899e
Adopt absl::string_view in rtc_base/log_sinks
...
This is part of a large scale effort to increase adoption of
absl::string_view across the WebRTC code base.
This CL adds absl::string_view versions of the OnLogMessage functions in
rtc::LogSink. The const std::string& versions are kept for now since
downstream clients use subclasses of LogSink and need to be migrated
before these are removed.
Bug: webrtc:13579
Change-Id: I57bb72ad503805ff0ca16f1d7aece2d44c65cb73
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253980
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Xavier Lepaul <xalep@webrtc.org>
Owners-Override: Xavier Lepaul <xalep@webrtc.org>
Commit-Queue: Ali Tofigh <alito@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36189}
2022-03-14 12:47:55 +00:00
Mirko Bonadei
d8543dedf2
Revert "Pacer: Reduce TQ wake up and improve packet size estimation"
...
This reverts commit 37195cf2e577cc09ad1362d046b5c8a9b65d4f99.
Reason for revert: Breaks downstream tests (more investigations and testing is necessary).
Original change's description:
> Pacer: Reduce TQ wake up and improve packet size estimation
>
> The TQ Pacer schedules delayed task according to target time of
> PacingController. It drains all valid ProcessPackets() in single loop,
> denies retired scheduled tasks, and round up the timeout to 1ms.
>
> This CL also improves packet size estimation in TQ Pacer by removing
> zero initialization, and introduces `include_overhead_` configuration.
>
> Tests:
> 1. webrtc_perf_tests: MaybeProcessPackets() calls
> 2075147 -> 2007995
>
> 2. module_unittests: MaybeProcessPackets() calls
> 203393 -> 183563
>
> 3. peerconnection_unittests: MaybeProcessPackets() calls
> 66713-> 64333
>
> Bug: webrtc:13417, webrtc:13437
> Change-Id: I18eb0a36dbe063c606b1f27014df74a65ebfc486
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/242962
> Reviewed-by: Erik Språng <sprang@webrtc.org>
> Reviewed-by: Henrik Boström <hbos@webrtc.org>
> Commit-Queue: Erik Språng <sprang@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#36179}
No-Try: True
Bug: webrtc:13417, webrtc:13437
Change-Id: I5418d26d3978f21765ef38acfb002398e671e036
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/255301
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36185}
2022-03-14 09:35:56 +00:00
webrtc-version-updater
2c64c6f50e
Update WebRTC code version (2022-03-14T04:04:50).
...
Bug: None
Change-Id: I946168ceee261e801cb2da71c78394c6b2c642ba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/255281
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36183}
2022-03-14 05:05:25 +00:00
Jianhui Dai
37195cf2e5
Pacer: Reduce TQ wake up and improve packet size estimation
...
The TQ Pacer schedules delayed task according to target time of
PacingController. It drains all valid ProcessPackets() in single loop,
denies retired scheduled tasks, and round up the timeout to 1ms.
This CL also improves packet size estimation in TQ Pacer by removing
zero initialization, and introduces `include_overhead_` configuration.
Tests:
1. webrtc_perf_tests: MaybeProcessPackets() calls
2075147 -> 2007995
2. module_unittests: MaybeProcessPackets() calls
203393 -> 183563
3. peerconnection_unittests: MaybeProcessPackets() calls
66713-> 64333
Bug: webrtc:13417, webrtc:13437
Change-Id: I18eb0a36dbe063c606b1f27014df74a65ebfc486
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/242962
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36179}
2022-03-11 14:17:33 +00:00
webrtc-version-updater
041c08377a
Update WebRTC code version (2022-03-11T04:02:47).
...
Bug: None
Change-Id: I17d0ee0403d10aa44d8db604f4498a3c5da7d9bb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254900
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36176}
2022-03-11 05:32:56 +00:00
webrtc-version-updater
e39955ede6
Update WebRTC code version (2022-03-10T04:03:07).
...
Bug: None
Change-Id: I89f313c9330a0ae03ccb5acfb10c37ac12b47097
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254440
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36167}
2022-03-10 05:10:30 +00:00
Jonas Oreland
c7f691a71a
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 2
...
convert call/ (and the collaterals)
Bug: webrtc:10335
Change-Id: I8f6bc13c032713aa2a947724b464f6f35454d39a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254320
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36165}
2022-03-09 22:17:52 +00:00
Jonas Oreland
ed99dae422
WebRTC-DeprecateGlobalFieldTrialString/Enabled/ - part 1
...
This cl/
1) move WebRtcKeyValueConfig from api/transport to api/ directory.
2) add a test/ScopedKeyValueConfig (compare ScopedFieldTrials).
3) removes usage of webrtc::field_trial:: from the pc/ directory.
4) removes a few unused includes of system_wrappers/field_trial.h.
Bug: webrtc:10335
Change-Id: If29c07900dbe791050b0a5ad05332bedfad035f2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253903
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36160}
2022-03-09 13:23:21 +00:00
webrtc-version-updater
41cf5fb721
Update WebRTC code version (2022-03-09T04:01:53).
...
Bug: None
Change-Id: I92463dab13eebfa2e6b5d6fe4f41ba9b69cb7034
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254200
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#36152}
2022-03-09 05:34:11 +00:00