henrike@webrtc.org
105e07193e
Removed usage of the deprecated critical section constructor in modules/utility.
...
Review URL: http://webrtc-codereview.appspot.com/321006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1223 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 19:53:46 +00:00
marpan@webrtc.org
57353a33f1
FEC Receiver: Fix to how old packets (e.g., re-tranmitted packets in hybird NACK-FEC mode) are treated.
...
This change avoids having old packets end up on the current packet list for FEC decoding, and so they are immediately sent out to jitter buffer.
The current list of packets for FEC decoding are sent out only when new packet arrives (with time-stamp greater than current).
Review URL: http://webrtc-codereview.appspot.com/322009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1222 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 17:21:09 +00:00
henrik.lundin@webrtc.org
e7d8c56c56
Fix for dual decoder in VCM receiver
...
In VCMReceiver::FrameForDecoding, one of the if-cases could sometimes
extract an incomplete frame without first copying the state to the
dual decoder.
Review URL: http://webrtc-codereview.appspot.com/328006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1221 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 15:40:52 +00:00
henrik.lundin@webrtc.org
a70f945086
Inject TickTimeInterface into VCM and tests
...
The purpose of this change is to introduce dependency injection
of the timer into the video coding module.
Review URL: http://webrtc-codereview.appspot.com/332003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1220 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 14:40:05 +00:00
asapersson@webrtc.org
5249cc8f77
Review URL: http://webrtc-codereview.appspot.com/295010
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1219 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 14:31:37 +00:00
tina.legrand@webrtc.org
9775a30859
Added variable to catch return value.
...
Review URL: http://webrtc-codereview.appspot.com/329004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1218 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 11:15:46 +00:00
kjellander@webrtc.org
08dec7f449
Now using fileutils.h OutputPath to write output to the right directory and ResourcePath to read resource files from the resource bundle.
...
Removed some Valgrind warnings by closing output files. There are still some Valgrind warnings left, that needs to be fixed by a developer with more insight.
Updated all include paths to contain full paths to header files.
Tested in Debug+Release on Linux, Mac and Windows.
All tests ran successfully except the VideoProcessingModuleTest.ContentAnalysis test that fails on Windows with the following error:
unknown file: error: SEH exception with code 0xc0000005
thrown in the test body.
Fixing that is out of scope for this CL.
Review URL: http://webrtc-codereview.appspot.com/266011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1217 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 10:31:38 +00:00
tina.legrand@webrtc.org
554ae1ad4e
Changes to solve warnings on Mac, issue #178 .
...
Review URL: http://webrtc-codereview.appspot.com/320005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1216 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-16 10:09:04 +00:00
henrike@webrtc.org
7136990a3f
Removed usage of the deprecated critical section constructor in udp_transport.
...
Review URL: http://webrtc-codereview.appspot.com/321005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1211 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 19:17:28 +00:00
leozwang@webrtc.org
0c839fe873
Add new source file to makefile
...
Review URL: http://webrtc-codereview.appspot.com/322015
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1209 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 19:10:24 +00:00
henrik.lundin@webrtc.org
0a10e3c4b2
Fix order of include and guard in tick_time_interface.h
...
Review URL: http://webrtc-codereview.appspot.com/331002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1207 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 16:08:36 +00:00
henrik.lundin@webrtc.org
c74b2861f3
Fix the include in fake_tick_timer_interface.h
...
The include was in error.
Review URL: http://webrtc-codereview.appspot.com/330002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1204 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 11:28:31 +00:00
kma@webrtc.org
ee36b9587d
corrected android makefile for isac build.
...
Review URL: http://webrtc-codereview.appspot.com/321013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1200 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 00:18:45 +00:00
andrew@webrtc.org
59ccd5c71f
Rename _windows.h -> _win.h in system_wrappers.
...
- Also rename _dummy -> no_op which states its purpose more clearly.
- Always use exclusion lists (i.e. sources! instead of sources)
TEST=builds and passes system_wrapper_unittest on Linux, Mac, Win
Review URL: http://webrtc-codereview.appspot.com/317007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1199 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-15 00:17:43 +00:00
kma@webrtc.org
6a17340db5
Review URL: http://webrtc-codereview.appspot.com/318014
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1197 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 22:16:57 +00:00
kma@webrtc.org
a30093bb85
Added one file associated with check in in r1192.
...
Review URL: http://webrtc-codereview.appspot.com/320012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1194 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 19:57:23 +00:00
leozwang@webrtc.org
9aa9f44ebc
Add new source files because of r1174
...
Review URL: http://webrtc-codereview.appspot.com/320011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1193 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 19:08:33 +00:00
kma@webrtc.org
f0a964dc0a
Optimized WebRtcIsacfix_NormLatticeFilterMa() function for iSAC fix for ARM Neon
...
architecture with intrinsics and assembly code. The total iSAC codec speech improved
about 3~5%.
Notes
(1) The Neon version after this optimization is not bit-exact with the generic
C version. The out quality, however, is not worse as verified by test vectors ouput,
and undertandably in theory (32bit x 32bit in Neon is more accurate than the approximation
C code in the generic version).
(2) In Android, a isac neon library will be built. Along with some new function structures,
it is partly for preparation of introducing a run time detection of Neon architecture soon.
Review URL: http://webrtc-codereview.appspot.com/268016
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1192 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 18:59:43 +00:00
kma@webrtc.org
6601902504
Introduced WebRtcSpl_SatW32ToW16 to iSAC fix, for Android platforms.
...
Review URL: http://webrtc-codereview.appspot.com/315005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1190 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 18:41:07 +00:00
leozwang@webrtc.org
f147bbc878
Change codec test app lib dependency from webrtc lib to codec library
...
Review URL: http://webrtc-codereview.appspot.com/317009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1189 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 18:22:41 +00:00
henrike@webrtc.org
7cdcde3460
Removed usage of the deprecated critical section constructor in media_file.
...
Review URL: http://webrtc-codereview.appspot.com/321004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1187 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 17:27:58 +00:00
stefan@webrtc.org
780a07a843
Fix infinite loop bug introduced in r1174.
...
Merges CleanUpSizeZeroFrames with CleanUpOldFrames, and changes the
behavior to go through all frames looking for empty frames.
TBR=mikhals
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/318013
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1186 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 15:55:19 +00:00
pwestin@webrtc.org
9fe3d51372
Set the new layer sync bit in the VP8 info struct.
...
Review URL: http://webrtc-codereview.appspot.com/324010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1185 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 15:13:04 +00:00
henrik.lundin@webrtc.org
fbf5af444b
Adding a mockable wrapper class for TickTime in VCM
...
The class is called TickTimeInterface, with a fake implementation in FakeTickTime.
Review URL: http://webrtc-codereview.appspot.com/323012
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1183 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 10:36:10 +00:00
stefan@webrtc.org
ef5247b5b1
Fix session_info_unittest error.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/324009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1182 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 10:25:38 +00:00
stefan@webrtc.org
0c40d3315f
Fixes an assert triggered in jitter_buffer_test and disables deblocking.
...
When deblocking is enabled the first frames can include uninitialized
memory. Disabling for now.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/320010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1181 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 09:39:30 +00:00
andrew@webrtc.org
6d609b59f3
Fix crashes due to static_instance.
...
- Initialize a needed critsect in the constructor of
UdpSocket2ManagerWindows.
- Don't return NULL when creating a static instance.
TEST=voe_auto_test on Windows.
Review URL: http://webrtc-codereview.appspot.com/324008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1177 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-14 02:36:33 +00:00
andrew@webrtc.org
5ae19de3ec
Fix error in RtpDump::Start due to r1156.
...
- r1156 fixed a check on the _text member of FileWrapper. Turns out this
was incompatibile with the RTP dumps, which want to write both binary
and text data. Writing text data to a file open as "b" isn't actually
an error, so I simply removed the check.
- Also cleans up the interface, most notably removing all WebRtc types.
TEST=vie_auto_test
Review URL: http://webrtc-codereview.appspot.com/317005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1175 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 22:59:33 +00:00
mikhal@webrtc.org
832cacacff
video-coding: Adding a decoded state to the JB logic (JB refactor).
...
This new class stores the last decoded info, including temporal info.
Review URL: http://webrtc-codereview.appspot.com/300005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1174 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 21:15:05 +00:00
henrike@webrtc.org
65573f2922
Removed usage of the deprecated critical section constructor in rtp_rtcp.
...
Review URL: http://webrtc-codereview.appspot.com/315004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1173 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 19:17:27 +00:00
stefan@webrtc.org
f4c8286222
Pass NACK and FEC overhead rates through the ProtectionCallback to VCM.
...
These overhead rates are used by the VCM to compensate the source
coding rate for NACK and FEC.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/323003
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1171 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 15:38:14 +00:00
henrik.lundin@webrtc.org
1ced840893
Fixing a nit in the unittest
...
This caused some of the build bots to fail.
Review URL: http://webrtc-codereview.appspot.com/324005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1170 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 14:59:00 +00:00
henrik.lundin@webrtc.org
eda86dc76b
Adding a LayerSync bit to VP8 RTP header
...
Updated RtpFormatVp8, ModuleRTPUtility, VP8Encoder and VP8Decoder
to support a new LayerSync ("Y") bit. Note, in VP8Encoder the bit
must be used together with a non-negative value for temporalIdx.
Fixing the plumbing between RTP module and and from VP8 wrapper.
Updating unit tests; all pass.
The new bit is yet to be used by the VP8 wrapper.
Review URL: http://webrtc-codereview.appspot.com/323008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1169 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 14:11:06 +00:00
henrik.lundin@webrtc.org
4aae0e489f
Shaping up formatting of rtp_utility_test.cc
...
Preparations for future work in this file.
Review URL: http://webrtc-codereview.appspot.com/318011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1168 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 09:15:21 +00:00
stefan@webrtc.org
076fa6e674
The second step towards a list based SessionInfo.
...
Added unittests for most of public functions of SessionInfo.
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/301014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1166 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 07:54:56 +00:00
mikhal@webrtc.org
352ade7023
video_coding: Allocating encoded buffer based on length and not size
...
Review URL: http://webrtc-codereview.appspot.com/318010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1163 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-13 00:54:28 +00:00
stefan@webrtc.org
1480f02faf
Fix VCM test build warnings on Mac with clang.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/318008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1160 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-12 13:45:59 +00:00
stefan@webrtc.org
7889a9b49a
Remove use of CriticalSectionScoped(CriticalSectionWrapper& critsect) in VCM.
...
BUG=
TEST=
Review URL: http://webrtc-codereview.appspot.com/318005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1159 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-12 08:18:24 +00:00
mikhal@webrtc.org
ea71440aec
video_coding: Adding the non reference flag to the receive side logic.
...
Review URL: http://webrtc-codereview.appspot.com/323005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1157 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-12 02:29:34 +00:00
henrike@webrtc.org
315282c01a
Fixes a compiler warning related to dynamically allocated static memory. the fix is to leak the memory since the OS will clean it up anyways. This will not add noise to memory tools so it's ok. The issue is reported here: http://code.google.com/p/webrtc/issues/detail?id=147 .
...
Review URL: http://webrtc-codereview.appspot.com/267023
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1150 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 17:46:20 +00:00
xians@webrtc.org
0744ee563d
Disable API tests on ALSA since the tests don't work for all the alsa devices.
...
Review URL: http://webrtc-codereview.appspot.com/317004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1147 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 14:05:29 +00:00
henrik.lundin@webrtc.org
6198624815
Remove warnings on Mac (Issue 178)
...
Remove an if-else that can never execute the else statement.
Remove double parenthesis.
BUG=http://code.google.com/p/webrtc/issues/detail?id=178
TEST=
Review URL: http://webrtc-codereview.appspot.com/318004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1146 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 13:58:17 +00:00
mflodman@webrtc.org
5cc4dc9e0c
Remove warnings in VideoEngine, capture module and render module.
...
BUG=164, 176, 180
Review URL: http://webrtc-codereview.appspot.com/303004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1145 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 10:12:57 +00:00
henrikg@webrtc.org
af225d6bf6
The change http://webrtc-codereview.appspot.com/299001 (commit 1062) does not do what it intends (exclude codecs from Chromium build). This is a fix for that. webrtc.gyp is not pulled in Chromium, hence it has no effect putting a define there. Moving it to src/build/common.gypi.
...
Review URL: http://webrtc-codereview.appspot.com/315002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1143 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 09:58:39 +00:00
mikhal@webrtc.org
2ab104e6be
Switching WebRtc to LibYuv.
...
General Notes:
1. In general, API structure was not modified and is based on VPLIB.
2. Modification to API: Return values are based on libyuv, i.e. 0 if ok, a negative value in case of an error (instead of length).
3. All scaling (inteprolation) is now done via the scale interface. Crop/Pad is not being used.
4. VPLIB was completely removed. All tests are now part of the libyuv unit test (significantly more comprehensive and based on gtest).
5. JPEG is yet to be implemented in LibYuv and therefore existing implementation remains.
Review URL: http://webrtc-codereview.appspot.com/258001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1140 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-09 02:46:22 +00:00
mallinath@webrtc.org
7766e2a82d
- This issue raised by the chromium team when clang compiler is used. This was not an error as in this case we were accessing IPV6 address with IPV4 struct which is defined as 14 bytes in the header file, but we had the runtime check to determine the address space.
...
Now the solution is to use IPV6 structures instead of IPV4 when address space is determined.
I haven't put the new solution behind AF_INET6 flag, as i don't think it's necessary.
Review URL: http://webrtc-codereview.appspot.com/291014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1138 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 21:37:19 +00:00
andrew@webrtc.org
b0be7aa7ae
Remove deprecated OS X Core Audio APIs.
...
We no longer support the 10.4 SDK, so we can remove the weak-leaking
feature and exclusively use the added-in-10.5 APIs.
BUG=issue143
TEST=voe_auto_test
Review URL: http://webrtc-codereview.appspot.com/322001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1136 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 20:15:36 +00:00
marpan@webrtc.org
63b50f60d6
test_fec: Fix to valgrind warnings.
...
Review URL: http://webrtc-codereview.appspot.com/304002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1135 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 19:05:39 +00:00
mikhal@webrtc.org
f5ee1dc3e6
video_coding: Adding temporal layer info support to receive side
...
Review URL: http://webrtc-codereview.appspot.com/303005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1134 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 19:04:47 +00:00
henrik.lundin@webrtc.org
d03718d1e4
Use ResourcePath in NetEQ unittest
...
Review URL: http://webrtc-codereview.appspot.com/320001
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1130 4adac7df-926f-26a2-2b94-8c16560cd09d
2011-12-08 11:42:43 +00:00