deadbeef
0a6c4ca942
Catching more errors when parsing ICE server URLs.
...
Every malformed URL should now produce an error message in JS, rather than
silently failing and possibly printing a warning message to the console (and
possibly crashing).
Also added some unit tests, and made "ParseIceServers" public.
BUG=445002
Review URL: https://codereview.webrtc.org/1344143002
Cr-Commit-Position: refs/heads/master@{#10186}
2015-10-06 18:38:33 +00:00
Henrik Boström
5e56c5927e
DtlsIdentityStoreInterface added and the implementation is called DtlsIdentityStoreImpl (previously named without the -Impl bit and without an interface).
...
DtlsIdentityStoreImpl is updated to take KeyType into account, something which will be relevant after this CL lands:
https://codereview.webrtc.org/1189583002
The DtlsIdentityService[Interface] classes are about to be removed (to be removed when Chromium no longer implements and uses the interface). This was an unnecessary layer of complexity. The FakeIdentityService is now instead a FakeDtlsIdentityStore.
Where a service was previously passed around, a store is now passed around.
Identity generation is now commonly performed using DtlsIdentityStoreInterface. Previously, if a service was not specified, WebRtcSessionDescriptionFactory could fall back on its own generation code. Now, a store has to be provided for generation to occur.
For more information about the steps being taken to land this without breaking Chromium, see referenced bug.
BUG=webrtc:4899
R=magjed@webrtc.org , tommi@webrtc.org
Review URL: https://codereview.webrtc.org/1176383004 .
Cr-Commit-Position: refs/heads/master@{#9696}
2015-08-11 08:33:27 +00:00
jbauch
fabe2c961f
Remove deprecated functions.
...
This CL removes some functions that are marked as deprecated. Chromium
has been updated in https://crrev.com/7dee3f68b7699ad72c7fc4d75332f72703313849
to call the new functions.
Review URL: https://codereview.webrtc.org/1237613003
Cr-Commit-Position: refs/heads/master@{#9598}
2015-07-16 20:43:27 +00:00
jiayl@webrtc.org
61e00b0bca
Create a in-memory DTLS identity store that keeps a free identity generated in the background.
...
BUG=4241
R=pthatcher@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8576
Committed: https://code.google.com/p/webrtc/source/detail?r=8581
Review URL: https://webrtc-codereview.appspot.com/37889004
Cr-Commit-Position: refs/heads/master@{#8605}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8605 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-04 22:18:18 +00:00
jiayl@webrtc.org
be77872d2c
Revert "Create a in-memory DTLS identity store that keeps a free identity generated in the background."
...
Breaking Chromium FYI.
TBR=pthatcher@webrtc.org
This reverts commit 369f68255ffd3d6f3e449e0defeae820cefd4f29.
BUG=4241
R=pthatcher@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8576
Review URL: https://webrtc-codereview.appspot.com/37889004
Review URL: https://webrtc-codereview.appspot.com/47389004
Cr-Commit-Position: refs/heads/master@{#8583}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8583 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-04 00:19:16 +00:00
jiayl@webrtc.org
369f68255f
Create a in-memory DTLS identity store that keeps a free identity generated in the background.
...
BUG=4241
R=pthatcher@webrtc.org
Committed: https://code.google.com/p/webrtc/source/detail?r=8576
Review URL: https://webrtc-codereview.appspot.com/37889004
Cr-Commit-Position: refs/heads/master@{#8581}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8581 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-03 23:14:18 +00:00
jiayl@webrtc.org
8ad96605c1
Revert "Create a in-memory DTLS identity store that keeps a free identity generated in the background."
...
Test failure: http://chromegw/i/client.webrtc/builders/Linux32%20Release/builds/3557
This reverts commit df512cc8b73ff519dcdf63a2603ab312d3443402.
TBR=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41089004
Cr-Commit-Position: refs/heads/master@{#8579}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8579 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-03 20:35:34 +00:00
jiayl@webrtc.org
df512cc8b7
Create a in-memory DTLS identity store that keeps a free identity generated in the background.
...
BUG=4241
R=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37889004
Cr-Commit-Position: refs/heads/master@{#8576}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8576 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-03-03 16:42:21 +00:00
pkasting@chromium.org
005b6fffe6
Convert some EXPECTs to ASSERTs to avoid crashes when object creation fails.
...
BUG=none
TEST=none
R=perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39649004
Cr-Commit-Position: refs/heads/master@{#8222}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8222 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-30 19:42:17 +00:00
jlmiller@webrtc.org
5f93d0a140
Update libjingle license statements at top of talk files for consistency
...
BUG=2133
R=juberti@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/39559004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8105 4adac7df-926f-26a2-2b94-8c16560cd09d
2015-01-20 21:36:13 +00:00
perkj@webrtc.org
c2dd5ee2c0
Prepare for removal of PeerConnectionObserver::OnError.
...
Prepare for removal of constraints to PeerConnection::AddStream.
OnError has never been implemented and has been removed from the spec.
Also, constraints to PeerConnection::AddStream has also been removed from the spec and have never been implemented.
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/23319004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7605 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-11-04 11:31:29 +00:00
pbos@webrtc.org
34f2a9ea72
Initialize SSL in unittest_main.cc.
...
Instead of having each test individually initialize and tear down SSL
move this to unittest_main.cc so that all tests are properly
initialized and new tests "don't have to think about it".
R=pthatcher@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/30549004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7316 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-09-28 11:36:45 +00:00
buildbot@webrtc.org
a09a99950e
(Auto)update libjingle 73222930-> 73226398
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6891 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-08-13 17:26:08 +00:00
buildbot@webrtc.org
d4e598d57a
(Auto)update libjingle 72097588-> 72159069
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6799 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-29 17:36:52 +00:00
tommi@webrtc.org
908f57ed94
Disable GetStatsForInvalidTrack while I rewrite it.
...
TBR=xians@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/17969005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6748 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-07-21 11:44:39 +00:00
jiayl@webrtc.org
001fd2d503
Fire OnRenegotiationNeeded only for the first SCTP DataChannel.
...
Subsequent DataChannels do not need renegotiation since SCTP data streams are not negotiated through SDP.
BUG=2431
R=pthatcher@google.com , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/12629004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6268 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-29 15:31:11 +00:00
buildbot@webrtc.org
f875f15afb
(Auto)update libjingle 64709629-> 64813990
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5897 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-14 16:06:21 +00:00
buildbot@webrtc.org
61c1b8ea32
(Auto)update libjingle 64585415-> 64594651
...
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5870 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-09 06:06:38 +00:00
jiayl@webrtc.org
db41b4dbcd
Remove the deprecated GetStats method from PeerConnectionInterface.
...
R=fischman@webrtc.org , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8879004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5634 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-03 21:30:06 +00:00
mallinath@webrtc.org
67ee6b9a62
Update talk to 60923971
...
Review URL: https://webrtc-codereview.appspot.com/7909004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5475 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-03 16:57:16 +00:00
jiayl@webrtc.org
a576faf82a
Enable SCTP and use OPENSSL on Anroid and NSS on other platforms.
...
It includes unit test fixes to properly initialize SSL if DTLS or SSL random number generator is used in the tests.
The private key and certificate constant strings used in some tests are updated to be compatible with NSS.
A few potentially overflow type conversions caused compiling warning on Windows and they are fixed by importing and using Chromium's checked_cast, which aborts the program if overflow occurs.
It also fixes a leak in nssstreamadapter.cc by releasing the PRFileDesc* in StreamClose.
BUG=2253
R=fischman@webrtc.org , juberti@google.com , wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4679005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5459 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-29 17:45:53 +00:00
mallinath@webrtc.org
0dac5378e5
Revert 5447 "Update talk to 60420316."
...
> Update talk to 60420316.
>
> TBR=wu@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/7719005
TBR=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7729004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5448 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-28 06:58:42 +00:00
mallinath@webrtc.org
752a017809
Update talk to 60420316.
...
TBR=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7719005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5447 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-28 06:45:52 +00:00
mallinath@webrtc.org
68cbd01216
enabling disabled data channels tests on win32. The real culprit was that ice candidates not included in SDP when there were failure causing transport channels never becoming writable.
...
BUG=2799
R=jiayl@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7369004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5410 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-01-22 00:16:46 +00:00
sergeyu@chromium.org
a23f0ca4ba
Update talk to 56619788
...
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3839005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5120 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-11-13 22:48:52 +00:00
wu@webrtc.org
cecfd1832d
Update talk to 55821645.
...
TEST=try bots
R=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/3139004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5053 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-30 05:18:12 +00:00
mallinath@webrtc.org
19f27e6a24
Update talk to 54527154.
...
TBR=wu
Review URL: https://webrtc-codereview.appspot.com/2389004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4954 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-10-13 17:18:27 +00:00
mallinath@webrtc.org
1112c30e1e
Update libjingle to 53057474.
...
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2274004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4818 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-23 20:34:45 +00:00
wu@webrtc.org
967bfff54d
Update talk to 52534915.
...
R=sergeyu@chromium.org
Review URL: https://webrtc-codereview.appspot.com/2251004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4786 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-19 05:49:50 +00:00
wu@webrtc.org
6603736038
PeerConnection::RemoveStream now removes the local stream even when it's closed. Updated the unit test accordingly.
...
RISK=P3
TESTED=PeerConnectionInterfaceTest.CloseAndTestMethods
TBR=fischman_webrtc
Review URL: https://webrtc-codereview.appspot.com/2018005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4535 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-13 00:09:35 +00:00
wu@webrtc.org
9dba525627
* Update libjingle to 50389769.
...
* Together with "Add texture support for i420 video frame." from
wuchengli@chromium.org .
https://webrtc-codereview.appspot.com/1413004
RISK=P1
TESTED=try bots
R=fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1967004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4489 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-05 20:36:57 +00:00
henrike@webrtc.org
28654cbc22
Update talk folder to revision=49713299.
...
TBR=mallinath@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1848004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4380 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-22 21:07:49 +00:00
henrike@webrtc.org
28e2075280
Adds trunk/talk folder of revision 359 from libjingles google code to
...
trunk/talk
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4318 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-07-10 00:45:36 +00:00