21 Commits

Author SHA1 Message Date
solenberg@webrtc.org
57e060251a Fix flaky test SendRtpRtcpHeaderExtensionsTest.SentPackets*.
Flakiness was caused by a race condition between two atomic integers shared by two threads. Fixed by counting bad packets (those not containing the expected extension) instead of the good packets.

The CL also eliminates another possible flake by introducing a test fixture which doesn't automatically start sending audio packets when constructed.

BUG=3340,3356
R=tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/14499004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6182 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-05-16 11:27:09 +00:00
henrik.lundin@webrtc.org
26e2b687fc Remove ACM1/ACM2 switching from VoiceEngine tests
The option to run VoiceEngine tests with both ACM1 and ACM2 was
introduced while the two versions of AudioCoding module where both
in use. Now, ACM1 is being deprecated, and the tests should use the
defualt one (ACM2).

BUG=2996
R=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12309004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5964 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-23 08:39:41 +00:00
aluebs@webrtc.org
f927fd6481 Re-enable AGC tests:
* AgcConfigTest.HasCorrectDefaultConfiguration
* AgcConfigTest.DealsWithInvalidParameters
* AgcConfigTest.CanGetAndSetAgcStatus
* AgcConfigTest.HasCorrectDefaultRxConfiguration
* AgcConfigTest.DealsWithInvalidRxParameters
* AgcConfigTest.CanGetAndSetRxAgcStatus
* AudioProcessingTest.AgcIsOnByDefault
* AudioProcessingTest.CanEnableAgcWithAllModes
* AudioProcessingTest.RxAgcShouldBeOffByDefault
* AudioProcessingTest.CanTurnOnDigitalRxAcg
* AudioProcessingTest.CannotTurnOnAdaptiveAnalogRxAgc

BUG=webrtc:2784
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/12019006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5918 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-16 11:58:18 +00:00
henrika@webrtc.org
b9309beea4 Removes VoECallReport sub API as part of a clean-up operation where the goal is to remove unused APIs.
BUG=3206
R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/11779004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5896 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-04-14 14:12:50 +00:00
solenberg@webrtc.org
b1f5010075 VoE changes to allow forwarding of packets from VoE to ViE BWE.
BUG=
R=mflodman@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/10419004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5757 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-03-24 10:38:25 +00:00
solenberg@webrtc.org
a07923339b Remove external encryption API for VoE.
BUG=
R=henrika@webrtc.org, henrikg@webrtc.org, phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/8459004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5564 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-18 11:27:22 +00:00
pbos@webrtc.org
064b32acbb Fix locking in LoopBackTransport::StorePacket.
The critical section in StorePacket was unnamed and only existed in
expression scope. Added GUARDED_BY annotations (which caught the bug),
then fixed it by naming the variable.

BUG=2880
R=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7979004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5484 4adac7df-926f-26a2-2b94-8c16560cd09d
2014-02-04 09:42:02 +00:00
minyue@webrtc.org
cc92e000f3 1. adding request of ACM version in the manual mode of voe_auto_test
2. adding command line flag for automated mode of voe_auto_test to choose between ACMs

3. adding request of ACM version in voe_cmd_test

R=phoglund@webrtc.org, xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/2281004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4877 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-09-30 08:43:50 +00:00
pbos@webrtc.org
6cd9341801 Hand over loopback packets to a network thread.
This version of LoopBackTransport hands packets over to a network thread
which will deliver them instead. This allows SendRTP and SendRTCP to
always be able to return, preventing deadlocks in voe_auto_test. The
previous case did not represent actual network usage. Now the send and
receive side can run concurrently with the receiving side. Previously
the sender thread also drove the receiving side, which does not
represent the regular use case where packets are put on a network
socket.

BUG=1568,2081,2178
TEST=Ran VoiceEngine RtpRtcpTest.*, known for deadlocking, 100+ times.
R=xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1985005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4516 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-09 21:11:57 +00:00
pbos@webrtc.org
12dc1a38ca Switch C++-style C headers with their C equivalents.
The C++ headers define the C functions within the std:: namespace, but
we mainly don't use the std:: namespace for C functions. Therefore we
should include the C headers.

BUG=1833
R=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1917004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4486 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-08-05 16:22:53 +00:00
pbos@webrtc.org
956aa7e087 Include files from webrtc/.. paths in voice_engine/
BUG=1662
R=henrikg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1434005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4079 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-21 13:52:32 +00:00
pbos@webrtc.org
8a025e26db Make sure VoiceEngine tests only include one test framework.
BUG=
R=henrikg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1499004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4078 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-21 11:25:12 +00:00
pbos@webrtc.org
9213521ea9 Remove const for plain data types in voice_engine/
BUG=1644
R=henrikg@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/1463004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@4018 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 08:31:39 +00:00
pwestin@webrtc.org
e30823911c Move the VoE tests to use external transport instead of the built in udp transport
Review URL: https://webrtc-codereview.appspot.com/1223006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3708 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-22 16:12:57 +00:00
pwestin@webrtc.org
684f0577fb Revert r3667 and r3665
Review URL: https://webrtc-codereview.appspot.com/1199004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3668 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-13 23:20:57 +00:00
pwestin@webrtc.org
361bac7a4f Removed the engine API:s related to transport such as SetSendDestination, the functionality is now provided via the test frame work.
Review URL: https://webrtc-codereview.appspot.com/1029004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3665 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-13 17:52:42 +00:00
phoglund@webrtc.org
d005468e9b Generalized mechanism for excluding gtests on platforms, disabled broken tests on mac.
BUG=1268
TEST=vie_auto_test on mac and linux
TBR=mflodman, kjellander

Review URL: https://webrtc-codereview.appspot.com/1027006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3347 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-09 16:53:42 +00:00
andrew@webrtc.org
1926d33344 Change Sleep() comment in test fixture.
TBR=phoglund

Review URL: https://webrtc-codereview.appspot.com/1023006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3335 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-05 03:30:11 +00:00
andrew@webrtc.org
00c7c4315b Replace voice engine utility functions with system wrapper variants.
SLEEP -> SleepMs
GET_TIME_IN_MS -> TickTime::MillisecondTimestamp

These could cause unused function errors on some compilers.

BUG=1228

Review URL: https://webrtc-codereview.appspot.com/1013004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3326 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-01-02 16:06:39 +00:00
phoglund@webrtc.org
8d334d387b Disabled flaky test on Linux, added disable-on-platform macros, fixed \n's
BUG=1155

Review URL: https://webrtc-codereview.appspot.com/972006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@3178 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-11-28 12:28:06 +00:00
andrew@webrtc.org
14b43beb7c Move src/ -> webrtc/
TBR=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/915006

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2963 4adac7df-926f-26a2-2b94-8c16560cd09d
2012-10-22 18:19:23 +00:00