webrtc_m130

Author SHA1 Message Date

Author	SHA1	Message	Date
kjellander@webrtc.org	14665ff7d4	Roll chromium_revision e144d30..6fdb142 (318658:318841) + remove OVERRIDE macro Clang version changed 223108:230914 Details: `e144d30..6fdb142`/tools/clang/scripts/update.sh Removes the OVERRIDE macro defined in: * webrtc/base/common.h * webrtc/typedefs.h The majority of the source changes were done by running this in src/: perl -0pi -e "s/virtual\s([^({;](\([^({;]\)[^({;]))(OVERRIDE\|override)/\1override/sg" `find {talk,webrtc} -name ".h" -o -name ".cc" -o -name ".mm"` which converted all: virtual Foo() OVERRIDE functions to: Foo() override Then I manually edited: * talk/media/webrtc/fakewebrtccommon.h * webrtc/test/fake_common.h Remaining uses of OVERRIDE was fixed by search+replace. Manual edits were done to fix virtual destructors that were overriding inherited ones. Finally a build error related to the pure virtual definitions of Read, Write and Rewind in common_types.h required a bit of refactoring in: * webrtc/common_types.cc * webrtc/common_types.h * webrtc/system_wrappers/interface/file_wrapper.h * webrtc/system_wrappers/source/file_impl.cc This roll should make it possible for us to finally re-enable deadlock detection for TSan on the buildbots. BUG=4106 R=pbos@webrtc.org, tommi@webrtc.org Review URL: https://webrtc-codereview.appspot.com/41069004 Cr-Commit-Position: refs/heads/master@{#8596} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8596 4adac7df-926f-26a2-2b94-8c16560cd09d	2015-03-04 13:04:54 +00:00
kwiberg@webrtc.org	00b8f6b364	Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away BUG= R=andrew@webrtc.org Review URL: https://webrtc-codereview.appspot.com/36229004 Cr-Commit-Position: refs/heads/master@{#8517} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8517 4adac7df-926f-26a2-2b94-8c16560cd09d	2015-02-26 14:43:50 +00:00
minyue@webrtc.org	aa5ea1c0f9	1. Make a clear distinction between codec internal FEC and RED, confusing mentioning of FEC in the old codes is replaced by RED 2. Add two new APIs to configure codec internal FEC 3. Add a test and listened to results. This is based modifying EncodeDecodeTest and deriving a new class from it. New ACM gives good result. Old ACM does not use NetEq 4, so FEC won't be decoded. BUG= R=tina.legrand@webrtc.org, turaj@webrtc.org Review URL: https://webrtc-codereview.appspot.com/11759004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6233 4adac7df-926f-26a2-2b94-8c16560cd09d	2014-05-23 15:16:51 +00:00

kjellander@webrtc.org

14665ff7d4

Roll chromium_revision e144d30..6fdb142 (318658:318841) + remove OVERRIDE macro

Clang version changed 223108:230914
Details: e144d30..6fdb142/tools/clang/scripts/update.sh

Removes the OVERRIDE macro defined in:
* webrtc/base/common.h
* webrtc/typedefs.h

The majority of the source changes were done by running this in src/:
perl -0pi -e "s/virtual\s([^({;]*(\([^({;]*\)[^({;]*))(OVERRIDE|override)/\1override/sg" `find {talk,webrtc} -name "*.h"  -o -name "*.cc*" -o -name "*.mm*"`

which converted all:
virtual Foo() OVERRIDE
functions to:
Foo() override

Then I manually edited:
* talk/media/webrtc/fakewebrtccommon.h
* webrtc/test/fake_common.h

Remaining uses of OVERRIDE was fixed by search+replace.

Manual edits were done to fix virtual destructors that were
overriding inherited ones.

Finally a build error related to the pure virtual definitions of
Read, Write and Rewind in common_types.h required a bit of
refactoring in:
* webrtc/common_types.cc
* webrtc/common_types.h
* webrtc/system_wrappers/interface/file_wrapper.h
* webrtc/system_wrappers/source/file_impl.cc

This roll should make it possible for us to finally re-enable deadlock
detection for TSan on the buildbots.

BUG=4106
R=pbos@webrtc.org, tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/41069004

Cr-Commit-Position: refs/heads/master@{#8596}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8596 4adac7df-926f-26a2-2b94-8c16560cd09d

2015-03-04 13:04:54 +00:00

kwiberg@webrtc.org

00b8f6b364

Use base/scoped_ptr.h; system_wrappers/interface/scoped_ptr.h is going away

BUG=
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/36229004

Cr-Commit-Position: refs/heads/master@{#8517}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8517 4adac7df-926f-26a2-2b94-8c16560cd09d

2015-02-26 14:43:50 +00:00

minyue@webrtc.org

aa5ea1c0f9

1. Make a clear distinction between codec internal FEC and RED, confusing mentioning of FEC in the old codes is replaced by RED

2. Add two new APIs to configure codec internal FEC

3. Add a test and listened to results. This is based modifying EncodeDecodeTest and deriving a new class from it.

New ACM gives good result.
Old ACM does not use NetEq 4, so FEC won't be decoded.

BUG=
R=tina.legrand@webrtc.org, turaj@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/11759004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6233 4adac7df-926f-26a2-2b94-8c16560cd09d

2014-05-23 15:16:51 +00:00

3 Commits