admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
43,182 Commits 1 Branch 0 Tags
Commit Graph

825 Commits

Author SHA1 Message Date
Christoffer Jansson
bf2d75d86f Add specific mac arm64 mb config 
Trying to solve https://ci.chromium.org/ui/p/webrtc/builders/perf/Perf%20Mac%20M1%20Arm64%2012/1/overview

Bug: b/230719743
Change-Id: I43e0206548fe6223552909a23748e3eea678e2a9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261902
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36837}
 2022-05-10 13:08:31 +00:00
Christoffer Jansson
598044f9ee Add M1 perf bot 
Companion CL: https://chromium-review.googlesource.com/c/chromium/tools/build/+/3634362

Bug: b/230719743
Change-Id: I52babb62dddbcadeb2854720c3c022ee3e04dbec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260321
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36829}
 2022-05-10 08:10:20 +00:00
Jeremy Leconte
4ef2de6290 Remove the iOS internal try bots. 
Bug: b/230708129
Change-Id: Ic4315997af0c01c5f5d987d13d88ada7d76ab0ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260191
Reviewed-by: Mirko Bonadei <mbonadei@google.com>
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36770}
 2022-05-05 07:20:49 +00:00
Jeremy Leconte
31e31c8c0a Adding jleconte to the tools_webrtc OWNERS file. 
Bug: b/230708129
Change-Id: Id005a9a1bd88530ef92fed3f31a29d951405c168
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261182
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36761}
 2022-05-04 14:26:07 +00:00
Jeremy Leconte
55c55c3c43 Reorder mb_config.pyl to fix 'mb.py validate' 
This is a follow up of this CL: https://crrev.com/c/3611486.

Bug: b/231404336
Change-Id: I3b6f4b780aa1939b6b2d0f1d08d1746a3a6f86dc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261080
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36752}
 2022-05-04 08:31:29 +00:00
Christoffer Jansson
b45d4deb3b Rename MacOS perf bot to 11 to reflect OS version 
Bug: b/227442116
Change-Id: I80cf745a3a38d08c833864d2f8e4533776be2585
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260460
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Jansson <jansson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36702}
 2022-04-29 09:24:13 +00:00
Jeremy Leconte
7c94291c58 Remove reference to //base in mb_unittest.py 
Also remove tests in //tools_webrtc/mb/mb_unittest.py that are testing exclusively code in //tools/mb/mb.py.

Bug: webrtc:13662
Change-Id: Ifdfbe26c11f7c315e307856b1d3ab06483d57641
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260041
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36651}
 2022-04-26 07:44:44 +00:00
hanpfei
edbaf57bd4 Fix a dead loop in tools_webrtc/libs/generate_licenses.py 
Bug: webrtc:13975
Signed-off-by: hanpfei <hanpfei@gmail.com>
Change-Id: I3943f66b1a80e3f1e4b05f4436dbeff23f3d6285
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259280
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36596}
 2022-04-21 07:43:05 +00:00
Björn Terelius
f0faa999a5 Make iwyu use public API for pthread library 
Bug: webrtc:13662
Change-Id: I8ee1d1b5882dcda6acdee7258f9a37676bbd0be7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259303
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36579}
 2022-04-20 06:37:22 +00:00
Jeremy Leconte
e288161529 Don't use windows path in mb.py 
Swarming Windows bots translate the path to Windows path.
https://chromium-swarm.appspot.com/task?id=5a5a3b202f930010

Bug: webrtc:13475
Change-Id: I21589e67057174651d467f4f78e33bdd21a4e1c5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259302
Reviewed-by: Christoffer Jansson <jansson@google.com>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36571}
 2022-04-19 12:24:26 +00:00
Jeremy Leconte
424cc65a4a Centralized test command argument in .pyl configuration. 
* Remove args from gn_isolate_map.pyl
* Set idempotent to false for performance tests

Bug: webrtc:13899
Change-Id: Icde80af02070e024c1292721db9c0b8a4d906343
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258685
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36531}
 2022-04-12 10:43:05 +00:00
Jeremy Leconte
f5fd25ca04 Remove duplicate gn_isolate_map.pyl 
The other one is in the //infra/specs folder.

Bug: webrtc:13899
Change-Id: Idbf3c888b60741aa8a35d25bd3b7deb4f1a81a95
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258682
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36525}
 2022-04-11 15:53:08 +00:00
Jeremy Leconte
f236ac73de Whitespace change to kick bots. 
Bug: None
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I68330a17f4738aa51a1ee61494e96c6d47cd5bd3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258136
Owners-Override: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36481}
 2022-04-07 14:20:52 +00:00
Florent Castelli
81acd03f89 tools: Better dependency fixing 
Lines like 'deps = [ "foo" ]' would fail to be fixed.
Just insert the new dependencies in front and let the formatter have fun
with this after.

Bug: None
Change-Id: I747925cd0a1de93715a00b9ff3490b555f237e97
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257906
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36429}
 2022-04-04 17:59:58 +00:00
Florent Castelli
48ad72e9eb tools: Fix gn_check_autofix.py with Python3 
Bug: None
Change-Id: Ib81f02823cae4a10697566d5889d4814a0184503
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257903
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36425}
 2022-04-04 13:23:56 +00:00
Florent Castelli
f2599a7f43 Remove usrsctp, dcSCTP is now the unique SCTP implementation 
Bug: chromium:1243702
Change-Id: Id11299d26f0f8713a57781b57277837aace531f2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251821
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Victor Boivie <boivie@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36423}
 2022-04-04 10:30:46 +00:00
Jeremy Leconte
4f279adb1b Remove redundant PRESUBMIT.py files. 
* tools_webrtc/PRESUBMIT.py is only checking the licence which is already done here:
38f35db4d4:PRESUBMIT.py;l=913;bpv=1;bpt=0;drc=4fc9bd9f69a0d88889d86d0cc9f8e27406e8a342

* sdk/android/PRESUBMIT.py was added before 'git cl format' was required from the root PRESUBMIT.py:
https://codereview.webrtc.org/2377113003

Bug: webrtc:13895
Change-Id: Ia5ea2529c36ceebfd7d4e6a6a72352bd30c573b9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257280
Reviewed-by: Christoffer Jansson <jansson@google.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36391}
 2022-03-31 10:48:31 +00:00
Jeremy Leconte
ac5cf78801 Add mb.py to pylint check of the root PRESUBMIT.py. 
This now possible because of https://webrtc-review.googlesource.com/c/src/+/256972

Bug: webrtc:13605
Change-Id: Ie5c058c5ff459dde05c90f757a1df8bd53f35ccc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257281
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@google.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36390}
 2022-03-31 10:24:02 +00:00
Jeremy Leconte
81635f33ef Make tools_webrtc/mb inherit from tools/mb (3rd attempt). 
Previous attempts:
https://webrtc-review.googlesource.com/c/src/+/256809
https://webrtc-review.googlesource.com/c/src/+/256970

Bug: webrtc:13867
Change-Id: I5dc268b711dc17016a5d673f2b3ec733c9cff4f2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256972
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36367}
 2022-03-29 12:07:30 +00:00
Jeremy Leconte
bddfa1d9de Prepare the code to inherit from chromium's mb.py (3rd attempt). 
Basically try to make low_bandwidth_audio_perf_test target work with chromium's mb.

Bug: webrtc:13867
Change-Id: If111e2b0f4f82935062d6321f4d16cc72c77d572
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256975
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36364}
 2022-03-29 10:11:51 +00:00
Jeremy Leconte
137173c296 Revert "Reland "Make tools_webrtc/mb inherit from tools/mb."" 
This reverts commit aa0d4061ba1d65bfbd562c6a173440911c0357d8.

Reason for revert: All green except for the android bots compiling low_bandwidth_audio_perf_test.
https://ci.chromium.org/ui/p/webrtc/builders/ci/Android32%20Builder%20arm/12133/overview

Original change's description:
> Reland "Make tools_webrtc/mb inherit from tools/mb."
>
> This is a reland of commit 7a324b977c5ab6f9b88bcce3353feade943ccefe
>
> Original change's description:
> > Make tools_webrtc/mb inherit from tools/mb.
> >
> > Bug: webrtc:13867
> > Change-Id: I33e998d260454d16120b09fedecf0c25d2654611
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256809
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> > Commit-Queue: Jeremy Leconte <jleconte@google.com>
> > Cr-Commit-Position: refs/heads/main@{#36347}
>
> Bug: webrtc:13867
> Change-Id: I8fe4424771876ea725f5c9a3c5d13b2f6ad83917
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256970
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Jeremy Leconte <jleconte@google.com>
> Cr-Commit-Position: refs/heads/main@{#36361}

Bug: webrtc:13867
Change-Id: I69948eb028a57b915feba1037e71e82e2d8bc7c7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256971
Auto-Submit: Jeremy Leconte <jleconte@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36362}
 2022-03-29 07:14:04 +00:00
Jeremy Leconte
aa0d4061ba Reland "Make tools_webrtc/mb inherit from tools/mb." 
This is a reland of commit 7a324b977c5ab6f9b88bcce3353feade943ccefe

Original change's description:
> Make tools_webrtc/mb inherit from tools/mb.
>
> Bug: webrtc:13867
> Change-Id: I33e998d260454d16120b09fedecf0c25d2654611
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256809
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Jeremy Leconte <jleconte@google.com>
> Cr-Commit-Position: refs/heads/main@{#36347}

Bug: webrtc:13867
Change-Id: I8fe4424771876ea725f5c9a3c5d13b2f6ad83917
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256970
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36361}
 2022-03-29 07:02:40 +00:00
Jeremy Leconte
145ff4cc45 Prepare the code to inherit from chromium's mb.py. 
* Don't use 'script' type because it's breaking mb gen.
* Simplify 'raw' type command generation.

Bug: webrtc:13867
Change-Id: I68486c5010c84e41297daafdf11ab63bbca58d4b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256862
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36351}
 2022-03-28 09:52:30 +00:00
Jeremy Leconte
ad3f490946 Revert "Make tools_webrtc/mb inherit from tools/mb." 
This reverts commit 7a324b977c5ab6f9b88bcce3353feade943ccefe.

Reason for revert: Some failures like this one:
https://ci.chromium.org/p/webrtc/builders/ci/Linux64%20Builder/12121

Original change's description:
> Make tools_webrtc/mb inherit from tools/mb.
>
> Bug: webrtc:13867
> Change-Id: I33e998d260454d16120b09fedecf0c25d2654611
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256809
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Jeremy Leconte <jleconte@google.com>
> Cr-Commit-Position: refs/heads/main@{#36347}

Bug: webrtc:13867
Change-Id: If11473f31c8c5f365018f464b413220b2730ee7a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256960
Auto-Submit: Jeremy Leconte <jleconte@google.com>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36348}
 2022-03-28 07:22:50 +00:00
Jeremy Leconte
7a324b977c Make tools_webrtc/mb inherit from tools/mb. 
Bug: webrtc:13867
Change-Id: I33e998d260454d16120b09fedecf0c25d2654611
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256809
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36347}
 2022-03-28 07:10:00 +00:00
Jeremy Leconte
d8654cf636 Prepare the code to inherit from chromium's mb.py. 
Type 'additional_compile_target' are not meant to be tests.
Type 'raw' has no usage for xctests.
Explicitly set dcheck_always_on=false.

Bug: webrtc:13867
Change-Id: Ie47c300609ff5054d36110e8ee6c7a059ec452da
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256805
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36336}
 2022-03-25 13:01:24 +00:00
Saúl Ibarra Corretgé
c62dcc951d Reland "Avoid using lld when compiling iin iOS with bitcode" 
This is a reland of commit b7ba6027659913883af3d64ec0fdfcba96176816

Original change's description:
> Avoid using lld when compiling iin iOS with bitcode
>
> The resulting framework's LLVM __bundle segment is empty otherwise.
>
> Bug: webrtc:13774
> Change-Id: I235a3005f8e0d68168f29108be0f7c5b7914182b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253140
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#36178}

Bug: webrtc:13774
Change-Id: Ia88b26d91bf1cf7323d04f024155ecf394498c41
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256481
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36302}
 2022-03-23 13:21:02 +00:00
Jeremy Leconte
94029b812f Remove unused script webrtc_dashboard_upload.py 
The script process_perf_results.py is used instead.

Bug: webrtc:13806
Change-Id: I672da41d7264d5f996eef38f1178f486dad968ee
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256220
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36278}
 2022-03-21 12:54:42 +00:00
Jeremy Leconte
4fc9bd9f69 Add a new script to upload perf tests. 
Also add a script to do the bridge between a python 2 and a python 3 interpreter.
This should be removed when the merge scripts will be using python 3 (https://crbug.com/webrtc/13835).

Note that webrtc_dashboard_upload.py will be removed when the new script is stabilized.

Bug: webrtc:13806
Change-Id: I806fa11f417ef37674bdaeb5126c71570e3697d7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/255560
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@google.com>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Christoffer Jansson <jansson@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36252}
 2022-03-18 13:30:59 +00:00
Jeremy Leconte
3f82d02742 mb: decode process output for Python3 
CL from chromium's mb:
https://chromium-review.googlesource.com/c/chromium/src/+/3321055

Bug: webrtc:13839
Change-Id: Ie90eceaff8c824aa23bc27149dc88b9ac4cd1936
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256006
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36244}
 2022-03-18 07:53:01 +00:00
Florent Castelli
023be3c977 Data Channel Benchmarking tool 
Create a server using:
./data_channel_benchmark --server --port 12345
Start the flow of data from the server to a client using:
./data_channel_benchmark --port 12345 --transfer_size 100
The throughput is reported on the server console.

The negotiation does not require a 3rd party server and is done over a
gRPC transport. No TURN server is configured, so both peers need to be
reachable using STUN only.

Bug: webrtc:13288
Change-Id: Iac9a96cf390ab465ea45a46bf0b40950c56dfceb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/235661
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36206}
 2022-03-15 16:18:16 +00:00
Byoungchan Lee
2e7579aed2 Remove unused bazel related code 
They are no longer used after
https://chromium-review.googlesource.com/c/chromium/src/+/3016508 and
https://chromium-review.googlesource.com/c/chromium/src/+/3206870.

Bug: None
Change-Id: Id5d3def2d902886bc8ffd5512e2820943cac41bf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/255540
Auto-Submit: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36204}
 2022-03-15 11:35:09 +00:00
Jeremy Leconte
fa577c5eb6 Fix file open mode issue for the uploader. 
This is a forward fix for https://webrtc-review.googlesource.com/c/src/+/255320.
The error is the following:
https://logs.chromium.org/logs/webrtc-internal/buildbucket/cr-buildbucket/8819696929332742321/+/u/webrtc_perf_tests_Dashboard_upload/stdout

Bug: webrtc:13806
Change-Id: I1ccba1be69edf0b1023c1d197d2033bdc718f64b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/255420
Owners-Override: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36196}
 2022-03-14 19:34:46 +00:00
Jeremy Leconte
fa2c945f73 Fix type issue for the uploader. 
This is a forward fix for https://webrtc-review.googlesource.com/c/src/+/255320.
The error is the following:
https://logs.chromium.org/logs/webrtc/buildbucket/cr-buildbucket/8819700229708372817/+/u/low_bandwidth_audio_perf_test_Dashboard_upload/stdout

Bug: webrtc:13806
Change-Id: Ia7d5362d1131d9bab41a9112946a4c84e509d98f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/255382
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36195}
 2022-03-14 17:22:35 +00:00
Jeremy Leconte
2c4a4472a5 Prepare uploader to be used as a 'merge script'. 
* Don't exit by throwing exceptions.
* Rely on a dataclass instead of argument list.
* Prepare to remove arg wait_upload because it's always true.
* Remove unused args wait_timeout_sec and wait_timeout_secwait_polling_period_sec.

Bug: webrtc:13806
Change-Id: I0879fa7fd22c72f5b174f8823bdd51d49f1f140b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/255320
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36193}
 2022-03-14 14:42:28 +00:00
Ilya Nikolaevskiy
7c453589a9 Revert "Avoid using lld when compiling iin iOS with bitcode" 
This reverts commit b7ba6027659913883af3d64ec0fdfcba96176816.

Reason for revert: Speculative revert as this seems to break the downstream project.

Original change's description:
> Avoid using lld when compiling iin iOS with bitcode
>
> The resulting framework's LLVM __bundle segment is empty otherwise.
>
> Bug: webrtc:13774
> Change-Id: I235a3005f8e0d68168f29108be0f7c5b7914182b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253140
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#36178}

Bug: webrtc:13774
Change-Id: Ib05469827783d8db5e48ab9c33b31fcebd14b52a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/255302
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36186}
 2022-03-14 10:29:55 +00:00
Saúl Ibarra Corretgé
b7ba602765 Avoid using lld when compiling iin iOS with bitcode 
The resulting framework's LLVM __bundle segment is empty otherwise.

Bug: webrtc:13774
Change-Id: I235a3005f8e0d68168f29108be0f7c5b7914182b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253140
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36178}
 2022-03-11 11:26:24 +00:00
Harald Alvestrand
c2a2bef4f7 Add a header-reduction argument to IWYU 
This allows to delete non-needed headers from .h files.
Ran this on peer_connection.cc to demonstrate.

Bug: none
Change-Id: I69ce48be25a9778297e521282898c6ac31e7ea6c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254600
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36170}
 2022-03-10 12:25:12 +00:00
Jeremy Leconte
a5f3c20f2d Fix warning 'Build argument has no effect: ios_build_chrome'. 
Same warning for ios_use_goma_rbe.
https://logs.chromium.org/logs/webrtc/buildbucket/cr-buildbucket/8820359174215951313/+/u/generate_build_files/stdout

Bug: webrtc:13556
Change-Id: I5342644d1f620d293a9a7f541ac59803dedf4d67
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253840
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36142}
 2022-03-07 13:02:53 +00:00
Jeremy Leconte
7befe8e5e4 Remove reference to an old branch. 
Bug: webrtc:13788
Change-Id: I628b27f3b26aaaf77824cdadca0089e43f0e976b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253781
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36139}
 2022-03-07 08:27:23 +00:00
Saúl Ibarra Corretgé
fabc3a5aa7 Add script to generate ssl_roots.h from Mozilla's CA bundle 
Bug: webrtc:11710
Change-Id: I6eac35a111f89f3c74ce8c2ffc0ab607ad881be2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253220
Reviewed-by: Christoffer Jansson <jansson@google.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36131}
 2022-03-04 13:50:58 +00:00
Harald Alvestrand
c24a2189d7 Update IWYU tool with a mapping file 
Also apply IWYU to all .cc files in pc/, and correct BUILD file to match.
Note: Some files came out wrong when iwyu was applied. These are not included.

Bug: none
Change-Id: Ib5ea46b8fcc505414d0447cca7218ad3afc2e321
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252280
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36064}
 2022-02-24 11:05:06 +00:00
Christoffer Jansson
3b393ec991 Fixes escaped line breaks 
Bug: webrtc:13607
Change-Id: I24c252ecb6d443abb8206e752bdff73ee5084807
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252260
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#36056}
 2022-02-23 09:08:30 +00:00
Christoffer Jansson
36cf4787d0 Remove binary mode 
Realized I could actually test this fully locally using:
vpython3 roll_deps.py --dry-run -i

No-Try: True
Bug: webrtc:13607
Change-Id: Ibd4d8c002f76b3524da22056a34645178c66687a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252064
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#36051}
 2022-02-22 13:22:46 +00:00
Christoffer Jansson
e20a5247f0 another decode... 
I went through more thoroghly this time I think I gotem all

Bug: webrtc:13607
Change-Id: I0e8773903bff16e807cc32a1a6f0177d43543e44
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252062
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#36050}
 2022-02-22 12:53:17 +00:00
Christoffer Jansson
f1e4a66e94 Fix py3 compatibility for webrtc_version_updater 
Bug: webrtc:13607
Change-Id: I5890dc86286b0a6ece793655bcda15315d415b39
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252060
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#36046}
 2022-02-22 10:59:46 +00:00
Christoffer Jansson
c8f0502f0f Fix typo - Parenthesis was in the wrong place. 
No-Try: True
Bug: webrtc:13607
Change-Id: Iba13bcf94f7a89cdc0e124d42e879b9c900a56cc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252003
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#36043}
 2022-02-22 08:09:14 +00:00
Jeremy Leconte
7a5978e4cd Revert "Add the possibility to output a json gtest output to the perf tests." 
This reverts commit cbfa235b3548ae1a0b8f5b80a879214ca5f1bd56.

Reason for revert: iOS bots will use flags_compatibility with isolated_script_test_output but not gtest_output.

Original change's description:
> Add the possibility to output a json gtest output to the perf tests.
>
> We use the Chromium existing flag isolated_script_test_output that we translate into gtest_output.
> This is because the Chromium flag has the same purpose as gtest_output and is already provided in the recipe modules.
>
> No-Presubmit: True
> Bug: b/197492097
> Change-Id: Ia432a85b0e0ab32008b39ffe751d11aefb9b24ea
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251041
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Jeremy Leconte <jleconte@google.com>
> Cr-Commit-Position: refs/heads/main@{#35937}

No-Presubmit: True
Bug: b/197492097
Change-Id: I94e75328570f89011fbb0daf035f0072b8ea2f7d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252040
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@google.com>
Cr-Commit-Position: refs/heads/main@{#36042}
 2022-02-22 07:57:34 +00:00
Christoffer Jansson
694eae7064 Decode/encode data to utf-8 
Currently blocking the chromium to webrtc roller

Bug: webrtc:13607
Change-Id: I02237b266d4f2a2fdec2975b9e67d1c4b2099a48
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252001
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#36041}
 2022-02-21 19:53:34 +00:00
Christoffer Jansson
c13caac2d5 Fix urllib import + add test 
Unblocks the chromium to webrtc roller.

Bug: webrtc:13607
Change-Id: I877d8d25624bdc924425ef338f392ce7686207f2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251984
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#36038}
 2022-02-21 16:24:34 +00:00