From fee13e8c0d32a81e4e4e09c1c0b4c6a0645e4571 Mon Sep 17 00:00:00 2001 From: Evan Shrubsole Date: Tue, 26 Feb 2019 15:25:52 +0100 Subject: [PATCH] Log pacer values to verbose log The metrics of interest are the pacer rate, both normally and during a queue drain, as well as padding rate. Bug: None Change-Id: I9c36219f63ce61b46f20d42678e0d97cb2a1873c Reviewed-on: https://webrtc-review.googlesource.com/c/123195 Commit-Queue: Evan Shrubsole Reviewed-by: Sebastian Jansson Reviewed-by: Konrad Hofbauer Cr-Commit-Position: refs/heads/master@{#26855} --- modules/pacing/paced_sender.cc | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/modules/pacing/paced_sender.cc b/modules/pacing/paced_sender.cc index 70c8ad435f..83dd01fa39 100644 --- a/modules/pacing/paced_sender.cc +++ b/modules/pacing/paced_sender.cc @@ -206,6 +206,10 @@ void PacedSender::SetPacingRates(uint32_t pacing_rate_bps, RTC_DCHECK(pacing_rate_bps > 0); pacing_bitrate_kbps_ = pacing_rate_bps / 1000; padding_budget_.set_target_rate_kbps(padding_rate_bps / 1000); + + RTC_LOG(LS_VERBOSE) << "bwe:pacer_updated pacing_kbps=" + << pacing_bitrate_kbps_ + << " padding_budget_kbps=" << padding_rate_bps / 1000; } void PacedSender::InsertPacket(RtpPacketSender::Priority priority, @@ -348,8 +352,11 @@ void PacedSender::Process() { 1, queue_time_limit - packets_.AverageQueueTimeMs()); int min_bitrate_needed_kbps = static_cast(queue_size_bytes * 8 / avg_time_left_ms); - if (min_bitrate_needed_kbps > target_bitrate_kbps) + if (min_bitrate_needed_kbps > target_bitrate_kbps) { target_bitrate_kbps = min_bitrate_needed_kbps; + RTC_LOG(LS_VERBOSE) << "bwe:large_pacing_queue pacing_rate_kbps=" + << target_bitrate_kbps; + } } }