From fe968dff86b2f2f976719f6cda76d99eb6b20cc0 Mon Sep 17 00:00:00 2001 From: Victor Boivie Date: Tue, 1 Feb 2022 11:26:05 +0100 Subject: [PATCH] pc: Disable flaky unit test on Android The DataChannelIntegrationTest.SomeQueuedPacketsGetDroppedInMaxRetransmitsMode test is flaky on Android. Bug: None Change-Id: Ia72081905368e405441d5518b53d03e60fac233b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250120 Reviewed-by: Tomas Gunnarsson Commit-Queue: Victor Boivie Cr-Commit-Position: refs/heads/main@{#35868} --- pc/data_channel_integrationtest.cc | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/pc/data_channel_integrationtest.cc b/pc/data_channel_integrationtest.cc index 47ea74a4b2..c70078b0df 100644 --- a/pc/data_channel_integrationtest.cc +++ b/pc/data_channel_integrationtest.cc @@ -37,6 +37,13 @@ namespace { // All tests in this file require SCTP support. #ifdef WEBRTC_HAVE_SCTP +#if defined(WEBRTC_ANDROID) +// Disable heavy tests running on low-end Android devices. +#define DISABLED_ON_ANDROID(t) DISABLED_##t +#else +#define DISABLED_ON_ANDROID(t) t +#endif + class DataChannelIntegrationTest : public PeerConnectionIntegrationBaseTest, public ::testing::WithParamInterface< std::tuple> { @@ -704,7 +711,7 @@ TEST_P(DataChannelIntegrationTest, } TEST_P(DataChannelIntegrationTest, - SomeQueuedPacketsGetDroppedInMaxRetransmitsMode) { + DISABLED_ON_ANDROID(SomeQueuedPacketsGetDroppedInMaxRetransmitsMode)) { CreatePeerConnectionWrappers(); ConnectFakeSignaling(); DataChannelInit init;