From fe02681809cce486f7b5993356bdfa6a650951ea Mon Sep 17 00:00:00 2001 From: Diep Bui Date: Wed, 18 Oct 2023 13:40:11 +0000 Subject: [PATCH] Remove unused loss based param. Bug: webrtc:12707 Change-Id: Ie6f8eac23a4fb2fbd648b2a213319af508c40230 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/324045 Commit-Queue: Diep Bui Reviewed-by: Per Kjellander Cr-Commit-Position: refs/heads/main@{#40967} --- modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc | 5 ----- modules/congestion_controller/goog_cc/loss_based_bwe_v2.h | 1 - 2 files changed, 6 deletions(-) diff --git a/modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc b/modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc index 4bcae9d2eb..c0d7d1011b 100644 --- a/modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc +++ b/modules/congestion_controller/goog_cc/loss_based_bwe_v2.cc @@ -394,8 +394,6 @@ absl::optional LossBasedBweV2::CreateConfig( FieldTrialParameter max_increase_factor("MaxIncreaseFactor", 1.3); FieldTrialParameter delayed_increase_window( "DelayedIncreaseWindow", TimeDelta::Millis(300)); - FieldTrialParameter use_acked_bitrate_only_when_overusing( - "UseAckedBitrateOnlyWhenOverusing", false); FieldTrialParameter not_increase_if_inherent_loss_less_than_average_loss( "NotIncreaseIfInherentLossLessThanAverageLoss", true); @@ -439,7 +437,6 @@ absl::optional LossBasedBweV2::CreateConfig( &bandwidth_backoff_lower_bound_factor, &max_increase_factor, &delayed_increase_window, - &use_acked_bitrate_only_when_overusing, ¬_increase_if_inherent_loss_less_than_average_loss, &high_loss_rate_threshold, &bandwidth_cap_at_high_loss_rate, @@ -496,8 +493,6 @@ absl::optional LossBasedBweV2::CreateConfig( bandwidth_backoff_lower_bound_factor.Get(); config->max_increase_factor = max_increase_factor.Get(); config->delayed_increase_window = delayed_increase_window.Get(); - config->use_acked_bitrate_only_when_overusing = - use_acked_bitrate_only_when_overusing.Get(); config->not_increase_if_inherent_loss_less_than_average_loss = not_increase_if_inherent_loss_less_than_average_loss.Get(); config->high_loss_rate_threshold = high_loss_rate_threshold.Get(); diff --git a/modules/congestion_controller/goog_cc/loss_based_bwe_v2.h b/modules/congestion_controller/goog_cc/loss_based_bwe_v2.h index aba70b04f1..9be8341a79 100644 --- a/modules/congestion_controller/goog_cc/loss_based_bwe_v2.h +++ b/modules/congestion_controller/goog_cc/loss_based_bwe_v2.h @@ -109,7 +109,6 @@ class LossBasedBweV2 { double bandwidth_backoff_lower_bound_factor = 0.0; double max_increase_factor = 0.0; TimeDelta delayed_increase_window = TimeDelta::Zero(); - bool use_acked_bitrate_only_when_overusing = false; bool not_increase_if_inherent_loss_less_than_average_loss = false; double high_loss_rate_threshold = 1.0; DataRate bandwidth_cap_at_high_loss_rate = DataRate::MinusInfinity();