From fdd1b9a58e4ffbd1442f7d5b1a0bc9c602a8ed5f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Patrik=20H=C3=B6glund?= Date: Thu, 17 Sep 2015 16:45:43 +0200 Subject: [PATCH] Reland: Bailing out if pc factory fails to get created. This was reverted, but it turned out GOMA was down. This prevents us from continuing if we fail initialization. The failure will happen closer to its source, rather than when we try to create the first peer connection. BUG=None R=glaznev@webrtc.org Committed: https://crrev.com/6eb75d9e67f02c256436eb96f3c77026486561a1 Cr-Commit-Position: refs/heads/master@{#9948} Review URL: https://codereview.webrtc.org/1339923004 . Cr-Commit-Position: refs/heads/master@{#9974} --- talk/app/webrtc/java/jni/peerconnection_jni.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/talk/app/webrtc/java/jni/peerconnection_jni.cc b/talk/app/webrtc/java/jni/peerconnection_jni.cc index 5761d862d4..f7d33b115f 100644 --- a/talk/app/webrtc/java/jni/peerconnection_jni.cc +++ b/talk/app/webrtc/java/jni/peerconnection_jni.cc @@ -1103,6 +1103,8 @@ JOW(jlong, PeerConnectionFactory_nativeCreatePeerConnectionFactory)( NULL, encoder_factory, decoder_factory)); + CHECK(factory) << "Failed to create the peer connection factory; " + << "WebRTC/libjingle init likely failed on this device"; OwnedFactoryAndThreads* owned_factory = new OwnedFactoryAndThreads( worker_thread, signaling_thread, encoder_factory, decoder_factory,