From fb862741984d9cf9341f7772c8a708b215ef35db Mon Sep 17 00:00:00 2001 From: Evan Shrubsole Date: Mon, 16 Mar 2020 16:18:36 +0100 Subject: [PATCH] NiceMock MockFecController in VideoStreamEncoderUnittests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The MockFecController is spitting out lots of warnings, as it is being called when we don't care about it, in normal tests. Making it a NiceMock allows it to receive calls without expectation and not warn. Bug: None Change-Id: I1ea219c4665d86917718692dc013ae3ac47222ad Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170600 Reviewed-by: Henrik Boström Reviewed-by: Elad Alon Reviewed-by: Erik Språng Commit-Queue: Evan Shrubsole Cr-Commit-Position: refs/heads/master@{#30820} --- video/video_stream_encoder_unittest.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/video/video_stream_encoder_unittest.cc b/video/video_stream_encoder_unittest.cc index 9d6925e9c7..934bf09fe5 100644 --- a/video/video_stream_encoder_unittest.cc +++ b/video/video_stream_encoder_unittest.cc @@ -999,7 +999,7 @@ class VideoStreamEncoderTest : public ::testing::Test { bool expect_null_frame_ = false; EncodedImageCallback* encoded_image_callback_ RTC_GUARDED_BY(local_crit_sect_) = nullptr; - MockFecControllerOverride fec_controller_override_; + NiceMock fec_controller_override_; int num_encoder_initializations_ RTC_GUARDED_BY(local_crit_sect_) = 0; std::vector resolution_bitrate_limits_ RTC_GUARDED_BY(local_crit_sect_);