admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Attempt to resolve crash in AudioDeviceIOS::UpdateAudioDeviceBuffer

Browse Source 
Bug: b/69547732
Change-Id: I078175f96d55351ab0318aa2de96f4b859e752ea
Reviewed-on: https://webrtc-review.googlesource.com/24864
Commit-Queue: Henrik Andreassson <henrika@webrtc.org>
Reviewed-by: Zeke Chin <tkchin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20903}
This commit is contained in:
henrika 2017-11-22 14:25:25 +01:00 committed by Commit Bot
parent 8f00ad02fb
commit fb09eeb8f1
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
modules/audio_device/ios/audio_device_ios.mm
View File

@ -675,6 +675,17 @@ void AudioDeviceIOS::SetupAudioBuffersForActiveAudioSession() {
RTC_LOG(LS_WARNING) << "Unable to set the preferred sample rate";
}
// Crash reports indicates that it can happen in rare cases that the reported
// sample rate is less than or equal to zero. If that happens and if a valid
// sample rate has already been set during initialization, the best guess we
// can do is to reuse the current sample rate.
if (sample_rate <= DBL_EPSILON && playout_parameters_.sample_rate() > 0) {
RTCLogError(@"Reported rate is invalid: %f. "
"Using %d as sample rate instead.",
sample_rate, playout_parameters_.sample_rate());
sample_rate = playout_parameters_.sample_rate();
}
// At this stage, we also know the exact IO buffer duration and can add
// that info to the existing audio parameters where it is converted into
// number of audio frames.