admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Allow parsing RTC event logs without a transaction ID.

Browse Source 
Bug: webrtc:9972
Change-Id: I01d60671d249adbd55f25c8f49f205b18787cbf4
Reviewed-on: https://webrtc-review.googlesource.com/c/113304
Reviewed-by: Zach Stein <zstein@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25914}
This commit is contained in:
Bjorn Terelius 2018-12-05 21:06:17 +01:00 committed by Commit Bot
parent 518add35a8
commit fafae11bfc
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
logging/rtc_event_log/rtc_event_log_parser_new.cc
View File

@ -2428,8 +2428,10 @@ void ParsedRtcEventLogNew::StoreIceCandidateEvent(
ice_event.type = GetRuntimeIceCandidatePairEventType(proto.event_type());
RTC_CHECK(proto.has_candidate_pair_id());
ice_event.candidate_pair_id = proto.candidate_pair_id();
RTC_CHECK(proto.has_transaction_id());
ice_event.transaction_id = proto.transaction_id();
// TODO(zstein): Make the transaction_id field required once all old versions
// of the log (which don't have the field) are obsolete.
if (proto.has_transaction_id())
ice_event.transaction_id = proto.transaction_id();
ice_candidate_pair_events_.push_back(ice_event);