admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete deprecated Create method and config from AudioCodingModule

Browse Source 
The method and config are no longer used. This concludes the work to
break apart AcmReceiver and AudioCodingModule.

Bug: webrtc:14867
Change-Id: I87219749a1ea72a01b95e960d1f32292f7352c9b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291801
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Reviewed-by: Tomas Lundqvist <tomasl@google.com>
Commit-Queue: Henrik Lundin <henrik.lundin@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39250}
This commit is contained in:
Henrik Lundin 2023-02-02 14:12:54 +00:00 committed by WebRTC LUCI CQ
parent 101c6aab1b
commit fad9a6dae7
2 changed files with 0 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
modules/audio_coding/acm2/audio_coding_module.cc
View File

@ -529,8 +529,4 @@ std::unique_ptr<AudioCodingModule> AudioCodingModule::Create() {
return std::make_unique<AudioCodingModuleImpl>(); return std::make_unique<AudioCodingModuleImpl>();
} }
AudioCodingModule* AudioCodingModule::Create(const Config& config) {
return new AudioCodingModuleImpl();
}
} // namespace webrtc } // namespace webrtc

19
modules/audio_coding/include/audio_coding_module.h
View File

@ -17,13 +17,9 @@
#include <vector> #include <vector>
#include "absl/types/optional.h" #include "absl/types/optional.h"
#include "api/audio_codecs/audio_decoder_factory.h"
#include "api/audio_codecs/audio_encoder.h" #include "api/audio_codecs/audio_encoder.h"
#include "api/function_view.h" #include "api/function_view.h"
#include "api/neteq/neteq.h"
#include "api/neteq/neteq_factory.h"
#include "modules/audio_coding/include/audio_coding_module_typedefs.h" #include "modules/audio_coding/include/audio_coding_module_typedefs.h"
#include "system_wrappers/include/clock.h"
namespace webrtc { namespace webrtc {
@ -64,22 +60,7 @@ class AudioCodingModule {
AudioCodingModule() {} AudioCodingModule() {}
public: public:
// Deprecated. Will be deleted when downlink clients have migrated off it.
struct Config {
Config() = default;
Config(const Config&) = default;
~Config() = default;
NetEq::Config neteq_config;
Clock* clock;
rtc::scoped_refptr<AudioDecoderFactory> decoder_factory;
NetEqFactory* neteq_factory = nullptr;
};
static std::unique_ptr<AudioCodingModule> Create(); static std::unique_ptr<AudioCodingModule> Create();
// Deprecated. Will be deleted when downlink clients have migrated to the
// above method.
static AudioCodingModule* Create(const Config& config);
virtual ~AudioCodingModule() = default; virtual ~AudioCodingModule() = default;
// `modifier` is called exactly once with one argument: a pointer to the // `modifier` is called exactly once with one argument: a pointer to the